)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c195ed9690f7cc610fa63d7a6c57af02297dd14c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add regression test for bug #1895696"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This includes some simple changes to the CinderFixture and GlanceFixture"},{"line_number":10,"context_line":"to accomidate these tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I15271fb0b8de7f1184acddd607d605837e2eb7d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_04bb0975","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":13},"updated":"2020-09-16 17:55:48.000000000","message":"accommodate","commit_id":"d993a1e2348bde5541efab41a7e4e2faacc30a0d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"12382edb6d8518f03c65051912e8cdefb21585b8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This includes some simple changes to the CinderFixture and GlanceFixture"},{"line_number":10,"context_line":"to accommodate these tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I15271fb0b8de7f1184acddd607d605837e2eb7d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_e8fdfa6e","line":11,"updated":"2020-09-17 11:14:08.000000000","message":"nit: Related-Bug: #1895696","commit_id":"deb1b5a90446564d5f671ec2c08fe050704ad102"}],"nova/tests/fixtures.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c195ed9690f7cc610fa63d7a6c57af02297dd14c","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"        },"},{"line_number":2224,"context_line":"    }"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"    cinder_encryption_key_image \u003d {"},{"line_number":2227,"context_line":"        \u0027id\u0027: \u00277ad1b3f2-1a49-4820-af53-6c4b4f402e43\u0027,"},{"line_number":2228,"context_line":"        \u0027name\u0027: \u0027cinder_encryption_key_image\u0027,"},{"line_number":2229,"context_line":"        \u0027created_at\u0027: timestamp,"},{"line_number":2230,"context_line":"        \u0027updated_at\u0027: timestamp,"},{"line_number":2231,"context_line":"        \u0027deleted_at\u0027: None,"},{"line_number":2232,"context_line":"        \u0027deleted\u0027: False,"},{"line_number":2233,"context_line":"        \u0027status\u0027: \u0027active\u0027,"},{"line_number":2234,"context_line":"        \u0027is_public\u0027: False,"},{"line_number":2235,"context_line":"        \u0027container_format\u0027: \u0027ova\u0027,"},{"line_number":2236,"context_line":"        \u0027disk_format\u0027: \u0027vhd\u0027,"},{"line_number":2237,"context_line":"        \u0027size\u0027: \u002774185822\u0027,"},{"line_number":2238,"context_line":"        \u0027min_ram\u0027: 0,"},{"line_number":2239,"context_line":"        \u0027min_disk\u0027: 0,"},{"line_number":2240,"context_line":"        \u0027protected\u0027: False,"},{"line_number":2241,"context_line":"        \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":2242,"context_line":"        \u0027tags\u0027: [],"},{"line_number":2243,"context_line":"        \u0027properties\u0027: {"},{"line_number":2244,"context_line":"            \u0027cinder_encryption_key_id\u0027: \u00278fbf84cf-eb96-484c-9699-0996e593da03\u0027,"},{"line_number":2245,"context_line":"        },"},{"line_number":2246,"context_line":"    }"},{"line_number":2247,"context_line":""},{"line_number":2248,"context_line":"    def __init__(self, test):"},{"line_number":2249,"context_line":"        super().__init__()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_446a21ed","line":2246,"range":{"start_line":2226,"start_character":0,"end_line":2246,"end_character":5},"updated":"2020-09-16 17:55:48.000000000","message":"Rather than doing this, could you simply define something like this in the test itself:\n\n  def create_image(self):\n      image \u003d {\n          \u0027id\u0027: \u00277ad1b3f2-1a49-4820-af53-6c4b4f402e43\u0027,\n          ...\n      }\n      return self.glance.create(None, image)\n\nThere doesn\u0027t seem to be any reason to persist this globally, fwict?","commit_id":"d993a1e2348bde5541efab41a7e4e2faacc30a0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c195ed9690f7cc610fa63d7a6c57af02297dd14c","unresolved":false,"context_lines":[{"line_number":2527,"context_line":"            if \u0027availability_zone\u0027 not in volume:"},{"line_number":2528,"context_line":"                volume[\u0027availability_zone\u0027] \u003d self.az"},{"line_number":2529,"context_line":""},{"line_number":2530,"context_line":"            # Check for our special image-backed volume."},{"line_number":2531,"context_line":"            if volume_id in (self.IMAGE_BACKED_VOL,"},{"line_number":2532,"context_line":"                             self.IMAGE_WITH_TRAITS_BACKED_VOL,"},{"line_number":2533,"context_line":"                             self.IMAGE_WITH_ENCRYPT_KEY_BACKED_VOL):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e4bff55d","line":2530,"range":{"start_line":2530,"start_character":49,"end_line":2530,"end_character":55},"updated":"2020-09-16 17:55:48.000000000","message":"volumes","commit_id":"d993a1e2348bde5541efab41a7e4e2faacc30a0d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5fc57165090039c731b05a0ccaa5b19d3c2056ad","unresolved":false,"context_lines":[{"line_number":2241,"context_line":"        \u0027visibility\u0027: \u0027public\u0027,"},{"line_number":2242,"context_line":"        \u0027tags\u0027: [],"},{"line_number":2243,"context_line":"        \u0027properties\u0027: {"},{"line_number":2244,"context_line":"            \u0027cinder_encryption_key_id\u0027: \u00278fbf84cf-eb96-484c-9699-0996e593da03\u0027,"},{"line_number":2245,"context_line":"        },"},{"line_number":2246,"context_line":"    }"},{"line_number":2247,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fe42d00c","line":2244,"range":{"start_line":2244,"start_character":40,"end_line":2244,"end_character":77},"updated":"2020-09-17 10:27:22.000000000","message":"I assume this is completely arbitrary and represents...a barbican key?","commit_id":"deb1b5a90446564d5f671ec2c08fe050704ad102"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5fc57165090039c731b05a0ccaa5b19d3c2056ad","unresolved":false,"context_lines":[{"line_number":2243,"context_line":"        \u0027properties\u0027: {"},{"line_number":2244,"context_line":"            \u0027cinder_encryption_key_id\u0027: \u00278fbf84cf-eb96-484c-9699-0996e593da03\u0027,"},{"line_number":2245,"context_line":"        },"},{"line_number":2246,"context_line":"    }"},{"line_number":2247,"context_line":""},{"line_number":2248,"context_line":"    def __init__(self, test):"},{"line_number":2249,"context_line":"        super().__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fed4904d","line":2246,"updated":"2020-09-17 10:27:22.000000000","message":"Any reason not to move this into the test too? The \u0027timestamp\u0027 attribute is easily replicated\n\nThis should make backporting easier since you wouldn\u0027t need to merge this change back into the old \u0027_FakeImageService\u0027 and could simply do\n\n  self.fake_image_service.create(...)","commit_id":"deb1b5a90446564d5f671ec2c08fe050704ad102"}],"nova/tests/functional/regressions/test_bug_1895696.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5fc57165090039c731b05a0ccaa5b19d3c2056ad","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":46,"context_line":"            {\u0027server\u0027: server})"},{"line_number":47,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":48,"context_line":"        self.assertIn(\"Direct booting of an image uploaded from an encrypted \""},{"line_number":49,"context_line":"                      \"volume is unsupported\", str(ex))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_nonbootable_metadata_bfv_image_metadata(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_be5a18ef","line":48,"range":{"start_line":48,"start_character":22,"end_line":48,"end_character":23},"updated":"2020-09-17 10:27:22.000000000","message":"nit: could drag this down to the next line?","commit_id":"deb1b5a90446564d5f671ec2c08fe050704ad102"}]}