)]}'
{"nova/api/metadata/base.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8a21b507a0a3141ed92dee43a59c2f29d8ebf327","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"def _format_instance_mapping(ctxt, instance):"},{"line_number":699,"context_line":"    bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":700,"context_line":"            ctxt, instance.uuid)"},{"line_number":701,"context_line":"    return block_device.instance_block_mapping(instance, bdms)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_10b956ca","line":700,"updated":"2020-09-18 16:18:37.000000000","message":"Note that the instance object already has a targeted context, and we really should be using that for loading things off of the instance. If this line used the instance.get_bdms() handler, then we would use the instance-bound targeted context and we wouldn\u0027t need to pass it through everywhere and change how the metadata object is initialized. I think the interface of metadata being \"here\u0027s an instance, don\u0027t worry about how I got it\" is ideal, unless we really can\u0027t handle that for some reason. From what I can tell, I think this patch could be reduced to just changing this line and that\u0027d be a lot nicer, IMHO.","commit_id":"0b4455e0b448f2a78d1fd53436b65934842173f2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e72faeb580f2d27036e599ef492b3d34f20f0d31","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"def _format_instance_mapping(ctxt, instance):"},{"line_number":699,"context_line":"    bdms \u003d objects.BlockDeviceMappingList.get_by_instance_uuid("},{"line_number":700,"context_line":"            ctxt, instance.uuid)"},{"line_number":701,"context_line":"    return block_device.instance_block_mapping(instance, bdms)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ea93f74c","line":700,"in_reply_to":"9f560f44_10b956ca","updated":"2020-09-21 16:01:06.000000000","message":"Good point! Done.","commit_id":"0b4455e0b448f2a78d1fd53436b65934842173f2"}]}