)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3e28bd606d9917d7a7f8c7e6810268319a3927c3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The \u0027vmcoreinfo\u0027 feature flag enables the vmcoreinfo device, which will"},{"line_number":10,"context_line":"\"create a fw_cfg entry for a guest to store dump details, necessary to"},{"line_number":11,"context_line":"process kernel dump with KASLR enabled and providing additional kernel"},{"line_number":12,"context_line":"details.\" [1] It\u0027s supported since libvirt 3.10 and QEMU 2.11, both of"},{"line_number":13,"context_line":"which are lower than our minimum versions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/libvirt/libvirt/commit/7e4177a35b"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5c49942c_b22ff71f","line":13,"range":{"start_line":12,"start_character":14,"end_line":13,"end_character":42},"updated":"2021-08-12 21:19:05.000000000","message":"Yes https://github.com/openstack/nova/blob/e0cacaa397f8414871f1e2cd589928f9afc27dc7/nova/virt/libvirt/driver.py#L217-L218","commit_id":"740e6f09bf5a3e5ab3c6dd6d412dd1fe33f81d9f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"17f5b6b03a8022db885078d326c998194719e8c3","unresolved":true,"context_lines":[{"line_number":5404,"context_line":""},{"line_number":5405,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":5406,"context_line":"            # vmcoreinfo support is x86, ARM-only for now"},{"line_number":5407,"context_line":"            if caps.host.cpu.arch in ("},{"line_number":5408,"context_line":"                fields.Architecture.I686, fields.Architecture.X86_64,"},{"line_number":5409,"context_line":"                fields.Architecture.AARCH64,"},{"line_number":5410,"context_line":"            ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"34ab5b7d_7565ad31","line":5407,"updated":"2021-01-29 18:37:44.000000000","message":"Instead of hardcoding what architectures we think support vmcoreinfo, I see that it\u0027s being reported in the host hypervisor capabilities, for example here [1] (the tempest job that ran on this very patch). Wouldn\u0027t it be better to parse that out and add \u003cvmcoreinfo/\u003e accordingly?\n\n[1] https://zuul.opendev.org/t/openstack/build/c33842dfe08246b3a8fed837212a748f/log/controller/logs/screen-n-cpu.txt#2671","commit_id":"198049dfe8e17e1566b2d51c744743eff1226d82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd32763486f6721358831d5b94ee88e5cf70042a","unresolved":false,"context_lines":[{"line_number":5404,"context_line":""},{"line_number":5405,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":5406,"context_line":"            # vmcoreinfo support is x86, ARM-only for now"},{"line_number":5407,"context_line":"            if caps.host.cpu.arch in ("},{"line_number":5408,"context_line":"                fields.Architecture.I686, fields.Architecture.X86_64,"},{"line_number":5409,"context_line":"                fields.Architecture.AARCH64,"},{"line_number":5410,"context_line":"            ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"57f71eed_18132ad5","line":5407,"in_reply_to":"34ab5b7d_7565ad31","updated":"2021-03-08 18:35:39.000000000","message":"Good idea. I won\u0027t do it here though since it\u0027ll add a domain capabilities check on the code path of many tests and stubbing that out is hard. I\u0027m removing the need to do so in most cases through improvements to the FakeLibvirtFixture in the secure boot series, but I don\u0027t want this change to depend on that.","commit_id":"198049dfe8e17e1566b2d51c744743eff1226d82"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11d02612b5fe6a3ee841aaee7a8a9d803874feeb","unresolved":true,"context_lines":[{"line_number":5405,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":5406,"context_line":"            # vmcoreinfo support is x86, ARM-only for now"},{"line_number":5407,"context_line":"            if caps.host.cpu.arch in ("},{"line_number":5408,"context_line":"                fields.Architecture.I686, fields.Architecture.X86_64,"},{"line_number":5409,"context_line":"                fields.Architecture.AARCH64,"},{"line_number":5410,"context_line":"            ):"},{"line_number":5411,"context_line":"                guest.features.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"77d0b74f_4a704434","line":5408,"range":{"start_line":5408,"start_character":16,"end_line":5408,"end_character":41},"updated":"2021-01-28 12:54:21.000000000","message":"Do we even support x86/i686 as the compute host arch?","commit_id":"198049dfe8e17e1566b2d51c744743eff1226d82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd32763486f6721358831d5b94ee88e5cf70042a","unresolved":false,"context_lines":[{"line_number":5405,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":5406,"context_line":"            # vmcoreinfo support is x86, ARM-only for now"},{"line_number":5407,"context_line":"            if caps.host.cpu.arch in ("},{"line_number":5408,"context_line":"                fields.Architecture.I686, fields.Architecture.X86_64,"},{"line_number":5409,"context_line":"                fields.Architecture.AARCH64,"},{"line_number":5410,"context_line":"            ):"},{"line_number":5411,"context_line":"                guest.features.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"13982761_c672cdcf","line":5408,"range":{"start_line":5408,"start_character":16,"end_line":5408,"end_character":41},"in_reply_to":"77d0b74f_4a704434","updated":"2021-03-08 18:35:39.000000000","message":"Yes and no. There are a plenty of references to it in the source code but we don\u0027t have hardware to test on (afaik, neither Intel nor AMD have made a non-embedded 32 bit CPU in years - the last ones from Intel were the early Atom chips iirc). I\u0027ve kept this here because it\u0027s technically correct but explicitly failing to run on non X86_64, AARCH64, PPC64(LE) or S390X hosts (and logging about lack of testing for everything non-X86_64) seems like a sensible thing to do in Xena.","commit_id":"198049dfe8e17e1566b2d51c744743eff1226d82"}],"releasenotes/notes/libvirt-vmcoreinfo-3be69e21dfe7dbd2.yaml":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11d02612b5fe6a3ee841aaee7a8a9d803874feeb","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When using the libvirt virt driver with the QEMU or KVM backends, instances"},{"line_number":5,"context_line":"    will now be created with the *vmcoreinfo* feature enabled by default. This"},{"line_number":6,"context_line":"    creates a fw_cfg entry for a guest to store dump details, necessary to"},{"line_number":7,"context_line":"    process kernel dump with KASLR enabled and providing additional kernel"},{"line_number":8,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"46e580dc_b42e6589","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":44},"updated":"2021-01-28 12:54:21.000000000","message":"Could you link to the libvirt docs?","commit_id":"198049dfe8e17e1566b2d51c744743eff1226d82"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd32763486f6721358831d5b94ee88e5cf70042a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When using the libvirt virt driver with the QEMU or KVM backends, instances"},{"line_number":5,"context_line":"    will now be created with the *vmcoreinfo* feature enabled by default. This"},{"line_number":6,"context_line":"    creates a fw_cfg entry for a guest to store dump details, necessary to"},{"line_number":7,"context_line":"    process kernel dump with KASLR enabled and providing additional kernel"},{"line_number":8,"context_line":"    details."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a87c6fde_5bc157b7","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":44},"in_reply_to":"46e580dc_b42e6589","updated":"2021-03-08 18:35:39.000000000","message":"Sure, done.","commit_id":"198049dfe8e17e1566b2d51c744743eff1226d82"}]}