)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f9ceeec90c19ba290ea349bb36cd9258743357ce","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Latest is this[2] \"null pointer dereference\" vulnerability in QEMU\u0027s"},{"line_number":17,"context_line":"floppy drive emulator."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Ideally, we might want to do a deprecation-followed-by-removing-it.  I"},{"line_number":20,"context_line":"first began adding a warning, but then I remembered that back in"},{"line_number":21,"context_line":"2019-February I asked[3] on the list if anyone relied on floppy drives"},{"line_number":22,"context_line":"(due to \u0027VENOM\u0027 at that time), I heard nothing except an ACK by a"},{"line_number":23,"context_line":"developer for the removal.  Though, I realize that not every Operator"},{"line_number":24,"context_line":"would pay attention to the list."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"TODO:"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_e5fca1b7","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":32},"updated":"2020-09-23 11:55:57.000000000","message":"right this does not qualify as deprecation notice so cannot be used to move forward with removal.\n\nunless we have a formal deprecation with a release note i dont think we can do any removal in code.","commit_id":"f222210c6c4f0b348030a59392d7855228aa73ce"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f9ceeec90c19ba290ea349bb36cd9258743357ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"TODO:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":" - Work out the details of versioned object bump when deprecating /"},{"line_number":29,"context_line":"   removing allowable values for hw_floppy_bus / fields.DiskBusField()"},{"line_number":30,"context_line":"   in nova/objects/image_meta.py"},{"line_number":31,"context_line":" - Tests - at a min, fix the below:"},{"line_number":32,"context_line":"    - test_get_device_name_for_instance_device_type"},{"line_number":33,"context_line":"    - test_find_disk_dev"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_252cd948","line":30,"range":{"start_line":28,"start_character":3,"end_line":30,"end_character":32},"updated":"2020-09-23 11:55:57.000000000","message":"you also need to account for hw_disk_bus and hw_rescue_bus\n\nim pretty sure hw_cdrom_bus which is used for isos and configdrive mainly does not work with floppy disks but you also need to check that.","commit_id":"f222210c6c4f0b348030a59392d7855228aa73ce"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9dd8755f304fd6d99ce7a0a8f7e74cb11ff711a3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    elif disk_bus \u003d\u003d \"usb\":"},{"line_number":148,"context_line":"        return \"sd\""},{"line_number":149,"context_line":"    elif disk_bus \u003d\u003d \"fdc\":"},{"line_number":150,"context_line":"        raise exception.EmulatedFloppyDriveIsDeprecated()"},{"line_number":151,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":152,"context_line":"        return \"ubd\""},{"line_number":153,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e56781b7","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":57},"updated":"2020-09-23 11:51:31.000000000","message":"this effectivly remove support it does not deprecate the use of floppy disk drives.\n\nwe shoudl be logging a deprecation waring instead.\n\nalthough likely only in one place not in all 3","commit_id":"3a4c4ad30594ec07e856e01506eb8175cfbe689e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f79112b71c3b52f3bc3e436e38b5fcf33899eab2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    elif disk_bus \u003d\u003d \"usb\":"},{"line_number":148,"context_line":"        return \"sd\""},{"line_number":149,"context_line":"    elif disk_bus \u003d\u003d \"fdc\":"},{"line_number":150,"context_line":"        raise exception.EmulatedFloppyDriveIsDeprecated()"},{"line_number":151,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":152,"context_line":"        return \"ubd\""},{"line_number":153,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_250339c0","line":150,"range":{"start_line":150,"start_character":7,"end_line":150,"end_character":57},"updated":"2020-09-23 11:53:11.000000000","message":"as noted on patchset 1 this effectivly removes supprot it does not depercate it.\nwe shoudl be loggin in one location only.","commit_id":"f222210c6c4f0b348030a59392d7855228aa73ce"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"801eeef52cdee06cb43b53c6ea02c603a69f27f3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    elif disk_bus \u003d\u003d \"usb\":"},{"line_number":148,"context_line":"        return \"sd\""},{"line_number":149,"context_line":"    elif disk_bus \u003d\u003d \"fdc\":"},{"line_number":150,"context_line":"        raise exception.EmulatedFloppyDriveIsDeprecated()"},{"line_number":151,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":152,"context_line":"        return \"ubd\""},{"line_number":153,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8078337e","line":150,"range":{"start_line":150,"start_character":7,"end_line":150,"end_character":57},"in_reply_to":"9f560f44_250339c0","updated":"2020-09-23 12:42:30.000000000","message":"Yeah, I realize that an exception immediately makes it stop working; hence I noted it in the commit message :-)  (I did have a local version where raised a warning indeed.)\n\nAnd yes, with a proper deprecation, reno, etc as indicated in the TODO in the commit message.\n\nAlso (IRC) point noted on the \u0027hw_disk_bus\u0027 and \u0027hw_rescue_bus\u0027.","commit_id":"f222210c6c4f0b348030a59392d7855228aa73ce"}]}