)]}'
{"nova/tests/functional/test_scheduler.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3cefa540711714b3a13f7db2ea8f6398a17c7ddc","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        self._create_aggregate(metadata\u003d{\u0027os_type\u0027: \u0027windows\u0027})"},{"line_number":100,"context_line":"        image \u003d self._create_image(metadata\u003d{\u0027os_type\u0027: \u0027windows\u0027})"},{"line_number":101,"context_line":"        self._create_server(image_uuid\u003dimage[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_filter_rejects_with_prefix(self):"},{"line_number":104,"context_line":"        \"\"\"Ensure the filter allows hosts in aggregates with matching metadata"},{"line_number":105,"context_line":"        when a namespace is configured."}],"source_content_type":"text/x-python","patch_set":1,"id":"b4b62024_ce4f92d2","line":102,"updated":"2021-07-23 14:45:44.000000000","message":"you should test that we also don\u0027t verify image properties related to agg metadata keys that don\u0027t use the namespace.\n\nhttps://github.com/openstack/nova/blob/3508263/nova/scheduler/filters/aggregate_image_properties_isolation.py#L51","commit_id":"c7b15929a6ff267642ded3d2be8ab66b0554197c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b00711f86a29c78037ec572baeb79ecc7fe5b48","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self._create_aggregate(metadata\u003d{\u0027os_type\u0027: \u0027windows\u0027})"},{"line_number":100,"context_line":"        image \u003d self._create_image(metadata\u003d{\u0027os_type\u0027: \u0027windows\u0027})"},{"line_number":101,"context_line":"        self._create_server(image_uuid\u003dimage[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_filter_rejects_with_prefix(self):"},{"line_number":104,"context_line":"        \"\"\"Ensure the filter allows hosts in aggregates with matching metadata"},{"line_number":105,"context_line":"        when a namespace is configured."}],"source_content_type":"text/x-python","patch_set":1,"id":"f13f6837_680cf853","line":102,"in_reply_to":"b4b62024_ce4f92d2","updated":"2021-07-23 14:59:58.000000000","message":"Done","commit_id":"c7b15929a6ff267642ded3d2be8ab66b0554197c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2cd60bb9fd93c89c5a8ffad11d362464bb8c3daa","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        self._create_server(image_uuid\u003dimage[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_filter_rejects_with_prefix(self):"},{"line_number":104,"context_line":"        \"\"\"Ensure the filter allows hosts in aggregates with matching metadata"},{"line_number":105,"context_line":"        when a namespace is configured."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        self.flags("}],"source_content_type":"text/x-python","patch_set":1,"id":"aec932d1_37364968","line":104,"range":{"start_line":104,"start_character":29,"end_line":104,"end_character":35},"updated":"2021-07-23 14:39:27.000000000","message":"copy pasta from above. this test ensures that hosts are rejected","commit_id":"c7b15929a6ff267642ded3d2be8ab66b0554197c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b00711f86a29c78037ec572baeb79ecc7fe5b48","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self._create_server(image_uuid\u003dimage[\u0027id\u0027])"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_filter_rejects_with_prefix(self):"},{"line_number":104,"context_line":"        \"\"\"Ensure the filter allows hosts in aggregates with matching metadata"},{"line_number":105,"context_line":"        when a namespace is configured."},{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        self.flags("}],"source_content_type":"text/x-python","patch_set":1,"id":"223f409c_fc4d19be","line":104,"range":{"start_line":104,"start_character":29,"end_line":104,"end_character":35},"in_reply_to":"aec932d1_37364968","updated":"2021-07-23 14:59:58.000000000","message":"Done","commit_id":"c7b15929a6ff267642ded3d2be8ab66b0554197c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f57a6ebf8ede09d3198df3955e507937ab107040","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        self._create_server(image_uuid\u003dimage[\u0027id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_filter_passes_with_irrelevant_key(self):"},{"line_number":122,"context_line":"        \"\"\"Ensure valid keys that are no in the namespace are ignored by the"},{"line_number":123,"context_line":"        filter."},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        self.flags("}],"source_content_type":"text/x-python","patch_set":2,"id":"ce5206cb_ed52b107","line":122,"range":{"start_line":122,"start_character":38,"end_line":122,"end_character":41},"updated":"2021-07-23 15:14:18.000000000","message":"nit:not","commit_id":"f0d17e774f483a97865f5950ab792041f1d66cfb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"32b2d8ce8949631142323960145d6d92ddd6850a","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        self._create_aggregate(metadata\u003d{\u0027os_type\u0027: \u0027windows\u0027})"},{"line_number":131,"context_line":"        image \u003d self._create_image(metadata\u003d{\u0027hw_firmware_type\u0027: \u0027uefi\u0027})"},{"line_number":132,"context_line":"        self._create_server(image_uuid\u003dimage[\u0027id\u0027])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"class MultiCellSchedulerTestCase(test.TestCase,"},{"line_number":136,"context_line":"                                 integrated_helpers.InstanceHelperMixin):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5655bfa6_7f89c17f","line":133,"updated":"2021-07-23 15:14:08.000000000","message":"thanks !","commit_id":"f0d17e774f483a97865f5950ab792041f1d66cfb"}]}