)]}'
{"nova/tests/functional/test_scheduler.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"08e38a443985ec5f93d0c3e04c7cca1da900f1b5","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_filter_rejects(self):"},{"line_number":143,"context_line":"        \"\"\"Ensure the filter rejects hosts in aggregates with mismatched"},{"line_number":144,"context_line":"        metadata."},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        self._create_aggregate(metadata\u003d{\u0027foo\u0027: \u0027bar\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b699585_52cc4cac","line":143,"range":{"start_line":143,"start_character":29,"end_line":143,"end_character":36},"updated":"2021-07-23 14:52:52.000000000","message":"but test below shows it is accepted not rejected","commit_id":"1fe3276772fb435a4539427475acc37320463ad7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"212647f63bf01d744d60b9fc9f501ae43d8425f4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def test_filter_rejects(self):"},{"line_number":143,"context_line":"        \"\"\"Ensure the filter rejects hosts in aggregates with mismatched"},{"line_number":144,"context_line":"        metadata."},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":"        self._create_aggregate(metadata\u003d{\u0027foo\u0027: \u0027bar\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"34da2616_f9dd9974","line":143,"range":{"start_line":143,"start_character":29,"end_line":143,"end_character":36},"in_reply_to":"2b699585_52cc4cac","updated":"2021-07-23 15:13:45.000000000","message":"I had the wrong filter enabled /o\\","commit_id":"1fe3276772fb435a4539427475acc37320463ad7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9b19425fa7ae78db404346abac882dcc4c252d18","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        flavor_id \u003d self._create_flavor("},{"line_number":148,"context_line":"            extra_spec\u003d{\u0027aggregate_instance_extra_specs:foo\u0027: \u0027baz\u0027})"},{"line_number":149,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"class MultiCellSchedulerTestCase(test.TestCase,"},{"line_number":153,"context_line":"                                 integrated_helpers.InstanceHelperMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"55bfdefd_5c6fd863","line":150,"updated":"2021-07-23 14:48:04.000000000","message":"please also test how to use the default scope for the metadata key, ie. create an agg with aggregate_instance_extra_specs:foo key.","commit_id":"1fe3276772fb435a4539427475acc37320463ad7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0eebd0e7cc14b0af852a846724b07de26cc79231","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        flavor_id \u003d self._create_flavor("},{"line_number":148,"context_line":"            extra_spec\u003d{\u0027aggregate_instance_extra_specs:foo\u0027: \u0027baz\u0027})"},{"line_number":149,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"class MultiCellSchedulerTestCase(test.TestCase,"},{"line_number":153,"context_line":"                                 integrated_helpers.InstanceHelperMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"474362ed_f8055635","line":150,"in_reply_to":"55bfdefd_5c6fd863","updated":"2021-07-23 15:12:55.000000000","message":"\u003e please also test how to use the default scope for the metadata key, ie. create an agg with aggregate_instance_extra_specs:foo key.\n\n\nCall me stupid, the key is on the flavor, not on the extraspec.\nThat\u0027s what happens when you\u0027re out of steam after 5pm on a Friday.","commit_id":"1fe3276772fb435a4539427475acc37320463ad7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"212647f63bf01d744d60b9fc9f501ae43d8425f4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        flavor_id \u003d self._create_flavor("},{"line_number":148,"context_line":"            extra_spec\u003d{\u0027aggregate_instance_extra_specs:foo\u0027: \u0027baz\u0027})"},{"line_number":149,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"class MultiCellSchedulerTestCase(test.TestCase,"},{"line_number":153,"context_line":"                                 integrated_helpers.InstanceHelperMixin):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1f6161f_9d33c778","line":150,"in_reply_to":"55bfdefd_5c6fd863","updated":"2021-07-23 15:13:45.000000000","message":"Discussed on IRC. The scope doesn\u0027t apply to the aggregate metadata, only the flavor metadata. I added tests to validate behavior of the latter *without* the prefix though (deprecated behavior, fwiw)","commit_id":"1fe3276772fb435a4539427475acc37320463ad7"}]}