)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a04571b01cc69f7a793d111027cb1208ffe53fdd","unresolved":false,"context_lines":[{"line_number":7328,"context_line":"        :param instance: Instance with original_volume_id attached"},{"line_number":7329,"context_line":"        :param new_attachment_id: ID of the new attachment for new_volume_id"},{"line_number":7330,"context_line":"        \"\"\""},{"line_number":7331,"context_line":"        @utils.synchronized(instance.uuid)"},{"line_number":7332,"context_line":"        def _do_locked_swap_volume(context, old_volume_id, new_volume_id,"},{"line_number":7333,"context_line":"                                   instance, new_attachment_id):"},{"line_number":7334,"context_line":"            self._do_swap_volume(context, old_volume_id, new_volume_id,"},{"line_number":7335,"context_line":"                                 instance, new_attachment_id)"},{"line_number":7336,"context_line":"        _do_locked_swap_volume(context, old_volume_id, new_volume_id, instance,"},{"line_number":7337,"context_line":"                               new_attachment_id)"},{"line_number":7338,"context_line":""},{"line_number":7339,"context_line":"    def _do_swap_volume(self, context, old_volume_id, new_volume_id,"},{"line_number":7340,"context_line":"                        instance, new_attachment_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f6b1bfe_3e02bbb5","line":7337,"range":{"start_line":7331,"start_character":0,"end_line":7337,"end_character":49},"updated":"2020-10-14 14:17:25.000000000","message":"This would be so much nicer with the structure:\n\n    with utils.lock(instance.uuid):\n        #logic that need locking\n\nit would only need the following def in nova.utils:\n\n    lock \u003d functools.partial(lockutils.lock, lock_file_prefix\u003d\u0027nova-\u0027)\n\nbut I know that we have this nested def and decorator based solution all over the place in nova.","commit_id":"6cf449bdd0d4beb95cf12311e7d2f8669e625fac"}]}