)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0a46db3ab253598eb424ca0213a0709a6af59f69","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"                    CONF.compute.max_concurrent_disk_ops)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        if CONF.compute.max_disk_devices_to_attach \u003d\u003d 0:"},{"line_number":1415,"context_line":"            msg \u003d _(\u0027[compute]max_disk_devices_to_attach has been set to 0, \u0027"},{"line_number":1416,"context_line":"                    \u0027which will prevent instances from being able to boot. \u0027"},{"line_number":1417,"context_line":"                    \u0027Set -1 for unlimited or set \u003e\u003d 1 to limit the maximum \u0027"},{"line_number":1418,"context_line":"                    \u0027number of disk devices.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"aa3b07cf_a880d94b","line":1415,"range":{"start_line":1415,"start_character":21,"end_line":1415,"end_character":56},"updated":"2021-01-28 18:33:50.000000000","message":"supernit - [compute]/max_disk_devices_to_attach","commit_id":"55fac9b2d4e780e27035c6ae3db2d152472fc715"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9c8e5caeb619cfd58dd30d11b1e2ce1aa107ce6b","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                    CONF.compute.max_concurrent_disk_ops)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        if CONF.compute.max_disk_devices_to_attach \u003d\u003d 0:"},{"line_number":1415,"context_line":"            msg \u003d _(\u0027[compute]max_disk_devices_to_attach has been set to 0, \u0027"},{"line_number":1416,"context_line":"                    \u0027which will prevent instances from being able to boot. \u0027"},{"line_number":1417,"context_line":"                    \u0027Set -1 for unlimited or set \u003e\u003d 1 to limit the maximum \u0027"},{"line_number":1418,"context_line":"                    \u0027number of disk devices.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b88968f4_0219a18e","line":1415,"range":{"start_line":1415,"start_character":21,"end_line":1415,"end_character":56},"in_reply_to":"4dfff016_2478dea0","updated":"2021-01-29 09:33:14.000000000","message":"/me blames mriedem for starting this awful trend 😃 Just dropped by to say you\u0027re both wrong and the slash is totally unnecessary because square brackets already delineate the group from the option 😛 If anything you\u0027d wrap the whole thing in quotes but it\u0027s still pretty easy figure out what\u0027s what without them.\n\nAs you were.","commit_id":"55fac9b2d4e780e27035c6ae3db2d152472fc715"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d4bc76abf3608a50a863ef8cf3372ff191b048b3","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"                    CONF.compute.max_concurrent_disk_ops)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        if CONF.compute.max_disk_devices_to_attach \u003d\u003d 0:"},{"line_number":1415,"context_line":"            msg \u003d _(\u0027[compute]max_disk_devices_to_attach has been set to 0, \u0027"},{"line_number":1416,"context_line":"                    \u0027which will prevent instances from being able to boot. \u0027"},{"line_number":1417,"context_line":"                    \u0027Set -1 for unlimited or set \u003e\u003d 1 to limit the maximum \u0027"},{"line_number":1418,"context_line":"                    \u0027number of disk devices.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4dfff016_2478dea0","line":1415,"range":{"start_line":1415,"start_character":21,"end_line":1415,"end_character":56},"in_reply_to":"aa3b07cf_a880d94b","updated":"2021-01-28 21:42:33.000000000","message":"I actually prefer the notation you suggest but stephenfin has asked for the opposite on other patches of mine in the past :P","commit_id":"55fac9b2d4e780e27035c6ae3db2d152472fc715"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21bad794a154178d074245b8f52687a9e4e1b73e","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                    CONF.compute.max_concurrent_disk_ops)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        if CONF.compute.max_disk_devices_to_attach \u003d\u003d 0:"},{"line_number":1415,"context_line":"            msg \u003d _(\u0027[compute]max_disk_devices_to_attach has been set to 0, \u0027"},{"line_number":1416,"context_line":"                    \u0027which will prevent instances from being able to boot. \u0027"},{"line_number":1417,"context_line":"                    \u0027Set -1 for unlimited or set \u003e\u003d 1 to limit the maximum \u0027"},{"line_number":1418,"context_line":"                    \u0027number of disk devices.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"eaddf6f8_84300a16","line":1415,"range":{"start_line":1415,"start_character":21,"end_line":1415,"end_character":56},"in_reply_to":"b88968f4_0219a18e","updated":"2021-01-29 13:21:00.000000000","message":"[compute]/max_disk_devices_to_attach is our convention so i agree with lee and melanie on this one.\nwe shoudl include the /\nbut its not worth holding this up.","commit_id":"55fac9b2d4e780e27035c6ae3db2d152472fc715"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7bc565ade8a661d23b232b4037e775f46b366057","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"                    CONF.compute.max_concurrent_disk_ops)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        if CONF.compute.max_disk_devices_to_attach \u003d\u003d 0:"},{"line_number":1415,"context_line":"            msg \u003d _(\u0027[compute]max_disk_devices_to_attach has been set to 0, \u0027"},{"line_number":1416,"context_line":"                    \u0027which will prevent instances from being able to boot. \u0027"},{"line_number":1417,"context_line":"                    \u0027Set -1 for unlimited or set \u003e\u003d 1 to limit the maximum \u0027"},{"line_number":1418,"context_line":"                    \u0027number of disk devices.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0c4f2415_1424352d","line":1415,"range":{"start_line":1415,"start_character":21,"end_line":1415,"end_character":56},"in_reply_to":"eaddf6f8_84300a16","updated":"2021-01-29 15:10:40.000000000","message":"\u003e is our convention\n\nIt\u0027s really not. I see loads of examples of things both with and without the slash in the code. I see no examples of the latter in the docs, but that\u0027s because we\u0027re using the \u0027:oslo.config:opt:\u0027 role basically everywhere (which renders without the slash). If you\u0027re concerned about delineating the option from the rest of the test, use quotes (or double backticks in rST).","commit_id":"55fac9b2d4e780e27035c6ae3db2d152472fc715"}],"nova/conf/compute.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a1255bf4215f9840379bb6ad76358d36007d0855","unresolved":true,"context_lines":[{"line_number":962,"context_line":"The configured maximum is not enforced on shelved offloaded servers, as they"},{"line_number":963,"context_line":"have no compute host."},{"line_number":964,"context_line":""},{"line_number":965,"context_line":".. note:: If this option is set to 0, it will cause instances not to boot"},{"line_number":966,"context_line":"          because instances will be allowed no disk devices at all."},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"Possible values:"},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c155ab1e_e4dafadc","line":966,"range":{"start_line":965,"start_character":10,"end_line":966,"end_character":67},"updated":"2020-12-07 22:46:46.000000000","message":"Wouldn\u0027t it actually stop n-cpu from starting given the InvalidConfiguration raised from init_host?","commit_id":"1841227c97c0899091b50437b721784bc19fc71c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7bd00ef81494920a59ff198a434e4fb109878270","unresolved":true,"context_lines":[{"line_number":962,"context_line":"The configured maximum is not enforced on shelved offloaded servers, as they"},{"line_number":963,"context_line":"have no compute host."},{"line_number":964,"context_line":""},{"line_number":965,"context_line":".. note:: If this option is set to 0, it will cause instances not to boot"},{"line_number":966,"context_line":"          because instances will be allowed no disk devices at all."},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"Possible values:"},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"0e234855_162696ec","line":966,"range":{"start_line":965,"start_character":10,"end_line":966,"end_character":67},"in_reply_to":"c155ab1e_e4dafadc","updated":"2020-12-07 23:02:37.000000000","message":"Argh, residue from an earlier PS that was only a doc change, before I found precedent of InvalidConfiguration. Thanks for catching.","commit_id":"1841227c97c0899091b50437b721784bc19fc71c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4a99e1e327e979a00ef6539edec944ffeb6343e6","unresolved":false,"context_lines":[{"line_number":962,"context_line":"The configured maximum is not enforced on shelved offloaded servers, as they"},{"line_number":963,"context_line":"have no compute host."},{"line_number":964,"context_line":""},{"line_number":965,"context_line":".. warning:: If this option is set to 0, the ``nova-compute`` service will fail"},{"line_number":966,"context_line":"             to start, as 0 disk devices is an invalid configuration that would"},{"line_number":967,"context_line":"             prevent instances from being able to boot."},{"line_number":968,"context_line":""},{"line_number":969,"context_line":"Possible values:"},{"line_number":970,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6ccbdeb4_5f2a93fa","line":967,"range":{"start_line":965,"start_character":13,"end_line":967,"end_character":54},"updated":"2020-12-08 12:39:42.000000000","message":"ACK thanks!","commit_id":"b0b758bb98fee22c68c025bb4094d366929cd349"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4a99e1e327e979a00ef6539edec944ffeb6343e6","unresolved":true,"context_lines":[{"line_number":969,"context_line":"Possible values:"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"* -1 means unlimited"},{"line_number":972,"context_line":"* Any integer \u003e\u003d 1 represents the maximum allowed. A value of 0"},{"line_number":973,"context_line":"  will cause instances not to boot because they will be allowed 0 disk devices."},{"line_number":974,"context_line":"\"\"\"),"},{"line_number":975,"context_line":"    cfg.StrOpt(\u0027provider_config_location\u0027,"},{"line_number":976,"context_line":"        default\u003d\u0027/etc/nova/provider_config/\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e905a18_d8f27a74","line":973,"range":{"start_line":972,"start_character":51,"end_line":973,"end_character":79},"updated":"2020-12-08 12:39:42.000000000","message":"Could you also update this part?","commit_id":"b0b758bb98fee22c68c025bb4094d366929cd349"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2683ba0c202ea600ad55d8e5a170fae8f513834c","unresolved":true,"context_lines":[{"line_number":969,"context_line":"Possible values:"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"* -1 means unlimited"},{"line_number":972,"context_line":"* Any integer \u003e\u003d 1 represents the maximum allowed. A value of 0"},{"line_number":973,"context_line":"  will cause instances not to boot because they will be allowed 0 disk devices."},{"line_number":974,"context_line":"\"\"\"),"},{"line_number":975,"context_line":"    cfg.StrOpt(\u0027provider_config_location\u0027,"},{"line_number":976,"context_line":"        default\u003d\u0027/etc/nova/provider_config/\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bc665493_6155e774","line":973,"range":{"start_line":972,"start_character":51,"end_line":973,"end_character":79},"in_reply_to":"4e905a18_d8f27a74","updated":"2020-12-08 22:19:35.000000000","message":"Sorry Lee, I am really knocking it out of the park here.","commit_id":"b0b758bb98fee22c68c025bb4094d366929cd349"}]}