)]}'
{"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f0dee67a5764e5bffa986872c059c65d6483f39","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def test_create_server_with_mixed_policy_fails(self):"},{"line_number":285,"context_line":"        \"\"\"Create a server using the \u0027hw:cpu_policy\u003dmixed\u0027 extra spec on a host"},{"line_number":286,"context_line":"        with insufficient shared cores on one node and dedicated cores on the"},{"line_number":287,"context_line":"        other."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        This should fail since both shared and dedicated instance cores should"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_19ce902c","line":286,"range":{"start_line":286,"start_character":13,"end_line":286,"end_character":25},"updated":"2020-10-06 17:30:52.000000000","message":"nit i would remove this","commit_id":"ffb3372d7cb18b45e86a26b902488f4ef9807a3d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f0dee67a5764e5bffa986872c059c65d6483f39","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        self.flags("},{"line_number":296,"context_line":"            cpu_dedicated_set\u003d\u00274-7\u0027, cpu_shared_set\u003d\u00270-3\u0027,"},{"line_number":297,"context_line":"            group\u003d\u0027compute\u0027)"},{"line_number":298,"context_line":"        self.flags(vcpu_pin_set\u003dNone)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        host_info \u003d fakelibvirt.HostInfo("},{"line_number":301,"context_line":"            cpu_nodes\u003d2, cpu_sockets\u003d1, cpu_cores\u003d4, cpu_threads\u003d1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f9d0fcca","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":37},"updated":"2020-10-06 17:30:52.000000000","message":"this should be the defualt by the way but that said i do like seeing it explicit but it technically should not be needed.","commit_id":"ffb3372d7cb18b45e86a26b902488f4ef9807a3d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"93d142b7e562548d13c2e4f44efcf2283803aebb","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        # configuration will result in a libvirt traceback due to attempting to"},{"line_number":328,"context_line":"        # pin the single shared instance vCPU to an empty set"},{"line_number":329,"context_line":"        # self._run_build_test(flavor_id, end_status\u003d\u0027ERROR\u0027)"},{"line_number":330,"context_line":"        self._run_build_test(flavor_id)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_create_server_with_dedicated_policy_old_configuration(self):"},{"line_number":333,"context_line":"        \"\"\"Create a server using the legacy extra spec and configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_58ac6287","line":330,"updated":"2020-10-08 14:12:49.000000000","message":"Maybe I\u0027m digging too deep here, but could we not hax fakelibvirt to validate this part of the XML, and raise the same exception real libvirt would if we pass it the invalid XML you mention in the bug report:\n\n       \u003cvcpupin vcpu\u003d\"0\" cpuset\u003d\"\"/\u003e\n\nIt\u0027s just weird that our functional test is essentially asserting success (albeit without checking usage) when in real life it would be an instance in ERROR.","commit_id":"ffb3372d7cb18b45e86a26b902488f4ef9807a3d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0652e7736aac4c1861d361715df4f830fda14c38","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        # configuration will result in a libvirt traceback due to attempting to"},{"line_number":328,"context_line":"        # pin the single shared instance vCPU to an empty set"},{"line_number":329,"context_line":"        # self._run_build_test(flavor_id, end_status\u003d\u0027ERROR\u0027)"},{"line_number":330,"context_line":"        self._run_build_test(flavor_id)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_create_server_with_dedicated_policy_old_configuration(self):"},{"line_number":333,"context_line":"        \"\"\"Create a server using the legacy extra spec and configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_96224bb9","line":330,"in_reply_to":"9f560f44_58ac6287","updated":"2020-10-08 15:20:02.000000000","message":"Just looked at this. I\u0027d have to add XML checks to \u0027defineXML\u0027, since that\u0027s what\u0027s raising the error. We don\u0027ty currently do a whole lot of error checking in the fakelibvirt driver in general and I don\u0027t think we want to add it since it\u0027s complex and would necessitate unit tests. I think the FIXME is clear enough and we resolve this in the next patch anyway.","commit_id":"ffb3372d7cb18b45e86a26b902488f4ef9807a3d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c8022e484cfc06ecd37cb61ada1999eddbde6fd7","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        # configuration will result in a libvirt traceback due to attempting to"},{"line_number":328,"context_line":"        # pin the single shared instance vCPU to an empty set"},{"line_number":329,"context_line":"        # self._run_build_test(flavor_id, end_status\u003d\u0027ERROR\u0027)"},{"line_number":330,"context_line":"        self._run_build_test(flavor_id)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_create_server_with_dedicated_policy_old_configuration(self):"},{"line_number":333,"context_line":"        \"\"\"Create a server using the legacy extra spec and configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6cc0887d","line":330,"in_reply_to":"9f560f44_96224bb9","updated":"2020-10-08 16:14:43.000000000","message":"Fair. And actually, since any error checking we add to fakelibvirt here would immediately become pointless with the next patch, it\u0027s not worth it.","commit_id":"ffb3372d7cb18b45e86a26b902488f4ef9807a3d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7285af88fecde16a427d691aa174c2df56a848f0","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        host_info \u003d fakelibvirt.HostInfo("},{"line_number":301,"context_line":"            cpu_nodes\u003d2, cpu_sockets\u003d1, cpu_cores\u003d4, cpu_threads\u003d1,"},{"line_number":302,"context_line":"            kB_mem\u003d15740000)"},{"line_number":303,"context_line":"        self.start_compute(host_info\u003dhost_info, hostname\u003d\u0027compute1\u0027)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        # sanity check the created host topology object; this is really just a"},{"line_number":306,"context_line":"        # test of the fakelibvirt module"}],"source_content_type":"text/x-python","patch_set":4,"id":"625436fc_fc392bb4","line":303,"range":{"start_line":303,"start_character":48,"end_line":303,"end_character":67},"updated":"2021-02-16 17:35:51.000000000","message":"Not required but makes the get_by_nodename call below make sense I guess.","commit_id":"9e1fe29d768fce81fedb83c4f36790897f25c4a1"}]}