)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8f82b880621f8459eb83e23941058433af174f6b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"In the case where it is not, the instantiation of md5 will be allowed."},{"line_number":18,"context_line":"See https://bugs.python.org/issue9216 for more details."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some downstream python versions already support this parameter.  To"},{"line_number":21,"context_line":"support these versions, a new encapsulation of md5() has been added to"},{"line_number":22,"context_line":"oslo_utils.  See https://review.opendev.org/#/c/750031/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch is to replace the instances of hashlib.md5() with this new"},{"line_number":25,"context_line":"encapsulation, adding an annotation indicating whether the usage is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_2d3ea9b8","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":55},"updated":"2020-10-07 09:04:47.000000000","message":"Do we need to bump the required oslo_utils version to see this addition?","commit_id":"627d449b0af7d66712c38e381ea42b96f6cd5201"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"04e6714c152979c7732bfd33e50722ed75de9f31","unresolved":false,"context_lines":[{"line_number":17,"context_line":"In the case where it is not, the instantiation of md5 will be allowed."},{"line_number":18,"context_line":"See https://bugs.python.org/issue9216 for more details."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Some downstream python versions already support this parameter.  To"},{"line_number":21,"context_line":"support these versions, a new encapsulation of md5() has been added to"},{"line_number":22,"context_line":"oslo_utils.  See https://review.opendev.org/#/c/750031/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch is to replace the instances of hashlib.md5() with this new"},{"line_number":25,"context_line":"encapsulation, adding an annotation indicating whether the usage is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_1c0dd134","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":55},"in_reply_to":"9f560f44_2d3ea9b8","updated":"2020-10-07 14:41:24.000000000","message":"Yes - and unfortunately, it seems that that won\u0027t be possible till we have an oslo.utils release - which probably won\u0027t be till after the PTG.  So, until then, the tests will not pass.\n\nI\u0027m putting these up now to get initial feedback, especially from security folks, to ensure that what we\u0027re doing is valid.","commit_id":"627d449b0af7d66712c38e381ea42b96f6cd5201"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8f82b880621f8459eb83e23941058433af174f6b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"functional tests pass when run on a FIPS enabled system."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: If0ec11e7b7fcde4dacc57265c4dd77b0f536bfab"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/#/c/756432"},{"line_number":38,"context_line":"Depends-On: https://review.opendev.org/#/c/756153"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_cd260d68","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":49},"updated":"2020-10-07 09:04:47.000000000","message":"I\u0027m not sure but I think the proper formatting of these is \n\nDepends-On: https://review.opendev.org/756432\nDepends-On: https://review.opendev.org/756153","commit_id":"627d449b0af7d66712c38e381ea42b96f6cd5201"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"04e6714c152979c7732bfd33e50722ed75de9f31","unresolved":false,"context_lines":[{"line_number":34,"context_line":"functional tests pass when run on a FIPS enabled system."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: If0ec11e7b7fcde4dacc57265c4dd77b0f536bfab"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/#/c/756432"},{"line_number":38,"context_line":"Depends-On: https://review.opendev.org/#/c/756153"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_bc25c5b0","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":49},"in_reply_to":"9f560f44_cd260d68","updated":"2020-10-07 14:41:24.000000000","message":"thanks - will fix.","commit_id":"627d449b0af7d66712c38e381ea42b96f6cd5201"}],"nova/utils.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3bafd6b6aa5fd1103bb2a20334ebe33a4669824e","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    \"\"\""},{"line_number":788,"context_line":"    if isinstance(base_str, six.text_type):"},{"line_number":789,"context_line":"        base_str \u003d base_str.encode(\u0027utf-8\u0027)"},{"line_number":790,"context_line":"    return md5(base_str, usedforsecurity\u003dFalse).hexdigest()"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"def get_sha256_str(base_str):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_4120eaac","line":790,"range":{"start_line":790,"start_character":4,"end_line":790,"end_character":59},"updated":"2020-11-10 15:13:58.000000000","message":"Ah so this doesn\u0027t actually change anything, as proven by the tests in oslo_utils:\n\nhttps://review.opendev.org/#/c/750031/9/oslo_utils/tests/test_secretutils.py","commit_id":"c82ce37635e397d0e3344ff99c971d92f06aa6c5"}]}