)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597ac868c88152e46cc49772cfa990049d5f31f2","unresolved":false,"context_lines":[{"line_number":980,"context_line":"  https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"\"\"\"),"},{"line_number":983,"context_line":"    cfg.ListOpt(\u0027image_type_exclude_list\u0027,"},{"line_number":984,"context_line":"                default\u003d[],"},{"line_number":985,"context_line":"                help\u003d\"\"\""},{"line_number":986,"context_line":"A list of image formats that should not be advertised as supported by this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9638793b","line":983,"range":{"start_line":983,"start_character":17,"end_line":983,"end_character":40},"updated":"2020-10-09 13:37:37.000000000","message":"this is kind of nit, but could we not have the \u0027_list\u0027 suffix? How about \u0027disabled_image_types\u0027 or \u0027ignored_image_types\u0027?","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c11fbe710142d56252664d30debc1be0a5ebaef9","unresolved":false,"context_lines":[{"line_number":980,"context_line":"  https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"\"\"\"),"},{"line_number":983,"context_line":"    cfg.ListOpt(\u0027image_type_exclude_list\u0027,"},{"line_number":984,"context_line":"                default\u003d[],"},{"line_number":985,"context_line":"                help\u003d\"\"\""},{"line_number":986,"context_line":"A list of image formats that should not be advertised as supported by this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f5fd6a3b","line":983,"range":{"start_line":983,"start_character":17,"end_line":983,"end_character":40},"in_reply_to":"9f560f44_913a43c1","updated":"2020-10-09 15:48:39.000000000","message":"\u003e I\u0027m fine removing the list suffix (although I\u0027m not sure why it\u0027s\n \u003e bad). Doing so makes the resulting name awkward though. I could\n \u003e make it \"excluded_image_types\"  but I dunno, that doesn\u0027t seem as\n \u003e good to me.\n\n\u0027excluded_image_types\u0027 would work for me. It indicates that it\u0027s a list (plural) and seems clear enough. \u0027unreported_image_types\u0027 is yet another option, though it is a bit of a mouthful. fwict we don\u0027t have any other options that encode their type into the name of the option so I\u0027m eager to avoid that","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2942590061953c0df43addc4c9c17120dc5f4ec","unresolved":false,"context_lines":[{"line_number":980,"context_line":"  https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"\"\"\"),"},{"line_number":983,"context_line":"    cfg.ListOpt(\u0027image_type_exclude_list\u0027,"},{"line_number":984,"context_line":"                default\u003d[],"},{"line_number":985,"context_line":"                help\u003d\"\"\""},{"line_number":986,"context_line":"A list of image formats that should not be advertised as supported by this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_913a43c1","line":983,"range":{"start_line":983,"start_character":17,"end_line":983,"end_character":40},"in_reply_to":"9f560f44_9638793b","updated":"2020-10-09 13:59:03.000000000","message":"Well, I don\u0027t like either of those because this doesn\u0027t disable (or ignore) them, it only disables advertising them, and if you don\u0027t filter based on those capabilities, the compute node will still boot these images.\n\nI\u0027m fine removing the list suffix (although I\u0027m not sure why it\u0027s bad). Doing so makes the resulting name awkward though. I could make it \"excluded_image_types\"  but I dunno, that doesn\u0027t seem as good to me.","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b10e09313cd4436a93a95e377af80cf46c5c6d67","unresolved":false,"context_lines":[{"line_number":980,"context_line":"  https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"\"\"\"),"},{"line_number":983,"context_line":"    cfg.ListOpt(\u0027image_type_exclude_list\u0027,"},{"line_number":984,"context_line":"                default\u003d[],"},{"line_number":985,"context_line":"                help\u003d\"\"\""},{"line_number":986,"context_line":"A list of image formats that should not be advertised as supported by this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f8639fdb","line":983,"range":{"start_line":983,"start_character":17,"end_line":983,"end_character":40},"in_reply_to":"9f560f44_f5fd6a3b","updated":"2020-10-09 16:07:27.000000000","message":"We have:\n\n iscsi_initiator_list\n\nas well as this which is similar enough to be considered the same I think:\n\n passthrough_whitelist\n\nI almost like \"unreported_image_types\" although it kinda sounds like it affects something visible to users or stats or something, which it doesn\u0027t. But again, I think we\u0027re far into the weeds of minutia here, so if you really want excluded_image_types or something, just say so and I\u0027ll change it.","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597ac868c88152e46cc49772cfa990049d5f31f2","unresolved":false,"context_lines":[{"line_number":984,"context_line":"                default\u003d[],"},{"line_number":985,"context_line":"                help\u003d\"\"\""},{"line_number":986,"context_line":"A list of image formats that should not be advertised as supported by this"},{"line_number":987,"context_line":"compute node. In some situations, it may be desirable to have a compute node"},{"line_number":988,"context_line":"refuse to support an expensive or complex image format. This factors into"},{"line_number":989,"context_line":"the decisions made by the scheduler about which compute node to select when"},{"line_number":990,"context_line":"booted with a given image."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3611adb0","line":987,"range":{"start_line":987,"start_character":13,"end_line":987,"end_character":14},"updated":"2020-10-09 13:37:37.000000000","message":"newline after this.\n\n  summary\n\n  description","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597ac868c88152e46cc49772cfa990049d5f31f2","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":"Related options:"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"* ``scheduler.query_placement_for_image_type_support`` - enables filtering"},{"line_number":999,"context_line":"  computes based on supported image types."},{"line_number":1000,"context_line":"\"\"\"),"},{"line_number":1001,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7607a571","line":998,"range":{"start_line":998,"start_character":4,"end_line":998,"end_character":14},"updated":"2020-10-09 13:37:37.000000000","message":"nit:\n\n  [scheduler]","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597ac868c88152e46cc49772cfa990049d5f31f2","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":"Related options:"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"* ``scheduler.query_placement_for_image_type_support`` - enables filtering"},{"line_number":999,"context_line":"  computes based on supported image types."},{"line_number":1000,"context_line":"\"\"\"),"},{"line_number":1001,"context_line":"]"},{"line_number":1002,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_365fed75","line":999,"range":{"start_line":998,"start_character":57,"end_line":999,"end_character":42},"updated":"2020-10-09 13:37:37.000000000","message":"This is ignored unless filtering of computes based on supported image types is enabled.","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"88f43b478bc5e842953726efa759236c3ce99f9d","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":"Related options:"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"* ``scheduler.query_placement_for_image_type_support`` - enables filtering"},{"line_number":999,"context_line":"  computes based on supported image types."},{"line_number":1000,"context_line":"\"\"\"),"},{"line_number":1001,"context_line":"]"},{"line_number":1002,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f1b1ff46","line":999,"range":{"start_line":998,"start_character":57,"end_line":999,"end_character":42},"in_reply_to":"9f560f44_365fed75","updated":"2020-10-09 14:01:11.000000000","message":"This sounds like you\u0027re saying the related option is ignored if ...something. But I\u0027ll tack on something to what I have to, I think, get at the spirit of what you\u0027re going for.","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"}],"nova/virt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597ac868c88152e46cc49772cfa990049d5f31f2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    \"\"\""},{"line_number":146,"context_line":"    image_type \u003d capability.replace(\u0027supports_image_type_\u0027, \u0027\u0027)"},{"line_number":147,"context_line":"    return (supported and"},{"line_number":148,"context_line":"            image_type not in CONF.compute.image_type_exclude_list)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ComputeDriver(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f61a95c4","line":148,"updated":"2020-10-09 13:37:37.000000000","message":"Given this only has the one caller and isn\u0027t complex, can we just fold it in? Shouldn\u0027t make the tests significantly more complex nor impact backportability","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c11fbe710142d56252664d30debc1be0a5ebaef9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    \"\"\""},{"line_number":146,"context_line":"    image_type \u003d capability.replace(\u0027supports_image_type_\u0027, \u0027\u0027)"},{"line_number":147,"context_line":"    return (supported and"},{"line_number":148,"context_line":"            image_type not in CONF.compute.image_type_exclude_list)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ComputeDriver(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b59db20a","line":148,"in_reply_to":"9f560f44_5120ab9a","updated":"2020-10-09 15:48:39.000000000","message":"Okay, cool. In that case, should it still be private? If we\u0027re expecting people to override \u0027capabilities_as_traits\u0027 but still call this, we probably don\u0027t want them accessing a \"private\" attribute from this module?","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b10e09313cd4436a93a95e377af80cf46c5c6d67","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    \"\"\""},{"line_number":146,"context_line":"    image_type \u003d capability.replace(\u0027supports_image_type_\u0027, \u0027\u0027)"},{"line_number":147,"context_line":"    return (supported and"},{"line_number":148,"context_line":"            image_type not in CONF.compute.image_type_exclude_list)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ComputeDriver(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_784f8f69","line":148,"in_reply_to":"9f560f44_b59db20a","updated":"2020-10-09 16:07:27.000000000","message":"I didn\u0027t mean to imply that we\u0027d expect people to override and call this themselves, I\u0027d still expect them to call super() like normal and not bypass the behavior in the subclass. I just think it makes the condition a little more non-negotiable being outside the class. I really didn\u0027t expect this much discussion or concern over it, especially given the similar pattern in the file here.\n\nSo, I don\u0027t really care - I can de-private  this, or I can move it into the class if you really feel strongly. If anything this gives us a place to clearly document the behavior of the filter without cluttering the otherwise simple caps-to-traits mapping function. Because of that, I\u0027d still prefer this arrangement, but I care less than the amount of time we\u0027ve spent discussing this already, so ... just tell me which you want and I\u0027ll change it :)","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2942590061953c0df43addc4c9c17120dc5f4ec","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    \"\"\""},{"line_number":146,"context_line":"    image_type \u003d capability.replace(\u0027supports_image_type_\u0027, \u0027\u0027)"},{"line_number":147,"context_line":"    return (supported and"},{"line_number":148,"context_line":"            image_type not in CONF.compute.image_type_exclude_list)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ComputeDriver(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5120ab9a","line":148,"in_reply_to":"9f560f44_f61a95c4","updated":"2020-10-09 13:59:03.000000000","message":"I specifically put this here to make it clear (which obviously failed) that this part of the logic shouldn\u0027t be override-able by the implementing driver. Obviously if they override capabilities_as_traits() and don\u0027t call this then they can avoid it, but the point is the signaling. Similar to swap_is_usable() above","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"}],"releasenotes/notes/image-type-exclusion-list-dac61a747a1140a3.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"597ac868c88152e46cc49772cfa990049d5f31f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A ``compute.image_type_exclusion_list`` configuration option was"},{"line_number":5,"context_line":"    added to remove supported image types from being advertised by a"},{"line_number":6,"context_line":"    compute node as supported. This is to be used in conjunction with"},{"line_number":7,"context_line":"    ``scheduler.query_placement_for_image_type_support`` to prevent"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_96ca3943","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":16},"updated":"2020-10-09 13:37:37.000000000","message":"nit:\n\n [compute] image_type_exclusions","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2942590061953c0df43addc4c9c17120dc5f4ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A ``compute.image_type_exclusion_list`` configuration option was"},{"line_number":5,"context_line":"    added to remove supported image types from being advertised by a"},{"line_number":6,"context_line":"    compute node as supported. This is to be used in conjunction with"},{"line_number":7,"context_line":"    ``scheduler.query_placement_for_image_type_support`` to prevent"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_f12e1f8b","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":16},"in_reply_to":"9f560f44_96ca3943","updated":"2020-10-09 13:59:03.000000000","message":"Er, yeah, I dunno why I did it this way this time.","commit_id":"d2e91decc53ab7d0fec0f6f32bc33344fb6899c3"}]}