)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"da335e16344a3997d9cb2ab778b7d2cf425891df","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch moves the allocation candidate query generation code from the"},{"line_number":10,"context_line":"scheduler utils to the RequestGroup o.vo as it clearly only depends on"},{"line_number":11,"context_line":"that object. The original utils code was predated the patch that added"},{"line_number":12,"context_line":"the RequestGroup o.vo"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is small change in logic. The mapping of the unnamed group, that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1eefbac8_d39e54e1","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":49},"updated":"2021-01-26 16:26:13.000000000","message":"nit: \"predated\" (past tense only)","commit_id":"160e229f85535493fbd4490003800ac2c3f3db80"}],"nova/scheduler/utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0823892e00f875273b8860764e69a7f93a683bd7","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                                  sorted(self._root_forbidden)]"},{"line_number":459,"context_line":"            qparams.append((\u0027root_required\u0027, \u0027,\u0027.join(vals)))"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        for ident, rg in self._rg_by_id.items():"},{"line_number":462,"context_line":"            # [(\u0027resources[$S]\u0027, \u0027rclass:amount,rclass:amount,...\u0027),"},{"line_number":463,"context_line":"            #  (\u0027required[$S]\u0027, \u0027trait_name,!trait_name,...\u0027),"},{"line_number":464,"context_line":"            #  (\u0027member_of[$S]\u0027, \u0027in:uuid,uuid,...\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f6b1bfe_696c6d36","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":48},"updated":"2020-10-15 09:22:49.000000000","message":"So \u0027_rg_by_id\u0027 is a dict of \u0027RequestGroup\u0027 objects keyed by the \u0027requester_id\u0027 of each of those objects. You\u0027ve correctly handled this in the o.vo variant. However, that means we no longer need the key here. Can you update this to use \u0027values()\u0027, now that you no longer require the identifier?","commit_id":"f6397b042aa9b294c43e1336eb1af6cb6e16e686"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c4b7006e4c975addf53ffe0da4bf1e39a6312c4b","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                                  sorted(self._root_forbidden)]"},{"line_number":459,"context_line":"            qparams.append((\u0027root_required\u0027, \u0027,\u0027.join(vals)))"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        for ident, rg in self._rg_by_id.items():"},{"line_number":462,"context_line":"            # [(\u0027resources[$S]\u0027, \u0027rclass:amount,rclass:amount,...\u0027),"},{"line_number":463,"context_line":"            #  (\u0027required[$S]\u0027, \u0027trait_name,!trait_name,...\u0027),"},{"line_number":464,"context_line":"            #  (\u0027member_of[$S]\u0027, \u0027in:uuid,uuid,...\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6e1dfa5_ad9ab702","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":48},"in_reply_to":"7f6b1bfe_696c6d36","updated":"2020-11-30 10:17:10.000000000","message":"Done","commit_id":"f6397b042aa9b294c43e1336eb1af6cb6e16e686"}]}