)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad935934bbc3181158e04de4a1000ce339780410","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute: Don\u0027t detach volumes when RescheduledException raised without retry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I877d8eff8d2fecde0cd16b01e80bff41bdb8d88a introduced a crude call to"},{"line_number":10,"context_line":"_cleanup_volumes within _do_build_and_run_instance when handling a"},{"line_number":11,"context_line":"RescheduledException exception raised from _build_and_run_instance"},{"line_number":12,"context_line":"without any retry information provided from the scheduler."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_309f98b5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":41},"updated":"2020-10-13 16:22:22.000000000","message":"You should comment on this stating that we later reverted it, just for anyone watching","commit_id":"32f0fe82b776868c8c63557cb0ba71b33a9956c3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"041dfd50c032fe0e4195c6da40ed6b4a90b11064","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute: Don\u0027t detach volumes when RescheduledException raised without retry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I877d8eff8d2fecde0cd16b01e80bff41bdb8d88a introduced a crude call to"},{"line_number":10,"context_line":"_cleanup_volumes within _do_build_and_run_instance when handling a"},{"line_number":11,"context_line":"RescheduledException exception raised from _build_and_run_instance"},{"line_number":12,"context_line":"without any retry information provided from the scheduler."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6b1bfe_d0f744d4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":41},"in_reply_to":"7f6b1bfe_309f98b5","updated":"2020-10-13 16:30:39.000000000","message":"Done.","commit_id":"32f0fe82b776868c8c63557cb0ba71b33a9956c3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d12ca53e0d27ce52ee88de7272ef64fbcd8875ad","unresolved":false,"context_lines":[{"line_number":15,"context_line":"skip the scheduler by providing both a target availability_zone and host"},{"line_number":16,"context_line":"in the format of `$availability_zone:$host`. If the instance is unable"},{"line_number":17,"context_line":"to build on the compute the failure will eventually lead to"},{"line_number":18,"context_line":"_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either"},{"line_number":19,"context_line":"detach (cinderv2) or delete the associated volume attachments (cinderv3)"},{"line_number":20,"context_line":"moving the volume to an `available` state, assuming it isn\u0027t"},{"line_number":21,"context_line":"multi-attached etc."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The issue with this is that this behaviour is in stark contrast to that"},{"line_number":24,"context_line":"of volumes associated with instances that have failed to schedule. In"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_82ff4466","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":19},"updated":"2020-11-23 18:58:49.000000000","message":"Due to I8b1c05317734e14ea73dc868941351bb31210bf0","commit_id":"b7e87f5f425b68a2d87c4d26a04194563e2a97e3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e08703f19c0e83adb81eb51c2c6500051e80cae6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"This change aims to align both cases by removing the call to"},{"line_number":29,"context_line":"_cleanup_volumes and in doing so keeping any volumes in a `reserved`"},{"line_number":30,"context_line":"state until the underlying instance is deleted."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: #1899649"},{"line_number":33,"context_line":"Change-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f621f24_e7bbaa0b","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":47},"updated":"2020-10-28 11:24:53.000000000","message":"this part is not covered with the current regression tests. But I think it is covered elsewhere https://review.opendev.org/#/c/340614/21/nova/tests/functional/regressions/test_bug_1404867.py@83","commit_id":"b7e87f5f425b68a2d87c4d26a04194563e2a97e3"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e08703f19c0e83adb81eb51c2c6500051e80cae6","unresolved":false,"context_lines":[{"line_number":2230,"context_line":"                    instance\u003dinstance)"},{"line_number":2231,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":2232,"context_line":"                    requested_networks)"},{"line_number":2233,"context_line":"                self._cleanup_volumes(context, instance,"},{"line_number":2234,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":2235,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":2236,"context_line":"                        instance, e, sys.exc_info(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_a7f412d1","side":"PARENT","line":2233,"updated":"2020-10-28 11:24:53.000000000","message":"This partially reverts https://review.opendev.org/#/c/528385/19/nova/compute/manager.py . Will we recreate the bug[1] that was solved there?\n\n[1] https://bugs.launchpad.net/nova/+bug/1633249","commit_id":"770c139edbd2a2c90d6cb2915948e1718dd1deca"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d12ca53e0d27ce52ee88de7272ef64fbcd8875ad","unresolved":false,"context_lines":[{"line_number":2230,"context_line":"                    instance\u003dinstance)"},{"line_number":2231,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":2232,"context_line":"                    requested_networks)"},{"line_number":2233,"context_line":"                self._cleanup_volumes(context, instance,"},{"line_number":2234,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":2235,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":2236,"context_line":"                        instance, e, sys.exc_info(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_cd116d56","side":"PARENT","line":2233,"in_reply_to":"1f621f24_a7f412d1","updated":"2020-11-23 18:58:49.000000000","message":"Yeah this reverts that when an instance isn\u0027t rescheduled.\n\nI\u0027m just looking to unify the failure cases here so we end up in a \\","commit_id":"770c139edbd2a2c90d6cb2915948e1718dd1deca"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0f627848c10b59eac7ee0f30023798a5a47841d5","unresolved":false,"context_lines":[{"line_number":2230,"context_line":"                    instance\u003dinstance)"},{"line_number":2231,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":2232,"context_line":"                    requested_networks)"},{"line_number":2233,"context_line":"                self._cleanup_volumes(context, instance,"},{"line_number":2234,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":2235,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":2236,"context_line":"                        instance, e, sys.exc_info(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c96e481_efa4251d","side":"PARENT","line":2233,"in_reply_to":"1f621f24_cd116d56","updated":"2020-11-25 10:38:50.000000000","message":"Apologies I had a draft comment that I forgot to finish and post. The recent gerrit upgrade then allowed me to post all these thus this random comment.\n\nWhat I believe I was trying to say was that with https://review.opendev.org/c/openstack/nova/+/340614 fixing the removal of volume attachments associated with an ERROR\u0027d out instance I think we should drop any attempt to do so during a failure to build etc to be consistent across the codebase.","commit_id":"770c139edbd2a2c90d6cb2915948e1718dd1deca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d8c94e3208bd3d7e7f245f497e0b414ffba7513f","unresolved":false,"context_lines":[{"line_number":2230,"context_line":"                    instance\u003dinstance)"},{"line_number":2231,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":2232,"context_line":"                    requested_networks)"},{"line_number":2233,"context_line":"                self._cleanup_volumes(context, instance,"},{"line_number":2234,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":2235,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":2236,"context_line":"                        instance, e, sys.exc_info(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"59aa5b94_ba1f30f1","side":"PARENT","line":2233,"in_reply_to":"6c96e481_efa4251d","updated":"2020-11-25 11:38:30.000000000","message":"So the attachment will be cleaned when the ERROR\u0027d VM is deleted. That is OK to me.","commit_id":"770c139edbd2a2c90d6cb2915948e1718dd1deca"}]}