)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8d5d49f8dbaa28fc725344bff5e9102456be12d0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-24 15:29:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"objects: Remove \u0027BandwidthUsage\u0027, \u0027BandwidthUsageList\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027re not able to remove them entirely yet, since they are still"},{"line_number":10,"context_line":"reported by Victoria-based compute nodes and Wallaby-era conductors must"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7e5dc329_d14ae76e","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":15},"updated":"2020-11-30 11:29:25.000000000","message":"nit - Well we don\u0027t actually remove them here, we just make them inert.","commit_id":"307a8a36cc96325a1f3ad247dd9cba99b0661749"}],"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"327b179fcc76b603cd223db329393b19d427b81d","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        return self.metadetails[\u0027availability_zone\u0027]"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"# TODO(stephenfin): Remove this in the X release or later, once we\u0027re sure we"},{"line_number":1213,"context_line":"# won\u0027t want it back (it\u0027s for a XenAPI-only feature)"},{"line_number":1214,"context_line":"class AgentBuild(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1215,"context_line":"    \"\"\"Represents an agent build.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9b718aab","line":1212,"updated":"2020-11-16 15:29:31.000000000","message":"You need to remove the model the release before you delete the table. I think you can go ahead and do that if you\u0027ve eliminated every possible way to get there, right?","commit_id":"edeb9786fb879071231ebd28ec94a8938142986a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8f902df62b40d09d46532563bf18e5d5b72be6e3","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        return self.metadetails[\u0027availability_zone\u0027]"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"# TODO(stephenfin): Remove this in the X release or later, once we\u0027re sure we"},{"line_number":1213,"context_line":"# won\u0027t want it back (it\u0027s for a XenAPI-only feature)"},{"line_number":1214,"context_line":"class AgentBuild(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1215,"context_line":"    \"\"\"Represents an agent build.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_d95c981a","line":1212,"updated":"2020-11-17 16:59:59.000000000","message":"Same comment from the previous set. Is there some reason you\u0027re not removing the models now? Because we won\u0027t be able to drop the tables in X if we don\u0027t. If all the code that hits them is gone in this release, there\u0027s really no reason to keep them, AFAIK. Somewhere in the model sync test there\u0027s a list you can add these to so it doesn\u0027t complain about them being missing.","commit_id":"9a9230131cb2edec2edc7caf055a543d980bcc76"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2324c2bdacbbe6027527224ddc24451c0245afe1","unresolved":true,"context_lines":[{"line_number":1209,"context_line":"        return self.metadetails[\u0027availability_zone\u0027]"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"# TODO(stephenfin): Remove this in the X release or later, once we\u0027re sure we"},{"line_number":1213,"context_line":"# won\u0027t want it back (it\u0027s for a XenAPI-only feature)"},{"line_number":1214,"context_line":"class AgentBuild(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1215,"context_line":"    \"\"\"Represents an agent build.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"db67efe5_23fe4ee2","line":1212,"in_reply_to":"1f621f24_d95c981a","updated":"2020-11-23 16:34:53.000000000","message":"I\u0027ve previously attempted to do this [1] but it\u0027s still not entirely clear to me how this should be achieved. [1] suggests that I should drop the table first. If it\u0027s okay with you, I\u0027d rather tackle this separately via a follow-up. There are loads of models to be cleaned up here.\n\n[1] https://review.opendev.org/c/openstack/nova/+/698706","commit_id":"9a9230131cb2edec2edc7caf055a543d980bcc76"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0f0f5a3c3894064d5c2392025ee5baa2fd7f2f47","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        return self.metadetails[\u0027availability_zone\u0027]"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"# TODO(stephenfin): Remove this in the X release or later, once we\u0027re sure we"},{"line_number":1213,"context_line":"# won\u0027t want it back (it\u0027s for a XenAPI-only feature)"},{"line_number":1214,"context_line":"class AgentBuild(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1215,"context_line":"    \"\"\"Represents an agent build.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"41fe122e_ed1a4780","line":1212,"in_reply_to":"5277228c_879e3ef3","updated":"2020-11-23 17:11:28.000000000","message":"Okay, let\u0027s do that so. I\u0027m going to keep it separate because I also have a load of other models to drop at the same time and I might as well do them in one go (same whitelist needed for all)","commit_id":"9a9230131cb2edec2edc7caf055a543d980bcc76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"655e93239d94d1b9758b8d826c74981101b2ee2e","unresolved":true,"context_lines":[{"line_number":1209,"context_line":"        return self.metadetails[\u0027availability_zone\u0027]"},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"# TODO(stephenfin): Remove this in the X release or later, once we\u0027re sure we"},{"line_number":1213,"context_line":"# won\u0027t want it back (it\u0027s for a XenAPI-only feature)"},{"line_number":1214,"context_line":"class AgentBuild(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1215,"context_line":"    \"\"\"Represents an agent build.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5277228c_879e3ef3","line":1212,"in_reply_to":"db67efe5_23fe4ee2","updated":"2020-11-23 16:53:35.000000000","message":"If you look at my last comment on that patch, it kinda explains the point. If you remove the models now, then you can drop the schema later knowing that every use of it is gone in the previous release. However, in that patch\u0027s case you were asserting that they were *already* completely unused and wanted to do both in the same cycle, which is why we had you put the schema drop before the model drop to prove it. It\u0027s just cleaner and clearer to drop the models when you drop the use of them (IMHO) so that next cycle it\u0027s obvious that the schema is unreachable by both the N-1 release we have to support, along with the N release in which you\u0027re doing it.\n\nI don\u0027t really care if you do it in this patch or a follow-on (although I\u0027m not sure why you would want to make it two patches).","commit_id":"9a9230131cb2edec2edc7caf055a543d980bcc76"}]}