)]}'
{"id":"openstack%2Fnova~759256","triplet_id":"openstack%2Fnova~master~I0aac6a3cc80cabc6c292374505f4bb1a2f513540","project":"openstack/nova","branch":"master","topic":"bp/compact-db-migrations-wallaby","hashtags":[],"change_id":"I0aac6a3cc80cabc6c292374505f4bb1a2f513540","subject":"db: Compact Kilo database migrations","status":"ABANDONED","created":"2020-10-22 12:35:28.000000000","updated":"2020-10-22 13:07:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c9ed87b26c3d5b05058f8c889737894e4cf2b5c0","_number":759256,"virtual_id_number":759256,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"all":[{"date":"2020-10-22 13:07:33.000000000","_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-22 13:07:33.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b40743c92ffc6daaaa12469864daad9e932fb58e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-10-22 12:35:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c08f5a1f5aae1d4f572a4ed6e17d3f033ffb2568","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-10-22 12:35:54.000000000","message":"Abandoned\n\nDuplicate of https://review.opendev.org/#/c/758396/","accounts_in_message":[],"_revision_number":1},{"id":"c9e6a58380204e96a2b6a56ab74ff04a3f280230","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-10-22 13:07:33.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/759256/1 : FAILURE","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c6e6f78428416561a262cd779dbb10a9cfe4716c","revisions":{"c6e6f78428416561a262cd779dbb10a9cfe4716c":{"kind":"REWORK","_number":1,"created":"2020-10-22 12:35:28.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/56/759256/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/56/759256/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/759256/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/759256/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/56/759256/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/56/759256/1"}}},"commit":{"parents":[{"commit":"673cc06c9c448ee06cd6c24682ddc3233d45cf4e","subject":"db: Compact Juno database migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/673cc06c9c448ee06cd6c24682ddc3233d45cf4e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-10-22 10:39:04.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-10-22 12:34:22.000000000","tz":60},"subject":"db: Compact Kilo database migrations","message":"db: Compact Kilo database migrations\n\nCompacts Kilo database migrations into a single migration,\n\u0027280_kilo.py\u0027.\n\nUsers will now need to update to Kilo before updating to Liberty of\nlater.\n\nThis change is significantly more complicated than previous compactions,\nmostly due to the changes to indexes specifically for PostgreSQL and\nSQLite.\n\nSpecific changes include:\n\n- Drop duplicate index covering \u0027host\u0027 and \u0027deleted\u0027 field of\n  \u0027instances\u0027 table (265)\n- Drop duplicate index covering \u0027host\u0027 field of \u0027iscsi_targets\u0027 table\n  (265)\n- Add \u0027tags\u0027 table (266)\n- Alter \u0027uuid\u0027 column of \u0027instances\u0027 table to be non-nullable (267)\n- Add unique constraint to \u0027uuid\u0027 column of \u0027instances\u0027 table (267)\n- Add \u0027host\u0027 column to \u0027compute_nodes\u0027 table (268)\n- Add unique constraint to \u0027host\u0027 and \u0027hypervisor_hostname\u0027 columns of\n  \u0027compute_nodes\u0027 table (268)\n- Add \u0027numa_node\u0027 column to \u0027pci_devices\u0027 table (269)\n- Add \u0027flavor\u0027 column to \u0027instance_extra\u0027 table (270)\n- Add a number of missing indexes to multiple tables on SQLite and\n  PostgreSQL (271)\n- Add a number of missing foreign keys and unique constraints to\n  multiple tables on SQLite (273)\n- Add index covering \u0027project_id\u0027 and \u0027deleted\u0027 columns of \u0027instances\u0027\n  table (274)\n- Drop index covering \u0027project_id\u0027 column of \u0027instances\u0027 table (274)\n- Add \u0027type\u0027 column to \u0027key_pairs\u0027 table (275)\n- Add \u0027vcpu_model\u0027 column to \u0027instance_extra\u0027 table (276)\n- Add index covering \u0027deleted\u0027, \u0027allocated\u0027, and \u0027updated_at\u0027 columns of\n  \u0027fixed_ips\u0027 table (277)\n- Alter \u0027service_id\u0027 column of \u0027compute_nodes\u0027 table to be nullable\n  (278)\n- Drop foreign key constraint on \u0027service_id\u0027 column of \u0027compute_nodes\u0027\n  table (278)\n- Drop unique constraint covering \u0027host\u0027 and \u0027hypervisor_hostname\u0027\n  columns of \u0027compute_nodes\u0027 table in favour of constraint covering\n  \u0027host\u0027, \u0027hypervisor_hostname\u0027 and \u0027deleted\u0027 columns (279)\n- Alter \u0027name\u0027 column of \u0027key_pairs\u0027 table to be non-nullable (280)\n\nOnce again, we have a case where we\u0027ve forgotten to apply a change to\nthe shadow table. We also have our first instance of table, the \u0027tags\u0027\ntable, that does is not soft deletable and therefore does not have a\nshadow table. Both are handled and the former can be resolved later.\n\nAlso note that we encounter a small bug in sqlalchemy-migrate, whereby\ndeclaration of an index before a foreign key that affects the same\ncolumn will result in it attempting to drop the index, even if it was\nnever created. See comments inline.\n\nNow that we can rely on the \u0027instances.uuid\u0027 column being unique and\nnon-nullable, we can remove the \u0027null_instance_uuid_scan\u0027 nova-manage\ncommand. This will be done separately.\n\nChange-Id: I0aac6a3cc80cabc6c292374505f4bb1a2f513540\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6e6f78428416561a262cd779dbb10a9cfe4716c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6e6f78428416561a262cd779dbb10a9cfe4716c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}