)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8b65c4535ace647d36a9a5879ba2aa3c3c174594","unresolved":true,"context_lines":[{"line_number":21081,"context_line":"        # for VGPU, for a total of 3 providers."},{"line_number":21082,"context_line":"        # All providers should have an empty dict because (1) we never updated"},{"line_number":21083,"context_line":"        # the self.shared_rp provider and (2) the other 2 providers have zero"},{"line_number":21084,"context_line":"        # for resource totals."},{"line_number":21085,"context_line":"        for uuid in self.pt.get_provider_uuids():"},{"line_number":21086,"context_line":"            self.assertEqual({}, self.pt.data(uuid).inventory)"},{"line_number":21087,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8218a1d2_0d0bcb07","line":21084,"updated":"2020-12-04 03:48:53.000000000","message":"Just realized I should add asserts for the number of expected providers.","commit_id":"9ccff586633dc4d9ebd45d88ba6b2488c615f3b1"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bdeb07bbff4bd98a0bc4804c85dde5b90c244f65","unresolved":false,"context_lines":[{"line_number":21062,"context_line":"        # inventory updates with total\u003d0 as they fail API schema validation."},{"line_number":21063,"context_line":""},{"line_number":21064,"context_line":"        # Use total\u003d0 for vgpus."},{"line_number":21065,"context_line":"        gpu_inventory_dicts \u003d {"},{"line_number":21066,"context_line":"            \u0027pci_0000_06_00_0\u0027: {\u0027total\u0027: 0,"},{"line_number":21067,"context_line":"                                 \u0027max_unit\u0027: 16,"},{"line_number":21068,"context_line":"                                 \u0027min_unit\u0027: 1,"},{"line_number":21069,"context_line":"                                 \u0027step_size\u0027: 1,"},{"line_number":21070,"context_line":"                                 \u0027reserved\u0027: 0,"},{"line_number":21071,"context_line":"                                 \u0027allocation_ratio\u0027: 1.0,"},{"line_number":21072,"context_line":"                                },"},{"line_number":21073,"context_line":"        }"},{"line_number":21074,"context_line":"        mock_gpu_invs.return_value \u003d gpu_inventory_dicts"},{"line_number":21075,"context_line":"        # Use an empty list for vpmems."},{"line_number":21076,"context_line":"        self.driver._vpmems_by_rc \u003d {\u0027CUSTOM_PMEM_NAMESPACE_4GB\u0027: []}"}],"source_content_type":"text/x-python","patch_set":4,"id":"09876e96_fbdd5861","line":21073,"range":{"start_line":21065,"start_character":0,"end_line":21073,"end_character":9},"updated":"2020-12-07 22:54:57.000000000","message":"supernit, not that this really matters in tests but...\n\n        gpu_inventory_dicts \u003d {\n            \u0027pci_0000_06_00_0\u0027: {\n                \u0027total\u0027: 0,\n                \u0027max_unit\u0027: 16,\n                \u0027min_unit\u0027: 1,\n                \u0027step_size\u0027: 1,\n                \u0027reserved\u0027: 0,\n                \u0027allocation_ratio\u0027: 1.0,\n            },\n        }","commit_id":"0b942dcaa5db81f927d1a300cb839b4e6c4d1c5e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b37262fe7019eebb5db4207b0dc513cdb2c09b2a","unresolved":true,"context_lines":[{"line_number":7704,"context_line":"        )"},{"line_number":7705,"context_line":""},{"line_number":7706,"context_line":"        result \u003d {}"},{"line_number":7707,"context_line":"        if memory_mb:"},{"line_number":7708,"context_line":"            result[orc.MEMORY_MB] \u003d {"},{"line_number":7709,"context_line":"                \u0027total\u0027: memory_mb,"},{"line_number":7710,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"34c64a49_31a38090","line":7707,"updated":"2020-12-03 08:45:51.000000000","message":"I\u0027m wondering when can be the total inventory 0 and still having a a working compute host.","commit_id":"fb4f9ed0ccae950f7632de5cc110b02aefe144e5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"085c5e47b66a7dc36745d3b387ef339314e1eb13","unresolved":true,"context_lines":[{"line_number":7704,"context_line":"        )"},{"line_number":7705,"context_line":""},{"line_number":7706,"context_line":"        result \u003d {}"},{"line_number":7707,"context_line":"        if memory_mb:"},{"line_number":7708,"context_line":"            result[orc.MEMORY_MB] \u003d {"},{"line_number":7709,"context_line":"                \u0027total\u0027: memory_mb,"},{"line_number":7710,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"42eea42f_5b00d3d8","line":7707,"in_reply_to":"34c64a49_31a38090","updated":"2020-12-03 20:47:46.000000000","message":"Fair point. I just did a sweep here to avoid any potential (theoretical?) 0 but it\u0027s possible that is not a thing that could realistically happen for MEMORY_MB. If you think it\u0027s worth leaving out this part of the change, let me know and I will remove it.","commit_id":"fb4f9ed0ccae950f7632de5cc110b02aefe144e5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"507743d57b9d4d08668ed1d3593c458f02227276","unresolved":true,"context_lines":[{"line_number":7704,"context_line":"        )"},{"line_number":7705,"context_line":""},{"line_number":7706,"context_line":"        result \u003d {}"},{"line_number":7707,"context_line":"        if memory_mb:"},{"line_number":7708,"context_line":"            result[orc.MEMORY_MB] \u003d {"},{"line_number":7709,"context_line":"                \u0027total\u0027: memory_mb,"},{"line_number":7710,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"734232c6_3ba4b62c","line":7707,"in_reply_to":"42eea42f_5b00d3d8","updated":"2020-12-04 08:29:06.000000000","message":"Let\u0027s keep the conditional for memory too.","commit_id":"fb4f9ed0ccae950f7632de5cc110b02aefe144e5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b37262fe7019eebb5db4207b0dc513cdb2c09b2a","unresolved":true,"context_lines":[{"line_number":7716,"context_line":""},{"line_number":7717,"context_line":"        # NOTE(stephenfin): We have to optionally report these since placement"},{"line_number":7718,"context_line":"        # forbids reporting inventory with total\u003d0"},{"line_number":7719,"context_line":"        if vcpus:"},{"line_number":7720,"context_line":"            result[orc.VCPU] \u003d {"},{"line_number":7721,"context_line":"                \u0027total\u0027: vcpus,"},{"line_number":7722,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a537ce85_a16ae470","line":7719,"updated":"2020-12-03 08:45:51.000000000","message":"I guess this could happen if we only have PCPUs","commit_id":"fb4f9ed0ccae950f7632de5cc110b02aefe144e5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b37262fe7019eebb5db4207b0dc513cdb2c09b2a","unresolved":true,"context_lines":[{"line_number":7726,"context_line":"                \u0027reserved\u0027: CONF.reserved_host_cpus,"},{"line_number":7727,"context_line":"            }"},{"line_number":7728,"context_line":""},{"line_number":7729,"context_line":"        if pcpus:"},{"line_number":7730,"context_line":"            result[orc.PCPU] \u003d {"},{"line_number":7731,"context_line":"                \u0027total\u0027: pcpus,"},{"line_number":7732,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef25dd6e_905f06b4","line":7729,"updated":"2020-12-03 08:45:51.000000000","message":"and vice versa","commit_id":"fb4f9ed0ccae950f7632de5cc110b02aefe144e5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b37262fe7019eebb5db4207b0dc513cdb2c09b2a","unresolved":true,"context_lines":[{"line_number":7754,"context_line":"        if provider_tree.has_sharing_provider(orc.DISK_GB):"},{"line_number":7755,"context_line":"            LOG.debug(\u0027Ignoring sharing provider - see bug #1784020\u0027)"},{"line_number":7756,"context_line":""},{"line_number":7757,"context_line":"        if disk_gb:"},{"line_number":7758,"context_line":"            result[orc.DISK_GB] \u003d {"},{"line_number":7759,"context_line":"                \u0027total\u0027: disk_gb,"},{"line_number":7760,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c747d331_ac510591","line":7757,"updated":"2020-12-03 08:45:51.000000000","message":"OK, this can happen if we only support boot from volume instances.","commit_id":"fb4f9ed0ccae950f7632de5cc110b02aefe144e5"}]}