)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f810a65f6d413d16f35246852ef09849b2059fbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"91563972_3f436ca1","updated":"2022-03-23 17:39:59.000000000","message":"Need to fix this.","commit_id":"1f9fd78797af56878e96aead95c08353e27bd49d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2520a0145951b641a9be5c0bfce70c2ca0581520","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c0c0c8ed_6bc758c1","updated":"2022-07-12 08:39:22.000000000","message":"I later had a change of mind on this\n\nI think we should be renaming the image and flavour extra spec to remove the word ephemeral and replace it with disk","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7f9f148fd64daaa88abc9c73f60d5d7c00e5845b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6e8b3982_78d8e327","in_reply_to":"30c16aed_3bdb021d","updated":"2022-08-09 23:22:42.000000000","message":"For completeness, what I replied on IRC earlier today [1]:\n\n\u003e [12:47:16]  \u003cmelwitt\u003e sean-k-mooney[m], stephenfin: wrt the naming, I wanted to give everyone a break before bringing it up again 😬 but ... I had thought more about it and thinking about it in the context of the other extra spec/image prop names, I thought \"hw_disk_encryption\" does seemingly fit better https://github.com/openstack/nova/blob/1220d53c2fd6231bb569a54f004a0e858536e970/nova/objects/image_meta.py#L347-L351 but as you pointed out, there\u0027s a\n\u003e [12:47:16]  \u003cmelwitt\u003e  chance that users might anyway think it could be referring to cinder volumes as well (?). none of the names are a slam dunk really :(\n\nLooking at those other properties: hw_disk_bus, hw_disk_type, those are understood to only mean local IIUC. So \"hw_disk_encryption\" would fit nicely in that regard.\n\nTo be clear, I\u0027m not advocating one vs the other. I will keep it as hw_ephemeral_encryption unless people think hw_disk_encryption would be better.\n\n[1] https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2022-08-09.log.html#t2022-08-09T19:47:16","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a15fdede13c58bdbe6ab5e7816cdebd39a3185a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ba279c17_827e7889","in_reply_to":"6e8b3982_78d8e327","updated":"2022-08-10 08:15:45.000000000","message":"hw_disk_bus, hw_disk_type, also apply to cinder volumes including boot form volume.\nthe hw_disk_bus form the root disk image metadata is appplied to all volumes nova or cinder that are attached to a vm.\n\ni do prefer hw_disk_encryption but i would also prefer if it applied to all volumes (root, ephemeral, swap and cinder). since this is only going to apply to root and ephmeral volumes i can live with hw_ephemeral_encryption. swap i think is clearly an oversite and i would like that to be covered at some point but lets focus on the planned/approved scope of the spec and deal with swap when everything else works.","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad04d78a5b58eaabdfd6b18cafc53818436f9fee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"af8ea142_f15272c0","in_reply_to":"ba279c17_827e7889","updated":"2022-08-16 06:06:01.000000000","message":"\u003e hw_disk_bus, hw_disk_type, also apply to cinder volumes including boot form volume.\n\u003e the hw_disk_bus form the root disk image metadata is appplied to all volumes nova or cinder that are attached to a vm.\n\nOh, nevermind then. Good to know.\n\n\u003e i do prefer hw_disk_encryption but i would also prefer if it applied to all volumes (root, ephemeral, swap and cinder). since this is only going to apply to root and ephmeral volumes i can live with hw_ephemeral_encryption. swap i think is clearly an oversite and i would like that to be covered at some point but lets focus on the planned/approved scope of the spec and deal with swap when everything else works.\n\nAck, agree swap should be included too and I can add it at the end.","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7db3dc7248c6fc1635eb9885a483022e24445ac0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7e2cdb50_d2a29916","in_reply_to":"c0c0c8ed_6bc758c1","updated":"2022-08-09 15:17:15.000000000","message":"Sean tells me this has been discussed and we\u0027re sticking with ephemeral.\n\n\u003csfinucan\u003e sean-k-mooney[m]: Can you give me a summary of what you concluded on the ephemeral vs. disk debate?\n\u003csfinucan\u003e At risk of rehashing old arguments, doesn\u0027t \u0027hw_disk_encryption\u0027 suggest cinder-backed \"disks\" (i.e. volumes) will be encrypted also?\n\u003csean-k-mooney[m]\u003e the term ephemeral is ambigious but its not worth changing as it has mindshare\n\u003csfinucan\u003e context is https://review.opendev.org/c/openstack/nova/+/760454\n\u003csean-k-mooney[m]\u003e so i was ment to drop my -1 and proceed with the current names\n\u003csean-k-mooney[m]\u003e but escalation\n\u003csean-k-mooney[m]\u003e so ill do that now\n\u003csfinucan\u003e Ah, no worries","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"391f61808b977003be0f33c48e768e37bec8697e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"30c16aed_3bdb021d","in_reply_to":"c0c0c8ed_6bc758c1","updated":"2022-08-09 15:17:51.000000000","message":"after a lot of back and forth on irc while i still dislike useing ephemeral here i have been conviced that there is enough mind share that improving the name will not be of benifit.\n\nthe \"wrong\" name IMO is already too engraned into peoples thinking that changing it now wont help the majority of our comunity so we will keep the current naming","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"391f61808b977003be0f33c48e768e37bec8697e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1f3f0bed_1ce52669","updated":"2022-08-09 15:17:51.000000000","message":"droping -1 but i still need to re review so reseting to 0","commit_id":"065b32483515fd6845dbdbb73202c2dd599933ae"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d99b1d1a8e2598304bc7c90fb42a1eb792a9ed20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ad40d82a_070d7291","updated":"2022-08-18 03:30:21.000000000","message":"recheck","commit_id":"065b32483515fd6845dbdbb73202c2dd599933ae"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e66083189500b8cab952f43c075e2e0d095d6504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4788513b_656ec86d","updated":"2022-08-18 08:46:40.000000000","message":"recheck openstack-tox-py39 post_failure","commit_id":"065b32483515fd6845dbdbb73202c2dd599933ae"}],"nova/objects/image_meta.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3d9e190ba80f98b4f424e1486ecd0176a59c7810","unresolved":true,"context_lines":[{"line_number":451,"context_line":"        \u0027hw_ephemeral_encryption\u0027: fields.FlexibleBooleanField(),"},{"line_number":452,"context_line":"        # encryption format to be used when ephemeral encryption is enabled"},{"line_number":453,"context_line":"        \u0027hw_ephemeral_encryption_format\u0027:"},{"line_number":454,"context_line":"            fields.BlockDeviceEncryptionFormatTypeField(),"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # if true download using bittorrent"},{"line_number":457,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":7,"id":"992f91b9_0552db3d","line":454,"range":{"start_line":454,"start_character":19,"end_line":454,"end_character":55},"updated":"2022-02-21 18:20:53.000000000","message":"Looks like you\u0027ve forgotten to include the definition for this?","commit_id":"6fadd0e5cac287c003c6a82b250afa5e0fb52090"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e975b6fd1f1bbdfc6783a8f1fa79c510d98a87f5","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        \u0027hw_ephemeral_encryption\u0027: fields.FlexibleBooleanField(),"},{"line_number":452,"context_line":"        # encryption format to be used when ephemeral encryption is enabled"},{"line_number":453,"context_line":"        \u0027hw_ephemeral_encryption_format\u0027:"},{"line_number":454,"context_line":"            fields.BlockDeviceEncryptionFormatTypeField(),"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # if true download using bittorrent"},{"line_number":457,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":7,"id":"52b1270d_42142358","line":454,"range":{"start_line":454,"start_character":19,"end_line":454,"end_character":55},"in_reply_to":"1dbe690c_ad210644","updated":"2022-03-23 23:38:24.000000000","message":"Done","commit_id":"6fadd0e5cac287c003c6a82b250afa5e0fb52090"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"40133c8e1c579ca3d42275466467b3d3a5075d26","unresolved":true,"context_lines":[{"line_number":451,"context_line":"        \u0027hw_ephemeral_encryption\u0027: fields.FlexibleBooleanField(),"},{"line_number":452,"context_line":"        # encryption format to be used when ephemeral encryption is enabled"},{"line_number":453,"context_line":"        \u0027hw_ephemeral_encryption_format\u0027:"},{"line_number":454,"context_line":"            fields.BlockDeviceEncryptionFormatTypeField(),"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # if true download using bittorrent"},{"line_number":457,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1dbe690c_ad210644","line":454,"range":{"start_line":454,"start_character":19,"end_line":454,"end_character":55},"in_reply_to":"992f91b9_0552db3d","updated":"2022-02-23 09:37:01.000000000","message":"FWIW looks like I forgot to pull the definition out of the change on top of this:\n\nhttps://review.opendev.org/c/openstack/nova/+/760453/7/nova/objects/fields.py#1208","commit_id":"6fadd0e5cac287c003c6a82b250afa5e0fb52090"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1559ba206aed84cf118d8107545bddda50732605","unresolved":true,"context_lines":[{"line_number":376,"context_line":"        primitive \u003d obj.obj_to_primitive(\u00271.31\u0027)"},{"line_number":377,"context_line":"        for field in new_fields:"},{"line_number":378,"context_line":"            self.assertNotIn(field, primitive[\u0027nova_object.data\u0027])"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def test_obj_make_compatible_hw_emulation(self):"},{"line_number":381,"context_line":"        \"\"\"Check \u0027hw_emulation_architecture\u0027 compatibility.\"\"\""},{"line_number":382,"context_line":"        # assert that \u0027hw_emulation_architecture\u0027 is supported"}],"source_content_type":"text/x-python","patch_set":9,"id":"909bf966_b4e57787","line":379,"updated":"2022-07-12 08:05:07.000000000","message":"+1","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad04d78a5b58eaabdfd6b18cafc53818436f9fee","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        primitive \u003d obj.obj_to_primitive(\u00271.31\u0027)"},{"line_number":377,"context_line":"        for field in new_fields:"},{"line_number":378,"context_line":"            self.assertNotIn(field, primitive[\u0027nova_object.data\u0027])"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def test_obj_make_compatible_hw_emulation(self):"},{"line_number":381,"context_line":"        \"\"\"Check \u0027hw_emulation_architecture\u0027 compatibility.\"\"\""},{"line_number":382,"context_line":"        # assert that \u0027hw_emulation_architecture\u0027 is supported"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f05f109_eb5b3e5b","line":379,"in_reply_to":"909bf966_b4e57787","updated":"2022-08-16 06:06:01.000000000","message":"Ack","commit_id":"6a68a16b8b1072bea6bb248e9549adcf82c8d655"}]}