)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"37ff0f9bf75e15927d2f6b4a6985365cc9ff5931","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"virt: Add ephemeral encryption flag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/759878"},{"line_number":10,"context_line":"Change-Id: I0f9affb3c8a80ff1c06b5a2f0c5324af6e384c62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"88caf079_ef7d480c","line":9,"updated":"2022-08-10 08:47:03.000000000","message":"ack, this was merged and released a long time ago but does not hurt to leave it here for documentation of what patch intoduced the traits","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"826819deea54ed1ca4a0271d24b853936939ee2a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"virt: Add ephemeral encryption flag"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: https://review.opendev.org/759878"},{"line_number":10,"context_line":"Change-Id: I0f9affb3c8a80ff1c06b5a2f0c5324af6e384c62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"f0d93b54_5fdd1dac","line":9,"in_reply_to":"88caf079_ef7d480c","updated":"2022-08-16 09:00:58.000000000","message":"Ack","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7cedf7f64c9ce5d8ebbd020990e26c1b8361ae9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3f95194e_d2d883b6","updated":"2022-03-24 08:36:08.000000000","message":"recheck bug 1946339","commit_id":"7580b5f2d2ecea296a0b5ce3b2c4a2012472e23e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"da2171fe40749df63d753f7f8fa442ef2d9a9771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0a9d9add_cc5e774e","updated":"2022-03-31 23:28:47.000000000","message":"recheck expected call event elapsed waiting time differs\n\n   Traceback (most recent call last):\n\n      File \"/home/zuul/src/opendev.org/openstack/nova/nova/tests/unit/compute/test_virtapi.py\", line 310, in test_wait_for_instance_event_multiple_events\n    mock_log.warning.assert_called_once_with(\n\n      File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py38/lib/python3.8/site-packages/mock/mock.py\", line 926, in assert_called_once_with\n    return self.assert_called_with(*args, **kwargs)\n\n      File \"/home/zuul/src/opendev.org/openstack/nova/.tox/py38/lib/python3.8/site-packages/mock/mock.py\", line 913, in assert_called_with\n    raise AssertionError(_error_message()) from cause\n\n    AssertionError: expected call not found.\nExpected: warning(\u0027Timeout waiting for %(events)s for instance with vm_state %(vm_state)s and task_state %(task_state)s. Event states are: %(event_states)s\u0027, {\u0027events\u0027: [\u0027received-event\u0027, \u0027early-event\u0027, \u0027missing-event\u0027, \u0027received-but-not-waited-event\u0027, \u0027missing-but-not-waited-event\u0027], \u0027vm_state\u0027: sentinel.vm_state, \u0027task_state\u0027: sentinel.task_state, \u0027event_states\u0027: \u0027received-event: received after waiting 0.00 seconds, early-event: received early, missing-event: timed out after 0.00 seconds, received-but-not-waited-event: received but not processed, missing-but-not-waited-event: expected but not received\u0027}, instance\u003d\u003cMock name\u003d\u0027mock.instance\u0027 id\u003d\u0027139747302866704\u0027\u003e)\nActual: warning(\u0027Timeout waiting for %(events)s for instance with vm_state %(vm_state)s and task_state %(task_state)s. Event states are: %(event_states)s\u0027, {\u0027events\u0027: [\u0027received-event\u0027, \u0027early-event\u0027, \u0027missing-event\u0027, \u0027received-but-not-waited-event\u0027, \u0027missing-but-not-waited-event\u0027], \u0027vm_state\u0027: sentinel.vm_state, \u0027task_state\u0027: sentinel.task_state, \u0027event_states\u0027: \u0027received-event: received after waiting 0.59 seconds, early-event: received early, missing-event: timed out after 0.00 seconds, received-but-not-waited-event: received but not processed, missing-but-not-waited-event: expected but not received\u0027}, instance\u003d\u003cMock name\u003d\u0027mock.instance\u0027 id\u003d\u0027139747302866704\u0027\u003e)","commit_id":"7580b5f2d2ecea296a0b5ce3b2c4a2012472e23e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3b8f2a526748309fc2d36479d374a4bafc7598a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9d4554cc_7795296f","updated":"2022-07-12 08:35:07.000000000","message":"the change looks good but I want to discuss the naming so -1 for now","commit_id":"df62729bd29121d81e1d3f5b881d72efd8e63916"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d087eb9db69985e6ed0e823db4adbafa99f4f9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d29ad7df_2c6e078c","updated":"2022-08-09 15:49:38.000000000","message":"droping -1 as noted on irc ill try and fined time to rereivew soon","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b61f389959496aa97a76a677eb01828b1f68caf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"61ba1a4b_4b5f8beb","updated":"2022-08-18 03:31:17.000000000","message":"recheck","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"},{"author":{"_account_id":28743,"name":"huang liujie","email":"huang.liujie@99cloud.net","username":"ljhuang"},"change_message_id":"df43d4d87d00b8a35bb59c30bea52f10a5dd4694","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"811e8d3c_5d923d88","updated":"2022-08-18 16:39:55.000000000","message":"recheck","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0ab21c811b3e7f1a3a5f9dfda1844c3d634eb806","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"24d5d3a7_20a6127f","updated":"2022-08-18 08:49:34.000000000","message":"recheck openstack-tox-py38 post_failure","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b718ee80fc7d58cc2418b35ceabefdc568ee66b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d8732411_ee5838ba","updated":"2022-08-18 12:56:01.000000000","message":"recheck tempest-integrated-compute post_failure","commit_id":"a370d1b581158a64a7f5f91fcc08beebe24df8d5"}],"nova/virt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3b8f2a526748309fc2d36479d374a4bafc7598a","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    \"supports_socket_pci_numa_affinity\":"},{"line_number":126,"context_line":"        os_traits.COMPUTE_SOCKET_PCI_NUMA_AFFINITY,"},{"line_number":127,"context_line":"    \"supports_remote_managed_ports\": os_traits.COMPUTE_REMOTE_MANAGED_PORTS,"},{"line_number":128,"context_line":"    \"supports_ephemeral_encryption\": os_traits.COMPUTE_EPHEMERAL_ENCRYPTION,"},{"line_number":129,"context_line":"    \"supports_ephemeral_encryption_luks\":"},{"line_number":130,"context_line":"        os_traits.COMPUTE_EPHEMERAL_ENCRYPTION_LUKS,"},{"line_number":131,"context_line":"    \"supports_ephemeral_encryption_plain\":"}],"source_content_type":"text/x-python","patch_set":11,"id":"6fd41a5b_aa901c5b","line":128,"range":{"start_line":128,"start_character":5,"end_line":128,"end_character":34},"updated":"2022-07-12 08:35:07.000000000","message":"as noted in the previous commit I think I want to replace all our usage of ephemeral in relation to this feature with disk","commit_id":"df62729bd29121d81e1d3f5b881d72efd8e63916"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc799552ab9cba88aae284b5f1e60002b5c05515","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    \"supports_socket_pci_numa_affinity\":"},{"line_number":126,"context_line":"        os_traits.COMPUTE_SOCKET_PCI_NUMA_AFFINITY,"},{"line_number":127,"context_line":"    \"supports_remote_managed_ports\": os_traits.COMPUTE_REMOTE_MANAGED_PORTS,"},{"line_number":128,"context_line":"    \"supports_ephemeral_encryption\": os_traits.COMPUTE_EPHEMERAL_ENCRYPTION,"},{"line_number":129,"context_line":"    \"supports_ephemeral_encryption_luks\":"},{"line_number":130,"context_line":"        os_traits.COMPUTE_EPHEMERAL_ENCRYPTION_LUKS,"},{"line_number":131,"context_line":"    \"supports_ephemeral_encryption_plain\":"}],"source_content_type":"text/x-python","patch_set":11,"id":"8bc63637_479cb210","line":128,"range":{"start_line":128,"start_character":5,"end_line":128,"end_character":34},"in_reply_to":"6fd41a5b_aa901c5b","updated":"2022-08-09 15:45:27.000000000","message":"We\u0027ve settled on keeping this. Just waiting for Sean to drop their -1 now","commit_id":"df62729bd29121d81e1d3f5b881d72efd8e63916"}]}