)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e75f3a6f8958bcea5e0263d85753debcb8496f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"35038e88_6ed428ee","updated":"2022-02-21 18:37:58.000000000","message":"Smallest of nits. Might not even be valid!","commit_id":"e2dfa87d54f8a526ca5dbfd150156ffeeaab3694"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"26bfe72b3a0bcc2f2bfae33e52db40416e820fff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"324c629a_767994cf","updated":"2022-07-12 08:38:27.000000000","message":"I\u0027m going to stop reviewing this here for now to get feedback on what I have already said.","commit_id":"5841f41d258818f339a08c414b10492aa064be3f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"884b1dcad0de92a6ea64ed925ab64a6751e4336b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f7664890_d536e62d","updated":"2022-06-30 21:05:58.000000000","message":"recheck bug 1944779","commit_id":"5841f41d258818f339a08c414b10492aa064be3f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"75ddb59a7de0e3aa5474f4429c3a1ce548c175d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9f1f939b_25649ae2","updated":"2022-08-09 15:54:37.000000000","message":"Very thorough","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"586516255eba171f2aaf9b43723b4b38d7b85e63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b682cbcd_7384b9f4","updated":"2022-08-18 03:31:35.000000000","message":"recheck","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1c308917a15d7c7f3de1a1b02a63306a675bf834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e411d8b7_9d50ca0c","updated":"2022-08-18 23:42:17.000000000","message":"recheck","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63782d7d3dbc98babbdf5f657b939e3a53f4cafe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4d9c19f9_c4184468","updated":"2022-08-09 15:45:53.000000000","message":"recheck post failure due to irrelevant timeout","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e054c1a49c0fac0673b83d4fa8758df7a3de71c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1dfc1737_e19752a7","updated":"2022-08-17 10:14:23.000000000","message":"we agreeded to keep the nameing so upgradign to +2w","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"}],"doc/api_samples/images/images-details-get-resp.json":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c26a831c22df61b53dfbb558c4cedae4b901b066","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"images\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"OS-EXT-IMG-SIZE:size\": \"25165824\","},{"line_number":5,"context_line":"            \"created\": \"2011-01-01T01:02:03Z\","},{"line_number":6,"context_line":"            \"id\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":7,"context_line":"            \"links\": ["}],"source_content_type":"application/json","patch_set":12,"id":"0c621fd1_95c8fb38","line":4,"updated":"2022-08-10 09:02:54.000000000","message":"i was confused why you were extendign this but i realise its because you are extendign the fixture.","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23a8f549ff4971428e07865c58c8b4abdba79cb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"images\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"OS-EXT-IMG-SIZE:size\": \"25165824\","},{"line_number":5,"context_line":"            \"created\": \"2011-01-01T01:02:03Z\","},{"line_number":6,"context_line":"            \"id\": \"155d900f-4e14-4e4c-a73d-069cbf4541e6\","},{"line_number":7,"context_line":"            \"links\": ["}],"source_content_type":"application/json","patch_set":12,"id":"2f70982c_39cfa451","line":4,"in_reply_to":"0c621fd1_95c8fb38","updated":"2022-08-16 09:01:05.000000000","message":"Ack","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"}],"nova/scheduler/request_filter.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e75f3a6f8958bcea5e0263d85753debcb8496f2","unresolved":true,"context_lines":[{"line_number":418,"context_line":"    eph_format \u003d hardware.get_ephemeral_encryption_format("},{"line_number":419,"context_line":"        request_spec.flavor, request_spec.image)"},{"line_number":420,"context_line":"    if eph_format:"},{"line_number":421,"context_line":"        trait_name \u003d f\"COMPUTE_EPHEMERAL_ENCRYPTION_{eph_format.upper()}\""},{"line_number":422,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":423,"context_line":"        LOG.debug(f\"ephemeral_encryption_filter added trait {trait_name}\")"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"50fe17e3_20e4faf5","line":421,"updated":"2022-02-21 18:37:58.000000000","message":"Do we need to make sure this is valid? I think not because the call to \u0027get_ephemeral_encryption_format\u0027 (or an earlier call to same) above will prevent invalid extra spec values getting through, but it\u0027d be good to call that out here if so","commit_id":"e2dfa87d54f8a526ca5dbfd150156ffeeaab3694"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"91c1f571dd12bb5c83693954a21d804df353d620","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    eph_format \u003d hardware.get_ephemeral_encryption_format("},{"line_number":419,"context_line":"        request_spec.flavor, request_spec.image)"},{"line_number":420,"context_line":"    if eph_format:"},{"line_number":421,"context_line":"        trait_name \u003d f\"COMPUTE_EPHEMERAL_ENCRYPTION_{eph_format.upper()}\""},{"line_number":422,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":423,"context_line":"        LOG.debug(f\"ephemeral_encryption_filter added trait {trait_name}\")"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"b2c8d7ac_29cdad68","line":421,"in_reply_to":"50fe17e3_20e4faf5","updated":"2022-04-05 05:37:07.000000000","message":"Done","commit_id":"e2dfa87d54f8a526ca5dbfd150156ffeeaab3694"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"26bfe72b3a0bcc2f2bfae33e52db40416e820fff","unresolved":true,"context_lines":[{"line_number":422,"context_line":"    if eph_format:"},{"line_number":423,"context_line":"        # We don\u0027t need to validate the trait here because the earlier call to"},{"line_number":424,"context_line":"        # get_ephemeral_encryption_format will raise if it is not valid"},{"line_number":425,"context_line":"        trait_name \u003d f\"COMPUTE_EPHEMERAL_ENCRYPTION_{eph_format.upper()}\""},{"line_number":426,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":427,"context_line":"        LOG.debug(f\"ephemeral_encryption_filter added trait {trait_name}\")"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0b36904b_18423c1d","line":425,"range":{"start_line":425,"start_character":23,"end_line":425,"end_character":52},"updated":"2022-07-12 08:38:27.000000000","message":"crap we have already merged this which makes it hard to change since we can\u0027t remove traits.\n\n\nI still think we should avoid the use of ephemeral in relation to this feature but maybe we sould only do that in the context of the extra specs and resuse this trait but the more I review this the less correct I think use ephemeral is","commit_id":"5841f41d258818f339a08c414b10492aa064be3f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"75ddb59a7de0e3aa5474f4429c3a1ce548c175d7","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    if eph_format:"},{"line_number":423,"context_line":"        # We don\u0027t need to validate the trait here because the earlier call to"},{"line_number":424,"context_line":"        # get_ephemeral_encryption_format will raise if it is not valid"},{"line_number":425,"context_line":"        trait_name \u003d f\"COMPUTE_EPHEMERAL_ENCRYPTION_{eph_format.upper()}\""},{"line_number":426,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":427,"context_line":"        LOG.debug(f\"ephemeral_encryption_filter added trait {trait_name}\")"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ab025eeb_67e97a17","line":425,"range":{"start_line":425,"start_character":23,"end_line":425,"end_character":52},"in_reply_to":"0b36904b_18423c1d","updated":"2022-08-09 15:54:37.000000000","message":"We\u0027re stick with the ephemeral terminology now, so this isn\u0027t an issue anymore","commit_id":"5841f41d258818f339a08c414b10492aa064be3f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c26a831c22df61b53dfbb558c4cedae4b901b066","unresolved":true,"context_lines":[{"line_number":426,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":427,"context_line":"        LOG.debug(f\"ephemeral_encryption_filter added trait {trait_name}\")"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    return True"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"ALL_REQUEST_FILTERS \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"e1855040_44392271","line":429,"updated":"2022-08-10 09:02:54.000000000","message":"im really happy with how simple adding pre filters is\n\ndan did a good job adding this facility.","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23a8f549ff4971428e07865c58c8b4abdba79cb7","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":427,"context_line":"        LOG.debug(f\"ephemeral_encryption_filter added trait {trait_name}\")"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    return True"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"ALL_REQUEST_FILTERS \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"f62756bb_1c835a56","line":429,"in_reply_to":"e1855040_44392271","updated":"2022-08-16 09:01:05.000000000","message":"Ack","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"}],"nova/tests/functional/test_ephemeral_encryption.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e75f3a6f8958bcea5e0263d85753debcb8496f2","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        # We only need a single compute for these tests"},{"line_number":58,"context_line":"        self._start_compute(host\u003d\u0027compute1\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _assert_build_request_success(self, server_request):"},{"line_number":61,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_request})"},{"line_number":62,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":63,"context_line":"        return server[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _assert_build_request_schedule_failure(self, server_request):"},{"line_number":66,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_request})"},{"line_number":67,"context_line":"        self._wait_for_state_change(server, \u0027ERROR\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _assert_bad_build_request_error(self, server_request):"},{"line_number":70,"context_line":"        ex \u003d self.assertRaises("},{"line_number":71,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":72,"context_line":"            {\u0027server\u0027: server_request})"},{"line_number":73,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _assert_build_request_error(self, server_request):"},{"line_number":76,"context_line":"        ex \u003d self.assertRaises("},{"line_number":77,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":78,"context_line":"            {\u0027server\u0027: server_request})"},{"line_number":79,"context_line":"        self.assertEqual(500, ex.response.status_code)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _assert_ephemeral_encryption_enabled("},{"line_number":82,"context_line":"            self, server_id, encryption_format\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"a99d589c_726fa579","line":79,"range":{"start_line":60,"start_character":0,"end_line":79,"end_character":54},"updated":"2022-02-21 18:37:58.000000000","message":"All of these should have equivalents in IntegratedTestBase. If they don\u0027t, perhaps you could add them there?","commit_id":"e2dfa87d54f8a526ca5dbfd150156ffeeaab3694"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"91c1f571dd12bb5c83693954a21d804df353d620","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # We only need a single compute for these tests"},{"line_number":58,"context_line":"        self._start_compute(host\u003d\u0027compute1\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _assert_build_request_success(self, server_request):"},{"line_number":61,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_request})"},{"line_number":62,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":63,"context_line":"        return server[\u0027id\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _assert_build_request_schedule_failure(self, server_request):"},{"line_number":66,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server_request})"},{"line_number":67,"context_line":"        self._wait_for_state_change(server, \u0027ERROR\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _assert_bad_build_request_error(self, server_request):"},{"line_number":70,"context_line":"        ex \u003d self.assertRaises("},{"line_number":71,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":72,"context_line":"            {\u0027server\u0027: server_request})"},{"line_number":73,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _assert_build_request_error(self, server_request):"},{"line_number":76,"context_line":"        ex \u003d self.assertRaises("},{"line_number":77,"context_line":"            client.OpenStackApiException, self.api.post_server,"},{"line_number":78,"context_line":"            {\u0027server\u0027: server_request})"},{"line_number":79,"context_line":"        self.assertEqual(500, ex.response.status_code)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _assert_ephemeral_encryption_enabled("},{"line_number":82,"context_line":"            self, server_id, encryption_format\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b91c09c_f445d73f","line":79,"range":{"start_line":60,"start_character":0,"end_line":79,"end_character":54},"in_reply_to":"a99d589c_726fa579","updated":"2022-04-05 05:37:07.000000000","message":"Done","commit_id":"e2dfa87d54f8a526ca5dbfd150156ffeeaab3694"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c26a831c22df61b53dfbb558c4cedae4b901b066","unresolved":true,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_utils.fixture import uuidsentinel"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":12,"id":"dd62fde0_1923cb77","line":12,"updated":"2022-08-10 09:02:54.000000000","message":"a genereal comment, these tests feel like a good candiate for ddt","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23a8f549ff4971428e07865c58c8b4abdba79cb7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_utils.fixture import uuidsentinel"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":12,"id":"175ca7a0_45596b76","line":12,"in_reply_to":"dd62fde0_1923cb77","updated":"2022-08-16 09:01:05.000000000","message":"Ack","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c26a831c22df61b53dfbb558c4cedae4b901b066","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        server_id \u003d self._assert_build_request_success(server_request)"},{"line_number":144,"context_line":"        self._assert_ephemeral_encryption_disabled(server_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_flavor_requested_and_image_disabled(self):"},{"line_number":147,"context_line":"        server_request \u003d self._build_server("},{"line_number":148,"context_line":"            flavor_id\u003duuidsentinel.eph_encryption_flavor,"},{"line_number":149,"context_line":"            image_uuid\u003duuidsentinel.eph_encryption_disabled,"},{"line_number":150,"context_line":"            networks\u003d[])"},{"line_number":151,"context_line":"        self._assert_bad_build_request_error(server_request)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def test_flavor_disabled_and_image_requested(self):"},{"line_number":154,"context_line":"        server_request \u003d self._build_server("},{"line_number":155,"context_line":"            flavor_id\u003duuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":156,"context_line":"            image_uuid\u003duuidsentinel.eph_encryption,"},{"line_number":157,"context_line":"            networks\u003d[])"},{"line_number":158,"context_line":"        self._assert_bad_build_request_error(server_request)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class TestEphemeralEncryptionUnavailable(_TestEphemeralEncryptionBase):"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"8de28213_d5a8450a","line":159,"range":{"start_line":146,"start_character":2,"end_line":159,"end_character":0},"updated":"2022-08-10 09:02:54.000000000","message":"+1\n\nthis is nice to see as its easy to miss the conflict cases.\n\nalthouhg this should result in a 400 and api error rather then the server endign inerror is that what will happen as i would expect the _build_server to raise an 400 osapi exception.","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23a8f549ff4971428e07865c58c8b4abdba79cb7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        server_id \u003d self._assert_build_request_success(server_request)"},{"line_number":144,"context_line":"        self._assert_ephemeral_encryption_disabled(server_id)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_flavor_requested_and_image_disabled(self):"},{"line_number":147,"context_line":"        server_request \u003d self._build_server("},{"line_number":148,"context_line":"            flavor_id\u003duuidsentinel.eph_encryption_flavor,"},{"line_number":149,"context_line":"            image_uuid\u003duuidsentinel.eph_encryption_disabled,"},{"line_number":150,"context_line":"            networks\u003d[])"},{"line_number":151,"context_line":"        self._assert_bad_build_request_error(server_request)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def test_flavor_disabled_and_image_requested(self):"},{"line_number":154,"context_line":"        server_request \u003d self._build_server("},{"line_number":155,"context_line":"            flavor_id\u003duuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":156,"context_line":"            image_uuid\u003duuidsentinel.eph_encryption,"},{"line_number":157,"context_line":"            networks\u003d[])"},{"line_number":158,"context_line":"        self._assert_bad_build_request_error(server_request)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class TestEphemeralEncryptionUnavailable(_TestEphemeralEncryptionBase):"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5dcbd774_ee084c5c","line":159,"range":{"start_line":146,"start_character":2,"end_line":159,"end_character":0},"in_reply_to":"8de28213_d5a8450a","updated":"2022-08-16 09:01:05.000000000","message":"Ack","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"}],"nova/tests/unit/scheduler/test_request_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c26a831c22df61b53dfbb558c4cedae4b901b066","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9dacaab4_b5da0b3e","line":702,"updated":"2022-08-10 09:02:54.000000000","message":"+1\n\ntheses alll look good.\n\nyou could add one mor ecase which is if you set the format only we would expect the fileter to be skipped.","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23a8f549ff4971428e07865c58c8b4abdba79cb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aaa676a9_5699d772","line":702,"in_reply_to":"9dacaab4_b5da0b3e","updated":"2022-08-16 09:01:05.000000000","message":"Done","commit_id":"794d2f98d9b2be122f852749d8612d53bdbfac69"}]}
