)]}'
{"nova/api/openstack/compute/contrib/admin_actions.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"f1f841c33014fb477f204a9b6b103f05a4abf29e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            raise exc.HTTPNotImplemented(explanation\u003dmsg)"},{"line_number":67,"context_line":"        except Exception:"},{"line_number":68,"context_line":"            readable \u003d traceback.format_exc()"},{"line_number":69,"context_line":"            LOG.error(_(\"Compute.api::pause %s\"), readable)"},{"line_number":70,"context_line":"            raise exc.HTTPUnprocessableEntity()"},{"line_number":71,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F41o%3D","line":69,"updated":"2014-03-03 16:22:38.000000000","message":"LOG.exception() is basically implemented like this:\n\n    def exception(self, msg, *args, **kwargs):\n        kwargs[\u0027exc_info\u0027] \u003d 1\n        self.error(msg, *args, **kwargs)\n\nSo it\u0027s probably best to keep the call to LOG.exception(), but drop the call to traceback.format_exc() since LOG.exception() will already log the exception.","commit_id":"48c746a1df0c4fe63362c79d827872f645d8c126"}],"nova/api/openstack/compute/contrib/multinic.py":[{"author":{"_account_id":7641,"name":"Shuangtai Tian","email":"hitianst@gmail.com","username":"shuangtai"},"change_message_id":"f0d1b8721543b2e6dccd429c97690b5a654f2e09","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.compute_api.remove_fixed_ip(context, instance, address)"},{"line_number":79,"context_line":"        except exception.FixedIpNotFoundForSpecificInstance:"},{"line_number":80,"context_line":"            LOG.debug(_(\"Unable to find address %r\") % address,"},{"line_number":81,"context_line":"                          instance\u003dinstance)"},{"line_number":82,"context_line":"            raise exc.HTTPBadRequest()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FsGs%3D","line":81,"updated":"2014-02-25 08:55:04.000000000","message":"I prefer to use the multiple arguments format, \nLOG.debug(_(\"Unable to find address %r\") , address, instance\u003dinstance)\nhttp://stackoverflow.com/questions/11615053/why-use-multiple-arguments-to-log-instead-of-interpolation","commit_id":"f91a221d7c0375ed571128f22d5fb9715b5af9ea"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"27de329e668f83ddaa942e6f5c4940bde9344ff2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.compute_api.remove_fixed_ip(context, instance, address)"},{"line_number":79,"context_line":"        except exception.FixedIpNotFoundForSpecificInstance:"},{"line_number":80,"context_line":"            LOG.debug(_(\"Unable to find address %r\") % address,"},{"line_number":81,"context_line":"                          instance\u003dinstance)"},{"line_number":82,"context_line":"            raise exc.HTTPBadRequest()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FsVY%3D","line":81,"updated":"2014-02-25 08:27:51.000000000","message":"I think it is better to remove this LOG.debug because this exception is due to BadRequest from a user and I hope log files are not filled from BadRequest.\n\nInstead of outputting LOG, how about passing this message to the following HTTPBadRequest as an explanation argument?","commit_id":"f91a221d7c0375ed571128f22d5fb9715b5af9ea"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"e6fc45a12f7f2e3fdbc75efe2195150b3a2d22ff","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.compute_api.remove_fixed_ip(context, instance, address)"},{"line_number":79,"context_line":"        except exception.FixedIpNotFoundForSpecificInstance:"},{"line_number":80,"context_line":"            LOG.debug(_(\"Unable to find address %r\") % address,"},{"line_number":81,"context_line":"                          instance\u003dinstance)"},{"line_number":82,"context_line":"            raise exc.HTTPBadRequest()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FjP0%3D","line":81,"in_reply_to":"AAAAU3%2F%2FsVY%3D","updated":"2014-03-02 23:12:29.000000000","message":"yes, that\u0027s a good point. I\u0027ll just remove it","commit_id":"f91a221d7c0375ed571128f22d5fb9715b5af9ea"}]}