)]}'
{"id":"openstack%2Fnova~760985","triplet_id":"openstack%2Fnova~stable%2Frocky~Ie62d3566230aa3e2786d129adbb2e3570b06e4c6","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1899541","hashtags":[],"change_id":"Ie62d3566230aa3e2786d129adbb2e3570b06e4c6","subject":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027","status":"ABANDONED","created":"2020-11-02 18:16:55.000000000","updated":"2022-11-11 18:31:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"43f949261893bf2376aee45ac45d86cb68d4a6f1","_number":760985,"virtual_id_number":760985,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-11-02 18:20:50.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2021-08-25 17:07:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-08-25 19:37:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2021-08-30 11:08:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-02 18:20:50.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-11-02 20:17:12.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-03 04:52:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-25 16:53:28.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"},{"updated":"2021-08-30 11:08:55.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"d7d397b97985e7ca171b8d934556acbff2798374","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-11-02 18:16:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"851827240a14620c036ae5bbb0ef7ffe77c878ee","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-02 18:18:36.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/760985/1 : FAILURE in 48s","accounts_in_message":[],"_revision_number":1},{"id":"5cef81e7c3b67ea77729ce28afdc5c741e24c01c","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-11-02 18:19:07.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"15e3a7af22ec107f93703eff17dce762eee3594e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-02 18:20:50.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/760985/2 : FAILURE in 49s","accounts_in_message":[],"_revision_number":2},{"id":"f127338bcd4ca1cf0ccf6326a47379ba547f6b08","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-02 20:17:12.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/85/760985/2/check/tempest-dsvm-full-bionic-py3/df09ee2/ : SUCCESS in 1h 27m 33s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/85/760985/2/check/grenade-dsvm-bionic/8114427/ : POST_FAILURE in 35m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"80989c08799c50b49229bd0059d7131a45f16691","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 04:52:38.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5639e8557c5f4f53aafbec71e4b79e6d : FAILURE in 9m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2817e46593784a68ae0c87db6823d9a0 : SUCCESS in 12m 54s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/7b8be40276544e2e903479f1eaa57fe8 : SUCCESS in 12m 45s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/8173198e23884f99b35a7b553ea339f5 : SUCCESS in 9m 33s\n- tempest-full https://zuul.opendev.org/t/openstack/build/73bdf13a44484262898f9c8f6ed655b4 : SUCCESS in 1h 37m 31s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/e8336ab4612c40588f1c4d33651c0d2c : SUCCESS in 47m 36s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bd132bcb0e2541fcb87eccf7eb6669e2 : SUCCESS in 1h 17m 15s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/5fe3c2da5fbe47498e3d0755930de988 : SUCCESS in 41m 52s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/82db4355ce344ae898ecb4617083841b : SUCCESS in 1h 08m 03s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/bd65aaf748a341fa9c6b0d8c583a55d5 : SUCCESS in 1h 09m 33s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/effc98d96e3248dbb70c29ea1d892ed0 : SUCCESS in 41m 56s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/61fb90c0666b4c7eb752586aa941b311 : SUCCESS in 1h 04m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/1b83a022389c47ca8c00108709d530a6 : SUCCESS in 1h 24m 03s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/ed9b1966023f482f91bcc96f1172a65f : SUCCESS in 2h 00m 27s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/d20d497aef7141dbb6411ce1ad77e336 : FAILURE in 21m 16s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/cb51d9e824d1493b99e3ac4f106d2085 : SUCCESS in 16m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/55611292f5974bb2ad3ca954ea329dc6 : SUCCESS in 14m 14s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/333db54fb3244ce98d38f967a3a1687b : SUCCESS in 1h 17m 03s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/5693eb5ef91544d196a721554af2f255 : SUCCESS in 1h 32m 42s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/598530d17d964230a7713166bd5efeef : SUCCESS in 1h 41m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ac880ebecc520b294477a739e0b0e999275a7acc","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-25 16:53:28.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"1a22541030418e48aca82b85d28112138c06509c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-08-25 17:07:44.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/e1cddc3bf6ad4981bf34ac7affbf80e1 : RETRY_LIMIT in 1m 00s","accounts_in_message":[],"_revision_number":2},{"id":"f2cd52e901056aed492293b748f0a7f157a9bdac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-25 19:37:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/38183e9a0d7d41169a2498898b2a3d83 : SUCCESS in 14m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0dc88d03be8a4e4eb009aba3c4bb0a25 : SUCCESS in 14m 58s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/adaca6900c4c4bc3b41e5536fe05f811 : SUCCESS in 14m 51s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/195152868f174706a083bece7ac1c397 : SUCCESS in 12m 12s\n- tempest-full https://zuul.opendev.org/t/openstack/build/39566689aa1440e684a6dfc0840a6d0a : SUCCESS in 1h 24m 26s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/693c9ab317694a22a47424c21a7571c0 : SUCCESS in 56m 45s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d88655114eae44449cb7b9311d9b01ad : SUCCESS in 1h 23m 08s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/913858a6f39d43fc9b198262f39eb759 : SUCCESS in 58m 59s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/29207dfcc263421993784396ac51e2f9 : SUCCESS in 57m 25s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/f8563c9d30ad4aa18be73cd53ea598d2 : SUCCESS in 1h 08m 09s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/a847b14a30a84d27a544f5511a231449 : SUCCESS in 47m 28s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/dc9c3c8ae5a8426b866d03a12f5b408c : SUCCESS in 57m 53s\n- nova-next https://zuul.opendev.org/t/openstack/build/c05791d92e924116bfa46bac0f2cd710 : SUCCESS in 1h 18m 35s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/bafea876becf42898df2974516dc0901 : SUCCESS in 1h 50m 52s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/7affa118e763472c9811e8bd96f68df0 : SUCCESS in 19m 03s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/b0e3e9f6acce46f0bea9a17a8e04a555 : SUCCESS in 20m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b4b413233faf41829b291ce422f9e75d : FAILURE in 4m 48s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/7bded5264cd947949f798a86147b8421 : SUCCESS in 1h 00m 39s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/29aeffd23ee74a38af2a272c7a194445 : SUCCESS in 1h 35m 15s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e6fef6b6ce47139a4a8544c2cc5f338b2cccf41b","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-08-30 11:08:55.000000000","message":"Patch Set 2: Code-Review+2\n\nClean backport from stable/stein, where the patch has merged. LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"43f949261893bf2376aee45ac45d86cb68d4a6f1","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:31:22.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"661179de486e710f260e448b005e3383038337b8","revisions":{"03c7a3dbce76443b43ba434c4b46f4542121516f":{"kind":"REWORK","_number":1,"created":"2020-11-02 18:16:55.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/85/760985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/760985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/760985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/760985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/760985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/760985/1"}}},"commit":{"parents":[{"commit":"211b5d1ca5dc8a8a8e504b308f77b6df5c13f984","subject":"Merge \"post live migration: don\u0027t call Neutron needlessly\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/211b5d1ca5dc8a8a8e504b308f77b6df5c13f984"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-10-12 22:27:52.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-11-02 18:16:35.000000000","tz":0},"subject":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027","message":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027\n\nCurrently in the archive_deleted_rows code, we will attempt to clean up\n\"residue\" of deleted instance records by assuming any table with a\n\u0027instance_uuid\u0027 column represents data tied to an instance\u0027s lifecycle\nand delete such records.\n\nThis behavior poses a problem in the case where an instance has a PCI\ndevice allocated and someone deletes the instance. The \u0027instance_uuid\u0027\ncolumn in the pci_devices table is used to track the allocation\nassociation of a PCI with an instance. There is a small time window\nduring which the instance record has been deleted but the PCI device\nhas not yet been freed from a database record perspective as PCI\ndevices are freed during the _complete_deletion method in the compute\nmanager as part of the resource tracker update call.\n\nRecords in the pci_devices table are anyway not related to the\nlifecycle of instances so they should not be considered residue to\nclean up if an instance is deleted. This adds a condition to avoid\narchiving pci_devices on the basis of an instance association.\n\nCloses-Bug: #1899541\n\nConflicts:\n    nova/db/sqlalchemy/api.py\n    nova/tests/functional/db/test_archive.py\n\nNOTE(melwitt): The conflicts are because change\nI9725f752f8aef8066f7c9705e87610cad887bf8e (refactor nova-manage\narchive_deleted_rows) and change\nId16c3d91d9ce5db9ffd125b59fffbfedf4a6843d (nova-manage db\narchive_deleted_rows is not multi-cell aware) are not in Stein.\n\nChange-Id: Ie62d3566230aa3e2786d129adbb2e3570b06e4c6\n(cherry picked from commit 1c256cf774693e2395ae8fe4a7a2f416a7aeb03a)\n(cherry picked from commit 09784db62fcd01124a101c4c69cab6e71e1ac781)\n(cherry picked from commit 79df36fecf8c8be5ae9d59397882ac844852043e)\n(cherry picked from commit e3bb6119cf2d0a503768979312aea4d10cf85cda)\n(cherry picked from commit da91b19d8be3b9cad8f713a3218a08e2d50238c8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/03c7a3dbce76443b43ba434c4b46f4542121516f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/03c7a3dbce76443b43ba434c4b46f4542121516f"}]},"branch":"refs/heads/stable/rocky"},"661179de486e710f260e448b005e3383038337b8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-11-02 18:19:07.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/85/760985/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/760985/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/760985/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/760985/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/760985/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/760985/2"}}},"commit":{"parents":[{"commit":"211b5d1ca5dc8a8a8e504b308f77b6df5c13f984","subject":"Merge \"post live migration: don\u0027t call Neutron needlessly\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/211b5d1ca5dc8a8a8e504b308f77b6df5c13f984"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-10-12 22:27:52.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-11-02 18:18:37.000000000","tz":0},"subject":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027","message":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027\n\nCurrently in the archive_deleted_rows code, we will attempt to clean up\n\"residue\" of deleted instance records by assuming any table with a\n\u0027instance_uuid\u0027 column represents data tied to an instance\u0027s lifecycle\nand delete such records.\n\nThis behavior poses a problem in the case where an instance has a PCI\ndevice allocated and someone deletes the instance. The \u0027instance_uuid\u0027\ncolumn in the pci_devices table is used to track the allocation\nassociation of a PCI with an instance. There is a small time window\nduring which the instance record has been deleted but the PCI device\nhas not yet been freed from a database record perspective as PCI\ndevices are freed during the _complete_deletion method in the compute\nmanager as part of the resource tracker update call.\n\nRecords in the pci_devices table are anyway not related to the\nlifecycle of instances so they should not be considered residue to\nclean up if an instance is deleted. This adds a condition to avoid\narchiving pci_devices on the basis of an instance association.\n\nCloses-Bug: #1899541\n\nChange-Id: Ie62d3566230aa3e2786d129adbb2e3570b06e4c6\n(cherry picked from commit 1c256cf774693e2395ae8fe4a7a2f416a7aeb03a)\n(cherry picked from commit 09784db62fcd01124a101c4c69cab6e71e1ac781)\n(cherry picked from commit 79df36fecf8c8be5ae9d59397882ac844852043e)\n(cherry picked from commit e3bb6119cf2d0a503768979312aea4d10cf85cda)\n(cherry picked from commit da91b19d8be3b9cad8f713a3218a08e2d50238c8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/661179de486e710f260e448b005e3383038337b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/661179de486e710f260e448b005e3383038337b8"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}