)]}'
{"id":"openstack%2Fnova~760987","triplet_id":"openstack%2Fnova~stable%2Fqueens~Ie62d3566230aa3e2786d129adbb2e3570b06e4c6","project":"openstack/nova","branch":"stable/queens","topic":"bug/1899541","hashtags":[],"change_id":"Ie62d3566230aa3e2786d129adbb2e3570b06e4c6","subject":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027","status":"ABANDONED","created":"2020-11-02 18:22:34.000000000","updated":"2022-11-11 18:24:17.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8825b8d7efc9ed03b125f6f8d0195f6d9ea09397","_number":760987,"virtual_id_number":760987,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-11-02 18:24:15.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2020-11-02 19:32:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-11-03 04:42:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-02 18:24:15.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-11-02 19:32:51.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-03 04:42:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"021a9f497837d4fda556bf95a1d99ca1f39ca7fd","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-11-02 18:22:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d51a4750128d2163de31f46a3564318cef07165","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-02 18:24:15.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/760987/1 : FAILURE in 48s","accounts_in_message":[],"_revision_number":1},{"id":"2e986582be83a0385235521f606f32e7b6537d56","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-02 19:32:51.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/87/760987/1/check/tempest-dsvm-full-xenial/f4686e8/ : FAILURE in 29m 34s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/87/760987/1/check/tempest-dsvm-full-xenial-py3/aa376af/ : FAILURE in 24m 52s","accounts_in_message":[],"_revision_number":1},{"id":"8ac321d6e4af1c02d3e9014e76bdd4d73a62379e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 04:42:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c236ed8f612e4c5386c5f68c9d5d904c : FAILURE in 9m 48s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6a46a60da06b4753a2c91fba96fe1ef2 : SUCCESS in 13m 35s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/eb5794b2f7e744d0b1347c96e6a329a7 : SUCCESS in 13m 01s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/8ed44d88a2294ba8ba1b7bc722e4765e : SUCCESS in 7m 20s\n- tempest-full https://zuul.opendev.org/t/openstack/build/8850c924105c4936b9d9e9d22f4b54cd : SUCCESS in 1h 23m 11s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/9eb5579cacc04b988065ec4bb1d6c7bb : SUCCESS in 58m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/61d01966751d42a1889845be2d9dac02 : SUCCESS in 1h 22m 56s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/cbe89296d86943f884932b7d338bbfad : SUCCESS in 1h 13m 36s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/7fcc6c8a0a33472d81e5413151d0aeb0 : SUCCESS in 59m 58s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/873b8cc3033044769f7b3578ab2848f6 : SUCCESS in 1h 01m 52s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/a322b44dbf774a88b7ce9355ed7f08d9 : SUCCESS in 50m 19s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/59023ca5b7be4e6d89513beb4871b8ac : SUCCESS in 56m 17s\n- nova-next https://zuul.opendev.org/t/openstack/build/ce360c540024440a97f6dd2082e097f1 : SUCCESS in 1h 19m 26s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/0eb2c0a2135e4ea1aa4a9837507350b5 : SUCCESS in 1h 50m 25s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/eb1832810d384bfa87876165b2a76a09 : SUCCESS in 20m 25s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/0b84116dd2e940f1b79637a25b99490a : SUCCESS in 19m 52s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/db5dc890297648f68203fe43f952d4b0 : SUCCESS in 1h 02m 52s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/1f34b31416b2458984b12ea7a3a24461 : FAILURE in 1h 10m 53s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/043ff93a0efd4f609a38b8d734606ae0 : SUCCESS in 1h 21m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8825b8d7efc9ed03b125f6f8d0195f6d9ea09397","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:24:17.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"54e8af9af15404fd81814775896db65b9b24091b","revisions":{"54e8af9af15404fd81814775896db65b9b24091b":{"kind":"REWORK","_number":1,"created":"2020-11-02 18:22:34.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/87/760987/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/760987/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/760987/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/760987/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/760987/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/760987/1"}}},"commit":{"parents":[{"commit":"78ac573a6cb6bba1f0c844a01602dec097a86b59","subject":"Merge \"[placement] Add status and links fields to version document at /\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78ac573a6cb6bba1f0c844a01602dec097a86b59"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-10-12 22:27:52.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-11-02 18:21:31.000000000","tz":0},"subject":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027","message":"Prevent archiving of pci_devices records because of \u0027instance_uuid\u0027\n\nCurrently in the archive_deleted_rows code, we will attempt to clean up\n\"residue\" of deleted instance records by assuming any table with a\n\u0027instance_uuid\u0027 column represents data tied to an instance\u0027s lifecycle\nand delete such records.\n\nThis behavior poses a problem in the case where an instance has a PCI\ndevice allocated and someone deletes the instance. The \u0027instance_uuid\u0027\ncolumn in the pci_devices table is used to track the allocation\nassociation of a PCI with an instance. There is a small time window\nduring which the instance record has been deleted but the PCI device\nhas not yet been freed from a database record perspective as PCI\ndevices are freed during the _complete_deletion method in the compute\nmanager as part of the resource tracker update call.\n\nRecords in the pci_devices table are anyway not related to the\nlifecycle of instances so they should not be considered residue to\nclean up if an instance is deleted. This adds a condition to avoid\narchiving pci_devices on the basis of an instance association.\n\nCloses-Bug: #1899541\n\nConflicts:\n    nova/tests/functional/db/test_archive.py\n\nNOTE(melwitt): The conflict is because change\nI6f87cf03d49be6bfad2c5e6f0c8accf0fab4e6ee (Add simple db purge command)\nis not in Queens.\n\nChange-Id: Ie62d3566230aa3e2786d129adbb2e3570b06e4c6\n(cherry picked from commit 1c256cf774693e2395ae8fe4a7a2f416a7aeb03a)\n(cherry picked from commit 09784db62fcd01124a101c4c69cab6e71e1ac781)\n(cherry picked from commit 79df36fecf8c8be5ae9d59397882ac844852043e)\n(cherry picked from commit e3bb6119cf2d0a503768979312aea4d10cf85cda)\n(cherry picked from commit da91b19d8be3b9cad8f713a3218a08e2d50238c8)\n(cherry picked from commit 661179de486e710f260e448b005e3383038337b8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/54e8af9af15404fd81814775896db65b9b24091b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/54e8af9af15404fd81814775896db65b9b24091b"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}