)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f19696eb21320fc186235ab0e4a4902b8a28d769","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix the compute RPC 5.12 issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In I147bf4d95e6d86ff1f967a8ce37260730f21d236 we added a new argument for"},{"line_number":10,"context_line":"the rebuild_instance() RPC method. Unfortunately, we missed to optionally it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Adding a default none value for it so rolling upgrades would work."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_45c78846","line":10,"range":{"start_line":10,"start_character":63,"end_line":10,"end_character":76},"updated":"2020-11-05 14:50:58.000000000","message":"I think you mean \"missed that it needs to be optional for older versions\" or something?","commit_id":"df47d0ad4d73001ae91fb870decf3eefb6052b54"}],"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7984da46c2094ae898a2d117a05a3858d33d0fb9","unresolved":false,"context_lines":[{"line_number":3352,"context_line":"        :param limits: Overcommit limits set by the scheduler. If a host was"},{"line_number":3353,"context_line":"                       specified by the user, this will be None"},{"line_number":3354,"context_line":"        :param request_spec: a RequestSpec object used to schedule the instance"},{"line_number":3355,"context_line":"        :param accel_uuids: a list of cyborg ARQ uuids."},{"line_number":3356,"context_line":""},{"line_number":3357,"context_line":"        \"\"\""},{"line_number":3358,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_8b3c1cc9","line":3355,"range":{"start_line":3355,"start_character":28,"end_line":3355,"end_character":34},"updated":"2020-11-04 19:33:48.000000000","message":"You\u0027re allowing this to be None now, even if that\u0027s not the RPC protocol, it\u0027s true. I\u0027m thinking you also want to set accel_uuids\u003d[] if this is not specified, to keep the code below consistent, else audit all the places we pass this to make sure they\u0027re okay with None.\n\nJust to be clear, there\u0027s nowhere we could or would have passed None in here from legit clients, right?","commit_id":"8e3b12ea7512f288811898a6c25235cb14037f7a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2b235daa2756adceb513fd68c077ca1ff51e7a7a","unresolved":false,"context_lines":[{"line_number":3352,"context_line":"        :param limits: Overcommit limits set by the scheduler. If a host was"},{"line_number":3353,"context_line":"                       specified by the user, this will be None"},{"line_number":3354,"context_line":"        :param request_spec: a RequestSpec object used to schedule the instance"},{"line_number":3355,"context_line":"        :param accel_uuids: a list of cyborg ARQ uuids."},{"line_number":3356,"context_line":""},{"line_number":3357,"context_line":"        \"\"\""},{"line_number":3358,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_f2349dfd","line":3355,"range":{"start_line":3355,"start_character":28,"end_line":3355,"end_character":34},"in_reply_to":"1f621f24_8b3c1cc9","updated":"2020-11-05 08:30:42.000000000","message":"Actually, that\u0027s a good point and I\u0027m not a Cyborg expert (so I don\u0027t know whether they support the nullable value later in the driver). \n\nGiven a list is a mutable object, I\u0027ll leave the default to be None but I\u0027ll see accel_uuids just below in a conditional.","commit_id":"8e3b12ea7512f288811898a6c25235cb14037f7a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e9bbf7b1452a5e11194a88807e6b4f46ddd22a2c","unresolved":false,"context_lines":[{"line_number":3352,"context_line":"        :param limits: Overcommit limits set by the scheduler. If a host was"},{"line_number":3353,"context_line":"                       specified by the user, this will be None"},{"line_number":3354,"context_line":"        :param request_spec: a RequestSpec object used to schedule the instance"},{"line_number":3355,"context_line":"        :param accel_uuids: a list of cyborg ARQ uuids."},{"line_number":3356,"context_line":""},{"line_number":3357,"context_line":"        \"\"\""},{"line_number":3358,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_2dafd894","line":3355,"range":{"start_line":3355,"start_character":28,"end_line":3355,"end_character":34},"in_reply_to":"1f621f24_f2349dfd","updated":"2020-11-05 09:06:24.000000000","message":"Well, I actually reviewed the compute manager to see when accel_uuids are used when we rebuild, and eventually it goes to https://github.com/openstack/nova/blob/edd8fef/nova/compute/manager.py#L3267 which sets an empty list if None is passed for the accel_uuids parameter.\n\nSo I think we don\u0027t need this conditional.","commit_id":"8e3b12ea7512f288811898a6c25235cb14037f7a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7984da46c2094ae898a2d117a05a3858d33d0fb9","unresolved":false,"context_lines":[{"line_number":3417,"context_line":"                    image_meta, injected_files, new_pass, orig_sys_metadata,"},{"line_number":3418,"context_line":"                    bdms, evacuate, on_shared_storage, preserve_ephemeral,"},{"line_number":3419,"context_line":"                    migration, request_spec, allocs, rebuild_claim,"},{"line_number":3420,"context_line":"                    scheduled_node, limits, accel_uuids)"},{"line_number":3421,"context_line":"            except (exception.ComputeResourcesUnavailable,"},{"line_number":3422,"context_line":"                    exception.RescheduledException) as e:"},{"line_number":3423,"context_line":"                if isinstance(e, exception.ComputeResourcesUnavailable):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_2b0d0837","line":3420,"range":{"start_line":3420,"start_character":44,"end_line":3420,"end_character":55},"updated":"2020-11-04 19:33:48.000000000","message":"Are we sure this can be None? Looks to me like virt/driver.py actually defaults this to \u003dNone (for some reason) so I _think_ we\u0027re okay. However, all the docstrings seem to imply this is a list, so unless there\u0027s something meaningful about an empty list, it seems like (especially for a backport) the safest thing would be to default accel_uuids\u003d[] if it\u0027s None coming into the manager method.","commit_id":"8e3b12ea7512f288811898a6c25235cb14037f7a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b8d121764c138b41520dafc28cae069df51057e8","unresolved":false,"context_lines":[{"line_number":3321,"context_line":"                         bdms, recreate, on_shared_storage,"},{"line_number":3322,"context_line":"                         preserve_ephemeral, migration,"},{"line_number":3323,"context_line":"                         scheduled_node, limits, request_spec,"},{"line_number":3324,"context_line":"                         accel_uuids\u003dNone):"},{"line_number":3325,"context_line":"        \"\"\"Destroy and re-make this instance."},{"line_number":3326,"context_line":""},{"line_number":3327,"context_line":"        A \u0027rebuild\u0027 effectively purges all existing data from the system and"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_edc160e6","line":3324,"updated":"2020-11-05 09:35:02.000000000","message":"Looks OK, the _rebuild_default_impl() handles the accel_uuids \u003d\u003d None case properly","commit_id":"e7d5d3a4fb5af7a306dfb6b7031c55dd7175aca9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b8d121764c138b41520dafc28cae069df51057e8","unresolved":false,"context_lines":[{"line_number":3352,"context_line":"        :param limits: Overcommit limits set by the scheduler. If a host was"},{"line_number":3353,"context_line":"                       specified by the user, this will be None"},{"line_number":3354,"context_line":"        :param request_spec: a RequestSpec object used to schedule the instance"},{"line_number":3355,"context_line":"        :param accel_uuids: a list of cyborg ARQ uuids."},{"line_number":3356,"context_line":""},{"line_number":3357,"context_line":"        \"\"\""},{"line_number":3358,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_2da35851","line":3355,"updated":"2020-11-05 09:35:02.000000000","message":"or None if the RPC version is \u003c 5.12","commit_id":"e7d5d3a4fb5af7a306dfb6b7031c55dd7175aca9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f19696eb21320fc186235ab0e4a4902b8a28d769","unresolved":false,"context_lines":[{"line_number":3353,"context_line":"                       specified by the user, this will be None"},{"line_number":3354,"context_line":"        :param request_spec: a RequestSpec object used to schedule the instance"},{"line_number":3355,"context_line":"        :param accel_uuids: a list of cyborg ARQ uuids or None if the RPC API"},{"line_number":3356,"context_line":"                            is \u003c\u003d5.11"},{"line_number":3357,"context_line":""},{"line_number":3358,"context_line":"        \"\"\""},{"line_number":3359,"context_line":"        # recreate\u003dTrue means the instance is being evacuated from a failed"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_25b36cec","line":3356,"updated":"2020-11-05 14:50:58.000000000","message":"Thanks, this at least captures that we\u0027ve audited that None is allowed.","commit_id":"df47d0ad4d73001ae91fb870decf3eefb6052b54"}],"releasenotes/notes/bug_1902925-351f563340a1e9a5.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"191d46f08d5711bc7cf17d59a14dfb34fa1b7f72","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    Compute RPC API was pinning to 5.11 (either automatically or by using"},{"line_number":7,"context_line":"    the specific rpc version in the option) but when rebuilding an instance,"},{"line_number":8,"context_line":"    a TypeError was raised as an argument was not provided. This error is"},{"line_number":9,"context_line":"    fixed by `bug 1902925`_."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. bug 1902925: https://bugs.launchpad.net/nova/+bug/1902925/"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f621f24_80efceae","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":9},"updated":"2020-11-05 16:14:21.000000000","message":"nit: tracked\n\nits fix by this commit.","commit_id":"df47d0ad4d73001ae91fb870decf3eefb6052b54"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"827bded2c92c12290c6eadac036a4ab3db8f250b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    a TypeError was raised as an argument was not provided. This error is"},{"line_number":9,"context_line":"    fixed by `bug 1902925`_."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. bug 1902925: https://bugs.launchpad.net/nova/+bug/1902925/"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f621f24_ba5af74b","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":19},"updated":"2020-11-05 14:11:39.000000000","message":".. _bug 1902925:","commit_id":"df47d0ad4d73001ae91fb870decf3eefb6052b54"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4d56022d9f1698f7d379ade8e736ee9471ef9f62","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    a TypeError was raised as an argument was not provided. This error is"},{"line_number":9,"context_line":"    fixed by `bug 1902925`_."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    .. bug 1902925: https://bugs.launchpad.net/nova/+bug/1902925/"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f621f24_05747098","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":19},"in_reply_to":"1f621f24_ba5af74b","updated":"2020-11-05 14:21:43.000000000","message":"Docs won\u0027t build until this is fixed.","commit_id":"df47d0ad4d73001ae91fb870decf3eefb6052b54"}]}