)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"daeaa0cf151bfa21a997a48bea17eb00e22f48bc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"following changes are performed"},{"line_number":28,"context_line":"- Modified the Neutron fixture to use LibvirtNeutron fixture."},{"line_number":29,"context_line":"- nova/tests/functional/libvirt/base.py is modified to include"},{"line_number":30,"context_line":"tenant_id in the port body."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: Id4ebb06e634a612c8be4be6c678d8265e0b99730"},{"line_number":33,"context_line":"Closes-Bug: #1892361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"83aecd20_c7d6d76a","line":30,"updated":"2020-11-30 14:48:08.000000000","message":"Thanks for the detailed explanation!\nnote to self: test_pci_sriov_servers.py is in conflict and modified due to test cleanup patch Iabe37dbdc244b019cb68099739b2c1c81b94a30d, and test refactoring patch I0c4f50ddd34d367f3c070a069c1d9b1da3869ce4 are not in Ussuri and we don\u0027t want to backport them.","commit_id":"4116c518de54cddbb9d8b4da62d7ab33ad93ff57"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"0bd897227f038af56a6faf21641edef9bd6c0874","unresolved":false,"context_lines":[{"line_number":27,"context_line":"following changes are performed"},{"line_number":28,"context_line":"- Modified the Neutron fixture to use LibvirtNeutron fixture."},{"line_number":29,"context_line":"- nova/tests/functional/libvirt/base.py is modified to include"},{"line_number":30,"context_line":"tenant_id in the port body."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: Id4ebb06e634a612c8be4be6c678d8265e0b99730"},{"line_number":33,"context_line":"Closes-Bug: #1892361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d72762c7_17793a4d","line":30,"in_reply_to":"83aecd20_c7d6d76a","updated":"2020-12-01 06:24:48.000000000","message":"Thanks","commit_id":"4116c518de54cddbb9d8b4da62d7ab33ad93ff57"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"daeaa0cf151bfa21a997a48bea17eb00e22f48bc","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: Id4ebb06e634a612c8be4be6c678d8265e0b99730"},{"line_number":33,"context_line":"Closes-Bug: #1892361"},{"line_number":34,"context_line":"(cherry picked from commit b8695de6da56db42b83b9d9d4c330148766644be)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ef19174_1ae56df3","line":34,"updated":"2020-11-30 14:48:08.000000000","message":"According to stable policy [1] the cherry pick should happen branch by branch. One indicator for that is the correct \u0027cherry picked from\u0027 lines. In case a cherry pick is properly done from branch N+1 to N (with \u0027git cherry-pick -x\u0027, then git extends the commit message with the proper \u0027cherry picked from\u0027 line. Could you please re-apply the cherry pick accordingly?\n\n[1] https://docs.openstack.org/project-team-guide/stable-branches.html#processes","commit_id":"4116c518de54cddbb9d8b4da62d7ab33ad93ff57"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"0bd897227f038af56a6faf21641edef9bd6c0874","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: Id4ebb06e634a612c8be4be6c678d8265e0b99730"},{"line_number":33,"context_line":"Closes-Bug: #1892361"},{"line_number":34,"context_line":"(cherry picked from commit b8695de6da56db42b83b9d9d4c330148766644be)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78a7666a_399648b8","line":34,"in_reply_to":"9ef19174_1ae56df3","updated":"2020-12-01 06:24:48.000000000","message":"I thought all the cherrypicks can be done from master, thanks for letting me know the correct process. \nThis is rectified in PS2. (Will update rest of backports as well accordingly.)","commit_id":"4116c518de54cddbb9d8b4da62d7ab33ad93ff57"}],"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5955efac8fefe7139c28685c1df77ad11fe32ce4","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        port \u003d copy.deepcopy(port)"},{"line_number":344,"context_line":"        port.update(body[\u0027port\u0027])"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # the tenant ID is normally extracted from credentials in the request"},{"line_number":347,"context_line":"        # and is not present in the body"},{"line_number":348,"context_line":"        if \u0027tenant_id\u0027 not in port:"},{"line_number":349,"context_line":"            port[\u0027tenant_id\u0027] \u003d nova_fixtures.NeutronFixture.tenant_id"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # similarly, these attributes are set by neutron itself"},{"line_number":352,"context_line":"        port[\u0027admin_state_up\u0027] \u003d True"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        self._ports[port[\u0027id\u0027]] \u003d port"},{"line_number":355,"context_line":"        # this copy is here as nova sometimes modifies the returned port"}],"source_content_type":"text/x-python","patch_set":2,"id":"7388cb7e_07815824","line":352,"range":{"start_line":346,"start_character":0,"end_line":352,"end_character":37},"updated":"2020-12-11 11:43:43.000000000","message":"this was added by https://github.com/openstack/nova/commit/17ba10b75961ef667e45b9dedbac34212a7e7e9b\nwhich i think we should also backport.","commit_id":"f58399cf496566e39d11f82a61e0b47900f2eafa"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"3cf2a8e11c4539098462551c13cfe66150304703","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        port \u003d copy.deepcopy(port)"},{"line_number":344,"context_line":"        port.update(body[\u0027port\u0027])"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        # the tenant ID is normally extracted from credentials in the request"},{"line_number":347,"context_line":"        # and is not present in the body"},{"line_number":348,"context_line":"        if \u0027tenant_id\u0027 not in port:"},{"line_number":349,"context_line":"            port[\u0027tenant_id\u0027] \u003d nova_fixtures.NeutronFixture.tenant_id"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # similarly, these attributes are set by neutron itself"},{"line_number":352,"context_line":"        port[\u0027admin_state_up\u0027] \u003d True"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        self._ports[port[\u0027id\u0027]] \u003d port"},{"line_number":355,"context_line":"        # this copy is here as nova sometimes modifies the returned port"}],"source_content_type":"text/x-python","patch_set":2,"id":"2bf9aa6b_e7040291","line":352,"range":{"start_line":346,"start_character":0,"end_line":352,"end_character":37},"in_reply_to":"7388cb7e_07815824","updated":"2021-01-05 05:51:43.000000000","message":"Ack","commit_id":"f58399cf496566e39d11f82a61e0b47900f2eafa"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5955efac8fefe7139c28685c1df77ad11fe32ce4","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    def setUp(self):"},{"line_number":126,"context_line":"        super().setUp()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # The ultimate base class _IntegratedTestBase uses NeutronFixture but"},{"line_number":129,"context_line":"        # we need a bit more intelligent neutron for these tests. Applying the"},{"line_number":130,"context_line":"        # new fixture here means that we re-stub what the previous neutron"},{"line_number":131,"context_line":"        # fixture already stubbed."},{"line_number":132,"context_line":"        self.neutron \u003d self.useFixture(base.LibvirtNeutronFixture(self))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _disable_sriov_in_pf(self, pci_info):"},{"line_number":135,"context_line":"        # Check for PF and change the capability from virt_functions"}],"source_content_type":"text/x-python","patch_set":2,"id":"9029efaa_8cc7c575","line":132,"range":{"start_line":128,"start_character":6,"end_line":132,"end_character":72},"updated":"2020-12-11 11:43:43.000000000","message":"so this is a partial backport of a different change\n\nwe might want to just backport https://github.com/openstack/nova/commit/0ab8a03c782851d4019c90e6159bd1f83c0658e6 instead","commit_id":"f58399cf496566e39d11f82a61e0b47900f2eafa"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"3cf2a8e11c4539098462551c13cfe66150304703","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    def setUp(self):"},{"line_number":126,"context_line":"        super().setUp()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # The ultimate base class _IntegratedTestBase uses NeutronFixture but"},{"line_number":129,"context_line":"        # we need a bit more intelligent neutron for these tests. Applying the"},{"line_number":130,"context_line":"        # new fixture here means that we re-stub what the previous neutron"},{"line_number":131,"context_line":"        # fixture already stubbed."},{"line_number":132,"context_line":"        self.neutron \u003d self.useFixture(base.LibvirtNeutronFixture(self))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _disable_sriov_in_pf(self, pci_info):"},{"line_number":135,"context_line":"        # Check for PF and change the capability from virt_functions"}],"source_content_type":"text/x-python","patch_set":2,"id":"74759363_a7e16b14","line":132,"range":{"start_line":128,"start_character":6,"end_line":132,"end_character":72},"in_reply_to":"9029efaa_8cc7c575","updated":"2021-01-05 05:51:43.000000000","message":"Ack","commit_id":"f58399cf496566e39d11f82a61e0b47900f2eafa"}],"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5955efac8fefe7139c28685c1df77ad11fe32ce4","unresolved":true,"context_lines":[{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"        nics \u003d \u0027\u0027"},{"line_number":1130,"context_line":"        for nic in self._def[\u0027devices\u0027][\u0027nics\u0027]:"},{"line_number":1131,"context_line":"            if \u0027source\u0027 in nic and nic[\u0027type\u0027] !\u003d \u0027hostdev\u0027:"},{"line_number":1132,"context_line":"                nics +\u003d \u0027\u0027\u0027\u003cinterface type\u003d\u0027%(type)s\u0027\u003e"},{"line_number":1133,"context_line":"          \u003cmac address\u003d\u0027%(mac)s\u0027/\u003e"},{"line_number":1134,"context_line":"          \u003csource %(type)s\u003d\u0027%(source)s\u0027/\u003e"}],"source_content_type":"text/x-python","patch_set":2,"id":"1df4757b_f71f9848","line":1131,"range":{"start_line":1131,"start_character":12,"end_line":1131,"end_character":60},"updated":"2020-12-11 11:43:43.000000000","message":"not that i am currenlty undoing this change on master.\nit was the incorrect approch to take initally\nhttps://review.opendev.org/c/openstack/nova/+/602432/26/nova/tests/unit/virt/libvirt/fakelibvirt.py#1203\nthat said since we will also need to backprot ^ its ok.","commit_id":"f58399cf496566e39d11f82a61e0b47900f2eafa"},{"author":{"_account_id":10366,"name":"Hemanth N","email":"hemanth.nakkina@canonical.com","username":"Hemanth"},"change_message_id":"3cf2a8e11c4539098462551c13cfe66150304703","unresolved":true,"context_lines":[{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"        nics \u003d \u0027\u0027"},{"line_number":1130,"context_line":"        for nic in self._def[\u0027devices\u0027][\u0027nics\u0027]:"},{"line_number":1131,"context_line":"            if \u0027source\u0027 in nic and nic[\u0027type\u0027] !\u003d \u0027hostdev\u0027:"},{"line_number":1132,"context_line":"                nics +\u003d \u0027\u0027\u0027\u003cinterface type\u003d\u0027%(type)s\u0027\u003e"},{"line_number":1133,"context_line":"          \u003cmac address\u003d\u0027%(mac)s\u0027/\u003e"},{"line_number":1134,"context_line":"          \u003csource %(type)s\u003d\u0027%(source)s\u0027/\u003e"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c70488c_f07462fd","line":1131,"range":{"start_line":1131,"start_character":12,"end_line":1131,"end_character":60},"in_reply_to":"1df4757b_f71f9848","updated":"2021-01-05 05:51:43.000000000","message":"Ack","commit_id":"f58399cf496566e39d11f82a61e0b47900f2eafa"}]}