)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5aa345a46fb489d7d19131a38f7f7213a3708e1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"service startup in such invalid configuration."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I89cdf3852266ed93a2ac7cd6261fe269932026ac"},{"line_number":21,"context_line":"Related-Bug: #1871482"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_73da174b","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":21},"updated":"2020-11-10 17:58:05.000000000","message":"+1 for inculding the ooo bug.","commit_id":"3b44275868e08992a36e9163f533d689f27a0119"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"4bfe6179273ddcdb6cbb4b41371c546f2c587f0c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"service startup in such invalid configuration."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I89cdf3852266ed93a2ac7cd6261fe269932026ac"},{"line_number":21,"context_line":"Related-Bug: #1871482"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_28994178","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":21},"in_reply_to":"1f621f24_73da174b","updated":"2020-11-11 14:45:05.000000000","message":"No, this patch isn\u0027t necessary to fix tripleo (already uses different conf files for compute/api). \n\nHowever this will be required until puppet-nova, docs, rpm/deb can split up nova.conf. I think it would be worth raising a new LP for that.","commit_id":"3b44275868e08992a36e9163f533d689f27a0119"}],"nova/utils.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5aa345a46fb489d7d19131a38f7f7213a3708e1","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                \u0027should run this service without the \u0027"},{"line_number":1080,"context_line":"                \u0027[api_database]/connection config option. The service version \u0027"},{"line_number":1081,"context_line":"                \u0027check will only query the local cell.\u0027)"},{"line_number":1082,"context_line":"            scope \u003d \u0027cell\u0027"},{"line_number":1083,"context_line":"            current_service_version \u003d service.Service.get_minimum_version("},{"line_number":1084,"context_line":"                ctxt, \u0027nova-compute\u0027)"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        scope \u003d \u0027cell\u0027"},{"line_number":1087,"context_line":"        # We in a cell so target our query to the current cell only"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_73b3370b","line":1084,"range":{"start_line":1082,"start_character":12,"end_line":1084,"end_character":37},"updated":"2020-11-10 17:58:05.000000000","message":"cool so this is just duplicating the else branch effectively +1","commit_id":"3b44275868e08992a36e9163f533d689f27a0119"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6eb11bbbec858fa752d629309f91f6de876a3597","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                \u0027should run this service without the \u0027"},{"line_number":1080,"context_line":"                \u0027[api_database]/connection config option. The service version \u0027"},{"line_number":1081,"context_line":"                \u0027check will only query the local cell.\u0027)"},{"line_number":1082,"context_line":"            scope \u003d \u0027cell\u0027"},{"line_number":1083,"context_line":"            current_service_version \u003d service.Service.get_minimum_version("},{"line_number":1084,"context_line":"                ctxt, \u0027nova-compute\u0027)"},{"line_number":1085,"context_line":"    else:"},{"line_number":1086,"context_line":"        scope \u003d \u0027cell\u0027"},{"line_number":1087,"context_line":"        # We in a cell so target our query to the current cell only"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_999c2dc1","line":1084,"range":{"start_line":1082,"start_character":12,"end_line":1084,"end_character":37},"in_reply_to":"1f621f24_73b3370b","updated":"2020-11-11 08:10:23.000000000","message":"yepp, it is the else branch all over again. As it is short I did not thought I should remove the duplication with a helper","commit_id":"3b44275868e08992a36e9163f533d689f27a0119"}]}