)]}'
{"nova/api/openstack/compute/contrib/simple_tenant_usage.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"50dc8032a447bc1fdac1614925def7ec16afabe8","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                            period_start,"},{"line_number":145,"context_line":"                                            period_stop)"},{"line_number":146,"context_line":"            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":147,"context_line":"            if not flavor:"},{"line_number":148,"context_line":"                continue"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            info[\u0027instance_id\u0027] \u003d instance.uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FQfE%3D","line":147,"updated":"2014-03-19 03:32:17.000000000","message":"If we still have to get fhe flavor we haven\u0027t actualy gained much with this patch have we? Or is there a plan to store the flavor name as well?\n\nAlso it looks like there is already fallback code in _get_flavor for when the instance has been deleted. Perhaps the additions just below should be in _get_flavor instead?","commit_id":"02e388ab0c0cabb5a1b56c30d86f47d418c5f54d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"dce9777f5a7d0878bdda314cc5215d7518d772c6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                            period_start,"},{"line_number":145,"context_line":"                                            period_stop)"},{"line_number":146,"context_line":"            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":147,"context_line":"            if not flavor:"},{"line_number":148,"context_line":"                continue"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            info[\u0027instance_id\u0027] \u003d instance.uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FHOM%3D","line":147,"in_reply_to":"AAAAWH%2F%2FQfE%3D","updated":"2014-03-20 06:14:52.000000000","message":"I think the purpose of this patch is \n(a) makes it more accurate and \n(b) avoids us failing to return usage info if a flavor disappears\n\nstore the flavor_name might not be a duplication because we already have flavor_id...\n\nI this we might need to set \u0027NOT EXIST\u0027 if we can\u0027t find the flavor","commit_id":"02e388ab0c0cabb5a1b56c30d86f47d418c5f54d"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"f5a361614b15204fdcff3991c5602a91df6676f0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                                            period_stop)"},{"line_number":146,"context_line":"            flavor \u003d self._get_flavor(context, instance, flavors)"},{"line_number":147,"context_line":"            if not flavor:"},{"line_number":148,"context_line":"                info[\u0027flavor\u0027] \u003d \u0027NOT EXIST\u0027"},{"line_number":149,"context_line":"            else:"},{"line_number":150,"context_line":"                info[\u0027flavor\u0027] \u003d flavor.name"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F95ag%3D","line":148,"updated":"2014-04-01 10:54:51.000000000","message":"I think it would be better to return the empty string rather than NOT EXIST","commit_id":"976d9abbf817dcd8911f62b634cf538471de1bda"}],"nova/tests/api/openstack/compute/contrib/test_simple_tenant_usage.py":[{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"ca901c0c9b04f21202c61534338097cdb20092a2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    inst[\u0027memory_mb\u0027] \u003d MEMORY_MB"},{"line_number":87,"context_line":"    inst[\u0027vcpus\u0027] \u003d VCPUS"},{"line_number":88,"context_line":"    inst[\u0027root_gb\u0027] \u003d ROOT_GB"},{"line_number":89,"context_line":"    inst[\u0027ephemeral_gb\u0027] \u003d EPHEMERAL_GB"},{"line_number":90,"context_line":"    inst[\u0027system_metadata\u0027] \u003d sys_meta"},{"line_number":91,"context_line":"    return inst"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fmzs%3D","line":89,"updated":"2014-02-25 17:47:42.000000000","message":"I\u0027m not sure if it will be better to change the stub_instance() for such information?","commit_id":"34dabb7ec80e2821d357876b8a6ce898a83123a5"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"da8c60917784d042d097d6fa9e9a103c31e52eb6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    inst[\u0027memory_mb\u0027] \u003d MEMORY_MB"},{"line_number":87,"context_line":"    inst[\u0027vcpus\u0027] \u003d VCPUS"},{"line_number":88,"context_line":"    inst[\u0027root_gb\u0027] \u003d ROOT_GB"},{"line_number":89,"context_line":"    inst[\u0027ephemeral_gb\u0027] \u003d EPHEMERAL_GB"},{"line_number":90,"context_line":"    inst[\u0027system_metadata\u0027] \u003d sys_meta"},{"line_number":91,"context_line":"    return inst"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FrNM%3D","line":89,"in_reply_to":"AAAAU3%2F%2FiuU%3D","updated":"2014-03-01 07:13:47.000000000","message":"I\u0027m not sure if followed change works. Other caller don\u0027t need change anything since we provide default value as 0, and this function can input value.\n\ndiff --git a/nova/tests/api/openstack/fakes.py b/nova/tests/api/openstack/fakes.py\nindex 4148399..1a4087c 100644\n--- a/nova/tests/api/openstack/fakes.py\n+++ b/nova/tests/api/openstack/fakes.py\n@@ -491,7 +491,8 @@ def stub_instance(id, user_id\u003dNone, project_id\u003dNone, host\u003dNone,\n                   limit\u003dNone, marker\u003dNone,\n                   launched_at\u003dtimeutils.utcnow(),\n                   terminated_at\u003dtimeutils.utcnow(),\n-                  availability_zone\u003d\u0027\u0027, locked_by\u003dNone, cleaned\u003dFalse):\n+                  availability_zone\u003d\u0027\u0027, locked_by\u003dNone, cleaned\u003dFalse,\n+                  memory_mb\u003d0, vcpus\u003d0,root_gb\u003d0,ephemeral_gb\u003d0):\n-\n     if user_id is None:\n         user_id \u003d \u0027fake_user\u0027\n@@ -547,10 +548,10 @@ def stub_instance(id, user_id\u003dNone, project_id\u003dNone, host\u003dNone,\n         \"vm_state\": vm_state or vm_states.BUILDING,\n         \"task_state\": task_state,\n         \"power_state\": power_state,\n-        \"memory_mb\": 0,\n-        \"vcpus\": 0,\n-        \"root_gb\": 0,\n-        \"ephemeral_gb\": 0,\n+        \"memory_mb\": memory_mb,\n+        \"vcpus\": vcpus,\n+        \"root_gb\": root_gb,\n+        \"ephemeral_gb\": ephemeral_gb,\n         \"ephemeral_key_uuid\": None,\n         \"hostname\": display_name or server_name,\n         \"host\": host,\n~\n~","commit_id":"34dabb7ec80e2821d357876b8a6ce898a83123a5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"703cbddc0f17452893b575de56c8d92b7e81101a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    inst[\u0027memory_mb\u0027] \u003d MEMORY_MB"},{"line_number":87,"context_line":"    inst[\u0027vcpus\u0027] \u003d VCPUS"},{"line_number":88,"context_line":"    inst[\u0027root_gb\u0027] \u003d ROOT_GB"},{"line_number":89,"context_line":"    inst[\u0027ephemeral_gb\u0027] \u003d EPHEMERAL_GB"},{"line_number":90,"context_line":"    inst[\u0027system_metadata\u0027] \u003d sys_meta"},{"line_number":91,"context_line":"    return inst"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FiuU%3D","line":89,"in_reply_to":"AAAAU3%2F%2Fmzs%3D","updated":"2014-02-26 01:44:44.000000000","message":"Yes, we can, I thought about it\nbut stub_instance didn\u0027t accept the param I need\n\nit use constant 0 and there are lot of place use \nstub_instance, so I don\u0027t want to modify it\n\n\"memory_mb\": 0,\n        \"vcpus\": 0,\n        \"root_gb\": 0,\n        \"ephemeral_gb\": 0,","commit_id":"34dabb7ec80e2821d357876b8a6ce898a83123a5"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7e74e6e7d2f593abde8d8ab084c10fdd2d102ce4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    inst[\u0027memory_mb\u0027] \u003d MEMORY_MB"},{"line_number":87,"context_line":"    inst[\u0027vcpus\u0027] \u003d VCPUS"},{"line_number":88,"context_line":"    inst[\u0027root_gb\u0027] \u003d ROOT_GB"},{"line_number":89,"context_line":"    inst[\u0027ephemeral_gb\u0027] \u003d EPHEMERAL_GB"},{"line_number":90,"context_line":"    inst[\u0027system_metadata\u0027] \u003d sys_meta"},{"line_number":91,"context_line":"    return inst"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fqlc%3D","line":89,"in_reply_to":"AAAAVX%2F%2FrNM%3D","updated":"2014-03-01 13:58:46.000000000","message":"make sense to me, thanks for your comments, I will set another patch","commit_id":"34dabb7ec80e2821d357876b8a6ce898a83123a5"}]}