)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"609ed4c55bcec1a83be8700adf85d6072c5702d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid changing transport_url value when updating Cell0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating cell0 using nova-manage client (nova-manage cell_v2 update_cell ...),"},{"line_number":10,"context_line":"its transport_url is being updated incorrectly. This happens because if an argument is not provided"},{"line_number":11,"context_line":"when invoking the client, its value is read from the configuration file,"},{"line_number":12,"context_line":"but cell0 has a special transport_url value (none:///), not provided via configuration file,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_8a7956c9","line":9,"range":{"start_line":9,"start_character":69,"end_line":9,"end_character":76},"updated":"2020-11-12 20:55:55.000000000","message":"As you can see by this dotted line, there is a size constraint on the lines of the commit message. I think there is a way to configure your vim to comply with that automatically.","commit_id":"ac07fad39645bd6cf6b833df207aaec973ae0899"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"38f4cc226aa7f7e1f0020bd6dae8e6e809a27a8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid changing transport_url value when updating Cell0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating cell0 using nova-manage client (nova-manage cell_v2 update_cell ...),"},{"line_number":10,"context_line":"its transport_url is being updated incorrectly. This happens because if an argument is not provided"},{"line_number":11,"context_line":"when invoking the client, its value is read from the configuration file,"},{"line_number":12,"context_line":"but cell0 has a special transport_url value (none:///), not provided via configuration file,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_edee2420","line":9,"range":{"start_line":9,"start_character":69,"end_line":9,"end_character":76},"in_reply_to":"1f621f24_8a7956c9","updated":"2020-11-12 21:26:22.000000000","message":"Done","commit_id":"ac07fad39645bd6cf6b833df207aaec973ae0899"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"609ed4c55bcec1a83be8700adf85d6072c5702d3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"In order to fix this issue, this patch will introdude the following changes:"},{"line_number":16,"context_line":"1- if transport_url is provided when updating cell0, the operation will fail with status code 6."},{"line_number":17,"context_line":"2- if transport_url is not provided when updating cell0, the client will try to execute the"},{"line_number":18,"context_line":"oeration without reading the transport_url value from the configuration file, leaving it value"},{"line_number":19,"context_line":"unchanged."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1888927"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_ca7fcea8","line":18,"range":{"start_line":18,"start_character":86,"end_line":18,"end_character":88},"updated":"2020-11-12 20:55:55.000000000","message":"its","commit_id":"ac07fad39645bd6cf6b833df207aaec973ae0899"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"38f4cc226aa7f7e1f0020bd6dae8e6e809a27a8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"In order to fix this issue, this patch will introdude the following changes:"},{"line_number":16,"context_line":"1- if transport_url is provided when updating cell0, the operation will fail with status code 6."},{"line_number":17,"context_line":"2- if transport_url is not provided when updating cell0, the client will try to execute the"},{"line_number":18,"context_line":"oeration without reading the transport_url value from the configuration file, leaving it value"},{"line_number":19,"context_line":"unchanged."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1888927"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_2df5bced","line":18,"range":{"start_line":18,"start_character":86,"end_line":18,"end_character":88},"in_reply_to":"1f621f24_ca7fcea8","updated":"2020-11-12 21:26:22.000000000","message":"Done","commit_id":"ac07fad39645bd6cf6b833df207aaec973ae0899"},{"author":{"_account_id":24407,"name":"Miriam Yumi Peixoto","display_name":"Miriam Yumi","email":"miriam.yumipeixoto@windriver.com","username":"miriamyumi"},"change_message_id":"67823982ff825153a5bc1b7914802d8ca1301985","unresolved":true,"context_lines":[{"line_number":14,"context_line":"(none:///), not provided via configuration file, so cell0 is updated"},{"line_number":15,"context_line":"with a wrong value."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In order to fix this issue, this patch will introdude the following"},{"line_number":18,"context_line":"changes:"},{"line_number":19,"context_line":"1- if transport_url is provided when updating cell0, the operation"},{"line_number":20,"context_line":"will fail with status code 6."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4b822b54_7593896c","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":53},"updated":"2020-11-24 16:15:06.000000000","message":"s/introdude/introduce","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"8f445ae7ea4a963729bfa10f3878331126cdbbb0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"(none:///), not provided via configuration file, so cell0 is updated"},{"line_number":15,"context_line":"with a wrong value."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In order to fix this issue, this patch will introdude the following"},{"line_number":18,"context_line":"changes:"},{"line_number":19,"context_line":"1- if transport_url is provided when updating cell0, the operation"},{"line_number":20,"context_line":"will fail with status code 6."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0e86b9e0_35928555","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":53},"in_reply_to":"4b822b54_7593896c","updated":"2020-11-24 20:39:25.000000000","message":"Done","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"}],"nova/cmd/manage.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"163cfaf32cf6a3cafde9bb9563763bf858f94511","unresolved":false,"context_lines":[{"line_number":1360,"context_line":"        # existing values, provided via configuration file,"},{"line_number":1361,"context_line":"        # but cell0 transport_url has a special, hardcoded value (none:///),"},{"line_number":1362,"context_line":"        # so we cannot get its value from the configuration file"},{"line_number":1363,"context_line":"        # when updating that cell"},{"line_number":1364,"context_line":"        if cell_mapping.is_cell0():"},{"line_number":1365,"context_line":"            if transport_url:"},{"line_number":1366,"context_line":"                print(_(\u0027Cell0 transport_url cannot be updated.\u0027))"},{"line_number":1367,"context_line":"                return 6"},{"line_number":1368,"context_line":"        else:"},{"line_number":1369,"context_line":"            transport_url \u003d self._validate_transport_url("},{"line_number":1370,"context_line":"                transport_url, warn_about_none\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_e33c2ac1","line":1367,"range":{"start_line":1363,"start_character":7,"end_line":1367,"end_character":24},"updated":"2020-11-19 19:05:54.000000000","message":"ok so this should block the case where we mistakenly pass the uuid of cell 0","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"163cfaf32cf6a3cafde9bb9563763bf858f94511","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"                print(_(\u0027Cell0 transport_url cannot be updated.\u0027))"},{"line_number":1367,"context_line":"                return 6"},{"line_number":1368,"context_line":"        else:"},{"line_number":1369,"context_line":"            transport_url \u003d self._validate_transport_url("},{"line_number":1370,"context_line":"                transport_url, warn_about_none\u003dFalse)"},{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":"        db_connection \u003d self._validate_database_connection("},{"line_number":1373,"context_line":"            db_connection, warn_about_none\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_434a5655","line":1370,"range":{"start_line":1369,"start_character":10,"end_line":1370,"end_character":53},"updated":"2020-11-19 19:05:54.000000000","message":"otherwise we can safely update.","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"}],"nova/tests/unit/cmd/test_manage.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"609ed4c55bcec1a83be8700adf85d6072c5702d3","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2063,"context_line":"        self.assertIn(\u0027Cell0 cannot be disabled.\u0027, output)"},{"line_number":2064,"context_line":""},{"line_number":2065,"context_line":"    def test_update_cell_update_cell0_transport_url_failed(self):"},{"line_number":2066,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2067,"context_line":"        uuid0 \u003d objects.CellMapping.CELL0_UUID"},{"line_number":2068,"context_line":"        objects.CellMapping(context\u003dctxt, uuid\u003duuid0, name\u003d\u0027cell0\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_aa537238","line":2065,"range":{"start_line":2065,"start_character":8,"end_line":2065,"end_character":58},"updated":"2020-11-12 20:55:55.000000000","message":"nice!","commit_id":"ac07fad39645bd6cf6b833df207aaec973ae0899"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"163cfaf32cf6a3cafde9bb9563763bf858f94511","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2067,"context_line":"        uuid0 \u003d objects.CellMapping.CELL0_UUID"},{"line_number":2068,"context_line":"        objects.CellMapping(context\u003dctxt, uuid\u003duuid0, name\u003d\u0027cell0\u0027,"},{"line_number":2069,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2070,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2071,"context_line":"        self.assertEqual(6, self.commands.update_cell("},{"line_number":2072,"context_line":"            uuid0, transport_url\u003d\u0027fake://mq2\u0027, db_connection\u003d\u0027fake:///db2\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_83d1de5a","line":2069,"range":{"start_line":2069,"start_character":43,"end_line":2069,"end_character":52},"updated":"2020-11-19 19:05:54.000000000","message":"this should be none:/// as you noted here right\n\nhttps://review.opendev.org/#/c/762433/5/nova/cmd/manage.py@1361","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"8b7d18bb23d57e52c86f16f204925bf9e4ecfb3c","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2067,"context_line":"        uuid0 \u003d objects.CellMapping.CELL0_UUID"},{"line_number":2068,"context_line":"        objects.CellMapping(context\u003dctxt, uuid\u003duuid0, name\u003d\u0027cell0\u0027,"},{"line_number":2069,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2070,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2071,"context_line":"        self.assertEqual(6, self.commands.update_cell("},{"line_number":2072,"context_line":"            uuid0, transport_url\u003d\u0027fake://mq2\u0027, db_connection\u003d\u0027fake:///db2\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_862d6c48","line":2069,"range":{"start_line":2069,"start_character":43,"end_line":2069,"end_character":52},"in_reply_to":"fffc6b78_83d1de5a","updated":"2020-11-19 20:33:33.000000000","message":"The purpose of test is to verify the CLI behavior when the user try to update the cell0 transport_url (and make sure that won\u0027t happen), and not to check the value itself. In this scenario, the initial value we set for cell0 transport_url would be irrelevant, IMHO. \n\nBut I\u0027m OK with changing it, if it will make easier to understand the test.","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"163cfaf32cf6a3cafde9bb9563763bf858f94511","unresolved":false,"context_lines":[{"line_number":2077,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2078,"context_line":"        uuid0 \u003d objects.CellMapping.CELL0_UUID"},{"line_number":2079,"context_line":"        objects.CellMapping(context\u003dctxt, uuid\u003duuid0, name\u003d\u0027cell0\u0027,"},{"line_number":2080,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2081,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2082,"context_line":"        self.assertEqual(0, self.commands.update_cell("},{"line_number":2083,"context_line":"            uuid0, \u0027foo\u0027, db_connection\u003d\u0027fake:///db2\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_633b1a9c","line":2080,"range":{"start_line":2080,"start_character":28,"end_line":2080,"end_character":54},"updated":"2020-11-19 19:05:54.000000000","message":"same here","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"},{"author":{"_account_id":32618,"name":"Daniel de Oliveira Pereira","display_name":"Daniel Pereira","email":"Daniel.Pereira@windriver.com","username":"danielpereira01"},"change_message_id":"8b7d18bb23d57e52c86f16f204925bf9e4ecfb3c","unresolved":false,"context_lines":[{"line_number":2077,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2078,"context_line":"        uuid0 \u003d objects.CellMapping.CELL0_UUID"},{"line_number":2079,"context_line":"        objects.CellMapping(context\u003dctxt, uuid\u003duuid0, name\u003d\u0027cell0\u0027,"},{"line_number":2080,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2081,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2082,"context_line":"        self.assertEqual(0, self.commands.update_cell("},{"line_number":2083,"context_line":"            uuid0, \u0027foo\u0027, db_connection\u003d\u0027fake:///db2\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fffc6b78_e61d5810","line":2080,"range":{"start_line":2080,"start_character":28,"end_line":2080,"end_character":54},"in_reply_to":"fffc6b78_633b1a9c","updated":"2020-11-19 20:33:33.000000000","message":"same here","commit_id":"6111f8bdb1813a55732e1824784ff772044b01ff"}]}