)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"90fbd08b8587407bd8d375371f6509757eb8afd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed84d264_ab56a7a8","updated":"2022-08-11 00:26:20.000000000","message":"i need to review this again when im not tired but this does not look correct to me","commit_id":"85eccda249630dd29515a2cfa98d8155928e8958"}],"nova/conductor/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"601ee03c8587b1d8baa7d59b01c1e8a0c2975ee0","unresolved":true,"context_lines":[{"line_number":1131,"context_line":"            else:"},{"line_number":1132,"context_line":"                # At this point, the user is either:"},{"line_number":1133,"context_line":"                #"},{"line_number":1134,"context_line":"                # 1. Doing a rebuild (not evacuate) and specified a new image."},{"line_number":1135,"context_line":"                # 2. Evacuating and specified a host but are not forcing it."},{"line_number":1136,"context_line":"                #"},{"line_number":1137,"context_line":"                # In either case, the API passes host\u003dNone but sets up the"}],"source_content_type":"text/x-python","patch_set":1,"id":"65abf665_db1befa9","line":1134,"updated":"2020-11-30 12:01:38.000000000","message":"Yes, this makes more sense. The previous conditional covers rebuilds on the same host with the same image (so bypassing the scheduler), while this covers rebuilds on the same host with a different image *or* rebuilds on another host. We weren\u0027t discussing the latter here.","commit_id":"85eccda249630dd29515a2cfa98d8155928e8958"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"90fbd08b8587407bd8d375371f6509757eb8afd8","unresolved":true,"context_lines":[{"line_number":1131,"context_line":"            else:"},{"line_number":1132,"context_line":"                # At this point, the user is either:"},{"line_number":1133,"context_line":"                #"},{"line_number":1134,"context_line":"                # 1. Doing a rebuild (not evacuate) and specified a new image."},{"line_number":1135,"context_line":"                # 2. Evacuating and specified a host but are not forcing it."},{"line_number":1136,"context_line":"                #"},{"line_number":1137,"context_line":"                # In either case, the API passes host\u003dNone but sets up the"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bee7b96_f59887e9","line":1134,"in_reply_to":"65abf665_db1befa9","updated":"2022-08-11 00:26:20.000000000","message":"we dont do rebuild to other hosts ever.\nrebuilds never change hosts only evaucates do.\n\nso droping on the same host is not really adding clarity here.\npepole constantoly mistake the fact that rebuid is not a move operation.","commit_id":"85eccda249630dd29515a2cfa98d8155928e8958"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"601ee03c8587b1d8baa7d59b01c1e8a0c2975ee0","unresolved":true,"context_lines":[{"line_number":1165,"context_line":"                try:"},{"line_number":1166,"context_line":"                    # if this is a rebuild of instance on the same host with"},{"line_number":1167,"context_line":"                    # new image."},{"line_number":1168,"context_line":"                    if not evacuate:"},{"line_number":1169,"context_line":"                        self._validate_image_traits_for_rebuild(context,"},{"line_number":1170,"context_line":"                                                                instance,"},{"line_number":1171,"context_line":"                                                                image_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b060229_9b8ca7b0","line":1168,"updated":"2020-11-30 12:01:38.000000000","message":"Yes, this is already handled at [1]. As it states there:\n\n \u003e If a new image is provided on rebuild, we will need to run\n \u003e through the scheduler again, but we want the instance to be\n \u003e rebuilt on the same host it\u0027s already on.\n\nSince we\u0027re in the else case, we already know that \u0027host\u0027 is unset which means, based on [1], we definitely have a different image.\n\nIn terms of RPC versioning, we don\u0027t support N -\u003e N-M, where M \u003e 1, so we can be sure that change I34ffaf285718059b55f90e812b57f1e11d566c6f which made that check at [1] mandatory is present.\n\n[1] https://github.com/openstack/nova/blob/b012361a53354787799168fef0aac075d6e55202/nova/compute/api.py#L3577-L3598","commit_id":"85eccda249630dd29515a2cfa98d8155928e8958"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"90fbd08b8587407bd8d375371f6509757eb8afd8","unresolved":true,"context_lines":[{"line_number":1165,"context_line":"                try:"},{"line_number":1166,"context_line":"                    # if this is a rebuild of instance on the same host with"},{"line_number":1167,"context_line":"                    # new image."},{"line_number":1168,"context_line":"                    if not evacuate:"},{"line_number":1169,"context_line":"                        self._validate_image_traits_for_rebuild(context,"},{"line_number":1170,"context_line":"                                                                instance,"},{"line_number":1171,"context_line":"                                                                image_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a99f6630_ff42debc","line":1168,"in_reply_to":"3b060229_9b8ca7b0","updated":"2022-08-11 00:26:20.000000000","message":"we explictly dont want to do the validation if the image is the same and do want to do it if it changes which appear to be lost here.","commit_id":"85eccda249630dd29515a2cfa98d8155928e8958"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"638fb69ded8c2476ec7bf0edf246fdb00baf9f8c","unresolved":true,"context_lines":[{"line_number":1165,"context_line":"                try:"},{"line_number":1166,"context_line":"                    # if this is a rebuild of instance on the same host with"},{"line_number":1167,"context_line":"                    # new image."},{"line_number":1168,"context_line":"                    if not evacuate:"},{"line_number":1169,"context_line":"                        self._validate_image_traits_for_rebuild(context,"},{"line_number":1170,"context_line":"                                                                instance,"},{"line_number":1171,"context_line":"                                                                image_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d3a22bf_e8c1205c","line":1168,"in_reply_to":"a99f6630_ff42debc","updated":"2023-06-30 17:43:32.000000000","message":"I agree with Sean, if same image and we are rebuilding on same host where instance image is already validated while instance creation, we do not need to validate it again.","commit_id":"85eccda249630dd29515a2cfa98d8155928e8958"}]}