)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b1cafe07b19d9b328005c8e3a3b83dd6e9af151d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-01-17 08:06:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Trivial] Rename host/node to hostname/nodename in conductor manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I34ade962c00edd63582c15537d3863e94ad6c80a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f4b240a_5ae3d899","line":8,"updated":"2021-01-20 13:34:52.000000000","message":"What we gain by that? Doesn\u0027t we introduce more confusion as now conductor manager uses this naming scheme why the rest of the code uses the host/node naming?","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"67ff2d43185041c43ce029d77bbf6c776daf1d18","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-01-17 08:06:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Trivial] Rename host/node to hostname/nodename in conductor manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I34ade962c00edd63582c15537d3863e94ad6c80a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"8ac0ba5e_b49b77e1","line":8,"in_reply_to":"3f4b240a_5ae3d899","updated":"2021-01-21 08:45:07.000000000","message":"IMO, this change make the developer easy to know what they are needed when they want to get the host/node name, it\u0027s friendly for the us, rather then using an ambiguous parameter to pass","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"}],"nova/conductor/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a6fdb47778771b232247f1904dd94263f31477c","unresolved":false,"context_lines":[{"line_number":992,"context_line":"                    selection \u003d host_list[0]"},{"line_number":993,"context_line":"                    scheduler_utils.populate_filter_properties("},{"line_number":994,"context_line":"                            filter_properties, selection)"},{"line_number":995,"context_line":"                    (hostname, nodename) \u003d (selection.service_host,"},{"line_number":996,"context_line":"                                            selection.nodename)"},{"line_number":997,"context_line":"                    instance.availability_zone \u003d ("},{"line_number":998,"context_line":"                        availability_zones.get_host_availability_zone("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_91c35457","line":995,"range":{"start_line":995,"start_character":20,"end_line":995,"end_character":21},"updated":"2020-11-12 11:36:53.000000000","message":"nit: you could remove these while you\u0027re here, or, better:\n\n  hostname \u003d selection.service_host\n  nodename \u003d selection.nodename","commit_id":"cb6a8e0c621fb5033b57ed69f1348f076672e537"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"80892a3432ccc0c4ecc9af35437b7c5af412795c","unresolved":false,"context_lines":[{"line_number":992,"context_line":"                    selection \u003d host_list[0]"},{"line_number":993,"context_line":"                    scheduler_utils.populate_filter_properties("},{"line_number":994,"context_line":"                            filter_properties, selection)"},{"line_number":995,"context_line":"                    (hostname, nodename) \u003d (selection.service_host,"},{"line_number":996,"context_line":"                                            selection.nodename)"},{"line_number":997,"context_line":"                    instance.availability_zone \u003d ("},{"line_number":998,"context_line":"                        availability_zones.get_host_availability_zone("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_717958c6","line":995,"range":{"start_line":995,"start_character":20,"end_line":995,"end_character":21},"in_reply_to":"1f621f24_91c35457","updated":"2020-11-12 12:19:41.000000000","message":"Done","commit_id":"cb6a8e0c621fb5033b57ed69f1348f076672e537"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a6fdb47778771b232247f1904dd94263f31477c","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"                            return_alternates\u003dFalse)"},{"line_number":1196,"context_line":"                    host_list \u003d host_lists[0]"},{"line_number":1197,"context_line":"                    selection \u003d host_list[0]"},{"line_number":1198,"context_line":"                    hostiname, nodename, limits \u003d (selection.service_host,"},{"line_number":1199,"context_line":"                            selection.nodename, selection.limits)"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"                    if recreate:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_f1a3a8b0","line":1198,"range":{"start_line":1198,"start_character":20,"end_line":1198,"end_character":29},"updated":"2020-11-12 11:36:53.000000000","message":"hostname","commit_id":"cb6a8e0c621fb5033b57ed69f1348f076672e537"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"80892a3432ccc0c4ecc9af35437b7c5af412795c","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"                            return_alternates\u003dFalse)"},{"line_number":1196,"context_line":"                    host_list \u003d host_lists[0]"},{"line_number":1197,"context_line":"                    selection \u003d host_list[0]"},{"line_number":1198,"context_line":"                    hostiname, nodename, limits \u003d (selection.service_host,"},{"line_number":1199,"context_line":"                            selection.nodename, selection.limits)"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":"                    if recreate:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_31452071","line":1198,"range":{"start_line":1198,"start_character":20,"end_line":1198,"end_character":29},"in_reply_to":"1f621f24_f1a3a8b0","updated":"2020-11-12 12:19:41.000000000","message":"Done","commit_id":"cb6a8e0c621fb5033b57ed69f1348f076672e537"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bef31f0c1e7e42edffe0239fa02cfcf63be5d798","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"        # now, so it would be nontrivial to change."},{"line_number":1094,"context_line":"        with compute_utils.EventReporter(context, \u0027rebuild_server\u0027,"},{"line_number":1095,"context_line":"                                         self.host, instance.uuid):"},{"line_number":1096,"context_line":"            node \u003d limits \u003d None"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"            try:"},{"line_number":1099,"context_line":"                migration \u003d objects.Migration.get_by_instance_and_status("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_009eccb7","line":1096,"updated":"2020-11-12 16:23:59.000000000","message":"pep8: F841 local variable \u0027node\u0027 is assigned to but never used","commit_id":"1f2f8ad9583fbf970b95658794e3609ede1a1d27"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"d0ee47e9ed5942edafc1be22350ea6477fc464d7","unresolved":false,"context_lines":[{"line_number":1086,"context_line":"        # confusing, so rename it to evacuate here at the top, which is simpler"},{"line_number":1087,"context_line":"        # than renaming a parameter in an RPC versioned method."},{"line_number":1088,"context_line":"        evacuate \u003d recreate"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"        # NOTE(efried): It would be nice if this were two separate events, one"},{"line_number":1091,"context_line":"        # for \u0027rebuild\u0027 and one for \u0027evacuate\u0027, but this is part of the API"},{"line_number":1092,"context_line":"        # now, so it would be nontrivial to change."}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_5e837c04","line":1089,"updated":"2020-11-13 02:16:33.000000000","message":"hostname \u003d host","commit_id":"338bfae8b9d627078f8a70e2eaf0b004333e86d1"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1e448469b35636931bf70a954dde19e7604570a0","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"        # now, so it would be nontrivial to change."},{"line_number":1093,"context_line":"        with compute_utils.EventReporter(context, \u0027rebuild_server\u0027,"},{"line_number":1094,"context_line":"                                         self.host, instance.uuid):"},{"line_number":1095,"context_line":"            node \u003d limits \u003d None"},{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"            try:"},{"line_number":1098,"context_line":"                migration \u003d objects.Migration.get_by_instance_and_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_9ed23427","line":1095,"updated":"2020-11-13 02:05:04.000000000","message":"pep8: F841 local variable \u0027node\u0027 is assigned to but never used","commit_id":"338bfae8b9d627078f8a70e2eaf0b004333e86d1"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8d5c9652046f61987adf67fc502c55f08c493f65","unresolved":true,"context_lines":[{"line_number":863,"context_line":"        try:"},{"line_number":864,"context_line":"            resource_provider_mapping \u003d ("},{"line_number":865,"context_line":"                request_spec.get_request_group_mapping())"},{"line_number":866,"context_line":"            # Using nodename instead of hostname. See:"},{"line_number":867,"context_line":"            # http://lists.openstack.org/pipermail/openstack-discuss/2019-November/011044.html  # noqa"},{"line_number":868,"context_line":"            return self._create_and_bind_arqs("},{"line_number":869,"context_line":"                context, instance.uuid, instance.flavor.extra_specs,"},{"line_number":870,"context_line":"                hostname, resource_provider_mapping)"}],"source_content_type":"text/x-python","patch_set":9,"id":"92c0fb47_3203310c","line":867,"range":{"start_line":866,"start_character":12,"end_line":867,"end_character":102},"updated":"2021-01-17 08:07:55.000000000","message":"move this to L840","commit_id":"a56f562e3fe806f2a70b727da95db9d14a88624a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b1cafe07b19d9b328005c8e3a3b83dd6e9af151d","unresolved":true,"context_lines":[{"line_number":838,"context_line":""},{"line_number":839,"context_line":"            try:"},{"line_number":840,"context_line":"                # Using nodename instead of hostname. See:"},{"line_number":841,"context_line":"                # http://lists.openstack.org/pipermail/openstack-discuss/2019-November/011044.html  # noqa"},{"line_number":842,"context_line":"                accel_uuids \u003d self._create_and_bind_arq_for_instance("},{"line_number":843,"context_line":"                    context, instance, host.nodename, local_reqspec)"},{"line_number":844,"context_line":"            except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":11,"id":"b031a14b_2903cc56","line":841,"updated":"2021-01-20 13:34:52.000000000","message":"moving the comment make sense as the actual decision to use the nodename happens here instead of L868","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b1cafe07b19d9b328005c8e3a3b83dd6e9af151d","unresolved":true,"context_lines":[{"line_number":1089,"context_line":"        evacuate \u003d recreate"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"        # NOTE(brinzhang): The host variable express the name of the host."},{"line_number":1092,"context_line":"        hostname \u003d host"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        # NOTE(efried): It would be nice if this were two separate events, one"},{"line_number":1095,"context_line":"        # for \u0027rebuild\u0027 and one for \u0027evacuate\u0027, but this is part of the API"}],"source_content_type":"text/x-python","patch_set":11,"id":"4fde1bbb_42069836","line":1092,"updated":"2021-01-20 13:34:52.000000000","message":"this rename feels forced to me","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"67ff2d43185041c43ce029d77bbf6c776daf1d18","unresolved":true,"context_lines":[{"line_number":1089,"context_line":"        evacuate \u003d recreate"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"        # NOTE(brinzhang): The host variable express the name of the host."},{"line_number":1092,"context_line":"        hostname \u003d host"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        # NOTE(efried): It would be nice if this were two separate events, one"},{"line_number":1095,"context_line":"        # for \u0027rebuild\u0027 and one for \u0027evacuate\u0027, but this is part of the API"}],"source_content_type":"text/x-python","patch_set":11,"id":"a9e86f3e_3ef30634","line":1092,"in_reply_to":"4fde1bbb_42069836","updated":"2021-01-21 08:45:07.000000000","message":"Indeed, the parameter in Line1083 \"host\u003dNone,\" should be defined as hostname, it\u0027s available in this function.\n\nIn my opinion, \u0027host\u0027 should be an \u0027object\u0027, but it just means a name of the host at here.\n\nThis is confusing for me, I think it also confusing for many new reviewer if they read nova code.","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b1cafe07b19d9b328005c8e3a3b83dd6e9af151d","unresolved":true,"context_lines":[{"line_number":1117,"context_line":"            if hostname:"},{"line_number":1118,"context_line":"                # We only create a new allocation on the specified host if"},{"line_number":1119,"context_line":"                # we\u0027re doing an evacuate since that is a move operation."},{"line_number":1120,"context_line":"                if hostname !\u003d instance.host:"},{"line_number":1121,"context_line":"                    # If a destination host is forced for evacuate, create"},{"line_number":1122,"context_line":"                    # allocations against it in Placement."},{"line_number":1123,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fde07fed_0264fd85","line":1120,"updated":"2021-01-20 13:34:52.000000000","message":"why we are doing a host -\u003e hostname rename in these code paths? Here it feels a step backward as it is matched with instance.host We have a lot of places where host means the hostname of the compute service. For example InstanceList.get_by_host_and_node()","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"67ff2d43185041c43ce029d77bbf6c776daf1d18","unresolved":true,"context_lines":[{"line_number":1117,"context_line":"            if hostname:"},{"line_number":1118,"context_line":"                # We only create a new allocation on the specified host if"},{"line_number":1119,"context_line":"                # we\u0027re doing an evacuate since that is a move operation."},{"line_number":1120,"context_line":"                if hostname !\u003d instance.host:"},{"line_number":1121,"context_line":"                    # If a destination host is forced for evacuate, create"},{"line_number":1122,"context_line":"                    # allocations against it in Placement."},{"line_number":1123,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"888fbd31_ee2d51cb","line":1120,"in_reply_to":"fde07fed_0264fd85","updated":"2021-01-21 08:45:07.000000000","message":"Theoretically, they are need to changed as the say way, but I ...","commit_id":"62506c51e4818be9701bc62fd1f46cf2d970efed"}]}