)]}'
{"nova/config.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ef236436e13cb66ba846e23fa643e2ca05707ec8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def set_lib_defaults():"},{"line_number":38,"context_line":"    \"\"\"Update default value for configuration options from other"},{"line_number":39,"context_line":"    namespace. Example oslo lib config options. This is needed for"},{"line_number":40,"context_line":"    config generator tool to pick these default value changes."},{"line_number":41,"context_line":"    https://docs.openstack.org/oslo.config/latest/cli/"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_3cd83eed","line":38,"updated":"2020-11-14 00:57:32.000000000","message":"pep8: H403: multi line docstrings should end on a new line","commit_id":"5fe0a4df029a257d9a315472db5ad3b87063dbf8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ef236436e13cb66ba846e23fa643e2ca05707ec8","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def set_lib_defaults():"},{"line_number":38,"context_line":"    \"\"\"Update default value for configuration options from other"},{"line_number":39,"context_line":"    namespace. Example oslo lib config options. This is needed for"},{"line_number":40,"context_line":"    config generator tool to pick these default value changes."},{"line_number":41,"context_line":"    https://docs.openstack.org/oslo.config/latest/cli/"},{"line_number":42,"context_line":"    generator.html#modifying-defaults-from-other-namespaces\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9ce352a4","line":39,"updated":"2020-11-14 00:57:32.000000000","message":"pep8: H403: multi line docstrings should end on a new line","commit_id":"5fe0a4df029a257d9a315472db5ad3b87063dbf8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ef236436e13cb66ba846e23fa643e2ca05707ec8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"def set_lib_defaults():"},{"line_number":38,"context_line":"    \"\"\"Update default value for configuration options from other"},{"line_number":39,"context_line":"    namespace. Example oslo lib config options. This is needed for"},{"line_number":40,"context_line":"    config generator tool to pick these default value changes."},{"line_number":41,"context_line":"    https://docs.openstack.org/oslo.config/latest/cli/"},{"line_number":42,"context_line":"    generator.html#modifying-defaults-from-other-namespaces\"\"\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_7cde36da","line":40,"updated":"2020-11-14 00:57:32.000000000","message":"pep8: H403: multi line docstrings should end on a new line","commit_id":"5fe0a4df029a257d9a315472db5ad3b87063dbf8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ef236436e13cb66ba846e23fa643e2ca05707ec8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \"\"\"Update default value for configuration options from other"},{"line_number":39,"context_line":"    namespace. Example oslo lib config options. This is needed for"},{"line_number":40,"context_line":"    config generator tool to pick these default value changes."},{"line_number":41,"context_line":"    https://docs.openstack.org/oslo.config/latest/cli/"},{"line_number":42,"context_line":"    generator.html#modifying-defaults-from-other-namespaces\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Update default value of oslo.middleware cors config option."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_dcf2ea6f","line":41,"updated":"2020-11-14 00:57:32.000000000","message":"pep8: H403: multi line docstrings should end on a new line","commit_id":"5fe0a4df029a257d9a315472db5ad3b87063dbf8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ef236436e13cb66ba846e23fa643e2ca05707ec8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    namespace. Example oslo lib config options. This is needed for"},{"line_number":40,"context_line":"    config generator tool to pick these default value changes."},{"line_number":41,"context_line":"    https://docs.openstack.org/oslo.config/latest/cli/"},{"line_number":42,"context_line":"    generator.html#modifying-defaults-from-other-namespaces\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Update default value of oslo.middleware cors config option."},{"line_number":45,"context_line":"    middleware.set_defaults()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_bcf56e59","line":42,"updated":"2020-11-14 00:57:32.000000000","message":"pep8: H403: multi line docstrings should end on a new line","commit_id":"5fe0a4df029a257d9a315472db5ad3b87063dbf8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2e4c5765e5ee3478e756383e534b66110ec21b57","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    rabbit_logger.addFilter(rabbit_heartbeat_filter)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    set_log_defaults()"},{"line_number":91,"context_line":"    rpc.set_defaults(control_exchange\u003d\u0027nova\u0027)"},{"line_number":92,"context_line":"    if profiler:"},{"line_number":93,"context_line":"        profiler.set_defaults(CONF)"},{"line_number":94,"context_line":"    middleware.set_defaults()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9943fddd_68d0fa02","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":45},"updated":"2020-11-24 11:08:05.000000000","message":"now this is called from two places, here and at L50. Can we centralize the default settings into set_lib_defaults() and only call that both from parse_args and from setup.cfg?","commit_id":"94e77831a8115e7e2b370f8035d2d8a487888e81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f53165b9e5be8d4afc9ad1a2912bff0dfb4c4d67","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    rabbit_logger.addFilter(rabbit_heartbeat_filter)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    set_log_defaults()"},{"line_number":91,"context_line":"    rpc.set_defaults(control_exchange\u003d\u0027nova\u0027)"},{"line_number":92,"context_line":"    if profiler:"},{"line_number":93,"context_line":"        profiler.set_defaults(CONF)"},{"line_number":94,"context_line":"    middleware.set_defaults()"}],"source_content_type":"text/x-python","patch_set":3,"id":"537ab5ba_f0e5676c","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":45},"in_reply_to":"9943fddd_68d0fa02","updated":"2020-11-25 00:03:53.000000000","message":"sure, done","commit_id":"94e77831a8115e7e2b370f8035d2d8a487888e81"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2e4c5765e5ee3478e756383e534b66110ec21b57","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    set_log_defaults()"},{"line_number":91,"context_line":"    rpc.set_defaults(control_exchange\u003d\u0027nova\u0027)"},{"line_number":92,"context_line":"    if profiler:"},{"line_number":93,"context_line":"        profiler.set_defaults(CONF)"},{"line_number":94,"context_line":"    middleware.set_defaults()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    CONF(argv[1:],"}],"source_content_type":"text/x-python","patch_set":3,"id":"b47b44f6_b55a0b0b","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":35},"updated":"2020-11-24 11:08:05.000000000","message":"While it looks like as a config override, without any other parameters it does not override any config[1] it just register the osprofiler opts. \n\n[1] https://github.com/openstack/osprofiler/blob/f4c47a18e79c227412547ce8fbaeb580ba9e4a1d/osprofiler/opts.py#L174","commit_id":"94e77831a8115e7e2b370f8035d2d8a487888e81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f53165b9e5be8d4afc9ad1a2912bff0dfb4c4d67","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    set_log_defaults()"},{"line_number":91,"context_line":"    rpc.set_defaults(control_exchange\u003d\u0027nova\u0027)"},{"line_number":92,"context_line":"    if profiler:"},{"line_number":93,"context_line":"        profiler.set_defaults(CONF)"},{"line_number":94,"context_line":"    middleware.set_defaults()"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    CONF(argv[1:],"}],"source_content_type":"text/x-python","patch_set":3,"id":"532155c2_5ea2e4b5","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":35},"in_reply_to":"b47b44f6_b55a0b0b","updated":"2020-11-25 00:03:53.000000000","message":"yeah no opt are passed in this to override so this just register the opts with default in osprofiler","commit_id":"94e77831a8115e7e2b370f8035d2d8a487888e81"}]}
