)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"4827dbdb779c7014778f889d81a32039ee44239a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003cstephenfin@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-16 17:47:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add missing exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change Idd49b0c70caedfcd42420ffa2ac926a6087d406e added support for"},{"line_number":10,"context_line":"discovery of PMEM devices by the libvirt driver. Some error handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f621f24_87076dca","line":7,"updated":"2020-11-16 20:32:44.000000000","message":"nit: missing name of the exception \u0027GetPMEMNamespacesFailed\u0027","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"}],"nova/exception.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"477727e16d7f907b78d9c7fd290059c101d44bbf","unresolved":false,"context_lines":[{"line_number":2274,"context_line":"                \"please check your conf file. \")"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":""},{"line_number":2277,"context_line":"class GetPMEMNamespacesFailed(NovaException):"},{"line_number":2278,"context_line":"    msg_fmt \u003d _(\"Get PMEM namespaces on host failed: %(reason)s.\")"},{"line_number":2279,"context_line":""},{"line_number":2280,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_71c00fe2","line":2277,"range":{"start_line":2277,"start_character":6,"end_line":2277,"end_character":29},"updated":"2020-11-16 18:28:12.000000000","message":"ok so this never actully existed before \n\nso when it was used here it was always wrong\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L449\n\nand your prvious change here \nhttps://review.opendev.org/#/c/703147/3/nova/virt/libvirt/driver.py@485\ndid not fix it.","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"4827dbdb779c7014778f889d81a32039ee44239a","unresolved":false,"context_lines":[{"line_number":27502,"context_line":"                          drvr._discover_vpmems, vpmem_conf)"},{"line_number":27503,"context_line":""},{"line_number":27504,"context_line":"    @mock.patch(\u0027nova.privsep.libvirt.get_pmem_namespaces\u0027)"},{"line_number":27505,"context_line":"    def test___get_vpmems_on_host__exception(self, mock_get_ns):"},{"line_number":27506,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":27507,"context_line":"        mock_get_ns.side_effect \u003d Exception(\u0027foo\u0027)"},{"line_number":27508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_07fb5dc0","line":27505,"range":{"start_line":27505,"start_character":12,"end_line":27505,"end_character":15},"updated":"2020-11-16 20:32:44.000000000","message":"extra underscores","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"},{"author":{"_account_id":27478,"name":"Archit Modi","email":"amodi@redhat.com","username":"amodi"},"change_message_id":"4827dbdb779c7014778f889d81a32039ee44239a","unresolved":false,"context_lines":[{"line_number":27502,"context_line":"                          drvr._discover_vpmems, vpmem_conf)"},{"line_number":27503,"context_line":""},{"line_number":27504,"context_line":"    @mock.patch(\u0027nova.privsep.libvirt.get_pmem_namespaces\u0027)"},{"line_number":27505,"context_line":"    def test___get_vpmems_on_host__exception(self, mock_get_ns):"},{"line_number":27506,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":27507,"context_line":"        mock_get_ns.side_effect \u003d Exception(\u0027foo\u0027)"},{"line_number":27508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_e7f581cc","line":27505,"range":{"start_line":27505,"start_character":33,"end_line":27505,"end_character":35},"updated":"2020-11-16 20:32:44.000000000","message":"same- extra underscores \u0027_\u0027","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4178cfbaba8355c86c80cf35c48f0b62abd97cd","unresolved":false,"context_lines":[{"line_number":27502,"context_line":"                          drvr._discover_vpmems, vpmem_conf)"},{"line_number":27503,"context_line":""},{"line_number":27504,"context_line":"    @mock.patch(\u0027nova.privsep.libvirt.get_pmem_namespaces\u0027)"},{"line_number":27505,"context_line":"    def test___get_vpmems_on_host__exception(self, mock_get_ns):"},{"line_number":27506,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":27507,"context_line":"        mock_get_ns.side_effect \u003d Exception(\u0027foo\u0027)"},{"line_number":27508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_10aa6c17","line":27505,"range":{"start_line":27505,"start_character":12,"end_line":27505,"end_character":15},"in_reply_to":"1f621f24_07fb5dc0","updated":"2020-11-17 10:15:19.000000000","message":"That\u0027s intentional - the function name is \u0027_get_vpmems_on_host\u0027, so the test is \u0027test_\u0027 + \u0027_get_vpmems_on_host\u0027","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4178cfbaba8355c86c80cf35c48f0b62abd97cd","unresolved":false,"context_lines":[{"line_number":27502,"context_line":"                          drvr._discover_vpmems, vpmem_conf)"},{"line_number":27503,"context_line":""},{"line_number":27504,"context_line":"    @mock.patch(\u0027nova.privsep.libvirt.get_pmem_namespaces\u0027)"},{"line_number":27505,"context_line":"    def test___get_vpmems_on_host__exception(self, mock_get_ns):"},{"line_number":27506,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":27507,"context_line":"        mock_get_ns.side_effect \u003d Exception(\u0027foo\u0027)"},{"line_number":27508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_f0a4104d","line":27505,"range":{"start_line":27505,"start_character":33,"end_line":27505,"end_character":35},"in_reply_to":"1f621f24_e7f581cc","updated":"2020-11-17 10:15:19.000000000","message":"So is this: test_name__condition","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"99591244bd699d099c5bbf95216afcac7fc4614f","unresolved":false,"context_lines":[{"line_number":27502,"context_line":"                          drvr._discover_vpmems, vpmem_conf)"},{"line_number":27503,"context_line":""},{"line_number":27504,"context_line":"    @mock.patch(\u0027nova.privsep.libvirt.get_pmem_namespaces\u0027)"},{"line_number":27505,"context_line":"    def test___get_vpmems_on_host__exception(self, mock_get_ns):"},{"line_number":27506,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":27507,"context_line":"        mock_get_ns.side_effect \u003d Exception(\u0027foo\u0027)"},{"line_number":27508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_9b821dff","line":27505,"range":{"start_line":27505,"start_character":33,"end_line":27505,"end_character":35},"in_reply_to":"1f621f24_f0a4104d","updated":"2020-11-17 11:37:45.000000000","message":"But why 3 underscores? One for the test_ prefix. One from then name of the original function _get_vpmems_on_host. But why the 3rd?","commit_id":"7fedbf664ad28480d758b58d07b535b036d75ba4"}]}