)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a41c3a02793bc15f4eff00df723a861f924171d","unresolved":true,"context_lines":[{"line_number":18,"context_line":"and common part of 1. upgrade check 2. policy fallback logic is moved"},{"line_number":19,"context_line":"from nova to oslo.upgradechecks and oslo.policy respectively."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- oslo.upgradechecks(1.2.0): https://review.opendev.org/#/c/763484/"},{"line_number":22,"context_line":"- oslo.policy(3.6.0): https://review.opendev.org/#/c/763261/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This commit make use these code form oslo lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6cbb1421_cd14b804","line":21,"range":{"start_line":21,"start_character":23,"end_line":21,"end_character":24},"updated":"2020-12-15 12:26:57.000000000","message":"1.3.0 ?\n\n(based on lower-constraints anyway)","commit_id":"ccc3d7aa9077537e3aa08fa47f82bf5dc5504217"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cdb2bed4255460ffa57c3b0ea4a55cc9d1cc74a6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"and common part of 1. upgrade check 2. policy fallback logic is moved"},{"line_number":19,"context_line":"from nova to oslo.upgradechecks and oslo.policy respectively."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- oslo.upgradechecks(1.2.0): https://review.opendev.org/#/c/763484/"},{"line_number":22,"context_line":"- oslo.policy(3.6.0): https://review.opendev.org/#/c/763261/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This commit make use these code form oslo lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4b6fa73d_40cc4f68","line":21,"range":{"start_line":21,"start_character":23,"end_line":21,"end_character":24},"in_reply_to":"6cbb1421_cd14b804","updated":"2020-12-15 18:38:49.000000000","message":"Done","commit_id":"ccc3d7aa9077537e3aa08fa47f82bf5dc5504217"}],"lower-constraints.txt":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1c94bb6d4c533fd7c05cec1f9999abe992eef5e2","unresolved":true,"context_lines":[{"line_number":82,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":83,"context_line":"oslo.serialization\u003d\u003d2.21.1"},{"line_number":84,"context_line":"oslo.service\u003d\u003d1.40.1"},{"line_number":85,"context_line":"oslo.upgradecheck\u003d\u003d1.3.0"},{"line_number":86,"context_line":"oslo.utils\u003d\u003d4.7.0"},{"line_number":87,"context_line":"oslo.versionedobjects\u003d\u003d1.35.0"},{"line_number":88,"context_line":"oslo.vmware\u003d\u003d2.17.0"}],"source_content_type":"text/plain","patch_set":9,"id":"ca1be212_f76c3a73","line":85,"updated":"2021-01-15 20:36:39.000000000","message":"FWIW it appears the code you need [1] is included earlier in 1.2.0.\n\n[1] https://review.opendev.org/c/openstack/oslo.upgradecheck/+/763484","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"04b5e08545fa46198daa078b0e37a2ee5266a084","unresolved":true,"context_lines":[{"line_number":82,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":83,"context_line":"oslo.serialization\u003d\u003d2.21.1"},{"line_number":84,"context_line":"oslo.service\u003d\u003d1.40.1"},{"line_number":85,"context_line":"oslo.upgradecheck\u003d\u003d1.3.0"},{"line_number":86,"context_line":"oslo.utils\u003d\u003d4.7.0"},{"line_number":87,"context_line":"oslo.versionedobjects\u003d\u003d1.35.0"},{"line_number":88,"context_line":"oslo.vmware\u003d\u003d2.17.0"}],"source_content_type":"text/plain","patch_set":9,"id":"da476a3b_8c23e3a0","line":85,"in_reply_to":"515136cf_10965fc7","updated":"2021-01-15 20:42:45.000000000","message":"Got it, sounds good.","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"657f0faa02bbb54991f77978dec914ac759fe6f0","unresolved":true,"context_lines":[{"line_number":82,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":83,"context_line":"oslo.serialization\u003d\u003d2.21.1"},{"line_number":84,"context_line":"oslo.service\u003d\u003d1.40.1"},{"line_number":85,"context_line":"oslo.upgradecheck\u003d\u003d1.3.0"},{"line_number":86,"context_line":"oslo.utils\u003d\u003d4.7.0"},{"line_number":87,"context_line":"oslo.versionedobjects\u003d\u003d1.35.0"},{"line_number":88,"context_line":"oslo.vmware\u003d\u003d2.17.0"}],"source_content_type":"text/plain","patch_set":9,"id":"515136cf_10965fc7","line":85,"in_reply_to":"ca1be212_f76c3a73","updated":"2021-01-15 20:40:36.000000000","message":"I added the CLI opt registration in 1.3.0 for safer side- https://github.com/openstack/oslo.upgradecheck/blob/1.3.0/oslo_upgradecheck/common_checks.py#L29","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"}],"nova/cmd/status.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a41c3a02793bc15f4eff00df723a861f924171d","unresolved":true,"context_lines":[{"line_number":439,"context_line":"        # Added in Ussuri"},{"line_number":440,"context_line":"        (_(\u0027Policy Scope-based Defaults\u0027), _check_policy),"},{"line_number":441,"context_line":"        # Added in Victoria"},{"line_number":442,"context_line":"        (_(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":443,"context_line":"            (common_checks.check_policy_json, {\u0027conf\u0027: CONF})),"},{"line_number":444,"context_line":"        # Added in Wallaby"},{"line_number":445,"context_line":"        (_(\u0027Older than N-1 computes\u0027), _check_old_computes)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b339b972_900a6a57","line":442,"range":{"start_line":442,"start_character":9,"end_line":442,"end_character":49},"updated":"2020-12-15 12:26:57.000000000","message":"nit: Can you put this on its own line too?\n\n  (\n      _(\u0027Policy File JSON to YAML Migration\u0027),\n      (common_checks.check_policy_json, {\u0027conf\u0027: CONF}),\n  ),","commit_id":"ccc3d7aa9077537e3aa08fa47f82bf5dc5504217"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cdb2bed4255460ffa57c3b0ea4a55cc9d1cc74a6","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        # Added in Ussuri"},{"line_number":440,"context_line":"        (_(\u0027Policy Scope-based Defaults\u0027), _check_policy),"},{"line_number":441,"context_line":"        # Added in Victoria"},{"line_number":442,"context_line":"        (_(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":443,"context_line":"            (common_checks.check_policy_json, {\u0027conf\u0027: CONF})),"},{"line_number":444,"context_line":"        # Added in Wallaby"},{"line_number":445,"context_line":"        (_(\u0027Older than N-1 computes\u0027), _check_old_computes)"}],"source_content_type":"text/x-python","patch_set":6,"id":"142c34c3_6697278e","line":442,"range":{"start_line":442,"start_character":9,"end_line":442,"end_character":49},"in_reply_to":"b339b972_900a6a57","updated":"2020-12-15 18:38:49.000000000","message":"Done","commit_id":"ccc3d7aa9077537e3aa08fa47f82bf5dc5504217"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dec318efb1e2d97218b3c89f78b6ae27907c2baa","unresolved":true,"context_lines":[{"line_number":440,"context_line":"        # Added in Victoria"},{"line_number":441,"context_line":"        ("},{"line_number":442,"context_line":"            _(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":443,"context_line":"            (common_checks.check_policy_json, {\u0027conf\u0027: CONF})"},{"line_number":444,"context_line":"        ),"},{"line_number":445,"context_line":"        # Added in Wallaby"},{"line_number":446,"context_line":"        (_(\u0027Older than N-1 computes\u0027), _check_old_computes)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7cc879ab_06986f2f","line":443,"updated":"2021-01-15 19:59:12.000000000","message":"I\u0027m not sure what is calling this, but you\u0027ve replaced a function reference with a (function, dict) tuple. Is that supported? I would have expected to see a lambda or functools.partial here. If this is calling protocol for the things in here, then that\u0027s fine I guess, but I\u0027m not sure that it is.","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c64921b18286b7cf9b3964fea4ddf5cdbd97ef53","unresolved":true,"context_lines":[{"line_number":440,"context_line":"        # Added in Victoria"},{"line_number":441,"context_line":"        ("},{"line_number":442,"context_line":"            _(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":443,"context_line":"            (common_checks.check_policy_json, {\u0027conf\u0027: CONF})"},{"line_number":444,"context_line":"        ),"},{"line_number":445,"context_line":"        # Added in Wallaby"},{"line_number":446,"context_line":"        (_(\u0027Older than N-1 computes\u0027), _check_old_computes)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a76ec45_f518ab52","line":443,"in_reply_to":"7cc879ab_06986f2f","updated":"2021-01-15 20:10:27.000000000","message":"yeah, support for that is added in oslo.upgradecheck side. https://github.com/openstack/oslo.upgradecheck/blob/a962943bdaa746ad238f003f56556eb02d1ea8e8/oslo_upgradecheck/upgradecheck.py#L104","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"}],"nova/policy.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dec318efb1e2d97218b3c89f78b6ae27907c2baa","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    if not _ENFORCER:"},{"line_number":77,"context_line":"        _ENFORCER \u003d policy.Enforcer("},{"line_number":78,"context_line":"            CONF,"},{"line_number":79,"context_line":"            policy_file\u003dpolicy_file,"},{"line_number":80,"context_line":"            rules\u003drules,"},{"line_number":81,"context_line":"            default_rule\u003ddefault_rule,"},{"line_number":82,"context_line":"            use_conf\u003duse_conf)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c2f931b4_13bd75bd","line":79,"updated":"2021-01-15 19:59:12.000000000","message":"Are you asserting that whatever calls this has already used oslo\u0027s equivalent of pick_policy_file() ?","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c64921b18286b7cf9b3964fea4ddf5cdbd97ef53","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    if not _ENFORCER:"},{"line_number":77,"context_line":"        _ENFORCER \u003d policy.Enforcer("},{"line_number":78,"context_line":"            CONF,"},{"line_number":79,"context_line":"            policy_file\u003dpolicy_file,"},{"line_number":80,"context_line":"            rules\u003drules,"},{"line_number":81,"context_line":"            default_rule\u003ddefault_rule,"},{"line_number":82,"context_line":"            use_conf\u003duse_conf)"}],"source_content_type":"text/x-python","patch_set":9,"id":"23ab5152_f1279caa","line":79,"in_reply_to":"c2f931b4_13bd75bd","updated":"2021-01-15 20:10:27.000000000","message":"oslo policy is default to do pick_policy_file() and that version of oslo.policy is bumped with lower bound in requriement.txt\n\nTest case for that is covered in oslo policy side. you want to keep tests on nova side too, these tests ?\n- https://review.opendev.org/c/openstack/nova/+/763487/9/nova/tests/unit/test_policy.py","commit_id":"a72ace1c6c67ab1f5318a39638ba718c81307726"}]}