)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d013db8689ee24b9d8fcf79bd3f85683791cf4ce","unresolved":false,"context_lines":[{"line_number":15,"context_line":"os-brick patch: I56bf09cbd40679eefa5e378c9b36383de89e980c"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/ceph/ceph/pull/33750"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9ad90817648ca12f80a6b53f6ba728df15cbafab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_3be3f235","line":18,"updated":"2020-11-20 13:30:54.000000000","message":"you need to add a blueprint link at a minium\nnormally i would say a spec too since it hsould have tracked both the os-brick work and hyperv driver work but since the nova change is so small id dont think its required.\n\nthe -1 is for the lack of testing.\n\nwe need at least unit tests.\npreferably functional or tempest intergration tests.\n\nyou also need to add docs for how to configre this.","commit_id":"af921d610cb44da453ab16b2ee305ac181fb71e7"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c0c83091ca4659f44a7f329dd170fe9f825e1251","unresolved":false,"context_lines":[{"line_number":15,"context_line":"os-brick patch: I56bf09cbd40679eefa5e378c9b36383de89e980c"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/ceph/ceph/pull/33750"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9ad90817648ca12f80a6b53f6ba728df15cbafab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_db0e26e4","line":18,"in_reply_to":"fffc6b78_3be3f235","updated":"2020-11-20 13:40:19.000000000","message":"I\u0027ve just filed a Nova blueprint: https://blueprints.launchpad.net/nova/+spec/hyperv-rbd\n\nAbout tempest tests: we have a Hyper-V CI covering multiple Openstack projects. For Nova, we\u0027re currently using LVM volumes but we do have os-brick jobs for other storage backends (e.g. SMB or FC). We\u0027re going to add another os-brick job for RBD.\n\nAbout the docs: configuring Ceph is outside the scope of the Nova docs. Nova doesn\u0027t require any special configuration, as long as Ceph is installed and the host can access the volume provided by Cinder.","commit_id":"af921d610cb44da453ab16b2ee305ac181fb71e7"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c59d1232b473ceb55bc69acdfb094beeaae766ff","unresolved":false,"context_lines":[{"line_number":15,"context_line":"os-brick patch: I56bf09cbd40679eefa5e378c9b36383de89e980c"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/ceph/ceph/pull/33750"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9ad90817648ca12f80a6b53f6ba728df15cbafab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_bb3fe2d4","line":18,"in_reply_to":"fffc6b78_5b4876cb","updated":"2020-11-20 14:27:47.000000000","message":"About Hyper-V testing, I\u0027d say we have pretty good coverage. The Nova job uses 2 Hyper-V nodes, doing a full tempest run, which includes (live) migrations. The Nova job uses OVS (we do have another neutron agent) and iSCSI (lvm).\n\nOther storage backends are tested by the Cinder and os-brick Windows CIs. The idea is that we have limited hardware resources so we\u0027re trying to have a reasonable amount of jobs. If Nova breaks one of the storage backends, we\u0027ll catch it afterwards when the os-brick CI starts failing. \n\nAbout the docs, that\u0027s the nice part, nothing has to be configured on the Nova side. All we need is for deployers to be aware that this feature is available.","commit_id":"af921d610cb44da453ab16b2ee305ac181fb71e7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"923ba036a003c68de394460a4be2c0cce1885c29","unresolved":false,"context_lines":[{"line_number":15,"context_line":"os-brick patch: I56bf09cbd40679eefa5e378c9b36383de89e980c"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/ceph/ceph/pull/33750"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9ad90817648ca12f80a6b53f6ba728df15cbafab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fffc6b78_5b4876cb","line":18,"in_reply_to":"fffc6b78_db0e26e4","updated":"2020-11-20 14:07:53.000000000","message":"ideally we would trigger that os-brick rbd job on changes to the hyperv driver.\n\nwe have very minimal testing for hyperv today so it would be good to improve that if we can.\n\non the docs front so there are not nova.conf or ceph.conf file changes for configurin auth required with hyperv.\n\ni dont want you to documetn how to dpeloy and configure ceph jsut how to set any config values nova will need to know about.\n\nif there are none great if there are any values that need to be set on the compute node we should have docs for those.","commit_id":"af921d610cb44da453ab16b2ee305ac181fb71e7"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3990a35f258fcd1ba75bce477ffe7d286fd81667","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This patch updates the Hyper-V driver so that it may be able to"},{"line_number":13,"context_line":"consume RBD volumes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"os-brick patch: I56bf09cbd40679eefa5e378c9b36383de89e980c"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://github.com/ceph/ceph/pull/33750"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"29a3c6a8_29f4ccf5","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":57},"updated":"2021-02-02 09:27:39.000000000","message":"Shouldn\u0027t this Depends-On this change?\n\n    Depends-On: https://review.opendev.org/c/openstack/os-brick/+/718403","commit_id":"5987bcc3b761eab129ea96cc59249dc683da646d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"13b815c4cd4f9f11e8b2b251d3bea352507339cd","unresolved":true,"context_lines":[{"line_number":19,"context_line":"                  without it"},{"line_number":20,"context_line":"* all other requirement changes - syncing os-brick and Nova minimum"},{"line_number":21,"context_line":"                                  requirements"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Depends-On: I56bf09cbd40679eefa5e378c9b36383de89e980c"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1] https://github.com/ceph/ceph/pull/33750"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"4c783add_05c793d0","line":22,"updated":"2021-02-22 18:47:57.000000000","message":"you should not sync the miniums form os-brick.\nits an optional depency of nova.\n\nthe only change you need to make to lower constrats is\n\n\nubuntu@numa-1:/opt/repos/nova$ git diff\ndiff --git a/lower-constraints.txt b/lower-constraints.txt\nindex 6cbd355860..ea845da6c6 100644\n--- a/lower-constraints.txt\n+++ b/lower-constraints.txt\n@@ -11,7 +11,7 @@ cffi\u003d\u003d1.14.0\n cliff\u003d\u003d2.11.0\n cmd2\u003d\u003d0.8.1\n colorama\u003d\u003d0.3.9\n-coverage\u003d\u003d4.0\n+coverage\u003d\u003d5.2.1\n cryptography\u003d\u003d2.7\n cursive\u003d\u003d0.2.1\n dataclasses\u003d\u003d0.7\n@@ -58,13 +58,13 @@ netifaces\u003d\u003d0.10.4\n networkx\u003d\u003d2.1.0\n numpy\u003d\u003d1.19.0\n openstacksdk\u003d\u003d0.35.0\n-os-brick\u003d\u003d3.1.0\n+os-brick\u003d\u003d4.2.0\n os-client-config\u003d\u003d1.29.0\n os-resource-classes\u003d\u003d0.4.0\n os-service-types\u003d\u003d1.7.0\n os-traits\u003d\u003d2.4.0\n os-vif\u003d\u003d1.14.0\n-os-win\u003d\u003d4.2.0\n+os-win\u003d\u003d5.4.0\n os-xenapi\u003d\u003d0.3.4\n osc-lib\u003d\u003d1.10.0\n oslo.cache\u003d\u003d1.26.0","commit_id":"4a7e804d555b248e5f8e30171c1921c7893b2e5c"}],"lower-constraints.txt":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7e4c5f0838af7504c42705d75648662c27c19565","unresolved":true,"context_lines":[{"line_number":58,"context_line":"networkx\u003d\u003d2.1.0"},{"line_number":59,"context_line":"numpy\u003d\u003d1.19.0"},{"line_number":60,"context_line":"openstacksdk\u003d\u003d0.35.0"},{"line_number":61,"context_line":"os-brick\u003d\u003d4.2.0"},{"line_number":62,"context_line":"os-client-config\u003d\u003d1.29.0"},{"line_number":63,"context_line":"os-resource-classes\u003d\u003d0.4.0"},{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"}],"source_content_type":"text/plain","patch_set":9,"id":"c76792db_d5269e5b","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":15},"updated":"2021-02-16 16:22:22.000000000","message":"ACK thanks for following up with this!","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7e4c5f0838af7504c42705d75648662c27c19565","unresolved":true,"context_lines":[{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":65,"context_line":"os-traits\u003d\u003d2.4.0"},{"line_number":66,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":67,"context_line":"os-win\u003d\u003d5.4.0"},{"line_number":68,"context_line":"os-xenapi\u003d\u003d0.3.4"},{"line_number":69,"context_line":"osc-lib\u003d\u003d1.10.0"},{"line_number":70,"context_line":"oslo.cache\u003d\u003d1.26.0"}],"source_content_type":"text/plain","patch_set":9,"id":"bfab34c6_9a4625dc","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":13},"updated":"2021-02-16 16:22:22.000000000","message":"Can you call this out in the commit?","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ea8bcfd965acc1d758024940ce35d37343c80602","unresolved":true,"context_lines":[{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":65,"context_line":"os-traits\u003d\u003d2.4.0"},{"line_number":66,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":67,"context_line":"os-win\u003d\u003d5.4.0"},{"line_number":68,"context_line":"os-xenapi\u003d\u003d0.3.4"},{"line_number":69,"context_line":"osc-lib\u003d\u003d1.10.0"},{"line_number":70,"context_line":"oslo.cache\u003d\u003d1.26.0"}],"source_content_type":"text/plain","patch_set":9,"id":"ec971446_2afb970b","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":13},"in_reply_to":"6b537e5b_28bc7bec","updated":"2021-02-18 09:03:49.000000000","message":"Not if you could just reference the change in *this* commit message and say why this has had to change. Would that be okay?","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ade230f9bde4d0f0240f5839ba996f8071500aae","unresolved":true,"context_lines":[{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":65,"context_line":"os-traits\u003d\u003d2.4.0"},{"line_number":66,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":67,"context_line":"os-win\u003d\u003d5.4.0"},{"line_number":68,"context_line":"os-xenapi\u003d\u003d0.3.4"},{"line_number":69,"context_line":"osc-lib\u003d\u003d1.10.0"},{"line_number":70,"context_line":"oslo.cache\u003d\u003d1.26.0"}],"source_content_type":"text/plain","patch_set":9,"id":"6b537e5b_28bc7bec","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":13},"in_reply_to":"bfab34c6_9a4625dc","updated":"2021-02-17 07:32:22.000000000","message":"The os-win dependency should\u0027ve been bumped by this patch: https://review.opendev.org/c/openstack/nova/+/752723/2/nova/virt/hyperv/vmops.py\n\nThe Hyper-V driver won\u0027t be able to spawn instances using os-win\u003d\u003d4.2.0. Please let me know if this requires a separate patch.","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f27db97ba83ee59f26a42afe9febccf6a7fd3889","unresolved":true,"context_lines":[{"line_number":64,"context_line":"os-service-types\u003d\u003d1.7.0"},{"line_number":65,"context_line":"os-traits\u003d\u003d2.4.0"},{"line_number":66,"context_line":"os-vif\u003d\u003d1.14.0"},{"line_number":67,"context_line":"os-win\u003d\u003d5.4.0"},{"line_number":68,"context_line":"os-xenapi\u003d\u003d0.3.4"},{"line_number":69,"context_line":"osc-lib\u003d\u003d1.10.0"},{"line_number":70,"context_line":"oslo.cache\u003d\u003d1.26.0"}],"source_content_type":"text/plain","patch_set":9,"id":"76d78911_fc846839","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":13},"in_reply_to":"ec971446_2afb970b","updated":"2021-02-18 09:40:39.000000000","message":"Sure, I\u0027ll update the commit message right away. Thanks!","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0861ce7a6f2c7916bd26318b1300ff7b3c18e631","unresolved":true,"context_lines":[{"line_number":77,"context_line":"oslo.messaging\u003d\u003d10.3.0"},{"line_number":78,"context_line":"oslo.middleware\u003d\u003d3.31.0"},{"line_number":79,"context_line":"oslo.policy\u003d\u003d3.4.0"},{"line_number":80,"context_line":"oslo.privsep\u003d\u003d1.33.2"},{"line_number":81,"context_line":"oslo.reports\u003d\u003d1.18.0"},{"line_number":82,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":83,"context_line":"oslo.serialization\u003d\u003d2.21.1"}],"source_content_type":"text/plain","patch_set":9,"id":"6d74d912_5f7825ce","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":20},"updated":"2021-02-18 09:41:16.000000000","message":"This also needs to be bumped to 2.4.0 FWIW as shown the lower-constraints job failures:\n\nThe conflict is caused by:\n    The user requested oslo.privsep\u003e\u003d1.33.2\n    os-brick 4.2.0 depends on oslo.privsep\u003e\u003d2.4.0\n\nhttps://zuul.opendev.org/t/openstack/build/be8f9096b21a4e7bb9dd8fed0a32576a","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a7a71794f429469b76d3c15384f941c5f64d2e2a","unresolved":true,"context_lines":[{"line_number":77,"context_line":"oslo.messaging\u003d\u003d10.3.0"},{"line_number":78,"context_line":"oslo.middleware\u003d\u003d3.31.0"},{"line_number":79,"context_line":"oslo.policy\u003d\u003d3.4.0"},{"line_number":80,"context_line":"oslo.privsep\u003d\u003d1.33.2"},{"line_number":81,"context_line":"oslo.reports\u003d\u003d1.18.0"},{"line_number":82,"context_line":"oslo.rootwrap\u003d\u003d5.8.0"},{"line_number":83,"context_line":"oslo.serialization\u003d\u003d2.21.1"}],"source_content_type":"text/plain","patch_set":9,"id":"793ca517_fce233c8","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":20},"in_reply_to":"6d74d912_5f7825ce","updated":"2021-02-18 09:42:50.000000000","message":"Awesome, thanks for pointing it out!","commit_id":"7af19ce462eaafd5f5ab860bd35fa91431ec830b"}],"nova/tests/unit/virt/hyperv/test_volumeops.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29c12164776417dea0c30a39c510c666d4d90112","unresolved":true,"context_lines":[{"line_number":620,"context_line":"        # has the right fields."},{"line_number":621,"context_line":"        self.assertTrue(drv._is_block_dev)"},{"line_number":622,"context_line":"        self.assertEqual(\u0027rbd\u0027, drv._protocol)"},{"line_number":623,"context_line":"        self.assertEqual(dict(do_local_attach\u003dTrue),"},{"line_number":624,"context_line":"                         drv._extra_connector_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1809903c_3e9784ed","line":623,"range":{"start_line":623,"start_character":30,"end_line":623,"end_character":50},"updated":"2020-11-26 16:46:27.000000000","message":"this is the main point to check as right. since local attach is the only mode supported when using hyperv","commit_id":"d77ad440444ff0a235698a1f99b297dcc3d34360"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c087963ed758cb8ba31698a34e6f636c0fcca636","unresolved":true,"context_lines":[{"line_number":620,"context_line":"        # has the right fields."},{"line_number":621,"context_line":"        self.assertTrue(drv._is_block_dev)"},{"line_number":622,"context_line":"        self.assertEqual(\u0027rbd\u0027, drv._protocol)"},{"line_number":623,"context_line":"        self.assertEqual(dict(do_local_attach\u003dTrue),"},{"line_number":624,"context_line":"                         drv._extra_connector_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"33a95f89_8a0c603f","line":623,"range":{"start_line":623,"start_character":30,"end_line":623,"end_character":50},"in_reply_to":"1809903c_3e9784ed","updated":"2020-11-26 16:52:47.000000000","message":"Indeed, it\u0027s probably worth adding an inline comment emphasizing that.","commit_id":"d77ad440444ff0a235698a1f99b297dcc3d34360"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"856316a667c8c6f1df75ebb4bdb02dd94ca52e37","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        # has the right fields."},{"line_number":621,"context_line":"        self.assertTrue(drv._is_block_dev)"},{"line_number":622,"context_line":"        self.assertEqual(\u0027rbd\u0027, drv._protocol)"},{"line_number":623,"context_line":"        self.assertEqual(dict(do_local_attach\u003dTrue),"},{"line_number":624,"context_line":"                         drv._extra_connector_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2104e880_0fb917bd","line":623,"range":{"start_line":623,"start_character":30,"end_line":623,"end_character":50},"in_reply_to":"33a95f89_8a0c603f","updated":"2020-12-03 10:25:28.000000000","message":"Done","commit_id":"d77ad440444ff0a235698a1f99b297dcc3d34360"}],"releasenotes/notes/rbd-hyperv-support-672a34b1d87e68eb.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d013db8689ee24b9d8fcf79bd3f85683791cf4ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The Hyper-V driver can now attach Cinder RBD volumes."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fffc6b78_fb932aa2","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":57},"updated":"2020-11-20 13:30:54.000000000","message":"that a pretty big and cool feature but it would be nice to have more context and detail the reuiqred version ectra","commit_id":"af921d610cb44da453ab16b2ee305ac181fb71e7"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c0c83091ca4659f44a7f329dd170fe9f825e1251","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The Hyper-V driver can now attach Cinder RBD volumes."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fffc6b78_bb2c0248","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":57},"in_reply_to":"fffc6b78_fb932aa2","updated":"2020-11-20 13:40:19.000000000","message":"makes sense","commit_id":"af921d610cb44da453ab16b2ee305ac181fb71e7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29c12164776417dea0c30a39c510c666d4d90112","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The Hyper-V driver can now attach Cinder RBD volumes. The minimum"},{"line_number":4,"context_line":"    required Ceph version is Ceph 16 (Pacific)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f31fc10f_467f111a","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":46},"updated":"2020-11-26 16:46:27.000000000","message":"thanks for adding the min ceph verions. if there is a min hyperv version this would be\nnice to add too but otherwise im ok with this.","commit_id":"d77ad440444ff0a235698a1f99b297dcc3d34360"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"856316a667c8c6f1df75ebb4bdb02dd94ca52e37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The Hyper-V driver can now attach Cinder RBD volumes. The minimum"},{"line_number":4,"context_line":"    required Ceph version is Ceph 16 (Pacific)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"938bc380_f90851fc","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":46},"in_reply_to":"9c65eb83_29c407e0","updated":"2020-12-03 10:25:28.000000000","message":"Done","commit_id":"d77ad440444ff0a235698a1f99b297dcc3d34360"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c087963ed758cb8ba31698a34e6f636c0fcca636","unresolved":true,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    The Hyper-V driver can now attach Cinder RBD volumes. The minimum"},{"line_number":4,"context_line":"    required Ceph version is Ceph 16 (Pacific)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9c65eb83_29c407e0","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":46},"in_reply_to":"f31fc10f_467f111a","updated":"2020-11-26 16:52:47.000000000","message":"Good point. We officially support Windows Server 2016 and onwards, that\u0027s definitely worth mentioning here.","commit_id":"d77ad440444ff0a235698a1f99b297dcc3d34360"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21453735af258bb8e767567d4cefc5be50d474a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d87c0d6d_5cd68c6e","line":5,"updated":"2021-02-24 19:43:34.000000000","message":"nit: you could mention the os-brick min version here","commit_id":"2062a3cadcfc654fd608a0322c343a912732dcd5"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"2ccf8d2faa7e9b58665004c9d6c717d6082d09ef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"002769e6_be7b3075","line":5,"in_reply_to":"d87c0d6d_5cd68c6e","updated":"2021-02-25 07:04:26.000000000","message":"Right, although I\u0027m quite sure that we\u0027ll bump the os-brick requirement before releasing Wallaby. There are a few new Cinder drivers that also need it.\n\nI\u0027ll mention it if I end up sending another patch.","commit_id":"2062a3cadcfc654fd608a0322c343a912732dcd5"}]}