)]}'
{"nova/tests/unit/api/openstack/compute/test_hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0bf3b5449d3157bd4ec5588d54f76753c575fa71","unresolved":true,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_detail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.DETAIL_HYPERS_DICTS[0])"},{"line_number":268,"context_line":"        expected_dict[\u0027state\u0027] \u003d \u0027down\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        req \u003d self._get_request(True)"},{"line_number":271,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":272,"context_line":"            self.TEST_HYPERS_OBJ[0], self.TEST_SERVICES[0], True, req)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        self.assertEqual(expected_dict, result)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def test_view_hypervisor_detail_service_disabled(self):"},{"line_number":277,"context_line":"        service \u003d copy.deepcopy(TEST_SERVICES[0])"},{"line_number":278,"context_line":"        service.disabled \u003d True"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        req \u003d self._get_request(True)"},{"line_number":281,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":282,"context_line":"            self.TEST_HYPERS_OBJ[0], service, True, req)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.assertEqual(\u0027disabled\u0027, result[\u0027status\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_view_hypervisor_servers(self):"},{"line_number":287,"context_line":"        req \u003d self._get_request(True)"},{"line_number":288,"context_line":"        result \u003d self.controller._view_hypervisor(self.TEST_HYPERS_OBJ[0],"}],"source_content_type":"text/x-python","patch_set":1,"id":"f63d9164_0fa7b87a","line":285,"range":{"start_line":264,"start_character":0,"end_line":285,"end_character":0},"updated":"2020-12-03 19:30:51.000000000","message":"how about adding for list hypervisor as old tests covered both list and detail API","commit_id":"c07a7f3369663e74f60c41aad1d8a67015e0566a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8cd1dab3502e04d4f29c814032b455faee5a8165","unresolved":true,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_detail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.DETAIL_HYPERS_DICTS[0])"},{"line_number":268,"context_line":"        expected_dict[\u0027state\u0027] \u003d \u0027down\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        req \u003d self._get_request(True)"},{"line_number":271,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":272,"context_line":"            self.TEST_HYPERS_OBJ[0], self.TEST_SERVICES[0], True, req)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        self.assertEqual(expected_dict, result)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def test_view_hypervisor_detail_service_disabled(self):"},{"line_number":277,"context_line":"        service \u003d copy.deepcopy(TEST_SERVICES[0])"},{"line_number":278,"context_line":"        service.disabled \u003d True"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        req \u003d self._get_request(True)"},{"line_number":281,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":282,"context_line":"            self.TEST_HYPERS_OBJ[0], service, True, req)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.assertEqual(\u0027disabled\u0027, result[\u0027status\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_view_hypervisor_servers(self):"},{"line_number":287,"context_line":"        req \u003d self._get_request(True)"},{"line_number":288,"context_line":"        result \u003d self.controller._view_hypervisor(self.TEST_HYPERS_OBJ[0],"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2b77608_7b7bd79f","line":285,"range":{"start_line":264,"start_character":0,"end_line":285,"end_character":0},"in_reply_to":"a3bfd209_872bb239","updated":"2020-12-07 20:13:18.000000000","message":"detail\u003dTrue is covered with service down and disable but did not see where we are covering as you are passing only True for detail in _view_hypervisor call.\n\ndetail \u003d False and a service is down\ndetail \u003d False and a service is disabled","commit_id":"c07a7f3369663e74f60c41aad1d8a67015e0566a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5e092a321a2d93c39ae25d72d462275c11608bdc","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_detail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.DETAIL_HYPERS_DICTS[0])"},{"line_number":268,"context_line":"        expected_dict[\u0027state\u0027] \u003d \u0027down\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        req \u003d self._get_request(True)"},{"line_number":271,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":272,"context_line":"            self.TEST_HYPERS_OBJ[0], self.TEST_SERVICES[0], True, req)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        self.assertEqual(expected_dict, result)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def test_view_hypervisor_detail_service_disabled(self):"},{"line_number":277,"context_line":"        service \u003d copy.deepcopy(TEST_SERVICES[0])"},{"line_number":278,"context_line":"        service.disabled \u003d True"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        req \u003d self._get_request(True)"},{"line_number":281,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":282,"context_line":"            self.TEST_HYPERS_OBJ[0], service, True, req)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.assertEqual(\u0027disabled\u0027, result[\u0027status\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_view_hypervisor_servers(self):"},{"line_number":287,"context_line":"        req \u003d self._get_request(True)"},{"line_number":288,"context_line":"        result \u003d self.controller._view_hypervisor(self.TEST_HYPERS_OBJ[0],"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf0c920a_a902d329","line":285,"range":{"start_line":264,"start_character":0,"end_line":285,"end_character":0},"in_reply_to":"c2b77608_7b7bd79f","updated":"2020-12-15 17:31:31.000000000","message":"Right. I figured they didn\u0027t matter because we didn\u0027t include the service information in the non-detailed response. However, the \u0027status\u0027 field if built on this. Added.","commit_id":"c07a7f3369663e74f60c41aad1d8a67015e0566a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f4e51076723d15b1e21f8d2f75e24bcabd95d8ff","unresolved":true,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_detail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.DETAIL_HYPERS_DICTS[0])"},{"line_number":268,"context_line":"        expected_dict[\u0027state\u0027] \u003d \u0027down\u0027"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        req \u003d self._get_request(True)"},{"line_number":271,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":272,"context_line":"            self.TEST_HYPERS_OBJ[0], self.TEST_SERVICES[0], True, req)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        self.assertEqual(expected_dict, result)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def test_view_hypervisor_detail_service_disabled(self):"},{"line_number":277,"context_line":"        service \u003d copy.deepcopy(TEST_SERVICES[0])"},{"line_number":278,"context_line":"        service.disabled \u003d True"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        req \u003d self._get_request(True)"},{"line_number":281,"context_line":"        result \u003d self.controller._view_hypervisor("},{"line_number":282,"context_line":"            self.TEST_HYPERS_OBJ[0], service, True, req)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.assertEqual(\u0027disabled\u0027, result[\u0027status\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_view_hypervisor_servers(self):"},{"line_number":287,"context_line":"        req \u003d self._get_request(True)"},{"line_number":288,"context_line":"        result \u003d self.controller._view_hypervisor(self.TEST_HYPERS_OBJ[0],"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3bfd209_872bb239","line":285,"range":{"start_line":264,"start_character":0,"end_line":285,"end_character":0},"in_reply_to":"f63d9164_0fa7b87a","updated":"2020-12-07 10:17:06.000000000","message":"I don\u0027t think they did. \u0027test_view_hypervisor_service_status\u0027 and \u0027test_view_hypervisor_detail_status\u0027 tested \u0027_view_hypervisor\u0027 under three conditions:\n\n- detail \u003d False/True\n- detail \u003d False/True and a service is down\n- detail \u003d False/True and a service is disabled\n\nWe already have the first conditions in \u0027test_view_hypervisor_nodetail_noservers\u0027 and \u0027test_view_hypervisor_detail_noservers\u0027 respectively. We\u0027re covering the other two here.","commit_id":"c07a7f3369663e74f60c41aad1d8a67015e0566a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"490534d372caadc46ac9d9d547031e502dc511f1","unresolved":true,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_nodetail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.INDEX_HYPER_DICTS[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"79ba9336_3c63a947","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":37},"updated":"2020-12-16 19:01:38.000000000","message":"at first glance, I read it like *node* *tail* :)","commit_id":"00ad3bb1f1ed9ca666dac909baaa3aa97a0e1865"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"aa751942fa7c249bacb45ec1108e12c28761ba84","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_nodetail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.INDEX_HYPER_DICTS[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b3de507_35f43465","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":37},"in_reply_to":"0e13facf_8f2ccf9a","updated":"2021-01-04 10:35:32.000000000","message":"https://www.penisland.net/\n\n(sorry not sorry)","commit_id":"00ad3bb1f1ed9ca666dac909baaa3aa97a0e1865"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7aabc5b7d17177abe07b028635e990e29cd9604e","unresolved":true,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.assertEqual(self.DETAIL_HYPERS_DICTS[0], result)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_view_hypervisor_nodetail_service_down(self):"},{"line_number":265,"context_line":"        self.controller.servicegroup_api.service_is_up.return_value \u003d False"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        expected_dict \u003d copy.deepcopy(self.INDEX_HYPER_DICTS[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"0e13facf_8f2ccf9a","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":37},"in_reply_to":"79ba9336_3c63a947","updated":"2021-01-04 10:09:50.000000000","message":"lol same here :D","commit_id":"00ad3bb1f1ed9ca666dac909baaa3aa97a0e1865"}]}