)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"21c970bee125c6bd272579eeb47578674c96078a","unresolved":true,"context_lines":[{"line_number":31,"context_line":"A small tweak to \u0027tox.ini\u0027 that allows us to share some venvs is"},{"line_number":32,"context_line":"included."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Part of blueprint deprecate-os-hypervisors"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I515e484ade6c6455f82a3067940a418a0d7d965a"},{"line_number":37,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"756f22f6_54e9ba8a","line":34,"updated":"2021-01-04 11:50:44.000000000","message":"The proper name of the bp is modernize-os-hypervisors-api","commit_id":"e4394b01a31095254c0e7bb7b337041eb70e1b0c"}],"api-ref/source/os-hypervisors.inc":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"323fe802994871349ced75da56a09f4d258e77ed","unresolved":true,"context_lines":[{"line_number":291,"context_line":".. warning::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    This API is deprecated and will fail with HTTP 404 starting with microversion"},{"line_number":294,"context_line":"    2.88. Use placement to get information on resource usage across hypervisors."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":297,"context_line":"this operation. Cloud providers can change these permissions through"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"c2c8b0fd_14b4bdae","line":294,"range":{"start_line":294,"start_character":10,"end_line":294,"end_character":80},"updated":"2021-01-06 12:00:09.000000000","message":"in this specific case it is not placement but the still existing os-hypervisors calls are the ones that can be use to obtain the same information","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b0dd5167583c2b8cffbdb0ebbb9d8642ebb8a5d","unresolved":false,"context_lines":[{"line_number":291,"context_line":".. warning::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    This API is deprecated and will fail with HTTP 404 starting with microversion"},{"line_number":294,"context_line":"    2.88. Use placement to get information on resource usage across hypervisors."},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":297,"context_line":"this operation. Cloud providers can change these permissions through"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"389c7907_db594132","line":294,"range":{"start_line":294,"start_character":10,"end_line":294,"end_character":80},"in_reply_to":"c2c8b0fd_14b4bdae","updated":"2021-01-06 12:07:30.000000000","message":"Done","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e86c6c8dfe0c0ace6d4d3e35dd8bfe33e994595a","unresolved":true,"context_lines":[{"line_number":291,"context_line":".. warning::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    This API is deprecated and will fail with HTTP 404 starting with"},{"line_number":294,"context_line":"    microversion 2.88. Use `Show Hypervisor Details`_ with microversion 2.53"},{"line_number":295,"context_line":"    and later to get this infromation."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Policy defaults enable only users with the administrative role to perform"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"f331df17_027edbb8","line":294,"range":{"start_line":294,"start_character":72,"end_line":294,"end_character":76},"updated":"2021-01-06 12:12:21.000000000","message":"I think the user need to use 2.88 to get the uptime from that API","commit_id":"f0ae1250f0d5cde2bb8502177719d539c5c4fbb6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6aa1c6d8184b1c85d71d0914bd7f6f821b94bf96","unresolved":false,"context_lines":[{"line_number":291,"context_line":".. warning::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    This API is deprecated and will fail with HTTP 404 starting with"},{"line_number":294,"context_line":"    microversion 2.88. Use `Show Hypervisor Details`_ with microversion 2.53"},{"line_number":295,"context_line":"    and later to get this infromation."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Policy defaults enable only users with the administrative role to perform"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"6942b359_6cfe4f5c","line":294,"range":{"start_line":294,"start_character":72,"end_line":294,"end_character":76},"in_reply_to":"f331df17_027edbb8","updated":"2021-01-06 14:13:56.000000000","message":"Whoops, copy-paste mistake. Done.","commit_id":"f0ae1250f0d5cde2bb8502177719d539c5c4fbb6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e86c6c8dfe0c0ace6d4d3e35dd8bfe33e994595a","unresolved":true,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    This API is deprecated and will fail with HTTP 404 starting with"},{"line_number":294,"context_line":"    microversion 2.88. Use `Show Hypervisor Details`_ with microversion 2.53"},{"line_number":295,"context_line":"    and later to get this infromation."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":298,"context_line":"this operation. Cloud providers can change these permissions through"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"1dff8dd0_979d4a25","line":295,"range":{"start_line":295,"start_character":26,"end_line":295,"end_character":37},"updated":"2021-01-06 12:12:21.000000000","message":"nit:information","commit_id":"f0ae1250f0d5cde2bb8502177719d539c5c4fbb6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6aa1c6d8184b1c85d71d0914bd7f6f821b94bf96","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    This API is deprecated and will fail with HTTP 404 starting with"},{"line_number":294,"context_line":"    microversion 2.88. Use `Show Hypervisor Details`_ with microversion 2.53"},{"line_number":295,"context_line":"    and later to get this infromation."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":298,"context_line":"this operation. Cloud providers can change these permissions through"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"e34a4c9c_e5da1e04","line":295,"range":{"start_line":295,"start_character":26,"end_line":295,"end_character":37},"in_reply_to":"1dff8dd0_979d4a25","updated":"2021-01-06 14:13:56.000000000","message":"Done","commit_id":"f0ae1250f0d5cde2bb8502177719d539c5c4fbb6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":142,"context_line":".. literalinclude:: ../../doc/api_samples/os-hypervisors/v2.88/hypervisors-detail-resp.json"},{"line_number":143,"context_line":"   :language: javascript"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Show Hypervisor Statistics"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rest_method:: GET /os-hypervisors/statistics"},{"line_number":149,"context_line":"   max_version: 2.87"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Shows summary statistics for all enabled hypervisors over all compute nodes."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. warning::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"   This API is deprecated and will fail with HTTP 404 starting with microversion"},{"line_number":156,"context_line":"   2.88. Use placement to get information on resource usage across hypervisors."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":159,"context_line":"this operation. Cloud providers can change these permissions through"},{"line_number":160,"context_line":"the ``policy.json`` file."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. note::"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   As noted, some of the parameters in the response representing totals do not"},{"line_number":165,"context_line":"   take allocation ratios into account. This can result in a disparity between"},{"line_number":166,"context_line":"   the totals and the usages. A more accurate representation of state can be"},{"line_number":167,"context_line":"   obtained using `placement`__."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"   __ https://docs.openstack.org/api-ref/placement/#list-resource-provider-usages"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Normal response codes: 200"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Error response codes: unauthorized(401), forbidden(403), itemNotFound(404)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Response"},{"line_number":176,"context_line":"--------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  - hypervisor_statistics: hypervisor_statistics"},{"line_number":181,"context_line":"  - count: hypervisor_count"},{"line_number":182,"context_line":"  - current_workload: current_workload"},{"line_number":183,"context_line":"  - disk_available_least: disk_available_least_total"},{"line_number":184,"context_line":"  - free_disk_gb: hypervisor_free_disk_gb_total"},{"line_number":185,"context_line":"  - free_ram_mb: free_ram_mb_total"},{"line_number":186,"context_line":"  - local_gb: local_gb_total"},{"line_number":187,"context_line":"  - local_gb_used: local_gb_used_total"},{"line_number":188,"context_line":"  - memory_mb: memory_mb_total"},{"line_number":189,"context_line":"  - memory_mb_used: memory_mb_used_total"},{"line_number":190,"context_line":"  - running_vms: running_vms_total"},{"line_number":191,"context_line":"  - vcpus: hypervisor_vcpus_total"},{"line_number":192,"context_line":"  - vcpus_used: hypervisor_vcpus_used_total"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"**Example Show Hypervisor Statistics: JSON response**"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"18edc505_145f650f","line":192,"range":{"start_line":145,"start_character":0,"end_line":192,"end_character":43},"updated":"2021-01-06 21:43:39.000000000","message":"let\u0027s move these deprecated APIs in separate deprecated-os-hypervisors.inc file so that we can add them in api-ref \u0027Deprecated APIs\u0027 section\nhttps://docs.openstack.org/api-ref/compute/#deprecated-apis","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":142,"context_line":".. literalinclude:: ../../doc/api_samples/os-hypervisors/v2.88/hypervisors-detail-resp.json"},{"line_number":143,"context_line":"   :language: javascript"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Show Hypervisor Statistics"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rest_method:: GET /os-hypervisors/statistics"},{"line_number":149,"context_line":"   max_version: 2.87"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Shows summary statistics for all enabled hypervisors over all compute nodes."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. warning::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"   This API is deprecated and will fail with HTTP 404 starting with microversion"},{"line_number":156,"context_line":"   2.88. Use placement to get information on resource usage across hypervisors."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":159,"context_line":"this operation. Cloud providers can change these permissions through"},{"line_number":160,"context_line":"the ``policy.json`` file."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. note::"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   As noted, some of the parameters in the response representing totals do not"},{"line_number":165,"context_line":"   take allocation ratios into account. This can result in a disparity between"},{"line_number":166,"context_line":"   the totals and the usages. A more accurate representation of state can be"},{"line_number":167,"context_line":"   obtained using `placement`__."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"   __ https://docs.openstack.org/api-ref/placement/#list-resource-provider-usages"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Normal response codes: 200"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Error response codes: unauthorized(401), forbidden(403), itemNotFound(404)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Response"},{"line_number":176,"context_line":"--------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  - hypervisor_statistics: hypervisor_statistics"},{"line_number":181,"context_line":"  - count: hypervisor_count"},{"line_number":182,"context_line":"  - current_workload: current_workload"},{"line_number":183,"context_line":"  - disk_available_least: disk_available_least_total"},{"line_number":184,"context_line":"  - free_disk_gb: hypervisor_free_disk_gb_total"},{"line_number":185,"context_line":"  - free_ram_mb: free_ram_mb_total"},{"line_number":186,"context_line":"  - local_gb: local_gb_total"},{"line_number":187,"context_line":"  - local_gb_used: local_gb_used_total"},{"line_number":188,"context_line":"  - memory_mb: memory_mb_total"},{"line_number":189,"context_line":"  - memory_mb_used: memory_mb_used_total"},{"line_number":190,"context_line":"  - running_vms: running_vms_total"},{"line_number":191,"context_line":"  - vcpus: hypervisor_vcpus_total"},{"line_number":192,"context_line":"  - vcpus_used: hypervisor_vcpus_used_total"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"**Example Show Hypervisor Statistics: JSON response**"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"aa421dd9_ec0fb94c","line":192,"range":{"start_line":145,"start_character":0,"end_line":192,"end_character":43},"in_reply_to":"18edc505_145f650f","updated":"2021-01-07 17:36:17.000000000","message":"I didn\u0027t move them because then we\u0027d end up with \u0027os-hypervisors\u0027 listed under the list of \u0027Deprecated APIs\u0027 section, which I think would be confusing. Instead, I added \u0027DEPRECATED\u0027 to the title. This is what we\u0027ve done in the past where we\u0027ve deprecated part of an API, e.g. the \u0027resetNetwork\u0027 action of the server actions API [1].\n\n[1] https://docs.openstack.org/api-ref/compute/?expanded\u003d#reset-networking-on-a-server-resetnetwork-action-deprecated","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01c15692b98d7e65b7554636b8ed999df041f11a","unresolved":false,"context_lines":[{"line_number":142,"context_line":".. literalinclude:: ../../doc/api_samples/os-hypervisors/v2.88/hypervisors-detail-resp.json"},{"line_number":143,"context_line":"   :language: javascript"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Show Hypervisor Statistics"},{"line_number":146,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":".. rest_method:: GET /os-hypervisors/statistics"},{"line_number":149,"context_line":"   max_version: 2.87"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Shows summary statistics for all enabled hypervisors over all compute nodes."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. warning::"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"   This API is deprecated and will fail with HTTP 404 starting with microversion"},{"line_number":156,"context_line":"   2.88. Use placement to get information on resource usage across hypervisors."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"Policy defaults enable only users with the administrative role to perform"},{"line_number":159,"context_line":"this operation. Cloud providers can change these permissions through"},{"line_number":160,"context_line":"the ``policy.json`` file."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. note::"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   As noted, some of the parameters in the response representing totals do not"},{"line_number":165,"context_line":"   take allocation ratios into account. This can result in a disparity between"},{"line_number":166,"context_line":"   the totals and the usages. A more accurate representation of state can be"},{"line_number":167,"context_line":"   obtained using `placement`__."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"   __ https://docs.openstack.org/api-ref/placement/#list-resource-provider-usages"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Normal response codes: 200"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Error response codes: unauthorized(401), forbidden(403), itemNotFound(404)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Response"},{"line_number":176,"context_line":"--------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  - hypervisor_statistics: hypervisor_statistics"},{"line_number":181,"context_line":"  - count: hypervisor_count"},{"line_number":182,"context_line":"  - current_workload: current_workload"},{"line_number":183,"context_line":"  - disk_available_least: disk_available_least_total"},{"line_number":184,"context_line":"  - free_disk_gb: hypervisor_free_disk_gb_total"},{"line_number":185,"context_line":"  - free_ram_mb: free_ram_mb_total"},{"line_number":186,"context_line":"  - local_gb: local_gb_total"},{"line_number":187,"context_line":"  - local_gb_used: local_gb_used_total"},{"line_number":188,"context_line":"  - memory_mb: memory_mb_total"},{"line_number":189,"context_line":"  - memory_mb_used: memory_mb_used_total"},{"line_number":190,"context_line":"  - running_vms: running_vms_total"},{"line_number":191,"context_line":"  - vcpus: hypervisor_vcpus_total"},{"line_number":192,"context_line":"  - vcpus_used: hypervisor_vcpus_used_total"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"**Example Show Hypervisor Statistics: JSON response**"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"150e86bd_96ae3691","line":192,"range":{"start_line":145,"start_character":0,"end_line":192,"end_character":43},"in_reply_to":"aa421dd9_ec0fb94c","updated":"2021-01-07 22:34:54.000000000","message":"ok, that works fine for me even better.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":280,"context_line":".. literalinclude:: ../../doc/api_samples/os-hypervisors/v2.88/hypervisors-show-with-servers-resp.json"},{"line_number":281,"context_line":"   :language: javascript"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Show Hypervisor Uptime"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":".. rest_method:: GET /os-hypervisors/{hypervisor_id}/uptime"},{"line_number":287,"context_line":"   max_version: 2.87"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"6404deba_a2d92e2d","line":285,"range":{"start_line":283,"start_character":0,"end_line":285,"end_character":0},"updated":"2021-01-06 21:43:39.000000000","message":"ditto","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":280,"context_line":".. literalinclude:: ../../doc/api_samples/os-hypervisors/v2.88/hypervisors-show-with-servers-resp.json"},{"line_number":281,"context_line":"   :language: javascript"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"Show Hypervisor Uptime"},{"line_number":284,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":".. rest_method:: GET /os-hypervisors/{hypervisor_id}/uptime"},{"line_number":287,"context_line":"   max_version: 2.87"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"62c0639e_a635e936","line":285,"range":{"start_line":283,"start_character":0,"end_line":285,"end_character":0},"in_reply_to":"6404deba_a2d92e2d","updated":"2021-01-07 17:36:17.000000000","message":"As above.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":2288,"context_line":"  in: body"},{"line_number":2289,"context_line":"  required: true"},{"line_number":2290,"context_line":"  type: integer"},{"line_number":2291,"context_line":"  max_version: 2.87"},{"line_number":2292,"context_line":"data:"},{"line_number":2293,"context_line":"  description: |"},{"line_number":2294,"context_line":"    The certificate."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3ef30d80_f8f27c88","line":2291,"updated":"2021-01-07 17:36:17.000000000","message":"Based on gmann\u0027s comments below, I\u0027ve created a new \u0027current_workload_total\u0027 parameter to be used for the \u0027os-hypervisors/statistics\u0027 docs since we don\u0027t want deprecation warnings on that.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":2508,"context_line":"  required: true"},{"line_number":2509,"context_line":"  type: integer"},{"line_number":2510,"context_line":"  max_version: 2.87"},{"line_number":2511,"context_line":"disk_available_least_total:"},{"line_number":2512,"context_line":"  description: |"},{"line_number":2513,"context_line":"    The actual free disk on all hypervisors(in GiB). If allocation ratios used"},{"line_number":2514,"context_line":"    for overcommit are configured, this may be negative. This is intentional as"},{"line_number":2515,"context_line":"    it provides insight into the amount by which the disk is overcommitted."},{"line_number":2516,"context_line":"  in: body"},{"line_number":2517,"context_line":"  required: true"},{"line_number":2518,"context_line":"  type: integer"},{"line_number":2519,"context_line":"  max_version: 2.87"},{"line_number":2520,"context_line":"disk_bus:"},{"line_number":2521,"context_line":"  description: |"},{"line_number":2522,"context_line":"    Disk bus type, some hypervisors (currently only libvirt) support"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"21791b9c_3e7cc8f2","line":2519,"range":{"start_line":2511,"start_character":0,"end_line":2519,"end_character":19},"updated":"2021-01-06 21:43:39.000000000","message":"these fields with *_total are for /os-hypervisors/statistics API for which we are already adding top level warning for deprecation. We can leave their specific field to mark as max microversion. This way it will be consistent with other deprecated APIs (/os-hypervisors/uptime or old one)\n- https://docs.openstack.org/api-ref/compute/#deprecated-apis\n\nsame for all below *_total fields","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":2508,"context_line":"  required: true"},{"line_number":2509,"context_line":"  type: integer"},{"line_number":2510,"context_line":"  max_version: 2.87"},{"line_number":2511,"context_line":"disk_available_least_total:"},{"line_number":2512,"context_line":"  description: |"},{"line_number":2513,"context_line":"    The actual free disk on all hypervisors(in GiB). If allocation ratios used"},{"line_number":2514,"context_line":"    for overcommit are configured, this may be negative. This is intentional as"},{"line_number":2515,"context_line":"    it provides insight into the amount by which the disk is overcommitted."},{"line_number":2516,"context_line":"  in: body"},{"line_number":2517,"context_line":"  required: true"},{"line_number":2518,"context_line":"  type: integer"},{"line_number":2519,"context_line":"  max_version: 2.87"},{"line_number":2520,"context_line":"disk_bus:"},{"line_number":2521,"context_line":"  description: |"},{"line_number":2522,"context_line":"    Disk bus type, some hypervisors (currently only libvirt) support"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"328d5072_1fc282cd","line":2519,"range":{"start_line":2511,"start_character":0,"end_line":2519,"end_character":19},"in_reply_to":"21791b9c_3e7cc8f2","updated":"2021-01-07 17:36:17.000000000","message":"Fair point. Done.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":3727,"context_line":"  in: body"},{"line_number":3728,"context_line":"  required: true"},{"line_number":3729,"context_line":"  type: object"},{"line_number":3730,"context_line":"hypervisor_count:"},{"line_number":3731,"context_line":"  description: |"},{"line_number":3732,"context_line":"    The number of hypervisors."},{"line_number":3733,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c28f13c5_3b9375dc","line":3730,"range":{"start_line":3730,"start_character":0,"end_line":3730,"end_character":17},"updated":"2021-01-06 21:43:39.000000000","message":"ditto. this is used in deprecated statistics API which has top level warning.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":3727,"context_line":"  in: body"},{"line_number":3728,"context_line":"  required: true"},{"line_number":3729,"context_line":"  type: object"},{"line_number":3730,"context_line":"hypervisor_count:"},{"line_number":3731,"context_line":"  description: |"},{"line_number":3732,"context_line":"    The number of hypervisors."},{"line_number":3733,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e5cd9ae1_d66bec0b","line":3730,"range":{"start_line":3730,"start_character":0,"end_line":3730,"end_character":17},"in_reply_to":"c28f13c5_3b9375dc","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":3839,"context_line":"  in: body"},{"line_number":3840,"context_line":"  required: true"},{"line_number":3841,"context_line":"  type: string"},{"line_number":3842,"context_line":"hypervisor_statistics:"},{"line_number":3843,"context_line":"  description: |"},{"line_number":3844,"context_line":"    The hypervisors statistics summary object."},{"line_number":3845,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1203af30_f25911ba","line":3842,"range":{"start_line":3842,"start_character":0,"end_line":3842,"end_character":22},"updated":"2021-01-06 21:43:39.000000000","message":"ditto","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":3839,"context_line":"  in: body"},{"line_number":3840,"context_line":"  required: true"},{"line_number":3841,"context_line":"  type: string"},{"line_number":3842,"context_line":"hypervisor_statistics:"},{"line_number":3843,"context_line":"  description: |"},{"line_number":3844,"context_line":"    The hypervisors statistics summary object."},{"line_number":3845,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8c49299d_4bb9f097","line":3842,"range":{"start_line":3842,"start_character":0,"end_line":3842,"end_character":22},"in_reply_to":"1203af30_f25911ba","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"doc/api_samples/os-hypervisors/v2.88/hypervisors-uptime-resp.json":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"323fe802994871349ced75da56a09f4d258e77ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d48bc242_250983fb","updated":"2021-01-06 12:00:09.000000000","message":"hm, this should have been removed in 2.88","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b0dd5167583c2b8cffbdb0ebbb9d8642ebb8a5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1714ab23_612a5387","in_reply_to":"d48bc242_250983fb","updated":"2021-01-06 12:07:30.000000000","message":"Whoops, missed this one. Done.","commit_id":"b460343061209bb0f851e630606023b020cf5581"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":238,"context_line":"             compute host reports the COMPUTE_BFV_RESCUE capability trait."},{"line_number":239,"context_line":"    * 2.88 - Drop statistics-style fields from the ``/os-hypervisors/detail``"},{"line_number":240,"context_line":"             and ``/os-hypervisors/{hypervisor_id}`` APIs, and remove the"},{"line_number":241,"context_line":"             ``/os-hypervisors/statistics`` API entirely."},{"line_number":242,"context_line":"\"\"\""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":6,"id":"71704a57_3079101a","line":241,"range":{"start_line":241,"start_character":43,"end_line":241,"end_character":44},"updated":"2021-01-06 21:43:39.000000000","message":"and ``/os-hypervisors/uptime``","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":238,"context_line":"             compute host reports the COMPUTE_BFV_RESCUE capability trait."},{"line_number":239,"context_line":"    * 2.88 - Drop statistics-style fields from the ``/os-hypervisors/detail``"},{"line_number":240,"context_line":"             and ``/os-hypervisors/{hypervisor_id}`` APIs, and remove the"},{"line_number":241,"context_line":"             ``/os-hypervisors/statistics`` API entirely."},{"line_number":242,"context_line":"\"\"\""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":6,"id":"8e85f65f_08f48543","line":241,"range":{"start_line":241,"start_character":43,"end_line":241,"end_character":44},"in_reply_to":"71704a57_3079101a","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"nova/api/openstack/compute/hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6709f46617f83d94c8d4f1feb1fb576018d145a8","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        # Empty list if there are no servers on hypervisors and it is"},{"line_number":106,"context_line":"        # requested in request."},{"line_number":107,"context_line":"        elif with_servers and api_version_request.is_supported("},{"line_number":108,"context_line":"            req, min_version\u003d\u00272.75\u0027,"},{"line_number":109,"context_line":"        ):"},{"line_number":110,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d []"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"73bab6d1_cdf10ac0","line":108,"range":{"start_line":108,"start_character":35,"end_line":108,"end_character":36},"updated":"2020-12-03 20:27:31.000000000","message":"?","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40b9328f6e60241c36cd4d934cbdd2f00dc0bfb6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # Empty list if there are no servers on hypervisors and it is"},{"line_number":106,"context_line":"        # requested in request."},{"line_number":107,"context_line":"        elif with_servers and api_version_request.is_supported("},{"line_number":108,"context_line":"            req, min_version\u003d\u00272.75\u0027,"},{"line_number":109,"context_line":"        ):"},{"line_number":110,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d []"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4ad5f100_a14364f9","line":108,"range":{"start_line":108,"start_character":35,"end_line":108,"end_character":36},"in_reply_to":"73bab6d1_cdf10ac0","updated":"2020-12-07 15:24:04.000000000","message":"Just matching what I did above. The double indentation is hideous 😊","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6709f46617f83d94c8d4f1feb1fb576018d145a8","unresolved":true,"context_lines":[{"line_number":418,"context_line":"            hypervisors.append(hyp)"},{"line_number":419,"context_line":"        return dict(hypervisors\u003dhypervisors)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @wsgi.Controller.api_version(\u00272.1\u0027, \u00272.87\u0027)"},{"line_number":422,"context_line":"    @wsgi.expected_errors(())"},{"line_number":423,"context_line":"    def statistics(self, req):"},{"line_number":424,"context_line":"        \"\"\"Prior to microversion 2.88, you could get statistics for the"}],"source_content_type":"text/x-python","patch_set":1,"id":"63724acf_51b7ead5","line":421,"range":{"start_line":421,"start_character":0,"end_line":421,"end_character":47},"updated":"2020-12-03 20:27:31.000000000","message":"this ill return 404 for microversion \u003e2.87 but spec said it will return 410 Gone. I think 404 make sense here as this API is not completely gone. Can you quickly update the spec also.","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40b9328f6e60241c36cd4d934cbdd2f00dc0bfb6","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            hypervisors.append(hyp)"},{"line_number":419,"context_line":"        return dict(hypervisors\u003dhypervisors)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @wsgi.Controller.api_version(\u00272.1\u0027, \u00272.87\u0027)"},{"line_number":422,"context_line":"    @wsgi.expected_errors(())"},{"line_number":423,"context_line":"    def statistics(self, req):"},{"line_number":424,"context_line":"        \"\"\"Prior to microversion 2.88, you could get statistics for the"}],"source_content_type":"text/x-python","patch_set":1,"id":"386e0f0d_1aca4800","line":421,"range":{"start_line":421,"start_character":0,"end_line":421,"end_character":47},"in_reply_to":"63724acf_51b7ead5","updated":"2020-12-07 15:24:04.000000000","message":"Yes, I\u0027ll update the spec","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"323fe802994871349ced75da56a09f4d258e77ed","unresolved":true,"context_lines":[{"line_number":110,"context_line":"                exception.ComputeServiceUnavailable,"},{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible get uptime for a down host"},{"line_number":114,"context_line":"                hyp_dict[\u0027uptime\u0027] \u003d None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if servers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"8241852d_2e0b41c8","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":30},"updated":"2021-01-06 12:00:09.000000000","message":"nit: possible to get","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b0dd5167583c2b8cffbdb0ebbb9d8642ebb8a5d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                exception.ComputeServiceUnavailable,"},{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible get uptime for a down host"},{"line_number":114,"context_line":"                hyp_dict[\u0027uptime\u0027] \u003d None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if servers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"27607477_fb9cc080","line":113,"range":{"start_line":113,"start_character":18,"end_line":113,"end_character":30},"in_reply_to":"8241852d_2e0b41c8","updated":"2021-01-06 12:07:30.000000000","message":"Done","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"323fe802994871349ced75da56a09f4d258e77ed","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible get uptime for a down host"},{"line_number":114,"context_line":"                hyp_dict[\u0027uptime\u0027] \u003d None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if servers:"},{"line_number":117,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"35d28a14_d9ec9494","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":41},"updated":"2021-01-06 12:00:09.000000000","message":"+1","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4b0dd5167583c2b8cffbdb0ebbb9d8642ebb8a5d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible get uptime for a down host"},{"line_number":114,"context_line":"                hyp_dict[\u0027uptime\u0027] \u003d None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if servers:"},{"line_number":117,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"491c56d8_d27ad626","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":41},"in_reply_to":"35d28a14_d9ec9494","updated":"2021-01-06 12:07:30.000000000","message":"Ack","commit_id":"b460343061209bb0f851e630606023b020cf5581"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":107,"context_line":"                    req.environ[\u0027nova.context\u0027], hypervisor.host)"},{"line_number":108,"context_line":"            except ("},{"line_number":109,"context_line":"                NotImplementedError,"},{"line_number":110,"context_line":"                exception.ComputeServiceUnavailable,"},{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible to get uptime for a down host"}],"source_content_type":"text/x-python","patch_set":6,"id":"a7f90aa0_eee8c78d","line":110,"range":{"start_line":110,"start_character":51,"end_line":110,"end_character":52},"updated":"2021-01-06 21:43:39.000000000","message":"we need to catch HostNotFound also as you mentioned here - https://review.opendev.org/c/openstack/nova/+/769520/1//COMMIT_MSG#31","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                    req.environ[\u0027nova.context\u0027], hypervisor.host)"},{"line_number":108,"context_line":"            except ("},{"line_number":109,"context_line":"                NotImplementedError,"},{"line_number":110,"context_line":"                exception.ComputeServiceUnavailable,"},{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible to get uptime for a down host"}],"source_content_type":"text/x-python","patch_set":6,"id":"8ba23a19_fc3f225c","line":110,"range":{"start_line":110,"start_character":51,"end_line":110,"end_character":52},"in_reply_to":"a7f90aa0_eee8c78d","updated":"2021-01-07 17:36:17.000000000","message":"And \u0027HostMappingNotFound,\u0027. Good catch.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible to get uptime for a down host"},{"line_number":114,"context_line":"                hyp_dict[\u0027uptime\u0027] \u003d None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if servers:"},{"line_number":117,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"d4c34372_5e46b556","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":41},"updated":"2021-01-06 21:43:39.000000000","message":"with previous uptime API, it used to raise 404 (or 501) if no uptime available but +1 on returning the None here as it is embedded with all other info not just uptime info.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            ):"},{"line_number":112,"context_line":"                # Not all virt drivers support this, and it\u0027s not generally"},{"line_number":113,"context_line":"                # possible to get uptime for a down host"},{"line_number":114,"context_line":"                hyp_dict[\u0027uptime\u0027] \u003d None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if servers:"},{"line_number":117,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"4a1d26de_ab5e4655","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":41},"in_reply_to":"d4c34372_5e46b556","updated":"2021-01-07 17:36:17.000000000","message":"Yeah, this seemed the most sensible approach. Return it if we could else return nothing.","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88d2d5492bb731c47f797614d2f2a40af1cf4847","unresolved":true,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"In addition, the ``/os-hypervisors/statistics`` API, which provided a summary"},{"line_number":1164,"context_line":"view with just these fields, has been removed entirely and will now raise a"},{"line_number":1165,"context_line":"HTTP 404 with microversion 2.88 or greater."},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"The fields were removed as the information they provided were frequently"},{"line_number":1168,"context_line":"misleading or outright wrong, and many can be better queried from placement."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e38bb898_27d43235","line":1165,"range":{"start_line":1165,"start_character":0,"end_line":1165,"end_character":8},"updated":"2020-12-04 13:47:59.000000000","message":"Now this is in sync with the impl, but gmann asks for 410 Gone in the impl.","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40b9328f6e60241c36cd4d934cbdd2f00dc0bfb6","unresolved":false,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"In addition, the ``/os-hypervisors/statistics`` API, which provided a summary"},{"line_number":1164,"context_line":"view with just these fields, has been removed entirely and will now raise a"},{"line_number":1165,"context_line":"HTTP 404 with microversion 2.88 or greater."},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"The fields were removed as the information they provided were frequently"},{"line_number":1168,"context_line":"misleading or outright wrong, and many can be better queried from placement."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fb36d1b0_2a6c8291","line":1165,"range":{"start_line":1165,"start_character":0,"end_line":1165,"end_character":8},"in_reply_to":"71ac5597_1ff26cea","updated":"2020-12-07 15:24:04.000000000","message":"Will update the spec","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9c3d25957380a05a0f516aa04cea49867944a850","unresolved":true,"context_lines":[{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"In addition, the ``/os-hypervisors/statistics`` API, which provided a summary"},{"line_number":1164,"context_line":"view with just these fields, has been removed entirely and will now raise a"},{"line_number":1165,"context_line":"HTTP 404 with microversion 2.88 or greater."},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"The fields were removed as the information they provided were frequently"},{"line_number":1168,"context_line":"misleading or outright wrong, and many can be better queried from placement."}],"source_content_type":"text/x-rst","patch_set":1,"id":"71ac5597_1ff26cea","line":1165,"range":{"start_line":1165,"start_character":0,"end_line":1165,"end_character":8},"in_reply_to":"e38bb898_27d43235","updated":"2020-12-04 16:18:36.000000000","message":"I am ok with 404 to have consistency with other deprecated APIs. But in spec we did not notice this and had 410 - https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/modernize-os-hypervisors-api.html#rest-api-impact\n\nmay be we can just update spec to replace 410 with 404 to match our spec documentation with implementation. .","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":1145,"context_line":"----"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"The following fields are no longer included in responses for the"},{"line_number":1148,"context_line":"``/os-hypervisors/detail`` and ``/os-hypervisors/{hypervisor_id}`` APIs:"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"- ``current_workload``"},{"line_number":1151,"context_line":"- ``cpu_info``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9152420d_c7d5aab9","line":1148,"range":{"start_line":1148,"start_character":0,"end_line":1148,"end_character":26},"updated":"2021-01-06 21:43:39.000000000","message":"GET ``/os-hypervisors/detail``","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":1145,"context_line":"----"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"The following fields are no longer included in responses for the"},{"line_number":1148,"context_line":"``/os-hypervisors/detail`` and ``/os-hypervisors/{hypervisor_id}`` APIs:"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"- ``current_workload``"},{"line_number":1151,"context_line":"- ``cpu_info``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6c071120_d843aef6","line":1148,"range":{"start_line":1148,"start_character":31,"end_line":1148,"end_character":66},"updated":"2021-01-06 21:43:39.000000000","message":"GET ``/os-hypervisors/{hypervisor_id}``","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"----"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"The following fields are no longer included in responses for the"},{"line_number":1148,"context_line":"``/os-hypervisors/detail`` and ``/os-hypervisors/{hypervisor_id}`` APIs:"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"- ``current_workload``"},{"line_number":1151,"context_line":"- ``cpu_info``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a1a9cc9_11c25925","line":1148,"range":{"start_line":1148,"start_character":31,"end_line":1148,"end_character":66},"in_reply_to":"6c071120_d843aef6","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"----"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"The following fields are no longer included in responses for the"},{"line_number":1148,"context_line":"``/os-hypervisors/detail`` and ``/os-hypervisors/{hypervisor_id}`` APIs:"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"- ``current_workload``"},{"line_number":1151,"context_line":"- ``cpu_info``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ab3a2a6c_23a5bfb8","line":1148,"range":{"start_line":1148,"start_character":0,"end_line":1148,"end_character":26},"in_reply_to":"9152420d_c7d5aab9","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"nova/tests/functional/api_sample_tests/test_hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"becf5487b7fd58c0479e2c21a2c1aeed7d9ad997","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        \"\"\"The statistics route is deprecated in 2.88 and now returns a 404."},{"line_number":283,"context_line":"        \"\"\""},{"line_number":284,"context_line":"        response \u003d self._do_get(\u0027os-hypervisors/statistics\u0027)"},{"line_number":285,"context_line":"        self.assertEqual(404, response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6aa55a3_3cab006c","line":285,"range":{"start_line":285,"start_character":50,"end_line":285,"end_character":51},"updated":"2020-12-03 21:50:41.000000000","message":"can you also add test for immediate previous microversion also to make sure no regression in old microversion:\n\n\nclass HypervisorsSampleJson287Tests(HypervisorsSampleJson253Tests):\n    microversion \u003d \u00272.87\u0027\n    scenarios \u003d [(\u0027v2_87\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5f36823c59859949b433e6524d1fa38e7a7d9f8b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        \"\"\"The statistics route is deprecated in 2.88 and now returns a 404."},{"line_number":283,"context_line":"        \"\"\""},{"line_number":284,"context_line":"        response \u003d self._do_get(\u0027os-hypervisors/statistics\u0027)"},{"line_number":285,"context_line":"        self.assertEqual(404, response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d19252e_61dee163","line":285,"range":{"start_line":285,"start_character":50,"end_line":285,"end_character":51},"in_reply_to":"46a4e86b_18abf9d0","updated":"2021-01-08 10:14:37.000000000","message":"Done","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01c15692b98d7e65b7554636b8ed999df041f11a","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        \"\"\"The statistics route is deprecated in 2.88 and now returns a 404."},{"line_number":283,"context_line":"        \"\"\""},{"line_number":284,"context_line":"        response \u003d self._do_get(\u0027os-hypervisors/statistics\u0027)"},{"line_number":285,"context_line":"        self.assertEqual(404, response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"46a4e86b_18abf9d0","line":285,"range":{"start_line":285,"start_character":50,"end_line":285,"end_character":51},"in_reply_to":"892c6fef_225094e7","updated":"2021-01-07 22:34:54.000000000","message":"I thought I removed this comment in favor of implementing unit tests but somehow i left this too\n\nI agree that we do not need to run functional tests but running unit tests on 2.87 would not add much runtime. I think adding it for 2.87 can help here along with existing 2.53. \n- https://review.opendev.org/c/openstack/nova/+/764040/6/nova/tests/unit/api/openstack/compute/test_hypervisors.py#1433","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40b9328f6e60241c36cd4d934cbdd2f00dc0bfb6","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        \"\"\"The statistics route is deprecated in 2.88 and now returns a 404."},{"line_number":283,"context_line":"        \"\"\""},{"line_number":284,"context_line":"        response \u003d self._do_get(\u0027os-hypervisors/statistics\u0027)"},{"line_number":285,"context_line":"        self.assertEqual(404, response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"892c6fef_225094e7","line":285,"range":{"start_line":285,"start_character":50,"end_line":285,"end_character":51},"in_reply_to":"b6aa55a3_3cab006c","updated":"2020-12-07 15:24:04.000000000","message":"I\u0027m already testing this with the 2.53 microversion above, and I\u0027m testing 2.87 in part via my changes to \u0027nova.tests.functional.test_servers.VolumeBackedServerTest\u0027 so I don\u0027t think this is necessary. It\u0027s another 10 tests or so, with the additional runtime included.","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"}],"nova/tests/unit/api/openstack/compute/test_hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":1430,"context_line":"                                                   id\u003duuids.hyper1)"},{"line_number":1431,"context_line":"        self.assertEqual(0, len(result[\u0027hypervisor\u0027][\u0027servers\u0027]))"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"class HypervisorsTestV288(HypervisorsTestV275):"},{"line_number":1435,"context_line":"    api_version \u003d \u00272.88\u0027"},{"line_number":1436,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"37c8e5a4_7d83eee4","line":1433,"range":{"start_line":1433,"start_character":0,"end_line":1433,"end_character":0},"updated":"2021-01-06 21:43:39.000000000","message":"also you can add immediate previous microversion test also to make sure until 2.87 all removed field and these 2 APIs work fine.\n\nclass HypervisorsTestV287(HypervisorsTestV275):\n\n    api_version \u003d \u00272.87\u0027","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                                                   id\u003duuids.hyper1)"},{"line_number":1431,"context_line":"        self.assertEqual(0, len(result[\u0027hypervisor\u0027][\u0027servers\u0027]))"},{"line_number":1432,"context_line":""},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"class HypervisorsTestV288(HypervisorsTestV275):"},{"line_number":1435,"context_line":"    api_version \u003d \u00272.88\u0027"},{"line_number":1436,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a0c0ea7_7ba489d3","line":1433,"range":{"start_line":1433,"start_character":0,"end_line":1433,"end_character":0},"in_reply_to":"37c8e5a4_7d83eee4","updated":"2021-01-07 17:36:17.000000000","message":"😊 https://review.opendev.org/c/openstack/nova/+/764040/1/nova/tests/functional/api_sample_tests/test_hypervisors.py#285","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"releasenotes/notes/microversion-2-88-7063636ed9c11a5d.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The 2.88 API microversion has been added. This microversion removes a"},{"line_number":5,"context_line":"    number of fields have been removed from the ``/os-hypervisors/detail``"},{"line_number":6,"context_line":"    (detailed list) and ``/os-hypervisors/{hypervisor_id}`` (show) APIs::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``current_workload``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f60ac30_382878ff","line":5,"range":{"start_line":5,"start_character":49,"end_line":5,"end_character":50},"updated":"2021-01-06 21:43:39.000000000","message":"GET","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The 2.88 API microversion has been added. This microversion removes a"},{"line_number":5,"context_line":"    number of fields have been removed from the ``/os-hypervisors/detail``"},{"line_number":6,"context_line":"    (detailed list) and ``/os-hypervisors/{hypervisor_id}`` (show) APIs::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``current_workload``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b3bf2f77_892627f6","line":5,"range":{"start_line":5,"start_character":49,"end_line":5,"end_character":50},"in_reply_to":"1f60ac30_382878ff","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21ab537446fb2e0b11e064d2f9555368cb65cfb4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The 2.88 API microversion has been added. This microversion removes a"},{"line_number":5,"context_line":"    number of fields have been removed from the ``/os-hypervisors/detail``"},{"line_number":6,"context_line":"    (detailed list) and ``/os-hypervisors/{hypervisor_id}`` (show) APIs::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``current_workload``"},{"line_number":9,"context_line":"    - ``cpu_info``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"39fb94b9_6de453d5","line":6,"range":{"start_line":6,"start_character":24,"end_line":6,"end_character":25},"updated":"2021-01-06 21:43:39.000000000","message":"GET","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d7b8606d347d5ae68de5e9ef7e358b676dfa731","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The 2.88 API microversion has been added. This microversion removes a"},{"line_number":5,"context_line":"    number of fields have been removed from the ``/os-hypervisors/detail``"},{"line_number":6,"context_line":"    (detailed list) and ``/os-hypervisors/{hypervisor_id}`` (show) APIs::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``current_workload``"},{"line_number":9,"context_line":"    - ``cpu_info``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6bc0e362_839fd203","line":6,"range":{"start_line":6,"start_character":24,"end_line":6,"end_character":25},"in_reply_to":"39fb94b9_6de453d5","updated":"2021-01-07 17:36:17.000000000","message":"Done","commit_id":"be6014feb9b3f8366c103e2e64247ca92341e20d"}],"tox.ini":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88d2d5492bb731c47f797614d2f2a40af1cf4847","unresolved":true,"context_lines":[{"line_number":126,"context_line":"  {[testenv:functional]commands}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"[testenv:api-samples]"},{"line_number":129,"context_line":"envdir \u003d {toxworkdir}/functional"},{"line_number":130,"context_line":"setenv \u003d"},{"line_number":131,"context_line":"  {[testenv]setenv}"},{"line_number":132,"context_line":"  GENERATE_SAMPLES\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":1,"id":"b4521fdd_87c1286b","line":129,"updated":"2020-12-04 13:47:59.000000000","message":"Is there a reasoning for this?","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dacfb5c18f73700cb96b7dde7fa60b55d9502632","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  {[testenv:functional]commands}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"[testenv:api-samples]"},{"line_number":129,"context_line":"envdir \u003d {toxworkdir}/functional"},{"line_number":130,"context_line":"setenv \u003d"},{"line_number":131,"context_line":"  {[testenv]setenv}"},{"line_number":132,"context_line":"  GENERATE_SAMPLES\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":1,"id":"b9441ce7_81977968","line":129,"in_reply_to":"97e516e7_f4aa45bb","updated":"2020-12-07 15:53:46.000000000","message":"ACK. Cool with me.","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40b9328f6e60241c36cd4d934cbdd2f00dc0bfb6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  {[testenv:functional]commands}"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"[testenv:api-samples]"},{"line_number":129,"context_line":"envdir \u003d {toxworkdir}/functional"},{"line_number":130,"context_line":"setenv \u003d"},{"line_number":131,"context_line":"  {[testenv]setenv}"},{"line_number":132,"context_line":"  GENERATE_SAMPLES\u003dTrue"}],"source_content_type":"text/x-properties","patch_set":1,"id":"97e516e7_f4aa45bb","line":129,"in_reply_to":"b4521fdd_87c1286b","updated":"2020-12-07 15:24:04.000000000","message":"Yes, I used this to regenerate the API samples and noticed this shared the same dependencies as the \u0027functional\u0027 testenv and could therefore share the virtualenv (avoids the need to build a new virtualenv to use this and therefore saves disk space and bandwidth, for when that matters)","commit_id":"61df85d8104d4dbe4c22d06ac9a2146ecfc7b0ae"}]}