)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3450263ac06bf4c8bab55f293162d491f73438ab","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"While this obviously optimises basic instance lifecycle flows such as a"},{"line_number":20,"context_line":"simple power on and power off it additionally resolves a more convoluted"},{"line_number":21,"context_line":"use case when the ``[compute]/resume_guests_state_on_host_boot``"},{"line_number":22,"context_line":"configurable is enabled. In this case the compute service has no request"},{"line_number":23,"context_line":"context with which to query the key manager when attempting to restart"},{"line_number":24,"context_line":"instances with encrypted volumes attached. As a result any attempt by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"775cdebe_52afe04c","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":28},"updated":"2020-11-26 10:31:40.000000000","message":"Gah, this isn\u0027t right, it\u0027s under DEFAULT. I\u0027ll correct if I respin.","commit_id":"3e44eee830615f1ba01e0a5670692b535e9e41e9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"278992fc6450b28ba982d4ff642979eb0372ba39","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"While this obviously optimises basic instance lifecycle flows such as a"},{"line_number":20,"context_line":"simple power on and power off it additionally resolves a more convoluted"},{"line_number":21,"context_line":"use case when the ``[compute]/resume_guests_state_on_host_boot``"},{"line_number":22,"context_line":"configurable is enabled. In this case the compute service has no request"},{"line_number":23,"context_line":"context with which to query the key manager when attempting to restart"},{"line_number":24,"context_line":"instances with encrypted volumes attached. As a result any attempt by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9646fc91_9393ea5c","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":28},"in_reply_to":"775cdebe_52afe04c","updated":"2020-11-30 08:54:33.000000000","message":"You did not updated the commit message.","commit_id":"3e44eee830615f1ba01e0a5670692b535e9e41e9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0d5e864f946f439a6d630794928af88bab7cbf3d","unresolved":true,"context_lines":[{"line_number":23,"context_line":"context with which to query the key manager when attempting to restart"},{"line_number":24,"context_line":"instances with encrypted volumes attached. As a result any attempt by"},{"line_number":25,"context_line":"the compute service to restart an instance with an attached encrypted"},{"line_number":26,"context_line":"volume would previously fail."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1905701"},{"line_number":29,"context_line":"Change-Id: Ia2007bc63ef09931ea0197cef29d6a5614ed821a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"178b1bd3_b653c954","line":26,"updated":"2020-11-26 10:17:21.000000000","message":"So this assumes that the secret is not removed during the host reboot. I could imagine a host repair situation (e.g. after disk corruptions) that makes the secret unavailable after the host reboot. Still I think your solution is needed as it solves common problems. Just wanted to mention that this is not a complete solution.","commit_id":"3e44eee830615f1ba01e0a5670692b535e9e41e9"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fe7f85398d36f54ed67fc6496c70a42631f2fca3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"context with which to query the key manager when attempting to restart"},{"line_number":24,"context_line":"instances with encrypted volumes attached. As a result any attempt by"},{"line_number":25,"context_line":"the compute service to restart an instance with an attached encrypted"},{"line_number":26,"context_line":"volume would previously fail."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1905701"},{"line_number":29,"context_line":"Change-Id: Ia2007bc63ef09931ea0197cef29d6a5614ed821a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"910905d0_cb4d428c","line":26,"in_reply_to":"178b1bd3_b653c954","updated":"2020-11-26 10:27:41.000000000","message":"Yeah true, this is a hackaround for the basic usecase. If the disk was replaced you would expect a rebuild to happen anyway that would also resolve this (assuming the caller is able to request the required secrets from the key manager etc).","commit_id":"3e44eee830615f1ba01e0a5670692b535e9e41e9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"278992fc6450b28ba982d4ff642979eb0372ba39","unresolved":false,"context_lines":[{"line_number":23,"context_line":"context with which to query the key manager when attempting to restart"},{"line_number":24,"context_line":"instances with encrypted volumes attached. As a result any attempt by"},{"line_number":25,"context_line":"the compute service to restart an instance with an attached encrypted"},{"line_number":26,"context_line":"volume would previously fail."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1905701"},{"line_number":29,"context_line":"Change-Id: Ia2007bc63ef09931ea0197cef29d6a5614ed821a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cd9aceb6_ee0179bc","line":26,"in_reply_to":"910905d0_cb4d428c","updated":"2020-11-30 08:54:33.000000000","message":"Yeah rebuild is the solution for a disk replacement.","commit_id":"3e44eee830615f1ba01e0a5670692b535e9e41e9"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ceda99e0577b4c2c073a940b45fbb3b350d77ffd","unresolved":true,"context_lines":[{"line_number":1723,"context_line":"        if self._host.find_secret(\u0027volume\u0027, volume_id):"},{"line_number":1724,"context_line":"            LOG.debug(f\"A libvirt secret for volume {volume_id} has been \""},{"line_number":1725,"context_line":"                       \"found on the host, skipping any attempt to create \""},{"line_number":1726,"context_line":"                       \"another or attach an encryptor.\")"},{"line_number":1727,"context_line":"            return"},{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"        if encryption is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4808580b_f3107889","line":1726,"updated":"2020-11-27 16:28:20.000000000","message":"This doesn\u0027t delay interpolation, which is what we get when we use \"LOG.debug(\u0027%s\u0027, \u0027foo\u0027)\" rather than \"LOG.debug(\u0027%s % \u0027foo\u0027)\". I think that\u0027s okay here, since the interpolation isn\u0027t expensive in this case, but I wonder if it would be best to keep doing delayed interpolation everywhere so one doesn\u0027t need to make this decision?","commit_id":"55327eff63045dff7c37c7acbf12669f5be4c738"}]}