)]}'
{"id":"openstack%2Fnova~764309","triplet_id":"openstack%2Fnova~stable%2Frocky~I83817f7301680801beaee375825f02eda526eda1","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1865040","hashtags":[],"change_id":"I83817f7301680801beaee375825f02eda526eda1","subject":"Validate id as integer for os-aggregates","status":"ABANDONED","created":"2020-11-27 12:27:46.000000000","updated":"2022-11-11 18:31:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":764308,"cherry_pick_of_patch_set":1,"meta_rev_id":"9fd88e06d9fdac99d699ff1d2503c555edbcbe9d","_number":764309,"virtual_id_number":764309,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-06-24 21:43:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2021-06-24 13:36:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-08-04 16:22:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-27 12:27:46.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"state":"REVIEWER"},{"updated":"2020-11-27 12:39:55.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2020-11-27 14:19:59.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-11-27 16:08:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-24 13:36:42.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2021-08-04 16:22:46.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"b6b72f0ffb1b7527c355a0996832930a7fa1225e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-27 12:27:46.000000000","message":"Patch Set 1: Cherry Picked from branch stable/stein.","accounts_in_message":[],"_revision_number":1},{"id":"69f02d60bde63d8b186ce5ae74f728a70aab56b8","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-27 12:29:13.000000000","message":"Topic bug/1865040-stable/rocky removed","accounts_in_message":[],"_revision_number":1},{"id":"97be33d14515e275b19781e55bf375ea0660ae54","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-27 12:29:20.000000000","message":"Topic set to bug/1865040","accounts_in_message":[],"_revision_number":1},{"id":"a5be87a549aebfabfcbf5f3311b6be7582dd4e08","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-27 12:39:55.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/764309/1 : FAILURE in 9m 53s","accounts_in_message":[],"_revision_number":1},{"id":"49fea64acaa8c1b09c5790854a01987bf67793ce","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-27 14:19:59.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/09/764309/1/check/tempest-dsvm-full-bionic-py3/7424aef/ : SUCCESS in 1h 31m 15s","accounts_in_message":[],"_revision_number":1},{"id":"6d54d86eba531b767ed470c9e4e61925938522eb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-27 16:08:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dbf2c092338d4db2b034354907aed0fb : FAILURE in 10m 11s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/134a9587adb54bfe8efc291ec8592482 : SUCCESS in 12m 44s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/67651b20c5cf4188b1d474692e4f555d : SUCCESS in 12m 46s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/3017f39440224b1a8bf8e836ab97e17b : SUCCESS in 9m 51s\n- tempest-full https://zuul.opendev.org/t/openstack/build/4bac46cfe09140a99d4eeaaff8beb2c4 : SUCCESS in 1h 40m 51s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/b8a3f8cb3a4f472b9f1e94692a5c8d66 : SUCCESS in 42m 06s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/356e528df3ec48f68f314783c3de93d0 : SUCCESS in 1h 49m 50s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2fc657d4583048ae8932d6db7cd99b4c : SUCCESS in 51m 59s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/b3c3985f1b9f4862a672404b14f736f6 : SUCCESS in 1h 01m 36s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/7f1326777c1541708766afffab0adf56 : SUCCESS in 1h 06m 11s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6990b515ae674df3889d953343ae6385 : FAILURE in 1h 06m 34s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/149a2a79e5874c3e8441259cffaf97f4 : SUCCESS in 1h 02m 03s\n- nova-next https://zuul.opendev.org/t/openstack/build/d2244bf607314ebcb36803ee7e752271 : SUCCESS in 1h 30m 58s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/c84c3fc1eb9e47e9b2f37a6eb903dd11 : FAILURE in 3h 11m 03s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/7611b26b5621406186c8e270ee48433e : SUCCESS in 17m 19s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/3e5afde777c040e89de51a929b9093de : SUCCESS in 20m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2ef3f16c098f42069e62dfbb10161ad0 : SUCCESS in 13m 18s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/7301e1fed6a94410afe1ee6a0cd7595d : SUCCESS in 1h 14m 00s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/ba81b92963e0431087024e5c08431f91 : SUCCESS in 46m 29s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/32dcd076637148ad9fb058176c86b2cd : SUCCESS in 1h 35m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"394571354190f636306880ae09acc04ef83f3552","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-24 13:36:42.000000000","message":"Patch Set 1: Code-Review+2\n\nClean cherry pick from Stein, where the patch has merged. LGTM","accounts_in_message":[],"_revision_number":1},{"id":"fbb5dc5137bbd41193f1e21d09796ec7e3352b41","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-06-24 13:37:00.000000000","message":"Patch Set 1:\n\nrecheck - stein patch has merged","accounts_in_message":[],"_revision_number":1},{"id":"6690a8e7209884f54d9be4a326dc8ac25f8ece23","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-06-24 18:00:39.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/8793543a3a9843438e2a2dd0535de676 : POST_FAILURE in 1h 51m 57s","accounts_in_message":[],"_revision_number":1},{"id":"1c7ec3f25833f0cdfb5937130452bd5cf02daccc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 21:43:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/298c12740de84b469efa082be86d2148 : SUCCESS in 13m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/845c3219dfbf4b80ac4d22b129b503ed : SUCCESS in 16m 18s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5d386832537b459c84a243f9a4b9c286 : SUCCESS in 16m 33s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/736357ae96634be89d3ed6ab9b1e5d34 : SUCCESS in 11m 29s\n- tempest-full https://zuul.opendev.org/t/openstack/build/c7b4297d40d0424cb630b0e3b5c6fdc6 : SUCCESS in 1h 21m 48s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/c64d6fc7b12e4449a75d0440f6374d58 : SUCCESS in 54m 41s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/af243ee0bd454d70a03b251680881b50 : SUCCESS in 1h 26m 29s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/3ff1eb7aba1f497994c73e945f5000fe : SUCCESS in 47m 33s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/efbb5ae49b0b4274838a85b0f5c257f4 : SUCCESS in 1h 14m 37s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/bf0caddf18514b8c8a37b8688f6a9058 : SUCCESS in 1h 15m 55s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/df9930cf61434f8ca7b05b281c71ee19 : SUCCESS in 53m 37s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/224121be28d0445b9e67901ccf6300f7 : SUCCESS in 1h 07m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/c45c8599a9bf4781aef76ddd06a82596 : SUCCESS in 1h 31m 24s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/e3458274c3d44d8ea98f21941a65d7e8 : SUCCESS in 1h 53m 49s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/2b548777a0cb4538aa1410431d2aa5bf : SUCCESS in 19m 30s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/20ed5073ebb6405ab456dfae9d541060 : SUCCESS in 21m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f2535dbe78954a6e8acb958c44f8170a : FAILURE in 6m 01s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/82a68ada9da244a7b3834d3362e58b3f : SUCCESS in 1h 00m 41s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/b302c5dedda149af862efd5f3cc4d139 : SUCCESS in 1h 29m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"15f21411240de086a8b9bd184fb8d39ad082c615","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2021-08-04 16:22:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9fd88e06d9fdac99d699ff1d2503c555edbcbe9d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:31:35.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ad8aca7965dd7cc95e151056a74b63deecbe90a1","revisions":{"ad8aca7965dd7cc95e151056a74b63deecbe90a1":{"kind":"REWORK","_number":1,"created":"2020-11-27 12:27:46.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/09/764309/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/764309/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/764309/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/764309/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/764309/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/764309/1"}}},"commit":{"parents":[{"commit":"3c774435502a339f202e94ae15d637e49a19d4ce","subject":"Follow up for cherry-pick check for merge patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c774435502a339f202e94ae15d637e49a19d4ce"}]}],"author":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-02-27 07:08:32.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-11-27 12:27:46.000000000","tz":0},"subject":"Validate id as integer for os-aggregates","message":"Validate id as integer for os-aggregates\n\nAccording to the api-ref, the id passed to calls in os-aggregates is\nsupposed to be an integer. No function validated this, so any value\npassed to these functions would directly reach the DB. While this is\nfine for SQLite, making a query with a string for an integer column on\nother databases like PostgreSQL results in a DBError exception and thus\na HTTP 500 instead of 400 or 404.\n\nThis commit adds validation for the id parameter the same way it\u0027s\nalready done for other endpoints.\n\nChange-Id: I83817f7301680801beaee375825f02eda526eda1\nCloses-Bug: 1865040\n(cherry picked from commit 2e70a1717f25652912886cbefa3f40e6df908c00)\n(cherry picked from commit 4653245ddcf989ebac4b964a41d881d78cf9ae2c)\n(cherry picked from commit 9448291d8f3ff6bef85d3bca4aa21c1e6036b3f1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ad8aca7965dd7cc95e151056a74b63deecbe90a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ad8aca7965dd7cc95e151056a74b63deecbe90a1"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
