)]}'
{"id":"openstack%2Fnova~764310","triplet_id":"openstack%2Fnova~stable%2Fqueens~I83817f7301680801beaee375825f02eda526eda1","project":"openstack/nova","branch":"stable/queens","topic":"bug/1865040","hashtags":[],"change_id":"I83817f7301680801beaee375825f02eda526eda1","subject":"Validate id as integer for os-aggregates","status":"ABANDONED","created":"2020-11-27 12:29:00.000000000","updated":"2022-11-11 18:24:05.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":764309,"cherry_pick_of_patch_set":1,"meta_rev_id":"7475ebd70dd23643806922a3e17bffeb7979ed8e","_number":764310,"virtual_id_number":764310,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-11-27 14:58:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-27 12:29:00.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"state":"REVIEWER"},{"updated":"2020-11-27 12:41:28.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2020-11-27 13:29:13.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-11-27 14:58:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0fbee43884684545ad69f2161984f6e1fcf068f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-27 12:29:00.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"f30938ae7d3333d312768c0238eb2ef83b5e5197","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-27 12:30:22.000000000","message":"Topic bug/1865040-stable/rocky-stable/queens removed","accounts_in_message":[],"_revision_number":1},{"id":"2f2da120a527fe849cdd9469cba2efbde8e9b8e5","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-27 12:30:26.000000000","message":"Topic set to bug/1865040","accounts_in_message":[],"_revision_number":1},{"id":"1da57c0aa5879d3478ca4d56cebf0067d3cc6f9f","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-27 12:41:28.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/764310/1 : FAILURE in 10m 29s","accounts_in_message":[],"_revision_number":1},{"id":"a4913acfb957cec2fbf31033ea2fbc675cae4cf4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-27 13:29:13.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/10/764310/1/check/tempest-dsvm-full-xenial/099c7cc/ : FAILURE in 27m 08s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/10/764310/1/check/tempest-dsvm-full-xenial-py3/210f53f/ : FAILURE in 24m 18s","accounts_in_message":[],"_revision_number":1},{"id":"c39663a96071735ea0fabde3bd68f5355fee1dc0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-27 14:58:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ecbb42cf5c4145d98801ca2b2c1b4e11 : FAILURE in 10m 30s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/002bd448921c49c2b726a92c863b63fa : SUCCESS in 23m 05s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5a756b08cd2f4542bb8e1dc72c01513b : SUCCESS in 13m 39s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/1b50763ca95644b0a97f180c45c5f4b9 : SUCCESS in 7m 24s\n- tempest-full https://zuul.opendev.org/t/openstack/build/82403f98ce7146b6ac467dea697cdaa3 : SUCCESS in 1h 25m 10s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/9f64dafb7c834789ab28974a6b1f8b8a : SUCCESS in 1h 00m 42s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/02777aa4c2624cf7a0b381881b88d5a2 : SUCCESS in 1h 25m 17s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/e3c33fbdfc614bf0ad6e7b04bd8da937 : SUCCESS in 51m 15s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/384a8c94cdbb45cb8be597bc6ef2c932 : SUCCESS in 55m 13s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/dc9512ace0664bf38bd1f61b34b91e16 : SUCCESS in 1h 04m 06s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f0e7850f3d79461eb6da894b286d9f09 : FAILURE in 37m 49s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/31c571eb92a94a28aa0ac87618157dc6 : SUCCESS in 1h 03m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/6e6c7e9630a845869686e3fc0e94ef92 : SUCCESS in 1h 27m 59s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/999f791bfcbf47acb7b933650441ab3d : SUCCESS in 1h 47m 41s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f98b4daf2e3d4b538f27f56ff726d808 : SUCCESS in 19m 29s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/2d3d63a1184243b4bcd8ccd1199844dc : SUCCESS in 23m 00s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/34ea0aeb1b8d49418cdefa0beca8339c : SUCCESS in 1h 14m 12s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/5b9baaced08d4452a209af38ced18fbf : FAILURE in 1h 07m 55s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/6b980de4630645dead89f31c6c756625 : SUCCESS in 1h 37m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7475ebd70dd23643806922a3e17bffeb7979ed8e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:24:05.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3d691d948e8d2c61a76602ad18f61475c0437a09","revisions":{"3d691d948e8d2c61a76602ad18f61475c0437a09":{"kind":"REWORK","_number":1,"created":"2020-11-27 12:29:00.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/10/764310/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/764310/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/764310/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/764310/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/764310/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/764310/1"}}},"commit":{"parents":[{"commit":"1516fdd3944dc8bb655664c136bb16715b0c1df2","subject":"Merge \"[stable-only] Use a separate transaction for reading after race\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1516fdd3944dc8bb655664c136bb16715b0c1df2"}]}],"author":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-02-27 07:08:32.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-11-27 12:29:00.000000000","tz":0},"subject":"Validate id as integer for os-aggregates","message":"Validate id as integer for os-aggregates\n\nAccording to the api-ref, the id passed to calls in os-aggregates is\nsupposed to be an integer. No function validated this, so any value\npassed to these functions would directly reach the DB. While this is\nfine for SQLite, making a query with a string for an integer column on\nother databases like PostgreSQL results in a DBError exception and thus\na HTTP 500 instead of 400 or 404.\n\nThis commit adds validation for the id parameter the same way it\u0027s\nalready done for other endpoints.\n\nChange-Id: I83817f7301680801beaee375825f02eda526eda1\nCloses-Bug: 1865040\n(cherry picked from commit 2e70a1717f25652912886cbefa3f40e6df908c00)\n(cherry picked from commit 4653245ddcf989ebac4b964a41d881d78cf9ae2c)\n(cherry picked from commit 9448291d8f3ff6bef85d3bca4aa21c1e6036b3f1)\n(cherry picked from commit ad8aca7965dd7cc95e151056a74b63deecbe90a1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3d691d948e8d2c61a76602ad18f61475c0437a09"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3d691d948e8d2c61a76602ad18f61475c0437a09"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}