)]}'
{"nova/pci/stats.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd67b9c57d2b634c6af10e7e889c17ac717d8ef0","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    def _filter_pools_for_spec(pools, request):"},{"line_number":239,"context_line":"        \"\"\"Filter out pools that don\u0027t match the request\u0027s device spec."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        The spec can define any of the following: vendor ID, product ID,"},{"line_number":242,"context_line":"        or device name (only for network devices)."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param pools: A list of PCI device pool dicts"},{"line_number":245,"context_line":"        :param request: An InstancePCIRequest object describing the type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"71f4c11f_031c83e6","line":242,"range":{"start_line":241,"start_character":8,"end_line":242,"end_character":50},"updated":"2020-11-26 18:38:25.000000000","message":"actully no\n\nhttps://github.com/openstack/nova/blob/master/nova/pci/request.py#L66-L99\nthe request can only be filterd on \n\n   \"capability_type\": {\n            \"type\": \"string\",\n            \"enum\": _ALIAS_CAP_TYPE,\n        },\n        \"product_id\": {\n            \"type\": \"string\",\n            \"pattern\": utils.PCI_VENDOR_PATTERN,\n        },\n        \"vendor_id\": {\n            \"type\": \"string\",\n            \"pattern\": utils.PCI_VENDOR_PATTERN,\n        },\n        \"device_type\": {\n            \"type\": \"string\",\n            \"enum\": list(obj_fields.PciDeviceType.ALL),\n        },\n        \"numa_policy\": {\n            \"type\": \"string\",\n            \"enum\": list(obj_fields.PCINUMAAffinityPolicy.ALL),\n        },\n\ndevice name is not applicable here","commit_id":"d62bab224dd6446a804fe2bf21deddb778ad2601"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"127919cf2e9a15342f20b6e4e4d4e41d5c27c695","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def _filter_pools_for_spec(pools, request):"},{"line_number":239,"context_line":"        \"\"\"Filter out pools that don\u0027t match the request\u0027s device spec."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        The spec can define any of the following: vendor ID, product ID,"},{"line_number":242,"context_line":"        or device name (only for network devices)."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param pools: A list of PCI device pool dicts"},{"line_number":245,"context_line":"        :param request: An InstancePCIRequest object describing the type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3b95a18_23fcfb9b","line":242,"range":{"start_line":241,"start_character":8,"end_line":242,"end_character":50},"in_reply_to":"71f4c11f_031c83e6","updated":"2020-11-27 10:16:39.000000000","message":"Right you are. I also don\u0027t know if we actually do anything about \u0027capability_type\u0027. I can\u0027t find any other references to it.","commit_id":"d62bab224dd6446a804fe2bf21deddb778ad2601"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc1e00f8e633eb2b550dde0984401e7b9d42a059","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def _filter_pools_for_spec(pools, request):"},{"line_number":239,"context_line":"        \"\"\"Filter out pools that don\u0027t match the request\u0027s device spec."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        The spec can define any of the following: vendor ID, product ID,"},{"line_number":242,"context_line":"        or device name (only for network devices)."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param pools: A list of PCI device pool dicts"},{"line_number":245,"context_line":"        :param request: An InstancePCIRequest object describing the type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0dac0047_b63be002","line":242,"range":{"start_line":241,"start_character":8,"end_line":242,"end_character":50},"in_reply_to":"e3b95a18_23fcfb9b","updated":"2020-11-27 11:48:16.000000000","message":"it is unused yes.\n\nthe data base filed however for capablities is where we store the info that should be reqported as traits.\n\nthe last 4 patches are the important one https://review.opendev.org/q/topic:%2522bp/enable-sriov-nic-features%2522+\n\nwe need to revive and complete that series at some point.","commit_id":"d62bab224dd6446a804fe2bf21deddb778ad2601"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e3ed052275fd088f1c7ce39c1755be8b86ec3961","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    def _filter_pools_for_spec(pools, request):"},{"line_number":239,"context_line":"        \"\"\"Filter out pools that don\u0027t match the request\u0027s device spec."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        Exclude pools that do not match the specified ``vendor_id``,"},{"line_number":242,"context_line":"        ``product_id`` and/or ``device_type`` specified in the alias config."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param pools: A list of PCI device pool dicts"},{"line_number":245,"context_line":"        :param request: An InstancePCIRequest object describing the type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"58ed117a_d27de4f4","line":242,"range":{"start_line":241,"start_character":55,"end_line":242,"end_character":45},"updated":"2020-11-27 13:42:26.000000000","message":"I think there is a wider match, happening on any field in the input. So if you add a new field to the spec and also have the same field in the pool then the current code is generic enough that it does match the new field too. I used this to match \u0027parent_ifname\u0027 for the qos case and I did not have to modify any code in this module for that.\n\nI think it would be good to mention this fact.","commit_id":"36fe17581dffa33d9b47fdf0eac6bf3738e35c93"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"779e164c43a4bc227ba32ee79777b446452d3b31","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    def _filter_pools_for_spec(pools, request):"},{"line_number":239,"context_line":"        \"\"\"Filter out pools that don\u0027t match the request\u0027s device spec."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        Exclude pools that do not match the specified ``vendor_id``,"},{"line_number":242,"context_line":"        ``product_id`` and/or ``device_type`` specified in the alias config."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param pools: A list of PCI device pool dicts"},{"line_number":245,"context_line":"        :param request: An InstancePCIRequest object describing the type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"73efd441_b103c016","line":242,"range":{"start_line":241,"start_character":55,"end_line":242,"end_character":45},"in_reply_to":"58ed117a_d27de4f4","updated":"2020-11-27 14:08:39.000000000","message":"thos are refered to as tags and yes we compare tags declared in the aliase/whitelist/request.\n\nphysical_network is an example of a tag\ntrusted_vf is also one but you can also define your own technically.\n\nsome of those are not really used with alisis e.g. physical_network but the shared code can mathc on them","commit_id":"36fe17581dffa33d9b47fdf0eac6bf3738e35c93"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6aa96b5a52a7728179d13db97c49fdb3fc2ef605","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    def _filter_pools_for_spec(pools, request):"},{"line_number":239,"context_line":"        \"\"\"Filter out pools that don\u0027t match the request\u0027s device spec."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        Exclude pools that do not match the specified ``vendor_id``,"},{"line_number":242,"context_line":"        ``product_id`` and/or ``device_type`` specified in the alias config."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param pools: A list of PCI device pool dicts"},{"line_number":245,"context_line":"        :param request: An InstancePCIRequest object describing the type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d10bcab6_f284f0cf","line":242,"range":{"start_line":241,"start_character":55,"end_line":242,"end_character":45},"in_reply_to":"73efd441_b103c016","updated":"2020-11-27 17:57:47.000000000","message":"Fair point. I was thinking about this from the context of PCI alises, configured via \u0027[pci] alias\u0027, which only allow those two attributes. However, you can indeed configure more. Will update.","commit_id":"36fe17581dffa33d9b47fdf0eac6bf3738e35c93"}]}