)]}'
{"id":"openstack%2Fnova~764479","triplet_id":"openstack%2Fnova~stable%2Fpike~I83817f7301680801beaee375825f02eda526eda1","project":"openstack/nova","branch":"stable/pike","topic":"bug/1865040","hashtags":[],"change_id":"I83817f7301680801beaee375825f02eda526eda1","subject":"Validate id as integer for os-aggregates","status":"ABANDONED","created":"2020-11-27 17:15:45.000000000","updated":"2022-08-01 16:08:34.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c876d7d8a7515e6ec7f3448d5b89a3c9b49c2dc2","_number":764479,"virtual_id_number":764479,"owner":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-11-27 19:25:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-27 17:15:45.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"state":"REVIEWER"},{"updated":"2020-11-27 17:32:59.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2020-11-27 17:53:23.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-11-27 19:25:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aec7439ffd41c2d665e9df7fbecf5eff70ae53a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-11-27 17:15:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b1413335f8f3366151f77267581cd44eab72ba9","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-27 17:32:59.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/764479/1 : FAILURE in 16m 03s","accounts_in_message":[],"_revision_number":1},{"id":"1b94eb9233453499f34f07f9629df617155aa89e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-11-27 17:45:39.000000000","message":"Topic set to bug/1865040","accounts_in_message":[],"_revision_number":1},{"id":"175fdd2f0417de6851073329b551fab10ae55755","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-27 17:53:23.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/79/764479/1/check/tempest-dsvm-full-xenial/6a39579/ : FAILURE in 22m 25s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/79/764479/1/check/tempest-dsvm-full-xenial-py3/a933110/ : FAILURE in 23m 51s","accounts_in_message":[],"_revision_number":1},{"id":"d8af6748c92f54cb0021752d55abab424b4d471f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-27 19:25:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f7043ed5a5be48c6a1d8c6d6969d1cfb : FAILURE in 9m 03s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/710b1fee306741e1a93209dbb7c66366 : SUCCESS in 14m 53s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/27e4c4d4e9fb4b90a217c610d2063d80 : SUCCESS in 13m 25s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/4b4de4f9b9d342219f6959352e09997f : SUCCESS in 6m 21s\n- tempest-full https://zuul.opendev.org/t/openstack/build/39d8ebe6d5be4a6492c746c5bba757d0 : SUCCESS in 1h 32m 26s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/118f95701ffb4edd9f456d880dce0c65 : FAILURE in 40m 17s (non-voting)\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d33d53eb47ba43d4a439dfda08153ea3 : FAILURE in 41m 21s (non-voting)\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/af34c0907a2044a5b3c6e4d2021994c4 : FAILURE in 33m 26s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3ae1088f4afc420eb1328bbbf6ee817d : SUCCESS in 46m 11s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/c5c57985fc2d44a9b156d7a5f6bbca8d : FAILURE in 2h 03m 50s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b2d3c3232afb4edea8f303f638ae2b7d : SUCCESS in 22m 16s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/43881a2bbc8b4679a54c67aa91b3dcd5 : SUCCESS in 19m 09s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/3de9f860c4984f7ebf8c0fced6dd7de9 : FAILURE in 44m 55s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/614d2e5858ed402ea0707527ab312f41 : SUCCESS in 1h 34m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9623c0504e7eb157293b3834a3f943ef89b21288","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-05-26 08:56:11.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"07d925dcd02c66f1f9d8c0c9d609314570002879","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-26 09:40:12.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bec4e084cbf5491789f1718470771399 : FAILURE in 10m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/87a19df0ba6c48c28dffdec47bdfbeda : SUCCESS in 13m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a9059ebb7b2b4cb6965371df3588dbbb : SUCCESS in 17m 04s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/dec7af5874d045c6bf49e83d8b1ed715 : SUCCESS in 8m 35s\n- tempest-full https://zuul.opendev.org/t/openstack/build/40cacb62035e40c6bc04c962fd0e5c4c : FAILURE in 15m 03s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/a48740a10c384de486307a9c10fcc280 : FAILURE in 33m 22s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/72d301caa6744d15a80c1b78ce4601d1 : SUCCESS in 41m 31s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/4bfdb93d56ba4c7cb16eded19ec41095 : FAILURE in 16m 40s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/c38b1c49300a4132b195e252d87e3718 : SUCCESS in 20m 35s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/57c9a51140a64ae4b88118be5265aa66 : SUCCESS in 23m 27s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/05544ffdd3d648b5877b94bb4d4db3b1 : FAILURE in 16m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b6e9345358df900a9d1a745a9cbec320314a4922","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-05-26 09:53:14.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial finger://zuul-v3-executor.novalocal/b336d0de25bd441dbc55183b8cde655f : RETRY_LIMIT in 1m 12s\n- tempest-dsvm-full-xenial-py3 finger://zuul-v3-executor.novalocal/13c5849015524a318d1b6a5c4c172951 : POST_FAILURE in 24m 45s","accounts_in_message":[],"_revision_number":1},{"id":"c876d7d8a7515e6ec7f3448d5b89a3c9b49c2dc2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-08-01 16:08:34.000000000","message":"Abandoned\n\nstable/pike has transitioned to End of Life for nova, open patches need to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b69910b5e47178b51bd9316264c562e659aa2e7b","revisions":{"b69910b5e47178b51bd9316264c562e659aa2e7b":{"kind":"REWORK","_number":1,"created":"2020-11-27 17:15:45.000000000","uploader":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"ref":"refs/changes/79/764479/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/79/764479/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/764479/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/764479/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/79/764479/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/79/764479/1"}}},"commit":{"parents":[{"commit":"fcd1195b09017d59667cca76c33c1e5c5c8a4fc9","subject":"Follow up for cherry-pick check for merge patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fcd1195b09017d59667cca76c33c1e5c5c8a4fc9"}]}],"author":{"name":"Johannes Kulik","email":"johannes.kulik@sap.com","date":"2020-02-27 07:08:32.000000000","tz":60},"committer":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2020-11-27 17:13:49.000000000","tz":60},"subject":"Validate id as integer for os-aggregates","message":"Validate id as integer for os-aggregates\n\nAccording to the api-ref, the id passed to calls in os-aggregates is\nsupposed to be an integer. No function validated this, so any value\npassed to these functions would directly reach the DB. While this is\nfine for SQLite, making a query with a string for an integer column on\nother databases like PostgreSQL results in a DBError exception and thus\na HTTP 500 instead of 400 or 404.\n\nThis commit adds validation for the id parameter the same way it\u0027s\nalready done for other endpoints.\n\nConflicts:\n  nova/api/openstack/compute/aggregates.py\n\nNOTE(elod.illes): the conflict is due to patch\nI4802c5b38001a756448d4feb9ca336908821f591 (Remove extensions module) is\nmissing from stable/pike\n\nChange-Id: I83817f7301680801beaee375825f02eda526eda1\nCloses-Bug: 1865040\n(cherry picked from commit 2e70a1717f25652912886cbefa3f40e6df908c00)\n(cherry picked from commit 4653245ddcf989ebac4b964a41d881d78cf9ae2c)\n(cherry picked from commit 9448291d8f3ff6bef85d3bca4aa21c1e6036b3f1)\n(cherry picked from commit ad8aca7965dd7cc95e151056a74b63deecbe90a1)\n(cherry picked from commit 3d691d948e8d2c61a76602ad18f61475c0437a09)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b69910b5e47178b51bd9316264c562e659aa2e7b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b69910b5e47178b51bd9316264c562e659aa2e7b"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}