)]}'
{"id":"openstack%2Fnova~764626","triplet_id":"openstack%2Fnova~stable%2Fussuri~I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1899649","attention_set":{},"removed_from_attention_set":{"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2024-02-07 12:52:22.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c","subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","status":"ABANDONED","created":"2020-11-30 10:30:44.000000000","updated":"2024-02-07 12:52:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1d533775e8537b236888cb522051c798065e537b","_number":764626,"virtual_id_number":764626,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-09-08 13:44:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-30 14:06:39.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-11-30 15:32:04.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2020-11-30 16:59:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-07 12:52:22.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"1186727d4ac7ccea4f1feb52c66e548a0475a756","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-11-30 10:30:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4c48c6cd8ce8649705698bbcf991b0e7dcabdce","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-11-30 10:43:23.000000000","message":"Topic set to bug/1899649","accounts_in_message":[],"_revision_number":1},{"id":"9057faf309dd7bae5ba6234af1c7ffa0427a94b3","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-30 14:06:39.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/764626/1/check/tempest-dsvm-full-bionic/b9711db/ : SUCCESS in 2h 07m 12s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/764626/1/check/tempest-dsvm-full-bionic-py3/0dd73b8/ : SUCCESS in 1h 48m 19s","accounts_in_message":[],"_revision_number":1},{"id":"e9ec1317bd70a4cff9969709f47e1fdb290dfcfb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-11-30 14:51:58.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"5923197ecbfb28ee7d30e7ade43b03f87655c604","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-11-30 15:32:04.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/764626/2 : FAILURE in 37m 00s","accounts_in_message":[],"_revision_number":2},{"id":"75386a727e4fa8c95cb66bde7fa0d874b6650d28","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-30 16:59:22.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/944ea0defa774ce2808834b407c46f8b : SUCCESS in 1h 24m 33s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/7d5bc05b06a3414cbc19957963c359a3 : FAILURE in 16m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1a16955025f641979deb8e3d6b3e0b19 : SUCCESS in 15m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6f2c41ece09749e1aae9e1cd37b3b623 : SUCCESS in 15m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f01c2f0000594245bc89e745b9fa3aa1 : FAILURE in 6m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e16d20f8056d4b1a885726bf15ae5cb6 : SUCCESS in 11m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4f9d23324d2f40e197096ea844095f82 : SUCCESS in 13m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81f75f7ae1374f9dba371b2de4962ea0 : SUCCESS in 9m 56s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/a720200849e54a979faff1d7cd7b8407 : FAILURE in 17m 55s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/08a56fcda44d49cea1ecc7615d68ff7d : FAILURE in 17m 18s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/0c39581b6892439f8c889069bd873e48 : SUCCESS in 1h 34m 57s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/296dfb7d0d4e4b90ae86749bc3bc3a76 : FAILURE in 20m 36s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/9398272846df4a9fa5909b08dff5157b : FAILURE in 17m 54s\n- nova-next https://zuul.opendev.org/t/openstack/build/e27c1172f81f4e3794e264673de7049a : POST_FAILURE in 16m 31s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/1c5ab271c1214664be7a07da7caa7aa8 : SUCCESS in 18m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f4fe2508557649fd9d6d6048e4361429 : FAILURE in 12m 08s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/136b82052d564c7c9c34021868d17943 : POST_FAILURE in 12m 18s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/2f36e23fa5fa435ba04ea0d0b4e2358c : FAILURE in 12m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8c76bffa57c5db48ad853402db31fc5ad0027040","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-11-30 18:28:26.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/764626/2/check/tempest-dsvm-full-bionic/20753e4/ : FAILURE in 48m 50s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/764626/2/check/tempest-dsvm-full-bionic-py3/31408f7/ : FAILURE in 22m 47s","accounts_in_message":[],"_revision_number":2},{"id":"cc1708c2af2068eb2786968487a7601718a8bf6c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-09-08 11:51:19.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"4ba5bad5f8fdbf807d0d9d410545e04e173e341c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-08 13:44:58.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1644ba45156e4ee5b4346a786ca378bc : SUCCESS in 1h 34m 30s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/acc2bb5e1e0d4cb9a130334ffb364272 : SUCCESS in 16m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7611a4a684e045d69e5764fd2c00bce6 : SUCCESS in 15m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/06128e69b1504905909a565f62938cf7 : SUCCESS in 8m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f49673f93e744ca99fc2798761ac5dcc : SUCCESS in 12m 40s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/755d5d61e1f84a58998475c63cd48b63 : SUCCESS in 13m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f9082f9823b240a7b4bf1642e3b4333f : SUCCESS in 10m 15s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ad545919cb1a490e9a2834e111881249 : SUCCESS in 1h 08m 13s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/2182c7cb179e4eb89d5bb367a5a53454 : SUCCESS in 1h 47m 59s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/9595287c1dc144ca87750f75124d34fa : SUCCESS in 49m 33s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/0a224c1658384042858221841f1a3a0b : SUCCESS in 1h 18m 59s\n- nova-next https://zuul.opendev.org/t/openstack/build/14129d5ba97f4985b8cec6d232b4f8f4 : SUCCESS in 1h 28m 44s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/e1ca4bf739a34bab89929ac28f9adceb : SUCCESS in 17m 08s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/4db4d68a650b4239bf246e3daddc3a7a : FAILURE in 5m 47s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/c05168afaf9140f49fcb6410c0fdd6fd : SUCCESS in 1h 21m 18s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f79e08f705ab4c2289f69ee2424d996b : SUCCESS in 54m 14s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/076c5cde0f4e4c36ac3dd2b86621a1b0 : SUCCESS in 52m 12s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/a40470a548b9436baab27aea514f8f6d : SUCCESS in 34m 02s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"515f9f4b462f8226c1b9397930601a2ad6b000c4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-09-08 14:00:06.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/764626/3/check/tempest-dsvm-full-bionic/bb6e275/ : SUCCESS in 2h 03m 13s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/764626/3/check/tempest-dsvm-full-bionic-py3/dc27e33/ : SUCCESS in 1h 57m 10s","accounts_in_message":[],"_revision_number":3},{"id":"98becc6ec337af80da38d4680b10948a2be23080","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-09-08 14:54:35.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/764626/3/iscsi : SUCCESS in 2h 57m 16s","accounts_in_message":[],"_revision_number":3},{"id":"1d533775e8537b236888cb522051c798065e537b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-07 12:52:22.000000000","message":"Abandoned\n\nstable/ussuri branch of openstack/nova transitioned to End of Life and is about to be deleted. To be able to do that, all open patches need to be abandoned.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"bf901a3872e0205bb3266f0bfb9102a9560c6a05","revisions":{"7def447f635022bfd56626f9973b2da143bc6b85":{"kind":"REWORK","_number":1,"created":"2020-11-30 10:30:44.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/26/764626/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/26/764626/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/26/764626/1"}}},"commit":{"parents":[{"commit":"eb344638b38f641ebd43f5d565bc0851481fca0c","subject":"Add regression test for bug #1899649","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eb344638b38f641ebd43f5d565bc0851481fca0c"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-10-13 15:01:19.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-11-30 10:25:49.000000000","tz":0},"subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","message":"compute: Don\u0027t detach volumes when RescheduledException raised without retry\n\nI8b1c05317734e14ea73dc868941351bb31210bf0 introduced a crude call to\n_cleanup_volumes within _do_build_and_run_instance when handling a\nRescheduledException exception raised from _build_and_run_instance\nwithout any retry information provided from the scheduler.\n\nThis situation can arise when using the \u0027availability_zone\u0027 parameter to\nskip the scheduler by providing both a target availability_zone and host\nin the format of `$availability_zone:$host`. If the instance is unable\nto build on the compute the failure will eventually lead to\n_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either\ndetach (cinderv2) or delete the associated volume attachments (cinderv3)\nmoving the volume to an `available` state, assuming it isn\u0027t\nmulti-attached etc.\n\nThe issue with this is that this behaviour is in stark contrast to that\nof volumes associated with instances that have failed to schedule. In\nthat case the volumes remain marked as reserved and associated with the\nERROR\u0027d out instance until the instance itself is deleted.\n\nThis change aims to align both cases by removing the call to\n_cleanup_volumes and in doing so keeping any volumes in a `reserved`\nstate until the underlying instance is deleted.\n\nNote that leaving these volumes associated with ERROR\u0027d out instances is\nnow safe after I4dc6c8bd3bb6c135f8a698af41f5d0e026c39117 landed and now\nensures that ports and volumes associated with such an instance are\ncorrectly cleaned up.\n\nNOTE(lyarwood): Test conflict as Idb9a0c06d8abdb158bcee5be12c35dcb67257e60\nlanded on stable/victoria removing hooks from Nova and an associated\nmock from test_rescheduled_exception_without_retry.\n\nConflicts:\n  nova/tests/unit/compute/test_compute_mgr.py\n\nCloses-Bug: #1899649\nChange-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c\n(cherry picked from commit 26c46a409fa3a75f11fe0ecfc3cf1a8e77da8f51)\n(cherry picked from commit d0daac2c089b015c28e02e7965afdb22f08e42a1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7def447f635022bfd56626f9973b2da143bc6b85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7def447f635022bfd56626f9973b2da143bc6b85"}]},"branch":"refs/heads/stable/ussuri"},"643d01970ec2dc8e9c15612af7279f9a5df57745":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-11-30 14:51:58.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/26/764626/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/26/764626/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/26/764626/2"}}},"commit":{"parents":[{"commit":"b1812aa18db793b50a682b995e0ae24f6fe23cfa","subject":"Add regression test for bug #1899649","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b1812aa18db793b50a682b995e0ae24f6fe23cfa"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-10-13 15:01:19.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-11-30 14:51:37.000000000","tz":0},"subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","message":"compute: Don\u0027t detach volumes when RescheduledException raised without retry\n\nI8b1c05317734e14ea73dc868941351bb31210bf0 introduced a crude call to\n_cleanup_volumes within _do_build_and_run_instance when handling a\nRescheduledException exception raised from _build_and_run_instance\nwithout any retry information provided from the scheduler.\n\nThis situation can arise when using the \u0027availability_zone\u0027 parameter to\nskip the scheduler by providing both a target availability_zone and host\nin the format of `$availability_zone:$host`. If the instance is unable\nto build on the compute the failure will eventually lead to\n_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either\ndetach (cinderv2) or delete the associated volume attachments (cinderv3)\nmoving the volume to an `available` state, assuming it isn\u0027t\nmulti-attached etc.\n\nThe issue with this is that this behaviour is in stark contrast to that\nof volumes associated with instances that have failed to schedule. In\nthat case the volumes remain marked as reserved and associated with the\nERROR\u0027d out instance until the instance itself is deleted.\n\nThis change aims to align both cases by removing the call to\n_cleanup_volumes and in doing so keeping any volumes in a `reserved`\nstate until the underlying instance is deleted.\n\nNote that leaving these volumes associated with ERROR\u0027d out instances is\nnow safe after I4dc6c8bd3bb6c135f8a698af41f5d0e026c39117 landed and now\nensures that ports and volumes associated with such an instance are\ncorrectly cleaned up.\n\nNOTE(lyarwood): Test conflict as Idb9a0c06d8abdb158bcee5be12c35dcb67257e60\nlanded on stable/victoria removing hooks from Nova and an associated\nmock from test_rescheduled_exception_without_retry.\n\nConflicts:\n  nova/tests/unit/compute/test_compute_mgr.py\n\nCloses-Bug: #1899649\nChange-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c\n(cherry picked from commit 26c46a409fa3a75f11fe0ecfc3cf1a8e77da8f51)\n(cherry picked from commit d0daac2c089b015c28e02e7965afdb22f08e42a1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/643d01970ec2dc8e9c15612af7279f9a5df57745"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/643d01970ec2dc8e9c15612af7279f9a5df57745"}]},"branch":"refs/heads/stable/ussuri"},"bf901a3872e0205bb3266f0bfb9102a9560c6a05":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-09-08 11:51:19.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/26/764626/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/26/764626/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/764626/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/26/764626/3"}}},"commit":{"parents":[{"commit":"9b376d118c40e3b7e7a6583faa35ebae3de67260","subject":"Add regression test for bug #1899649","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b376d118c40e3b7e7a6583faa35ebae3de67260"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-10-13 15:01:19.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-09-08 11:51:19.000000000","tz":0},"subject":"compute: Don\u0027t detach volumes when RescheduledException raised without retry","message":"compute: Don\u0027t detach volumes when RescheduledException raised without retry\n\nI8b1c05317734e14ea73dc868941351bb31210bf0 introduced a crude call to\n_cleanup_volumes within _do_build_and_run_instance when handling a\nRescheduledException exception raised from _build_and_run_instance\nwithout any retry information provided from the scheduler.\n\nThis situation can arise when using the \u0027availability_zone\u0027 parameter to\nskip the scheduler by providing both a target availability_zone and host\nin the format of `$availability_zone:$host`. If the instance is unable\nto build on the compute the failure will eventually lead to\n_cleanup_volumes calling DriverVolumeBlockDevice.detach that will either\ndetach (cinderv2) or delete the associated volume attachments (cinderv3)\nmoving the volume to an `available` state, assuming it isn\u0027t\nmulti-attached etc.\n\nThe issue with this is that this behaviour is in stark contrast to that\nof volumes associated with instances that have failed to schedule. In\nthat case the volumes remain marked as reserved and associated with the\nERROR\u0027d out instance until the instance itself is deleted.\n\nThis change aims to align both cases by removing the call to\n_cleanup_volumes and in doing so keeping any volumes in a `reserved`\nstate until the underlying instance is deleted.\n\nNote that leaving these volumes associated with ERROR\u0027d out instances is\nnow safe after I4dc6c8bd3bb6c135f8a698af41f5d0e026c39117 landed and now\nensures that ports and volumes associated with such an instance are\ncorrectly cleaned up.\n\nNOTE(lyarwood): Test conflict as Idb9a0c06d8abdb158bcee5be12c35dcb67257e60\nlanded on stable/victoria removing hooks from Nova and an associated\nmock from test_rescheduled_exception_without_retry.\n\nConflicts:\n  nova/tests/unit/compute/test_compute_mgr.py\n\nCloses-Bug: #1899649\nChange-Id: I5dda9e8bca5fbaae77ece12b67176945ca4d9a4c\n(cherry picked from commit 26c46a409fa3a75f11fe0ecfc3cf1a8e77da8f51)\n(cherry picked from commit d0daac2c089b015c28e02e7965afdb22f08e42a1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bf901a3872e0205bb3266f0bfb9102a9560c6a05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bf901a3872e0205bb3266f0bfb9102a9560c6a05"}]},"branch":"refs/heads/stable/ussuri","description":"Rebase"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}