)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e65dd189cec4982a53e431a5519b1a0002ecd1c3","unresolved":true,"context_lines":[{"line_number":3367,"context_line":"        retry_countdown \u003d retry_interval"},{"line_number":3368,"context_line":""},{"line_number":3369,"context_line":"        start_time \u003d time.time()"},{"line_number":3370,"context_line":"        for sec in range(timeout):"},{"line_number":3371,"context_line":"            guest \u003d self._host.get_guest(instance)"},{"line_number":3372,"context_line":"            state \u003d guest.get_power_state(self._host)"},{"line_number":3373,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0f795245_05ff336e","line":3370,"range":{"start_line":3370,"start_character":7,"end_line":3370,"end_character":34},"updated":"2020-12-14 12:54:40.000000000","message":"can you make this a \"while True:\"","commit_id":"2d2c9c2ecce18ccb2760e183d9beef386a634cf8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e65dd189cec4982a53e431a5519b1a0002ecd1c3","unresolved":true,"context_lines":[{"line_number":3390,"context_line":"                # will get an exception when we call shutdown"},{"line_number":3391,"context_line":"                try:"},{"line_number":3392,"context_line":"                    LOG.debug(\"Instance in state %s after %d seconds - \""},{"line_number":3393,"context_line":"                              \"resending shutdown\", state, sec,"},{"line_number":3394,"context_line":"                              instance\u003dinstance)"},{"line_number":3395,"context_line":"                    guest.shutdown()"},{"line_number":3396,"context_line":"                except libvirt.libvirtError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b3eb76ba_f9ce4aa0","line":3393,"range":{"start_line":3393,"start_character":59,"end_line":3393,"end_character":62},"updated":"2020-12-14 12:54:40.000000000","message":"and replace this with \"time.time() - start_time\"\n\nthis way this acutlly be the correct time interval","commit_id":"2d2c9c2ecce18ccb2760e183d9beef386a634cf8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0e02f766b7221db63bd4399bb89c04acbdfc3b63","unresolved":true,"context_lines":[{"line_number":3364,"context_line":"        LOG.debug(\"Shutting down instance from state %s\", state,"},{"line_number":3365,"context_line":"                  instance\u003dinstance)"},{"line_number":3366,"context_line":"        guest.shutdown()"},{"line_number":3367,"context_line":"        retry_countdown \u003d retry_interval"},{"line_number":3368,"context_line":""},{"line_number":3369,"context_line":"        start_time \u003d time.time()"},{"line_number":3370,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9325ff3c_15fb3321","line":3367,"range":{"start_line":3367,"start_character":8,"end_line":3367,"end_character":40},"updated":"2020-12-21 13:43:46.000000000","message":"This is also wrong, retry_interval is the *interval* between attempts to shutdown the instance, not a counter.","commit_id":"4e8b49de40a6c3b30e50599c578654b4d9f39e22"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0e02f766b7221db63bd4399bb89c04acbdfc3b63","unresolved":true,"context_lines":[{"line_number":3366,"context_line":"        guest.shutdown()"},{"line_number":3367,"context_line":"        retry_countdown \u003d retry_interval"},{"line_number":3368,"context_line":""},{"line_number":3369,"context_line":"        start_time \u003d time.time()"},{"line_number":3370,"context_line":"        while True:"},{"line_number":3371,"context_line":""},{"line_number":3372,"context_line":"            guest \u003d self._host.get_guest(instance)"},{"line_number":3373,"context_line":"            state \u003d guest.get_power_state(self._host)"}],"source_content_type":"text/x-python","patch_set":5,"id":"daaba7bf_1f6134e2","line":3370,"range":{"start_line":3369,"start_character":0,"end_line":3370,"end_character":19},"updated":"2020-12-21 13:43:46.000000000","message":"As Matt suggested in the bug I would simply rewrite this using FixedIntervalWithTimeoutLoopingCall. I\u0027m not sure about his follow up comment in the bug as to me retry_interval is the time between attempts to shutdown the instance.","commit_id":"4e8b49de40a6c3b30e50599c578654b4d9f39e22"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0e02f766b7221db63bd4399bb89c04acbdfc3b63","unresolved":true,"context_lines":[{"line_number":3404,"context_line":"            else:"},{"line_number":3405,"context_line":"                retry_countdown -\u003d 1"},{"line_number":3406,"context_line":""},{"line_number":3407,"context_line":"            time.sleep(1)"},{"line_number":3408,"context_line":""},{"line_number":3409,"context_line":"        LOG.info(\"Instance failed to shutdown in %d seconds.\","},{"line_number":3410,"context_line":"                 timeout, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa4fba16_c3bf768b","line":3407,"range":{"start_line":3407,"start_character":12,"end_line":3407,"end_character":25},"updated":"2020-12-21 13:43:46.000000000","message":"We should be using retry_interval here instead of the hard coded 1.","commit_id":"4e8b49de40a6c3b30e50599c578654b4d9f39e22"}]}