)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fe6201cad34e08e025b88fac5acbe6e49e6995c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"350d73ec_cfc923ba","updated":"2022-02-14 17:59:29.000000000","message":"lgtm","commit_id":"5b21fd9e3fd147374d9835b52fe684c5961a00f8"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c425494413957422a2fe85536201a8f8cea6504a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"508a9c63_8eb9ca6d","updated":"2022-05-18 08:33:41.000000000","message":"recheck","commit_id":"b9eebf4f3478ce171c1985af083d11a73a23b5c8"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"715cfa686f2c733141be977696b0d910ca8496ba","unresolved":true,"context_lines":[{"line_number":393,"context_line":"    .. note::"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"       In microversion 2.88, we have removed this parameter, and replaced it"},{"line_number":396,"context_line":"       with ``all_projects``."},{"line_number":397,"context_line":"  in: query"},{"line_number":398,"context_line":"  required: false"},{"line_number":399,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"89bc9ea2_fd20536b","line":396,"updated":"2020-12-03 14:05:11.000000000","message":"This is only for os-fping that returns 404 since microversion 2.36 and removed in Rocky. So I don\u0027t think we need to update this any more. I would even remove the os-fping doc from our api ref but that might not be possible.","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"11c0e964b575ea32c7f84e16391579d7bc484caa","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    .. note::"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"       In microversion 2.88, we have removed this parameter, and replaced it"},{"line_number":396,"context_line":"       with ``all_projects``."},{"line_number":397,"context_line":"  in: query"},{"line_number":398,"context_line":"  required: false"},{"line_number":399,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"36975864_bfe405a8","line":396,"in_reply_to":"83526a65_6792a991","updated":"2020-12-06 04:56:24.000000000","message":"Done","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aca440d62770117704bc075e64fcc63123d55921","unresolved":true,"context_lines":[{"line_number":393,"context_line":"    .. note::"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"       In microversion 2.88, we have removed this parameter, and replaced it"},{"line_number":396,"context_line":"       with ``all_projects``."},{"line_number":397,"context_line":"  in: query"},{"line_number":398,"context_line":"  required: false"},{"line_number":399,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"83526a65_6792a991","line":396,"in_reply_to":"89bc9ea2_fd20536b","updated":"2020-12-03 15:18:56.000000000","message":"After talking with Stephen now I think we should not update this description at all. This description only document a code that is already deleted. The tenant_id change does not (cannot) affect a code that is already deleted.","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"af45966c2e295fe09d18755e6b7d97704cc0b712","unresolved":true,"context_lines":[{"line_number":431,"context_line":"  in: query"},{"line_number":432,"context_line":"  required: false"},{"line_number":433,"context_line":"  type: string"},{"line_number":434,"context_line":"all_projects_query:"},{"line_number":435,"context_line":"  description: |"},{"line_number":436,"context_line":"    Specify the ``all_projects`` query parameter to list all instances"},{"line_number":437,"context_line":"    for all projects. By default this is only allowed by administrators."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"65499bc4_b2c90276","line":434,"updated":"2020-12-07 00:57:13.000000000","message":"Move this to Line386","commit_id":"25dec495167c92bd994e48c8668c3c4145dd1319"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":405,"context_line":"  in: query"},{"line_number":406,"context_line":"  required: false"},{"line_number":407,"context_line":"  type: string"},{"line_number":408,"context_line":"all_tenants_query:"},{"line_number":409,"context_line":"  description: |"},{"line_number":410,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":411,"context_line":"    for all projects. By default this is only allowed by administrators."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"65a90558_91abcf9e","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":17},"updated":"2021-01-04 15:36:13.000000000","message":"Is this still referenced somewhere in the doc?","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fa9107a75bfa7a3c6a009428633e0deb7ca568c","unresolved":true,"context_lines":[{"line_number":405,"context_line":"  in: query"},{"line_number":406,"context_line":"  required: false"},{"line_number":407,"context_line":"  type: string"},{"line_number":408,"context_line":"all_tenants_query:"},{"line_number":409,"context_line":"  description: |"},{"line_number":410,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":411,"context_line":"    for all projects. By default this is only allowed by administrators."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c4c2d83f_008398d6","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":17},"in_reply_to":"65a90558_91abcf9e","updated":"2021-01-12 12:54:05.000000000","message":"yes, while I do the next patch, I also seen this has been used, so I would like to search in the end, if there is no used I can remove it in the end patch.","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":405,"context_line":"  in: query"},{"line_number":406,"context_line":"  required: false"},{"line_number":407,"context_line":"  type: string"},{"line_number":408,"context_line":"all_tenants_query:"},{"line_number":409,"context_line":"  description: |"},{"line_number":410,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":411,"context_line":"    for all projects. By default this is only allowed by administrators."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b3b131b1_513b3794","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":17},"updated":"2021-01-22 21:59:06.000000000","message":"you can change this itself by adding   max_version: 2.89 as this is only used for list server query.","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":405,"context_line":"  in: query"},{"line_number":406,"context_line":"  required: false"},{"line_number":407,"context_line":"  type: string"},{"line_number":408,"context_line":"all_tenants_query:"},{"line_number":409,"context_line":"  description: |"},{"line_number":410,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":411,"context_line":"    for all projects. By default this is only allowed by administrators."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"078ae975_e5ee5d9a","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":17},"in_reply_to":"b3b131b1_513b3794","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee36bea4481e43defe59b053ef49dfe85ef47ae4","unresolved":true,"context_lines":[{"line_number":405,"context_line":"  in: query"},{"line_number":406,"context_line":"  required: false"},{"line_number":407,"context_line":"  type: string"},{"line_number":408,"context_line":"all_tenants_query:"},{"line_number":409,"context_line":"  description: |"},{"line_number":410,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":411,"context_line":"    for all projects. By default this is only allowed by administrators."},{"line_number":412,"context_line":"    If the value of this parameter is not specified, it is treated as"},{"line_number":413,"context_line":"    ``True``. If the value is specified, ``1``, ``t``, ``true``,"},{"line_number":414,"context_line":"    ``on``, ``y`` and ``yes`` are treated as ``True``. ``0``, ``f``,"},{"line_number":415,"context_line":"    ``false``, ``off``, ``n`` and ``no`` are treated as ``False``."},{"line_number":416,"context_line":"    (They are case-insensitive.)"},{"line_number":417,"context_line":"  in: query"},{"line_number":418,"context_line":"  required: false"},{"line_number":419,"context_line":"  type: boolean"},{"line_number":420,"context_line":"  max_version: 2.89"},{"line_number":421,"context_line":"all_tenants_query_2_89:"},{"line_number":422,"context_line":"  description: |"},{"line_number":423,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"4cdc8704_4792eb9b","line":420,"range":{"start_line":408,"start_character":0,"end_line":420,"end_character":19},"updated":"2021-01-27 23:14:01.000000000","message":"if yoou are keeping all_tenants_query_2_89 then this one can be remove completely.","commit_id":"ee24fa8b090ef16bd3a5af23e46f354bf5b658e2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"02f5a43c22ac24955809af7b9da32a1eceddc396","unresolved":false,"context_lines":[{"line_number":405,"context_line":"  in: query"},{"line_number":406,"context_line":"  required: false"},{"line_number":407,"context_line":"  type: string"},{"line_number":408,"context_line":"all_tenants_query:"},{"line_number":409,"context_line":"  description: |"},{"line_number":410,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":411,"context_line":"    for all projects. By default this is only allowed by administrators."},{"line_number":412,"context_line":"    If the value of this parameter is not specified, it is treated as"},{"line_number":413,"context_line":"    ``True``. If the value is specified, ``1``, ``t``, ``true``,"},{"line_number":414,"context_line":"    ``on``, ``y`` and ``yes`` are treated as ``True``. ``0``, ``f``,"},{"line_number":415,"context_line":"    ``false``, ``off``, ``n`` and ``no`` are treated as ``False``."},{"line_number":416,"context_line":"    (They are case-insensitive.)"},{"line_number":417,"context_line":"  in: query"},{"line_number":418,"context_line":"  required: false"},{"line_number":419,"context_line":"  type: boolean"},{"line_number":420,"context_line":"  max_version: 2.89"},{"line_number":421,"context_line":"all_tenants_query_2_89:"},{"line_number":422,"context_line":"  description: |"},{"line_number":423,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"e93d1043_1189acfb","line":420,"range":{"start_line":408,"start_character":0,"end_line":420,"end_character":19},"in_reply_to":"4cdc8704_4792eb9b","updated":"2021-02-02 13:07:36.000000000","message":"Done","commit_id":"ee24fa8b090ef16bd3a5af23e46f354bf5b658e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45b8181180f461ee1d1bd40b544081b85fb8ddf0","unresolved":true,"context_lines":[{"line_number":415,"context_line":"    ``false``, ``off``, ``n`` and ``no`` are treated as ``False``."},{"line_number":416,"context_line":"    (They are case-insensitive.)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    .. note::"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"       In microversion 2.90, we have removed this parameter, and replaced it"},{"line_number":421,"context_line":"       with ``all_projects``."},{"line_number":422,"context_line":"  in: query"},{"line_number":423,"context_line":"  required: false"},{"line_number":424,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"fc1a3e0c_c3848bea","line":421,"range":{"start_line":418,"start_character":1,"end_line":421,"end_character":29},"updated":"2021-02-25 00:22:30.000000000","message":"max_version: 2.89 reflect this but I am ok with this keep extra note too which is I think is more eye catching than max_version :)","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"}],"nova/api/openstack/common.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"715cfa686f2c733141be977696b0d910ca8496ba","unresolved":true,"context_lines":[{"line_number":497,"context_line":"        raise exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"def is_all_projects(search_opts, tenants_or_projects\u003dNone):"},{"line_number":501,"context_line":"    \"\"\"Checks to see if the all_projects flag is in search_opts"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    After microversion 2.88 from Wallaby(23.0.0) release, we have replaced"}],"source_content_type":"text/x-python","patch_set":1,"id":"74732999_8d034ddd","line":500,"range":{"start_line":500,"start_character":53,"end_line":500,"end_character":57},"updated":"2020-12-03 14:05:11.000000000","message":"I would make it non defaulted as it is always used below","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"11c0e964b575ea32c7f84e16391579d7bc484caa","unresolved":true,"context_lines":[{"line_number":497,"context_line":"        raise exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"def is_all_projects(search_opts, tenants_or_projects\u003dNone):"},{"line_number":501,"context_line":"    \"\"\"Checks to see if the all_projects flag is in search_opts"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    After microversion 2.88 from Wallaby(23.0.0) release, we have replaced"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf3006ea_0d923165","line":500,"range":{"start_line":500,"start_character":53,"end_line":500,"end_character":57},"in_reply_to":"74732999_8d034ddd","updated":"2020-12-06 04:56:24.000000000","message":"Yes, it couldnot be set to default None.","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"715cfa686f2c733141be977696b0d910ca8496ba","unresolved":true,"context_lines":[{"line_number":507,"context_line":"    :param string tenants_or_projects: \u0027all_projects\u0027 or \u0027all_projects\u0027"},{"line_number":508,"context_line":"    :returns: boolean indicating if all_projects are being requested or not"},{"line_number":509,"context_line":"    \"\"\""},{"line_number":510,"context_line":"    all_projects \u003d search_opts.get(tenants_or_projects)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    if all_projects:"},{"line_number":513,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9cca4028_c56c3a15","line":510,"range":{"start_line":510,"start_character":34,"end_line":510,"end_character":55},"updated":"2020-12-03 14:05:11.000000000","message":"It could be now search_opts.get(None) if tenants_or_projects is not specified by the caller.","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"11c0e964b575ea32c7f84e16391579d7bc484caa","unresolved":false,"context_lines":[{"line_number":507,"context_line":"    :param string tenants_or_projects: \u0027all_projects\u0027 or \u0027all_projects\u0027"},{"line_number":508,"context_line":"    :returns: boolean indicating if all_projects are being requested or not"},{"line_number":509,"context_line":"    \"\"\""},{"line_number":510,"context_line":"    all_projects \u003d search_opts.get(tenants_or_projects)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    if all_projects:"},{"line_number":513,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"938c42f5_727c3c1e","line":510,"range":{"start_line":510,"start_character":34,"end_line":510,"end_character":55},"in_reply_to":"9cca4028_c56c3a15","updated":"2020-12-06 04:56:24.000000000","message":"Done","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":503,"context_line":"    \u0027all_tenants\u0027 with \u0027all_projects\u0027."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    :param dict search_opts: The search options for a request"},{"line_number":506,"context_line":"    :param string tenants_or_projects: \u0027all_projects\u0027 or \u0027all_projects\u0027"},{"line_number":507,"context_line":"    :returns: boolean indicating if all_projects are being requested or not"},{"line_number":508,"context_line":"    \"\"\""},{"line_number":509,"context_line":"    all_projects \u003d search_opts.get(tenants_or_projects)"}],"source_content_type":"text/x-python","patch_set":9,"id":"02170339_1e86ae1f","line":506,"range":{"start_line":506,"start_character":39,"end_line":506,"end_character":71},"updated":"2021-01-04 15:36:13.000000000","message":"I guess one of these meant to be \u0027all_tenants\u0027","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fa9107a75bfa7a3c6a009428633e0deb7ca568c","unresolved":true,"context_lines":[{"line_number":503,"context_line":"    \u0027all_tenants\u0027 with \u0027all_projects\u0027."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"    :param dict search_opts: The search options for a request"},{"line_number":506,"context_line":"    :param string tenants_or_projects: \u0027all_projects\u0027 or \u0027all_projects\u0027"},{"line_number":507,"context_line":"    :returns: boolean indicating if all_projects are being requested or not"},{"line_number":508,"context_line":"    \"\"\""},{"line_number":509,"context_line":"    all_projects \u003d search_opts.get(tenants_or_projects)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f94475e_923a32e5","line":506,"range":{"start_line":506,"start_character":39,"end_line":506,"end_character":71},"in_reply_to":"02170339_1e86ae1f","updated":"2021-01-12 12:54:05.000000000","message":"yes","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45b8181180f461ee1d1bd40b544081b85fb8ddf0","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        raise exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"def is_all_projects(search_opts, tenants_or_projects):"},{"line_number":500,"context_line":"    \"\"\"Checks to see if the all_projects flag is in search_opts"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    After microversion 2.90 from Wallaby(23.0.0) release, we have replaced"}],"source_content_type":"text/x-python","patch_set":16,"id":"b365b05d_356098a9","line":499,"range":{"start_line":499,"start_character":33,"end_line":499,"end_character":52},"updated":"2021-02-25 00:22:30.000000000","message":"this seems like we are passing project or tenant. Let\u0027s name this as opt_name which can be \u0027all_tenants\u0027 for older microversion and \u0027all_projects\u0027 for newer.","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"16bd31772c172d9e2dffe8c73976f6e925d0d6fe","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        raise exc.HTTPNotFound(explanation\u003derror.format_message())"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"def is_all_projects(search_opts, tenants_or_projects):"},{"line_number":500,"context_line":"    \"\"\"Checks to see if the all_projects flag is in search_opts"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    After microversion 2.90 from Wallaby(23.0.0) release, we have replaced"}],"source_content_type":"text/x-python","patch_set":16,"id":"7e119fa7_b1cfbee0","line":499,"range":{"start_line":499,"start_character":33,"end_line":499,"end_character":52},"in_reply_to":"b365b05d_356098a9","updated":"2021-03-01 06:55:04.000000000","message":"Done","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"* ``GET /servers``"},{"line_number":1151,"context_line":"* ``GET /servers/detail``"},{"line_number":1152,"context_line":"* ``PUT /servers/{server_id}``"}],"source_content_type":"text/x-rst","patch_set":9,"id":"a0525dcc_319879b2","line":1152,"updated":"2021-01-04 15:36:13.000000000","message":"Add the List Server APIs to this list and then you don\u0027t have to change the heading of this list at all.","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fa9107a75bfa7a3c6a009428633e0deb7ca568c","unresolved":true,"context_lines":[{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"* ``GET /servers``"},{"line_number":1151,"context_line":"* ``GET /servers/detail``"},{"line_number":1152,"context_line":"* ``PUT /servers/{server_id}``"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff3f4fe4_53721969","line":1152,"in_reply_to":"a0525dcc_319879b2","updated":"2021-01-12 12:54:05.000000000","message":"Yeah, whether is ok:D.","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":1144,"context_line":"2.88"},{"line_number":1145,"context_line":"----"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":1148,"context_line":"The following fields are no longer included in responses for the"},{"line_number":1149,"context_line":"``GET /os-hypervisors/detail`` and ``GET /os-hypervisors/{hypervisor_id}``"},{"line_number":1150,"context_line":"APIs:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"72ffce58_22c41415","line":1147,"range":{"start_line":1147,"start_character":0,"end_line":1147,"end_character":12},"updated":"2021-01-22 21:59:06.000000000","message":"oops, rebase left over.","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"2.88"},{"line_number":1145,"context_line":"----"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":1148,"context_line":"The following fields are no longer included in responses for the"},{"line_number":1149,"context_line":"``GET /os-hypervisors/detail`` and ``GET /os-hypervisors/{hypervisor_id}``"},{"line_number":1150,"context_line":"APIs:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e37768c1_da910a81","line":1147,"range":{"start_line":1147,"start_character":0,"end_line":1147,"end_character":12},"in_reply_to":"72ffce58_22c41415","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"715cfa686f2c733141be977696b0d910ca8496ba","unresolved":true,"context_lines":[{"line_number":341,"context_line":"                    search_opts\u003dsearch_opts, limit\u003dlimit, marker\u003dmarker,"},{"line_number":342,"context_line":"                    expected_attrs\u003dexpected_attrs, sort_keys\u003dsort_keys,"},{"line_number":343,"context_line":"                    sort_dirs\u003dsort_dirs, cell_down_support\u003dcell_down_support,"},{"line_number":344,"context_line":"                    all_tenants\u003dall_projects)"},{"line_number":345,"context_line":"        except exception.MarkerNotFound:"},{"line_number":346,"context_line":"            msg \u003d _(\u0027marker [%s] not found\u0027) % marker"},{"line_number":347,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c825542_b683bd8d","line":344,"range":{"start_line":344,"start_character":20,"end_line":344,"end_character":31},"updated":"2020-12-03 14:05:11.000000000","message":"renaming this could be done later separately without api impact","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"11c0e964b575ea32c7f84e16391579d7bc484caa","unresolved":true,"context_lines":[{"line_number":341,"context_line":"                    search_opts\u003dsearch_opts, limit\u003dlimit, marker\u003dmarker,"},{"line_number":342,"context_line":"                    expected_attrs\u003dexpected_attrs, sort_keys\u003dsort_keys,"},{"line_number":343,"context_line":"                    sort_dirs\u003dsort_dirs, cell_down_support\u003dcell_down_support,"},{"line_number":344,"context_line":"                    all_tenants\u003dall_projects)"},{"line_number":345,"context_line":"        except exception.MarkerNotFound:"},{"line_number":346,"context_line":"            msg \u003d _(\u0027marker [%s] not found\u0027) % marker"},{"line_number":347,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5df202a7_be25df4d","line":344,"range":{"start_line":344,"start_character":20,"end_line":344,"end_character":31},"in_reply_to":"6c825542_b683bd8d","updated":"2020-12-06 04:56:24.000000000","message":"Yes, this is also my decision, after I updated all api changes, then rename this parameter.","commit_id":"495a372f3f9474a35d72f9fbc9b113106aea7ebe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":283,"context_line":"                    search_opts[tag_filter] \u003d search_opts["},{"line_number":284,"context_line":"                        tag_filter].split(\u0027,\u0027)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        # use the boolean from here on out so remove the entry from search_opts"},{"line_number":287,"context_line":"        # if it\u0027s present."},{"line_number":288,"context_line":"        # NOTE(tssurya): In case we support handling down cells"},{"line_number":289,"context_line":"        # we need to know further down the stack whether the \u0027all_tenants\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"eefd3704_42d71d40","line":286,"range":{"start_line":286,"start_character":10,"end_line":286,"end_character":35},"updated":"2021-01-04 15:36:13.000000000","message":"use the all_projects boolean from here","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            # request."},{"line_number":170,"context_line":"            pag_sort \u003d any("},{"line_number":171,"context_line":"                ps in req.GET.keys() for ps in PAGING_SORTING_PARAMS)"},{"line_number":172,"context_line":"            if api_version_request.is_supported(req, max_version\u003d\u00272.87\u0027):"},{"line_number":173,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":174,"context_line":"                # allowed filter exception when handling down cells."},{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("}],"source_content_type":"text/x-python","patch_set":11,"id":"07f9292f_763f4ca1","line":172,"range":{"start_line":172,"start_character":68,"end_line":172,"end_character":70},"updated":"2021-01-22 21:59:06.000000000","message":"2.89 now","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # request."},{"line_number":170,"context_line":"            pag_sort \u003d any("},{"line_number":171,"context_line":"                ps in req.GET.keys() for ps in PAGING_SORTING_PARAMS)"},{"line_number":172,"context_line":"            if api_version_request.is_supported(req, max_version\u003d\u00272.87\u0027):"},{"line_number":173,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":174,"context_line":"                # allowed filter exception when handling down cells."},{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("}],"source_content_type":"text/x-python","patch_set":11,"id":"ce526b91_505868d9","line":172,"range":{"start_line":172,"start_character":68,"end_line":172,"end_character":70},"in_reply_to":"07f9292f_763f4ca1","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":176,"context_line":"                    [u\u0027all_tenants\u0027], [])"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                # Since microversion 2.88, we replaced \u0027all_tenants\u0027 with"},{"line_number":179,"context_line":"                # \u0027all_projects\u0027, so, the reason is the same as above."},{"line_number":180,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":181,"context_line":"                    [u\u0027all_projects\u0027], [])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7b47c060_d59c879b","line":178,"range":{"start_line":178,"start_character":37,"end_line":178,"end_character":41},"updated":"2021-01-22 21:59:06.000000000","message":"2.90","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":176,"context_line":"                    [u\u0027all_tenants\u0027], [])"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                # Since microversion 2.88, we replaced \u0027all_tenants\u0027 with"},{"line_number":179,"context_line":"                # \u0027all_projects\u0027, so, the reason is the same as above."},{"line_number":180,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":181,"context_line":"                    [u\u0027all_projects\u0027], [])"}],"source_content_type":"text/x-python","patch_set":11,"id":"32667c2d_2affa7c7","line":178,"range":{"start_line":178,"start_character":37,"end_line":178,"end_character":41},"in_reply_to":"7b47c060_d59c879b","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        # further down the stack."},{"line_number":292,"context_line":"        # NOTE(brinzhang): Since microversion 2.88, we have replaced"},{"line_number":293,"context_line":"        # \u0027all_tenants\u0027 with \u0027all_projects\u0027."},{"line_number":294,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.88\u0027):"},{"line_number":295,"context_line":"            all_projects \u003d common.is_all_projects(search_opts, \u0027all_projects\u0027)"},{"line_number":296,"context_line":"            search_opts.pop(\u0027all_projects\u0027, None)"},{"line_number":297,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5dd8464f_d3858ba1","line":294,"range":{"start_line":294,"start_character":62,"end_line":294,"end_character":66},"updated":"2021-01-22 21:59:06.000000000","message":"ditto about new microversion number now","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        # further down the stack."},{"line_number":292,"context_line":"        # NOTE(brinzhang): Since microversion 2.88, we have replaced"},{"line_number":293,"context_line":"        # \u0027all_tenants\u0027 with \u0027all_projects\u0027."},{"line_number":294,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.88\u0027):"},{"line_number":295,"context_line":"            all_projects \u003d common.is_all_projects(search_opts, \u0027all_projects\u0027)"},{"line_number":296,"context_line":"            search_opts.pop(\u0027all_projects\u0027, None)"},{"line_number":297,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bccf0344_35870547","line":294,"range":{"start_line":294,"start_character":62,"end_line":294,"end_character":66},"in_reply_to":"5dd8464f_d3858ba1","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":347,"context_line":"                    search_opts\u003dsearch_opts, limit\u003dlimit, marker\u003dmarker,"},{"line_number":348,"context_line":"                    expected_attrs\u003dexpected_attrs, sort_keys\u003dsort_keys,"},{"line_number":349,"context_line":"                    sort_dirs\u003dsort_dirs, cell_down_support\u003dcell_down_support,"},{"line_number":350,"context_line":"                    all_tenants\u003dall_projects)"},{"line_number":351,"context_line":"        except exception.MarkerNotFound:"},{"line_number":352,"context_line":"            msg \u003d _(\u0027marker [%s] not found\u0027) % marker"},{"line_number":353,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7b2b259c_711004da","line":350,"range":{"start_line":350,"start_character":20,"end_line":350,"end_character":31},"updated":"2021-01-22 21:59:06.000000000","message":"are you going to replace it in separate patch?","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":true,"context_lines":[{"line_number":347,"context_line":"                    search_opts\u003dsearch_opts, limit\u003dlimit, marker\u003dmarker,"},{"line_number":348,"context_line":"                    expected_attrs\u003dexpected_attrs, sort_keys\u003dsort_keys,"},{"line_number":349,"context_line":"                    sort_dirs\u003dsort_dirs, cell_down_support\u003dcell_down_support,"},{"line_number":350,"context_line":"                    all_tenants\u003dall_projects)"},{"line_number":351,"context_line":"        except exception.MarkerNotFound:"},{"line_number":352,"context_line":"            msg \u003d _(\u0027marker [%s] not found\u0027) % marker"},{"line_number":353,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":11,"id":"11996fb9_de6b87ed","line":350,"range":{"start_line":350,"start_character":20,"end_line":350,"end_character":31},"in_reply_to":"7b2b259c_711004da","updated":"2021-01-25 12:32:50.000000000","message":"Yes, separate in https://review.opendev.org/c/openstack/nova/+/769329","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":1301,"context_line":"                         \u0027user_id\u0027,)"},{"line_number":1302,"context_line":"        if api_version_request.is_supported(req, max_version\u003d\u00272.89\u0027):"},{"line_number":1303,"context_line":"            opt_list +\u003d (\u0027all_tenants\u0027,)"},{"line_number":1304,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.90\u0027):"},{"line_number":1305,"context_line":"            opt_list +\u003d (\u0027project_id\u0027, \u0027all_projects\u0027,)"},{"line_number":1306,"context_line":"        return opt_list"},{"line_number":1307,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff91f036_402c9b07","line":1304,"range":{"start_line":1304,"start_character":8,"end_line":1304,"end_character":69},"updated":"2021-01-22 21:59:06.000000000","message":"this can be else condition.","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"                         \u0027user_id\u0027,)"},{"line_number":1302,"context_line":"        if api_version_request.is_supported(req, max_version\u003d\u00272.89\u0027):"},{"line_number":1303,"context_line":"            opt_list +\u003d (\u0027all_tenants\u0027,)"},{"line_number":1304,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.90\u0027):"},{"line_number":1305,"context_line":"            opt_list +\u003d (\u0027project_id\u0027, \u0027all_projects\u0027,)"},{"line_number":1306,"context_line":"        return opt_list"},{"line_number":1307,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5d86ad63_cfa02743","line":1304,"range":{"start_line":1304,"start_character":8,"end_line":1304,"end_character":69},"in_reply_to":"ff91f036_402c9b07","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45b8181180f461ee1d1bd40b544081b85fb8ddf0","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            # request."},{"line_number":170,"context_line":"            pag_sort \u003d any("},{"line_number":171,"context_line":"                ps in req.GET.keys() for ps in PAGING_SORTING_PARAMS)"},{"line_number":172,"context_line":"            if api_version_request.is_supported(req, max_version\u003d\u00272.89\u0027):"},{"line_number":173,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":174,"context_line":"                # allowed filter exception when handling down cells."},{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("}],"source_content_type":"text/x-python","patch_set":16,"id":"72f9fe9f_119a339c","line":172,"range":{"start_line":172,"start_character":53,"end_line":172,"end_character":71},"updated":"2021-02-25 00:22:30.000000000","message":"let\u0027s keep consistent to other checks min_version\u003d\u00272.90\u0027 and move current else part here.","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"16bd31772c172d9e2dffe8c73976f6e925d0d6fe","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # request."},{"line_number":170,"context_line":"            pag_sort \u003d any("},{"line_number":171,"context_line":"                ps in req.GET.keys() for ps in PAGING_SORTING_PARAMS)"},{"line_number":172,"context_line":"            if api_version_request.is_supported(req, max_version\u003d\u00272.89\u0027):"},{"line_number":173,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":174,"context_line":"                # allowed filter exception when handling down cells."},{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("}],"source_content_type":"text/x-python","patch_set":16,"id":"c3aaf97b_d7969f6f","line":172,"range":{"start_line":172,"start_character":53,"end_line":172,"end_character":71},"in_reply_to":"72f9fe9f_119a339c","updated":"2021-03-01 06:55:04.000000000","message":"Done","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45b8181180f461ee1d1bd40b544081b85fb8ddf0","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        # further down the stack."},{"line_number":292,"context_line":"        # NOTE(brinzhang): Since microversion 2.90, we have replaced"},{"line_number":293,"context_line":"        # \u0027all_tenants\u0027 with \u0027all_projects\u0027."},{"line_number":294,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.90\u0027):"},{"line_number":295,"context_line":"            all_projects \u003d common.is_all_projects(search_opts, \u0027all_projects\u0027)"},{"line_number":296,"context_line":"            search_opts.pop(\u0027all_projects\u0027, None)"},{"line_number":297,"context_line":"        else:"},{"line_number":298,"context_line":"            all_projects \u003d common.is_all_projects(search_opts, \u0027all_tenants\u0027)"},{"line_number":299,"context_line":"            search_opts.pop(\u0027all_tenants\u0027, None)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if \u0027locked\u0027 in search_opts:"},{"line_number":302,"context_line":"            search_opts[\u0027locked\u0027] \u003d common.is_locked(search_opts)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ec02d982_a2721feb","line":299,"range":{"start_line":294,"start_character":0,"end_line":299,"end_character":48},"updated":"2021-02-25 00:22:30.000000000","message":"or make it more simple and easy to distinguish the difference. \n\n        opt_name \u003d \u0027all_tenants\u0027\n        if api_version_request.is_supported(req, min_version\u003d\u00272.90\u0027):\n            opt_name \u003d \u0027all_projects\u0027\n        all_projects \u003d common.is_all_projects(search_opts, opt_name )\n        search_opts.pop(opt_name, None)","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"16bd31772c172d9e2dffe8c73976f6e925d0d6fe","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        # further down the stack."},{"line_number":292,"context_line":"        # NOTE(brinzhang): Since microversion 2.90, we have replaced"},{"line_number":293,"context_line":"        # \u0027all_tenants\u0027 with \u0027all_projects\u0027."},{"line_number":294,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.90\u0027):"},{"line_number":295,"context_line":"            all_projects \u003d common.is_all_projects(search_opts, \u0027all_projects\u0027)"},{"line_number":296,"context_line":"            search_opts.pop(\u0027all_projects\u0027, None)"},{"line_number":297,"context_line":"        else:"},{"line_number":298,"context_line":"            all_projects \u003d common.is_all_projects(search_opts, \u0027all_tenants\u0027)"},{"line_number":299,"context_line":"            search_opts.pop(\u0027all_tenants\u0027, None)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if \u0027locked\u0027 in search_opts:"},{"line_number":302,"context_line":"            search_opts[\u0027locked\u0027] \u003d common.is_locked(search_opts)"}],"source_content_type":"text/x-python","patch_set":16,"id":"aec2f478_65e48c63","line":299,"range":{"start_line":294,"start_character":0,"end_line":299,"end_character":48},"in_reply_to":"ec02d982_a2721feb","updated":"2021-03-01 06:55:04.000000000","message":"Done, it\u0027s nice to change and easy to know what difference of this.","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"45b8181180f461ee1d1bd40b544081b85fb8ddf0","unresolved":true,"context_lines":[{"line_number":1298,"context_line":"                         \u0027created_at\u0027, \u0027launched_at\u0027, \u0027terminated_at\u0027,"},{"line_number":1299,"context_line":"                         \u0027power_state\u0027, \u0027task_state\u0027, \u0027vm_state\u0027, \u0027progress\u0027,"},{"line_number":1300,"context_line":"                         \u0027user_id\u0027,)"},{"line_number":1301,"context_line":"        if api_version_request.is_supported(req, max_version\u003d\u00272.89\u0027):"},{"line_number":1302,"context_line":"            opt_list +\u003d (\u0027all_tenants\u0027,)"},{"line_number":1303,"context_line":"        else:"},{"line_number":1304,"context_line":"            opt_list +\u003d (\u0027all_projects\u0027,)"}],"source_content_type":"text/x-python","patch_set":16,"id":"4d8fce6a_d9f3e6d8","line":1301,"range":{"start_line":1301,"start_character":49,"end_line":1301,"end_character":67},"updated":"2021-02-25 00:22:30.000000000","message":"ditto, let\u0027s do min_version\u003d\u00272.90\u0027 first","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"16bd31772c172d9e2dffe8c73976f6e925d0d6fe","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                         \u0027created_at\u0027, \u0027launched_at\u0027, \u0027terminated_at\u0027,"},{"line_number":1299,"context_line":"                         \u0027power_state\u0027, \u0027task_state\u0027, \u0027vm_state\u0027, \u0027progress\u0027,"},{"line_number":1300,"context_line":"                         \u0027user_id\u0027,)"},{"line_number":1301,"context_line":"        if api_version_request.is_supported(req, max_version\u003d\u00272.89\u0027):"},{"line_number":1302,"context_line":"            opt_list +\u003d (\u0027all_tenants\u0027,)"},{"line_number":1303,"context_line":"        else:"},{"line_number":1304,"context_line":"            opt_list +\u003d (\u0027all_projects\u0027,)"}],"source_content_type":"text/x-python","patch_set":16,"id":"903b8918_b14118c2","line":1301,"range":{"start_line":1301,"start_character":49,"end_line":1301,"end_character":67},"in_reply_to":"4d8fce6a_d9f3e6d8","updated":"2021-03-01 06:55:04.000000000","message":"Done","commit_id":"2b01bb253ddb752297c531b1dcdb13441b8e6968"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ed120dc3fdf5dbdeff0b18a4db392feb9d3db9a","unresolved":true,"context_lines":[{"line_number":1299,"context_line":"                         \u0027created_at\u0027, \u0027launched_at\u0027, \u0027terminated_at\u0027,"},{"line_number":1300,"context_line":"                         \u0027power_state\u0027, \u0027task_state\u0027, \u0027vm_state\u0027, \u0027progress\u0027,"},{"line_number":1301,"context_line":"                         \u0027user_id\u0027,)"},{"line_number":1302,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.88\u0027):"},{"line_number":1303,"context_line":"            opt_list +\u003d (\u0027all_projects\u0027,)"},{"line_number":1304,"context_line":"        else:"},{"line_number":1305,"context_line":"            opt_list +\u003d (\u0027all_tenants\u0027,)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae6a58c_17bad89e","line":1302,"range":{"start_line":1302,"start_character":62,"end_line":1302,"end_character":66},"updated":"2021-05-21 01:28:58.000000000","message":"it needs to be 2.89 as you are using min_version here","commit_id":"f357bd5859727a1a2a724c25cfc318c4f1c68d72"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f36c3b734f8944f4083f27ce3cbade1f4a48f885","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"                         \u0027created_at\u0027, \u0027launched_at\u0027, \u0027terminated_at\u0027,"},{"line_number":1300,"context_line":"                         \u0027power_state\u0027, \u0027task_state\u0027, \u0027vm_state\u0027, \u0027progress\u0027,"},{"line_number":1301,"context_line":"                         \u0027user_id\u0027,)"},{"line_number":1302,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.88\u0027):"},{"line_number":1303,"context_line":"            opt_list +\u003d (\u0027all_projects\u0027,)"},{"line_number":1304,"context_line":"        else:"},{"line_number":1305,"context_line":"            opt_list +\u003d (\u0027all_tenants\u0027,)"}],"source_content_type":"text/x-python","patch_set":20,"id":"d0af4df2_fbe12650","line":1302,"range":{"start_line":1302,"start_character":62,"end_line":1302,"end_character":66},"in_reply_to":"dae6a58c_17bad89e","updated":"2021-05-21 06:58:52.000000000","message":"Done","commit_id":"f357bd5859727a1a2a724c25cfc318c4f1c68d72"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":173,"context_line":"                # Since microversion 2.89, we replaced \u0027all_tenants\u0027 with"},{"line_number":174,"context_line":"                # \u0027all_projects\u0027, so, the reason is the same as above."},{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":176,"context_line":"                    [u\u0027all_projects\u0027], [])"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":179,"context_line":"                # allowed filter exception when handling down cells."}],"source_content_type":"text/x-python","patch_set":23,"id":"6955d9cd_7f787347","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":22},"updated":"2021-06-29 16:55:29.000000000","message":"nit: you don\u0027t need this in Python 3-only code. Strings are unicode by default","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                # Since microversion 2.89, we replaced \u0027all_tenants\u0027 with"},{"line_number":174,"context_line":"                # \u0027all_projects\u0027, so, the reason is the same as above."},{"line_number":175,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":176,"context_line":"                    [u\u0027all_projects\u0027], [])"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":179,"context_line":"                # allowed filter exception when handling down cells."}],"source_content_type":"text/x-python","patch_set":23,"id":"78015192_33e51a85","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":22},"in_reply_to":"6955d9cd_7f787347","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":178,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":179,"context_line":"                # allowed filter exception when handling down cells."},{"line_number":180,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":181,"context_line":"                    [u\u0027all_tenants\u0027], [])"},{"line_number":182,"context_line":"            if pag_sort or filters:"},{"line_number":183,"context_line":"                cell_down_support \u003d False"},{"line_number":184,"context_line":"        return cell_down_support"}],"source_content_type":"text/x-python","patch_set":23,"id":"1db5dbb9_532dcd7a","line":181,"range":{"start_line":181,"start_character":21,"end_line":181,"end_character":22},"updated":"2021-06-29 16:55:29.000000000","message":"nit","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                # NOTE(tssurya): ``nova list --all_tenants`` is the only"},{"line_number":179,"context_line":"                # allowed filter exception when handling down cells."},{"line_number":180,"context_line":"                filters \u003d list(search_opts.keys()) not in ("},{"line_number":181,"context_line":"                    [u\u0027all_tenants\u0027], [])"},{"line_number":182,"context_line":"            if pag_sort or filters:"},{"line_number":183,"context_line":"                cell_down_support \u003d False"},{"line_number":184,"context_line":"        return cell_down_support"}],"source_content_type":"text/x-python","patch_set":23,"id":"345d800e_e10901bc","line":181,"range":{"start_line":181,"start_character":21,"end_line":181,"end_character":22},"in_reply_to":"1db5dbb9_532dcd7a","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"}],"nova/tests/unit/api/openstack/compute/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ed120dc3fdf5dbdeff0b18a4db392feb9d3db9a","unresolved":true,"context_lines":[{"line_number":2864,"context_line":"            use_admin_context\u003dTrue, version\u003d\u00272.88\u0027)"},{"line_number":2865,"context_line":"        self.controller.index(req)"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"    def test_get_servers_by_all_tenants_with_index_old_version(self):"},{"line_number":2868,"context_line":"        req \u003d self.req(self.path_with_query % \u0027all_tenants\u003d1\u0027,"},{"line_number":2869,"context_line":"            use_admin_context\u003dTrue, version\u003d\u00272.88\u0027)"},{"line_number":2870,"context_line":"        self.controller.index(req)"},{"line_number":2871,"context_line":""},{"line_number":2872,"context_line":"    def test_get_servers_by_all_proejcts_with_index(self):"},{"line_number":2873,"context_line":"        req \u003d self.req(self.path_with_query % \u0027all_projects\u003d1\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ccd720b4_7ded6551","line":2870,"range":{"start_line":2867,"start_character":0,"end_line":2870,"end_character":34},"updated":"2021-05-21 01:28:58.000000000","message":"let\u0027s add negative case also, all_tenants is 404 for \u003e\u003d2.89","commit_id":"f357bd5859727a1a2a724c25cfc318c4f1c68d72"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f36c3b734f8944f4083f27ce3cbade1f4a48f885","unresolved":true,"context_lines":[{"line_number":2864,"context_line":"            use_admin_context\u003dTrue, version\u003d\u00272.88\u0027)"},{"line_number":2865,"context_line":"        self.controller.index(req)"},{"line_number":2866,"context_line":""},{"line_number":2867,"context_line":"    def test_get_servers_by_all_tenants_with_index_old_version(self):"},{"line_number":2868,"context_line":"        req \u003d self.req(self.path_with_query % \u0027all_tenants\u003d1\u0027,"},{"line_number":2869,"context_line":"            use_admin_context\u003dTrue, version\u003d\u00272.88\u0027)"},{"line_number":2870,"context_line":"        self.controller.index(req)"},{"line_number":2871,"context_line":""},{"line_number":2872,"context_line":"    def test_get_servers_by_all_proejcts_with_index(self):"},{"line_number":2873,"context_line":"        req \u003d self.req(self.path_with_query % \u0027all_projects\u003d1\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"bc22e61f_9d25ae04","line":2870,"range":{"start_line":2867,"start_character":0,"end_line":2870,"end_character":34},"in_reply_to":"ccd720b4_7ded6551","updated":"2021-05-21 06:58:52.000000000","message":"Yes, we can, but it\u0027s should be 400 code.","commit_id":"f357bd5859727a1a2a724c25cfc318c4f1c68d72"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6ed120dc3fdf5dbdeff0b18a4db392feb9d3db9a","unresolved":true,"context_lines":[{"line_number":2900,"context_line":"            use_admin_context\u003dTrue)"},{"line_number":2901,"context_line":"        self.controller.detail(req)"},{"line_number":2902,"context_line":""},{"line_number":2903,"context_line":"    @mock.patch(\u0027nova.api.openstack.compute.views.servers.ViewBuilder.detail\u0027)"},{"line_number":2904,"context_line":"    def test_get_servers_by_all_tenants_with_detail_old_version(self,"},{"line_number":2905,"context_line":"            mock_detail):"},{"line_number":2906,"context_line":"        req \u003d self.req(self.path_detail_with_query % \u0027all_tenants\u003d1\u0027,"},{"line_number":2907,"context_line":"            use_admin_context\u003dTrue, version\u003d\u00272.88\u0027)"},{"line_number":2908,"context_line":"        self.controller.detail(req)"},{"line_number":2909,"context_line":""},{"line_number":2910,"context_line":"    def test_get_servers_additional_tenant_id_with_detail(self):"},{"line_number":2911,"context_line":"        req \u003d self.req(self.path_detail_with_query % \u0027tenant_id\u003dfake_project\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"99dc4513_324ce270","line":2908,"range":{"start_line":2903,"start_character":0,"end_line":2908,"end_character":35},"updated":"2021-05-21 01:28:58.000000000","message":"ditto","commit_id":"f357bd5859727a1a2a724c25cfc318c4f1c68d72"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f36c3b734f8944f4083f27ce3cbade1f4a48f885","unresolved":true,"context_lines":[{"line_number":2900,"context_line":"            use_admin_context\u003dTrue)"},{"line_number":2901,"context_line":"        self.controller.detail(req)"},{"line_number":2902,"context_line":""},{"line_number":2903,"context_line":"    @mock.patch(\u0027nova.api.openstack.compute.views.servers.ViewBuilder.detail\u0027)"},{"line_number":2904,"context_line":"    def test_get_servers_by_all_tenants_with_detail_old_version(self,"},{"line_number":2905,"context_line":"            mock_detail):"},{"line_number":2906,"context_line":"        req \u003d self.req(self.path_detail_with_query % \u0027all_tenants\u003d1\u0027,"},{"line_number":2907,"context_line":"            use_admin_context\u003dTrue, version\u003d\u00272.88\u0027)"},{"line_number":2908,"context_line":"        self.controller.detail(req)"},{"line_number":2909,"context_line":""},{"line_number":2910,"context_line":"    def test_get_servers_additional_tenant_id_with_detail(self):"},{"line_number":2911,"context_line":"        req \u003d self.req(self.path_detail_with_query % \u0027tenant_id\u003dfake_project\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"67ac0da1_4df1c03e","line":2908,"range":{"start_line":2903,"start_character":0,"end_line":2908,"end_character":35},"in_reply_to":"99dc4513_324ce270","updated":"2021-05-21 06:58:52.000000000","message":"ditto","commit_id":"f357bd5859727a1a2a724c25cfc318c4f1c68d72"}],"nova/tests/unit/api/openstack/test_common.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":437,"context_line":"    def test_is_all_tenants_false(self):"},{"line_number":438,"context_line":"        for value in (\u00270\u0027, \u0027false\u0027, \u0027False\u0027):"},{"line_number":439,"context_line":"            search_opts \u003d {\u0027all_tenants\u0027: value}"},{"line_number":440,"context_line":"            self.assertFalse(common.is_all_projects(search_opts,"},{"line_number":441,"context_line":"                                                    \u0027all_tenants\u0027))"},{"line_number":442,"context_line":"            self.assertIn(\u0027all_tenants\u0027, search_opts)"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"90abdfd3_db3dfa16","line":440,"range":{"start_line":440,"start_character":28,"end_line":440,"end_character":30},"updated":"2021-01-04 15:36:13.000000000","message":"nit: I would wrap the line here (and similarly in TestMiscFunctionsV288)","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fa9107a75bfa7a3c6a009428633e0deb7ca568c","unresolved":false,"context_lines":[{"line_number":437,"context_line":"    def test_is_all_tenants_false(self):"},{"line_number":438,"context_line":"        for value in (\u00270\u0027, \u0027false\u0027, \u0027False\u0027):"},{"line_number":439,"context_line":"            search_opts \u003d {\u0027all_tenants\u0027: value}"},{"line_number":440,"context_line":"            self.assertFalse(common.is_all_projects(search_opts,"},{"line_number":441,"context_line":"                                                    \u0027all_tenants\u0027))"},{"line_number":442,"context_line":"            self.assertIn(\u0027all_tenants\u0027, search_opts)"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3621b40a_dec276e5","line":440,"range":{"start_line":440,"start_character":28,"end_line":440,"end_character":30},"in_reply_to":"90abdfd3_db3dfa16","updated":"2021-01-12 12:54:05.000000000","message":"Done","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def test_is_all_tenants_invalid(self):"},{"line_number":448,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: \u0027wonk\u0027}"},{"line_number":449,"context_line":"        self.assertRaises(exception.InvalidInput, common.is_all_projects,"},{"line_number":450,"context_line":"                          search_opts, \u0027all_tenants\u0027)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"e91483cd_44dc70b3","line":449,"range":{"start_line":449,"start_character":25,"end_line":449,"end_character":27},"updated":"2021-01-04 15:36:13.000000000","message":"nit: I would wrap the line here (and similarly in TestMiscFunctionsV288)","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fa9107a75bfa7a3c6a009428633e0deb7ca568c","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def test_is_all_tenants_invalid(self):"},{"line_number":448,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: \u0027wonk\u0027}"},{"line_number":449,"context_line":"        self.assertRaises(exception.InvalidInput, common.is_all_projects,"},{"line_number":450,"context_line":"                          search_opts, \u0027all_tenants\u0027)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"defb32ce_58e1b6f7","line":449,"range":{"start_line":449,"start_character":25,"end_line":449,"end_character":27},"in_reply_to":"e91483cd_44dc70b3","updated":"2021-01-12 12:54:05.000000000","message":"Done","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                     task_states.RESIZE_PREP])"},{"line_number":429,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def test_is_all_tenants_true(self):"},{"line_number":432,"context_line":"        for value in (\u0027\u0027, \u00271\u0027, \u0027true\u0027, \u0027True\u0027):"},{"line_number":433,"context_line":"            search_opts \u003d {\u0027all_tenants\u0027: value}"},{"line_number":434,"context_line":"            self.assertTrue(common.is_all_projects(search_opts, \u0027all_tenants\u0027))"}],"source_content_type":"text/x-python","patch_set":23,"id":"7b438226_ec764016","line":431,"range":{"start_line":431,"start_character":20,"end_line":431,"end_character":27},"updated":"2021-06-29 16:55:29.000000000","message":"projects\n\n(the test is named after the function, which is called \u0027is_all_projects\u0027 now)","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                     task_states.RESIZE_PREP])"},{"line_number":429,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def test_is_all_tenants_true(self):"},{"line_number":432,"context_line":"        for value in (\u0027\u0027, \u00271\u0027, \u0027true\u0027, \u0027True\u0027):"},{"line_number":433,"context_line":"            search_opts \u003d {\u0027all_tenants\u0027: value}"},{"line_number":434,"context_line":"            self.assertTrue(common.is_all_projects(search_opts, \u0027all_tenants\u0027))"}],"source_content_type":"text/x-python","patch_set":23,"id":"309d17bd_fb9eb309","line":431,"range":{"start_line":431,"start_character":20,"end_line":431,"end_character":27},"in_reply_to":"7b438226_ec764016","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":434,"context_line":"            self.assertTrue(common.is_all_projects(search_opts, \u0027all_tenants\u0027))"},{"line_number":435,"context_line":"            self.assertIn(\u0027all_tenants\u0027, search_opts)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_is_all_tenants_false(self):"},{"line_number":438,"context_line":"        for value in (\u00270\u0027, \u0027false\u0027, \u0027False\u0027):"},{"line_number":439,"context_line":"            search_opts \u003d {\u0027all_tenants\u0027: value}"},{"line_number":440,"context_line":"            self.assertFalse("}],"source_content_type":"text/x-python","patch_set":23,"id":"8672d127_1f28d92a","line":437,"range":{"start_line":437,"start_character":20,"end_line":437,"end_character":27},"updated":"2021-06-29 16:55:29.000000000","message":"projects","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            self.assertTrue(common.is_all_projects(search_opts, \u0027all_tenants\u0027))"},{"line_number":435,"context_line":"            self.assertIn(\u0027all_tenants\u0027, search_opts)"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_is_all_tenants_false(self):"},{"line_number":438,"context_line":"        for value in (\u00270\u0027, \u0027false\u0027, \u0027False\u0027):"},{"line_number":439,"context_line":"            search_opts \u003d {\u0027all_tenants\u0027: value}"},{"line_number":440,"context_line":"            self.assertFalse("}],"source_content_type":"text/x-python","patch_set":23,"id":"15b0eae4_4db73111","line":437,"range":{"start_line":437,"start_character":20,"end_line":437,"end_character":27},"in_reply_to":"8672d127_1f28d92a","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                common.is_all_projects(search_opts, \u0027all_tenants\u0027))"},{"line_number":442,"context_line":"            self.assertIn(\u0027all_tenants\u0027, search_opts)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_is_all_tenants_missing(self):"},{"line_number":445,"context_line":"        self.assertFalse(common.is_all_projects({}, \u0027all_tenants\u0027))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def test_is_all_tenants_invalid(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"b2f2284f_d2b2659c","line":444,"range":{"start_line":444,"start_character":20,"end_line":444,"end_character":27},"updated":"2021-06-29 16:55:29.000000000","message":"projects","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                common.is_all_projects(search_opts, \u0027all_tenants\u0027))"},{"line_number":442,"context_line":"            self.assertIn(\u0027all_tenants\u0027, search_opts)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_is_all_tenants_missing(self):"},{"line_number":445,"context_line":"        self.assertFalse(common.is_all_projects({}, \u0027all_tenants\u0027))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def test_is_all_tenants_invalid(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"36fbc337_85a81d77","line":444,"range":{"start_line":444,"start_character":20,"end_line":444,"end_character":27},"in_reply_to":"b2f2284f_d2b2659c","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":444,"context_line":"    def test_is_all_tenants_missing(self):"},{"line_number":445,"context_line":"        self.assertFalse(common.is_all_projects({}, \u0027all_tenants\u0027))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def test_is_all_tenants_invalid(self):"},{"line_number":448,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: \u0027wonk\u0027}"},{"line_number":449,"context_line":"        self.assertRaises("},{"line_number":450,"context_line":"            exception.InvalidInput, common.is_all_projects,"}],"source_content_type":"text/x-python","patch_set":23,"id":"1e00b5c3_2b4a0251","line":447,"range":{"start_line":447,"start_character":20,"end_line":447,"end_character":27},"updated":"2021-06-29 16:55:29.000000000","message":"projects","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def test_is_all_tenants_missing(self):"},{"line_number":445,"context_line":"        self.assertFalse(common.is_all_projects({}, \u0027all_tenants\u0027))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def test_is_all_tenants_invalid(self):"},{"line_number":448,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: \u0027wonk\u0027}"},{"line_number":449,"context_line":"        self.assertRaises("},{"line_number":450,"context_line":"            exception.InvalidInput, common.is_all_projects,"}],"source_content_type":"text/x-python","patch_set":23,"id":"fc0128ed_d5faaf1c","line":447,"range":{"start_line":447,"start_character":20,"end_line":447,"end_character":27},"in_reply_to":"1e00b5c3_2b4a0251","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":475,"context_line":"        search_opts \u003d {\u0027all_projects\u0027: \u0027wonk\u0027}"},{"line_number":476,"context_line":"        self.assertRaises("},{"line_number":477,"context_line":"            exception.InvalidInput, common.is_all_projects,"},{"line_number":478,"context_line":"            search_opts, \u0027all_projects\u0027)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"class TestCollectionLinks(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"2a4a2b84_b396bfb6","line":478,"updated":"2021-06-29 16:55:29.000000000","message":"There\u0027s no need for this to be a separate test case. You\u0027re not checking the API version in the function. Instead you\u0027re passing the argument you want to check for. As such, we can include these four tests in the previous class. Duplicating things like this results in an additional...17 tests running for no reason","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        search_opts \u003d {\u0027all_projects\u0027: \u0027wonk\u0027}"},{"line_number":476,"context_line":"        self.assertRaises("},{"line_number":477,"context_line":"            exception.InvalidInput, common.is_all_projects,"},{"line_number":478,"context_line":"            search_opts, \u0027all_projects\u0027)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"class TestCollectionLinks(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":23,"id":"bd547cab_ca959af8","line":478,"in_reply_to":"2a4a2b84_b396bfb6","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"}],"releasenotes/notes/bp-remove-tenant-id-dd0193d587a00d30.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1c5728736b21a81919c253b804002cf4fa4b3135","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``GET /servers (List Servers)``"},{"line_number":9,"context_line":"    - ``GET /servers/detail (List Server Detailed)``"},{"line_number":10,"context_line":"    - ``PUT /servers/{server_id} (Update Server)``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"cfac676d_44dae780","line":10,"updated":"2021-01-04 15:36:13.000000000","message":"add the List Server APIs to this list and then you don\u0027t have to modify the heading of the list","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8fa9107a75bfa7a3c6a009428633e0deb7ca568c","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``GET /servers (List Servers)``"},{"line_number":9,"context_line":"    - ``GET /servers/detail (List Server Detailed)``"},{"line_number":10,"context_line":"    - ``PUT /servers/{server_id} (Update Server)``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"be7dd126_0b9d8ab3","line":10,"in_reply_to":"cfac676d_44dae780","updated":"2021-01-12 12:54:05.000000000","message":"Yeah, whether is ok:D.","commit_id":"64208718bf87454c6826be52916a8e3ebe7c5452"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"be5ce3fdd232967fa989a782aebb0eda25fc207d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.90, replaced ``tenant_id`` with ``project_id`` in"},{"line_number":5,"context_line":"    List Server APIs, and replaced ``tenant_id`` with ``project_id`` in"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``GET /servers (List Servers)``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1aba564b_1ca6cc5f","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":71},"updated":"2021-01-22 21:59:06.000000000","message":"all_tenants with all_proejcts","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a917eaaefdbdda80d89328086b2ca01d76ed107a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.90, replaced ``tenant_id`` with ``project_id`` in"},{"line_number":5,"context_line":"    List Server APIs, and replaced ``tenant_id`` with ``project_id`` in"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``GET /servers (List Servers)``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"70ba3b51_34e751a7","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":71},"in_reply_to":"1aba564b_1ca6cc5f","updated":"2021-01-25 12:32:50.000000000","message":"Done","commit_id":"e61e3642c9bc5eba0de59bf40f19559e86d35a22"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee36bea4481e43defe59b053ef49dfe85ef47ae4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.90, replaced ``tenant_id`` with ``project_id`` in"},{"line_number":5,"context_line":"    List Server APIs, and replaced ``all_tenants`` with ``all_projects`` in"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``GET /servers (List Servers)``"},{"line_number":9,"context_line":"    - ``GET /servers/detail (List Server Detailed)``"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"47d2e569_d78e7355","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":19},"updated":"2021-01-27 23:14:01.000000000","message":"it is other way around.\n\nIn microversion 2.90, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in List Server APIs, and replaces\n\u0027tenant_id\u0027 with \u0027project_id\u0027 in the following APIs:","commit_id":"ee24fa8b090ef16bd3a5af23e46f354bf5b658e2"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"02f5a43c22ac24955809af7b9da32a1eceddc396","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.90, replaced ``tenant_id`` with ``project_id`` in"},{"line_number":5,"context_line":"    List Server APIs, and replaced ``all_tenants`` with ``all_projects`` in"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    - ``GET /servers (List Servers)``"},{"line_number":9,"context_line":"    - ``GET /servers/detail (List Server Detailed)``"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"546dbf12_e264cea3","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":19},"in_reply_to":"47d2e569_d78e7355","updated":"2021-02-02 13:07:36.000000000","message":"Done","commit_id":"ee24fa8b090ef16bd3a5af23e46f354bf5b658e2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.89, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in"},{"line_number":5,"context_line":"    List Server APIs, and replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"d26235ff_0a366646","line":4,"range":{"start_line":4,"start_character":54,"end_line":4,"end_character":68},"updated":"2021-06-29 16:55:29.000000000","message":"nit:\n\n  ``all_projects``","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.89, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in"},{"line_number":5,"context_line":"    List Server APIs, and replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"35195327_833e3ad2","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":48},"updated":"2021-06-29 16:55:29.000000000","message":"nit:\n\n  ``all_tenants``","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.89, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in"},{"line_number":5,"context_line":"    List Server APIs, and replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"36f6b8a6_295db07b","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":48},"in_reply_to":"35195327_833e3ad2","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.89, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in"},{"line_number":5,"context_line":"    List Server APIs, and replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"facb8e85_f4f396d1","line":4,"range":{"start_line":4,"start_character":54,"end_line":4,"end_character":68},"in_reply_to":"d26235ff_0a366646","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.89, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in"},{"line_number":5,"context_line":"    List Server APIs, and replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In request body/query of:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bc098a38_7b6cddf4","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":64},"updated":"2021-06-29 16:55:29.000000000","message":"nit:\n\n  ``tenant_id`` with ``project_id``","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"565ff6f46e3060b8c572c02e582df253c1d7bc73","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In microversion 2.89, replaces \u0027all_tenants\u0027 with \u0027all_projects\u0027 in"},{"line_number":5,"context_line":"    List Server APIs, and replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the"},{"line_number":6,"context_line":"    following APIs:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In request body/query of:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bedbcdfe_81d5d41b","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":64},"in_reply_to":"bc098a38_7b6cddf4","updated":"2021-08-05 06:58:55.000000000","message":"Done","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fa70ca6d39bf808713e0d347f30f7d865e95793","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In request body/query of:"},{"line_number":9,"context_line":"      - ``GET /servers``,"},{"line_number":10,"context_line":"      - ``GET /servers/detail``"},{"line_number":11,"context_line":"    In response body of:"},{"line_number":12,"context_line":"      - ``GET /servers/detail``"},{"line_number":13,"context_line":"      - ``GET /servers/{server_id}``."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"817ea3dd_dec20ae0","line":10,"updated":"2021-06-29 16:55:29.000000000","message":"the spacing of these is still wrong, but that\u0027s got to be fixed in the first patch","commit_id":"a7344c642e5a981fa9e56bcec11715093480ac75"}]}