)]}'
{"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7a75c4b197e0398b920baeb96a4817dafeba18c5","unresolved":true,"context_lines":[{"line_number":3960,"context_line":""},{"line_number":3961,"context_line":"        # NOTE(aarents): Ensure image_base_image_ref is present as it will be"},{"line_number":3962,"context_line":"        # needed during finish_resize/cross_cell_resize and instance rebuild"},{"line_number":3963,"context_line":"        # done before Bug/1893618 fix dropped it."},{"line_number":3964,"context_line":"        instance.system_metadata.update("},{"line_number":3965,"context_line":"                {\u0027image_base_image_ref\u0027: instance.image_ref}"},{"line_number":3966,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"08d5f77c_6101f22c","line":3963,"range":{"start_line":3963,"start_character":15,"end_line":3963,"end_character":49},"updated":"2020-12-07 09:53:46.000000000","message":"It is not clear to me. Do you mean that the fix https://review.opendev.org/c/openstack/nova/+/749205 was incomplete and we need to store image_ref here as well?","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"ec634acb341a991086be9e7c381300a6fff3b2ef","unresolved":true,"context_lines":[{"line_number":3960,"context_line":""},{"line_number":3961,"context_line":"        # NOTE(aarents): Ensure image_base_image_ref is present as it will be"},{"line_number":3962,"context_line":"        # needed during finish_resize/cross_cell_resize and instance rebuild"},{"line_number":3963,"context_line":"        # done before Bug/1893618 fix dropped it."},{"line_number":3964,"context_line":"        instance.system_metadata.update("},{"line_number":3965,"context_line":"                {\u0027image_base_image_ref\u0027: instance.image_ref}"},{"line_number":3966,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"d89b8c94_84a61957","line":3963,"range":{"start_line":3963,"start_character":15,"end_line":3963,"end_character":49},"in_reply_to":"08d5f77c_6101f22c","updated":"2020-12-07 10:21:31.000000000","message":"This fix was enough for new deployement that already have the fix.\nThis couple of lines ensures that for upgraded openstack with old instance impacted (aka rebuild with old code and so without this mandatory property) it will work.\n\nI can drop those line if you prefer, as it is just a very edge case.\nbut I would prefer to have it in my large deployemnt because it should concern few thousands of instance, or may be I can simply fix this by a one time SQL script in my DBs, but this my operator POV. So no worry to drop it if you prefer.","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"546a847461f3bc70c3e5e2c7f30b3ba1be2e2f0a","unresolved":false,"context_lines":[{"line_number":3960,"context_line":""},{"line_number":3961,"context_line":"        # NOTE(aarents): Ensure image_base_image_ref is present as it will be"},{"line_number":3962,"context_line":"        # needed during finish_resize/cross_cell_resize and instance rebuild"},{"line_number":3963,"context_line":"        # done before Bug/1893618 fix dropped it."},{"line_number":3964,"context_line":"        instance.system_metadata.update("},{"line_number":3965,"context_line":"                {\u0027image_base_image_ref\u0027: instance.image_ref}"},{"line_number":3966,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9b157eae_1a80ef8a","line":3963,"range":{"start_line":3963,"start_character":15,"end_line":3963,"end_character":49},"in_reply_to":"6ddcf5ef_a1e491ba","updated":"2020-12-08 09:41:06.000000000","message":"Done","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0a3c2dd305a35583ef6f584158e7ad42ea0c35d0","unresolved":true,"context_lines":[{"line_number":3960,"context_line":""},{"line_number":3961,"context_line":"        # NOTE(aarents): Ensure image_base_image_ref is present as it will be"},{"line_number":3962,"context_line":"        # needed during finish_resize/cross_cell_resize and instance rebuild"},{"line_number":3963,"context_line":"        # done before Bug/1893618 fix dropped it."},{"line_number":3964,"context_line":"        instance.system_metadata.update("},{"line_number":3965,"context_line":"                {\u0027image_base_image_ref\u0027: instance.image_ref}"},{"line_number":3966,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ddcf5ef_a1e491ba","line":3963,"range":{"start_line":3963,"start_character":15,"end_line":3963,"end_character":49},"in_reply_to":"d89b8c94_84a61957","updated":"2020-12-07 10:29:37.000000000","message":"\u003e This fix was enough for new deployement that already have the fix.\n\u003e This couple of lines ensures that for upgraded openstack with old instance impacted (aka rebuild with old code and so without this mandatory property) it will work.\n\u003e \n\nPlease add this to the comment as from the bug link this was not obvious to me.\n\n\u003e I can drop those line if you prefer, as it is just a very edge case.\n\u003e but I would prefer to have it in my large deployemnt because it should concern few thousands of instance, or may be I can simply fix this by a one time SQL script in my DBs, but this my operator POV. So no worry to drop it if you prefer.\n\nI think this is OK to have this fixed here.","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46e6f6151ea54dbc76858d26d7a3a8b83e53328e","unresolved":true,"context_lines":[{"line_number":3961,"context_line":"        # NOTE(aarents): Ensure image_base_image_ref is present as it will be"},{"line_number":3962,"context_line":"        # needed during finish_resize/cross_cell_resize. Instances upgraded"},{"line_number":3963,"context_line":"        # from an older nova release may not have this property because of"},{"line_number":3964,"context_line":"        # a rebuild bug Bug/1893618."},{"line_number":3965,"context_line":"        instance.system_metadata.update("},{"line_number":3966,"context_line":"                {\u0027image_base_image_ref\u0027: instance.image_ref}"},{"line_number":3967,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"bb8124c9_ac7e0a09","line":3964,"range":{"start_line":3964,"start_character":24,"end_line":3964,"end_character":28},"updated":"2020-12-15 12:23:48.000000000","message":"#","commit_id":"f02899418db9fa118a7bd0c813446b8dce51b7d7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46e6f6151ea54dbc76858d26d7a3a8b83e53328e","unresolved":true,"context_lines":[{"line_number":3963,"context_line":"        # from an older nova release may not have this property because of"},{"line_number":3964,"context_line":"        # a rebuild bug Bug/1893618."},{"line_number":3965,"context_line":"        instance.system_metadata.update("},{"line_number":3966,"context_line":"                {\u0027image_base_image_ref\u0027: instance.image_ref}"},{"line_number":3967,"context_line":"        )"},{"line_number":3968,"context_line":""},{"line_number":3969,"context_line":"        # If flavor_id is not provided, only migrate the instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"8fe35b0c_ddf938e7","line":3966,"range":{"start_line":3966,"start_character":12,"end_line":3966,"end_character":16},"updated":"2020-12-15 12:23:48.000000000","message":"nit","commit_id":"f02899418db9fa118a7bd0c813446b8dce51b7d7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f190c8cc8cf4d988d711f4c839c358d23605c473","unresolved":true,"context_lines":[{"line_number":4178,"context_line":"            # using a snapshot image. Extra work is needed in order to rebase"},{"line_number":4179,"context_line":"            # disk image to its original image_ref. Disk backing file will"},{"line_number":4180,"context_line":"            # then represent back image_ref instead of snapshot image."},{"line_number":4181,"context_line":"            if self._needs_rebase_original_qcow2_image(instance, backend):"},{"line_number":4182,"context_line":"                self._rebase_original_qcow2_image(context, instance, backend)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"            if need_inject:"},{"line_number":4185,"context_line":"                self._inject_data(backend, instance, injection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"001bba97_03380c8b","line":4182,"range":{"start_line":4181,"start_character":0,"end_line":4182,"end_character":77},"updated":"2020-12-07 10:24:23.000000000","message":"nit - Can we fold this into a single call and have the check within it?","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"546a847461f3bc70c3e5e2c7f30b3ba1be2e2f0a","unresolved":false,"context_lines":[{"line_number":4178,"context_line":"            # using a snapshot image. Extra work is needed in order to rebase"},{"line_number":4179,"context_line":"            # disk image to its original image_ref. Disk backing file will"},{"line_number":4180,"context_line":"            # then represent back image_ref instead of snapshot image."},{"line_number":4181,"context_line":"            if self._needs_rebase_original_qcow2_image(instance, backend):"},{"line_number":4182,"context_line":"                self._rebase_original_qcow2_image(context, instance, backend)"},{"line_number":4183,"context_line":""},{"line_number":4184,"context_line":"            if need_inject:"},{"line_number":4185,"context_line":"                self._inject_data(backend, instance, injection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e6087f5_4002d6b7","line":4182,"range":{"start_line":4181,"start_character":0,"end_line":4182,"end_character":77},"in_reply_to":"001bba97_03380c8b","updated":"2020-12-08 09:41:06.000000000","message":"Done","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f190c8cc8cf4d988d711f4c839c358d23605c473","unresolved":true,"context_lines":[{"line_number":4191,"context_line":"        return created_disks"},{"line_number":4192,"context_line":""},{"line_number":4193,"context_line":"    def _needs_rebase_original_qcow2_image(self, instance, backend):"},{"line_number":4194,"context_line":"        if isinstance(backend, imagebackend.Qcow2):"},{"line_number":4195,"context_line":"            if instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":4196,"context_line":"                return True"},{"line_number":4197,"context_line":"            if instance.task_state \u003d\u003d task_states.RESIZE_FINISH:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d14fa650_34d97abe","line":4194,"range":{"start_line":4194,"start_character":0,"end_line":4194,"end_character":51},"updated":"2020-12-07 10:24:23.000000000","message":"nit - I prefer to bail early if possible, also avoids nesting the actual logic below this.\n\n  if not isinstance(backend, imagebackend.Qcow2):\n      return False\n\netc.","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"546a847461f3bc70c3e5e2c7f30b3ba1be2e2f0a","unresolved":true,"context_lines":[{"line_number":4191,"context_line":"        return created_disks"},{"line_number":4192,"context_line":""},{"line_number":4193,"context_line":"    def _needs_rebase_original_qcow2_image(self, instance, backend):"},{"line_number":4194,"context_line":"        if isinstance(backend, imagebackend.Qcow2):"},{"line_number":4195,"context_line":"            if instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":4196,"context_line":"                return True"},{"line_number":4197,"context_line":"            if instance.task_state \u003d\u003d task_states.RESIZE_FINISH:"}],"source_content_type":"text/x-python","patch_set":1,"id":"acd398bf_53ed2e9e","line":4194,"range":{"start_line":4194,"start_character":0,"end_line":4194,"end_character":51},"in_reply_to":"d14fa650_34d97abe","updated":"2020-12-08 09:41:06.000000000","message":"makes sense","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f190c8cc8cf4d988d711f4c839c358d23605c473","unresolved":true,"context_lines":[{"line_number":4195,"context_line":"            if instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":4196,"context_line":"                return True"},{"line_number":4197,"context_line":"            if instance.task_state \u003d\u003d task_states.RESIZE_FINISH:"},{"line_number":4198,"context_line":"                # We only need to rebase during cross cell resize"},{"line_number":4199,"context_line":"                # as we spawn from snapshot id."},{"line_number":4200,"context_line":"                base_image_ref \u003d instance.system_metadata.get("},{"line_number":4201,"context_line":"                        \u0027image_base_image_ref\u0027)"},{"line_number":4202,"context_line":"                if base_image_ref !\u003d instance.image_ref:"},{"line_number":4203,"context_line":"                    return True"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6d75ae5_d1f0a0bb","line":4202,"range":{"start_line":4198,"start_character":0,"end_line":4202,"end_character":56},"updated":"2020-12-07 10:24:23.000000000","message":"Any reason not to use this check when `instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED` also?","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"546a847461f3bc70c3e5e2c7f30b3ba1be2e2f0a","unresolved":true,"context_lines":[{"line_number":4195,"context_line":"            if instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":4196,"context_line":"                return True"},{"line_number":4197,"context_line":"            if instance.task_state \u003d\u003d task_states.RESIZE_FINISH:"},{"line_number":4198,"context_line":"                # We only need to rebase during cross cell resize"},{"line_number":4199,"context_line":"                # as we spawn from snapshot id."},{"line_number":4200,"context_line":"                base_image_ref \u003d instance.system_metadata.get("},{"line_number":4201,"context_line":"                        \u0027image_base_image_ref\u0027)"},{"line_number":4202,"context_line":"                if base_image_ref !\u003d instance.image_ref:"},{"line_number":4203,"context_line":"                    return True"},{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"665672cf_4584a317","line":4202,"range":{"start_line":4198,"start_character":0,"end_line":4202,"end_character":56},"in_reply_to":"f6d75ae5_d1f0a0bb","updated":"2020-12-08 09:41:06.000000000","message":"because in SHELVED_OFFLOADED in all cases, base_image_ref and image_ref will be different.\nwhereas in RESIZE_FINISH there is 2 cases to distinguish local and cross resize.\n(local will be the same because we do scp and not spawn(snap_id))","commit_id":"5f3a577b571a3dadeb4e6511f9f2e216484486c5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46e6f6151ea54dbc76858d26d7a3a8b83e53328e","unresolved":true,"context_lines":[{"line_number":4209,"context_line":"            # Rebase is only needed in cross cell case because instance"},{"line_number":4210,"context_line":"            # is spawn from a snapshot."},{"line_number":4211,"context_line":"            base_image_ref \u003d instance.system_metadata.get("},{"line_number":4212,"context_line":"                    \u0027image_base_image_ref\u0027)"},{"line_number":4213,"context_line":"            if base_image_ref !\u003d instance.image_ref:"},{"line_number":4214,"context_line":"                return True"},{"line_number":4215,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"2eb2ab70_f4a120d5","line":4212,"range":{"start_line":4212,"start_character":16,"end_line":4212,"end_character":20},"updated":"2020-12-15 12:23:48.000000000","message":"nit","commit_id":"f02899418db9fa118a7bd0c813446b8dce51b7d7"}]}