)]}'
{"nova/tests/integrated/v3/test_migrate_server.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"d4b9fec326f5a49a97a016e9d7d738d4c3097fe6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                           report_count\u003d1,"},{"line_number":56,"context_line":"                           updated_at\u003d\u0027foo\u0027,"},{"line_number":57,"context_line":"                           hypervisor_type\u003d\u0027bar\u0027,"},{"line_number":58,"context_line":"                           hypervisor_version\u003d\u00271000\u0027,"},{"line_number":59,"context_line":"                           disabled\u003dFalse)"},{"line_number":60,"context_line":"            return {\u0027compute_node\u0027: [service]}"},{"line_number":61,"context_line":"        self.stubs.Set(db, \"service_get_by_compute_host\", fake_get_compute)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_c6c24333","line":58,"updated":"2014-07-14 15:05:16.000000000","message":"Shouldn\u0027t this be an int now too? Or maybe call utils.convert_version_to_int(\u00271.0\u0027) like you do in test_api_samples.py?","commit_id":"026583e60e9ec2b83049e8ceee16f182560d2562"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a333f911fd00517b7c53a630e06f168e1b75acb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                           report_count\u003d1,"},{"line_number":56,"context_line":"                           updated_at\u003d\u0027foo\u0027,"},{"line_number":57,"context_line":"                           hypervisor_type\u003d\u0027bar\u0027,"},{"line_number":58,"context_line":"                           hypervisor_version\u003d\u00271000\u0027,"},{"line_number":59,"context_line":"                           disabled\u003dFalse)"},{"line_number":60,"context_line":"            return {\u0027compute_node\u0027: [service]}"},{"line_number":61,"context_line":"        self.stubs.Set(db, \"service_get_by_compute_host\", fake_get_compute)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ddb25795","line":58,"in_reply_to":"baada198_c6c24333","updated":"2014-07-18 11:20:39.000000000","message":"+1 but it seems minor and I trust jogo with a follow up patch","commit_id":"026583e60e9ec2b83049e8ceee16f182560d2562"}],"nova/tests/virt/test_virt_drivers.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"d4b9fec326f5a49a97a016e9d7d738d4c3097fe6","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    def test_get_host_stats(self):"},{"line_number":598,"context_line":"        host_status \u003d self.connection.get_host_stats()"},{"line_number":599,"context_line":"        self._check_available_resource_fields(host_status)"},{"line_number":600,"context_line":"        self.assertIsInstance(host_status[\u0027hypervisor_version\u0027], int)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @catch_notimplementederror"},{"line_number":603,"context_line":"    def test_get_available_resource(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a61d4f11","line":600,"updated":"2014-07-14 15:05:16.000000000","message":"This looks like it\u0027s unnecessary since _check_available_resource_fields does the same assert now.","commit_id":"026583e60e9ec2b83049e8ceee16f182560d2562"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a333f911fd00517b7c53a630e06f168e1b75acb","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    def test_get_host_stats(self):"},{"line_number":598,"context_line":"        host_status \u003d self.connection.get_host_stats()"},{"line_number":599,"context_line":"        self._check_available_resource_fields(host_status)"},{"line_number":600,"context_line":"        self.assertIsInstance(host_status[\u0027hypervisor_version\u0027], int)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @catch_notimplementederror"},{"line_number":603,"context_line":"    def test_get_available_resource(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_3dad1332","line":600,"in_reply_to":"baada198_a61d4f11","updated":"2014-07-18 11:20:39.000000000","message":"+1 but its minor","commit_id":"026583e60e9ec2b83049e8ceee16f182560d2562"}]}
