)]}'
{"id":"openstack%2Fnova~766364","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I6150a785b532e170b39cec1c9615c855b2c30c33","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1907511","hashtags":[],"change_id":"I6150a785b532e170b39cec1c9615c855b2c30c33","subject":"WIP [stable-only] Target cell for min bw migration service lookup","status":"ABANDONED","created":"2020-12-09 23:40:14.000000000","updated":"2020-12-14 17:45:17.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"85a9f5addcc08fa9461f14bb99f9c8b4cafbfa99","_number":766364,"virtual_id_number":766364,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-10 06:25:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":-1,"date":"2020-12-11 15:22:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-10 03:04:29.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2020-12-10 03:05:30.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-12-10 06:25:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-11 15:22:47.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"ede495b1c6e34c3739a92fc4e9f8642fc52023b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-12-09 23:40:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f97e8426d137d9144a9195cabf0311a33ffd7d37","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-12-10 03:04:29.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/766364/1 : FAILURE in 3h 22m 53s","accounts_in_message":[],"_revision_number":1},{"id":"c0159f4f788716d71f58840470b5a7cdbda997c8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2020-12-10 03:05:30.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/64/766364/1/SRIOV-nova-direct : ABORTED\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/64/766364/1/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"52daa44e081bc3d59ca94589cfcb7571e3a5884a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2020-12-10 04:59:00.000000000","message":"Patch Set 1:\n\nBuild Successful \n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/64/766364/1/SRIOV-nova-macvtap : SUCCESS\n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/64/766364/1/SRIOV-nova-direct : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1e17566b18a6972880686608e6379420381992d8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-10 06:25:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/1987cfb458654bf7bd21b6fc9584b6f5 : ERROR Failed to update project None in 1h 46m 35s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/72911ed24f9b4131be09efbab02c9991 : ERROR Failed to update project None in 2h 07m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4618ee3b62254d39913a1beb074b4cfa : SUCCESS in 14m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7ec92a132f9c4a7690d2c27bf3999eb6 : ERROR Failed to update project None in 1h 23m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3df03f43eefd4785acdd2a58a7f62bc5 : ERROR Failed to update project None in 1h 26m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/93b3af2f0947406baebb1577e0f4fae4 : ERROR Failed to update project None in 2h 19m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f65467e7cf9a40f0b785ace7df3b11c5 : ERROR Failed to update project None in 2h 46m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d1a83d946ac41ddaadbe14011300a4b : ERROR Failed to update project None in 2h 11m 59s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/0c4254f31e084257baa5de2b4e1031c5 : ERROR Failed to update project None in 1h 42m 38s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/668e5e526f154d14923e13987156f454 : ERROR Failed to update project None in 1h 51m 38s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/ae714a7a877448419b6efc5ad98559df : ERROR Failed to update project None in 2h 02m 13s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/2629d79933b2433681efdc61bde95b77 : ERROR Failed to update project None in 1h 59m 07s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ea9d318133f14a0596d0b664a62aa328 : ERROR Failed to update project None in 1h 59m 07s\n- nova-next https://zuul.opendev.org/t/openstack/build/331334425395471eb96f1186bfdd5a65 : SUCCESS in 1h 33m 55s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a623b00f582a48e2a227767a5f972b65 : ERROR Failed to update project None in 2h 02m 12s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/084938bc69574bebb2e8d6c8c819455f : ERROR Failed to update project None in 2h 09m 58s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/a0a539500506425ca43fdf614f0a385b : ERROR Failed to update project None in 1h 46m 35s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/eece21e877f74a1c844c512acd7f7c95 : ERROR Failed to update project None in 1h 26m 15s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/850ce4daf3444aff97476cbb251e6c07 : ERROR Failed to update project None in 2h 07m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ea892279332edcdb9876ed1a5d69be0ed6991316","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-12-10 06:41:46.000000000","message":"Patch Set 1:\n\nrecheck https://review.opendev.org/c/opendev/system-config/+/766400","accounts_in_message":[],"_revision_number":1},{"id":"adaea03128003814901e3d30b26828091badc70b","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-12-10 07:53:14.000000000","message":"Patch Set 1:\n\nGuh, looks like this patch is chicken and egg with https://review.opendev.org/c/openstack/nova/+/765749 😑","accounts_in_message":[],"_revision_number":1},{"id":"c206ee02f26a4bfdb8f016a8ed31301a56da09bd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2020-12-10 08:59:50.000000000","message":"Patch Set 1:\n\nBuild Successful \n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/64/766364/1/SRIOV-nova-macvtap : SUCCESS\n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/64/766364/1/SRIOV-nova-direct : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"42ad056cfdc274f9561d2dbcbba4e4106d16a6c5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-12-10 09:25:30.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/766364/1 : SUCCESS in 2h 42m 46s","accounts_in_message":[],"_revision_number":1},{"id":"75c7270d41d9035156fd69d09d9b81c680ba669f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-10 10:43:42.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/e2c9f3d29e634e3e94db2841fc2871d4 : ERROR Failed to update project None in 2s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/db72c9239cb249b5824ffdec54354b82 : SUCCESS in 1h 37m 28s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1b6b12c04c1f4d5382cc8d9a1d3c9031 : SUCCESS in 16m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4047aa44006d458f9ad182af55978a7a : FAILURE in 10m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c62e309a17114f9ab31d51b128bb4239 : SUCCESS in 10m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4ae5f0bb3674c54a1955fae4f115098 : SUCCESS in 17m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8442bc1788bf45a7816da0a110dc09f5 : SUCCESS in 18m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/917b4d29aba74742bcb1703ced099016 : SUCCESS in 10m 42s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/af287e2ae33441e3aac5995f7177970e : SUCCESS in 1h 31m 04s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/d62b22f2ece642e48aa85fe6334c112a : SUCCESS in 1h 07m 22s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4f0ddd0860eb4355a826d9df4ae8d022 : FAILURE in 1h 19m 59s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5698531e37ee40bfa2563340559a331c : SUCCESS in 1h 10m 09s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/18e79d6c7aaf4522a0f277dd904709ad : TIMED_OUT in 3h 05m 11s\n- nova-next https://zuul.opendev.org/t/openstack/build/9bd3cb9a097d414fb4fd8f5608f45f3a : SUCCESS in 1h 22m 51s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5718fce3933c407fa120854f6cc8533d : ERROR Failed to update project None in 0s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7922069ceb0243829aa605fef96afb75 : SUCCESS in 1h 01m 22s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ad47ab6798a44fec9f5cf79ab912ff43 : SUCCESS in 1h 06m 27s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/be4ced29e6a04bea84364ae3fc535f0c : FAILURE in 30m 58s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/a3531e1fbd7440dd86df7613678ae64e : ERROR Failed to update project None in 2s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2c054859e3d90840b81893242128bafa67996702","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-12-11 15:22:47.000000000","message":"Patch Set 1: Code-Review-1\n\nNow we know that the implementation is missing for qos ports for cross cell resize. This fix is a prerequisite for the whole support but we need to do a lot more. I think the full support will only be added to master as it is more like a feature work. On stable what we can do is basically not trigger a cross cell resize if there are qos ports attached to the instance but simply fall back to same cell resize (and maybe log a warning).\n\nSo I will do this fallback first on master, then backport it to stable. And for that backport I will need this fix too. Until then we can keep this open.\nI leave a procedural -1 on this now.","accounts_in_message":[],"_revision_number":1},{"id":"85a9f5addcc08fa9461f14bb99f9c8b4cafbfa99","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-12-14 17:45:17.000000000","message":"Abandoned\n\nBecause cross-cell migration support for instances with qos ports is more like a feature, it will only be added on the master branch. For stable branches, we will instead backport a change to disallow cross-cell migrations for instances with qos ports citing the absence of support:\n\nhttps://review.opendev.org/c/openstack/nova/+/766925\n\nSo this patch will not be used.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2b6cf6f6089448442651aa74b75e3d1ee263f764","revisions":{"2b6cf6f6089448442651aa74b75e3d1ee263f764":{"kind":"REWORK","_number":1,"created":"2020-12-09 23:40:14.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/64/766364/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/64/766364/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/766364/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/766364/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/64/766364/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/64/766364/1"}}},"commit":{"parents":[{"commit":"f1e4f6b078baf72e83cd7341c380aa0fc511519e","subject":"Follow up for cherry-pick check for merge patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f1e4f6b078baf72e83cd7341c380aa0fc511519e"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-12-09 23:18:23.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-12-09 23:19:24.000000000","tz":0},"subject":"WIP [stable-only] Target cell for min bw migration service lookup","message":"WIP [stable-only] Target cell for min bw migration service lookup\n\nWhen we get a request to migrate a server that has minimum bandwidth\nresource requests, we check whether the service on the target host is\nnew enough to support resource requests. However, we are not targeting\nthe target host\u0027s cell database when we do the lookup. This works OK\nwhen the migration is occuring within the same cell, but if the target\nhost is in another cell, we will fail to lookup the service record in\nthe source cell with the following error:\n\n  Failed to compute_task_migrate_server: \u0027NoneType\u0027 object has no\n  attribute \u0027version\u0027\n\nThis is because when Service.get_by_host_and_binary fails to find a\nmatching record, it returns (and thus returns None).\n\nThis failure has recently emerged in the nova-multi-cell gate job\nbecause tempest tests were recently added for minimum bandwidth\nresource requests in change I8c573c4a11a76932057d8415d76114a03269b9f3\nand these tests include migration tests.\n\nTo fix this, we just need to target the cell database for the target\nhost\u0027s service record when we lookup the service.\n\nThis change is stable-only because the service version check was\nrecently removed in change I14177e35b9d6d27d49e092604bf0f288cd05f57e\nand only exists in stable branches.\n\nTODO: test coverage\n\nCloses-Bug: #1907511\n\nChange-Id: I6150a785b532e170b39cec1c9615c855b2c30c33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b6cf6f6089448442651aa74b75e3d1ee263f764"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b6cf6f6089448442651aa74b75e3d1ee263f764"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}