)]}'
{"api-ref/source/servers-actions.inc":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0ba86fec4b96049a9456320a617e9bfc1878c5f6","unresolved":true,"context_lines":[{"line_number":621,"context_line":"  - name: server_name"},{"line_number":622,"context_line":"  - OS-DCF:diskConfig: disk_config"},{"line_number":623,"context_line":"  - status: server_status"},{"line_number":624,"context_line":"  - tenant_id: tenant_id_body_2_87"},{"line_number":625,"context_line":"  - project_id: project_id_body_2_88"},{"line_number":626,"context_line":"  - updated: updated"},{"line_number":627,"context_line":"  - user_id: user_id"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1b84cc0f_7e8bcf31","line":624,"range":{"start_line":624,"start_character":15,"end_line":624,"end_character":34},"updated":"2021-01-14 00:35:46.000000000","message":"tenant_id_body_2_89","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9f5acde32494e0f147f499299406c8f1854b8fb6","unresolved":false,"context_lines":[{"line_number":621,"context_line":"  - name: server_name"},{"line_number":622,"context_line":"  - OS-DCF:diskConfig: disk_config"},{"line_number":623,"context_line":"  - status: server_status"},{"line_number":624,"context_line":"  - tenant_id: tenant_id_body_2_87"},{"line_number":625,"context_line":"  - project_id: project_id_body_2_88"},{"line_number":626,"context_line":"  - updated: updated"},{"line_number":627,"context_line":"  - user_id: user_id"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"b37c6631_c5c0f53a","line":624,"range":{"start_line":624,"start_character":15,"end_line":624,"end_character":34},"in_reply_to":"1b84cc0f_7e8bcf31","updated":"2021-01-14 07:08:52.000000000","message":"Done","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0ba86fec4b96049a9456320a617e9bfc1878c5f6","unresolved":true,"context_lines":[{"line_number":622,"context_line":"  - OS-DCF:diskConfig: disk_config"},{"line_number":623,"context_line":"  - status: server_status"},{"line_number":624,"context_line":"  - tenant_id: tenant_id_body_2_87"},{"line_number":625,"context_line":"  - project_id: project_id_body_2_88"},{"line_number":626,"context_line":"  - updated: updated"},{"line_number":627,"context_line":"  - user_id: user_id"},{"line_number":628,"context_line":"  - adminPass: adminPass_response"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"92ce0f90_be4e080e","line":625,"range":{"start_line":625,"start_character":16,"end_line":625,"end_character":36},"updated":"2021-01-14 00:35:46.000000000","message":"project_id_body_2_90","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9f5acde32494e0f147f499299406c8f1854b8fb6","unresolved":false,"context_lines":[{"line_number":622,"context_line":"  - OS-DCF:diskConfig: disk_config"},{"line_number":623,"context_line":"  - status: server_status"},{"line_number":624,"context_line":"  - tenant_id: tenant_id_body_2_87"},{"line_number":625,"context_line":"  - project_id: project_id_body_2_88"},{"line_number":626,"context_line":"  - updated: updated"},{"line_number":627,"context_line":"  - user_id: user_id"},{"line_number":628,"context_line":"  - adminPass: adminPass_response"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"cf1abda3_663d3c37","line":625,"range":{"start_line":625,"start_character":16,"end_line":625,"end_character":36},"in_reply_to":"92ce0f90_be4e080e","updated":"2021-01-14 07:08:52.000000000","message":"Done","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0ba86fec4b96049a9456320a617e9bfc1878c5f6","unresolved":true,"context_lines":[{"line_number":658,"context_line":"  - security_group.name: name_update_rebuild"},{"line_number":659,"context_line":"  - host_status: host_status_update_rebuild"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"**Example Rebuild Server (rebuild Action) (v2.88)**"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":".. literalinclude:: ../../doc/api_samples/servers/v2.88/server-action-rebuild-resp.json"},{"line_number":664,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"92a10d08_7c1fd077","line":661,"range":{"start_line":661,"start_character":44,"end_line":661,"end_character":48},"updated":"2021-01-14 00:35:46.000000000","message":"2.90","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9f5acde32494e0f147f499299406c8f1854b8fb6","unresolved":false,"context_lines":[{"line_number":658,"context_line":"  - security_group.name: name_update_rebuild"},{"line_number":659,"context_line":"  - host_status: host_status_update_rebuild"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"**Example Rebuild Server (rebuild Action) (v2.88)**"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":".. literalinclude:: ../../doc/api_samples/servers/v2.88/server-action-rebuild-resp.json"},{"line_number":664,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"d8638cc8_3099705a","line":661,"range":{"start_line":661,"start_character":44,"end_line":661,"end_character":48},"in_reply_to":"92a10d08_7c1fd077","updated":"2021-01-14 07:08:52.000000000","message":"Done","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0ba86fec4b96049a9456320a617e9bfc1878c5f6","unresolved":true,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"**Example Rebuild Server (rebuild Action) (v2.88)**"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":".. literalinclude:: ../../doc/api_samples/servers/v2.88/server-action-rebuild-resp.json"},{"line_number":664,"context_line":"   :language: javascript"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"Remove (Disassociate) Floating Ip (removeFloatingIp Action) (DEPRECATED)"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"6c676e51_cd09cc51","line":663,"range":{"start_line":663,"start_character":51,"end_line":663,"end_character":55},"updated":"2021-01-14 00:35:46.000000000","message":"ditto","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"9f5acde32494e0f147f499299406c8f1854b8fb6","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"**Example Rebuild Server (rebuild Action) (v2.88)**"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":".. literalinclude:: ../../doc/api_samples/servers/v2.88/server-action-rebuild-resp.json"},{"line_number":664,"context_line":"   :language: javascript"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"Remove (Disassociate) Floating Ip (removeFloatingIp Action) (DEPRECATED)"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"32706556_c849ae11","line":663,"range":{"start_line":663,"start_character":51,"end_line":663,"end_character":55},"in_reply_to":"6c676e51_cd09cc51","updated":"2021-01-14 07:08:52.000000000","message":"Done","commit_id":"d6f2e51b77dc1f21b93428271640db38c40e6003"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2c419be5646f28cdbc37111e4d73ca967d70727d","unresolved":true,"context_lines":[{"line_number":239,"context_line":"    * 2.88 - Replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the following APIs:"},{"line_number":240,"context_line":"             ``GET /servers``, ``GET /servers/detail``,"},{"line_number":241,"context_line":"             ``PUT /servers/{server_id}`` and"},{"line_number":242,"context_line":"             ``POST /servers/{server_id}/action``."},{"line_number":243,"context_line":"\"\"\""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"9513f6ea_918ed137","line":242,"updated":"2021-01-04 15:42:47.000000000","message":"you can do a bullet point list here similar to the release notes","commit_id":"0018c5cd4600feedbfe38fdb5713d9198f06a43f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bb83ea564f2bb92945653a033cb1c5ca5c5cb95d","unresolved":true,"context_lines":[{"line_number":244,"context_line":"    * 2.90 - Replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the following APIs:"},{"line_number":245,"context_line":"             ``GET /servers``, ``GET /servers/detail`` and"},{"line_number":246,"context_line":"             ``PUT /servers/{server_id}``."},{"line_number":247,"context_line":"             ``POST /servers/{server_id}/action``."},{"line_number":248,"context_line":"\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":7,"id":"74737c82_f1130cb9","line":247,"range":{"start_line":247,"start_character":41,"end_line":247,"end_character":47},"updated":"2021-01-22 22:01:57.000000000","message":"POST /servers/{server_id}/action (rebuild)","commit_id":"e8c9eb13247ca32f0ad72a3861512e9bf76b3979"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cc10fd58ab3c0ea3974ba2891fb7081c47fa1292","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    * 2.90 - Replaces \u0027tenant_id\u0027 with \u0027project_id\u0027 in the following APIs:"},{"line_number":245,"context_line":"             ``GET /servers``, ``GET /servers/detail`` and"},{"line_number":246,"context_line":"             ``PUT /servers/{server_id}``."},{"line_number":247,"context_line":"             ``POST /servers/{server_id}/action``."},{"line_number":248,"context_line":"\"\"\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f77fa1a_12a69311","line":247,"range":{"start_line":247,"start_character":41,"end_line":247,"end_character":47},"in_reply_to":"74737c82_f1130cb9","updated":"2021-01-25 13:40:09.000000000","message":"Done","commit_id":"e8c9eb13247ca32f0ad72a3861512e9bf76b3979"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2c419be5646f28cdbc37111e4d73ca967d70727d","unresolved":true,"context_lines":[{"line_number":1150,"context_line":"* ``GET /servers``"},{"line_number":1151,"context_line":"* ``GET /servers/detail``"},{"line_number":1152,"context_line":"* ``PUT /servers/{server_id}``"},{"line_number":1153,"context_line":"* ``POST /servers/{server_id}/action``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7b0f58b1_6d76e7b4","line":1153,"range":{"start_line":1153,"start_character":0,"end_line":1153,"end_character":38},"updated":"2021-01-04 15:42:47.000000000","message":"please add a note that this is currently incomplete (as it is only done for rebuild). Then you can remove this note when the last action is transformed.","commit_id":"0018c5cd4600feedbfe38fdb5713d9198f06a43f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c83e959a7ee211c426e9077b0dd309dbaf1707cd","unresolved":true,"context_lines":[{"line_number":1150,"context_line":"* ``GET /servers``"},{"line_number":1151,"context_line":"* ``GET /servers/detail``"},{"line_number":1152,"context_line":"* ``PUT /servers/{server_id}``"},{"line_number":1153,"context_line":"* ``POST /servers/{server_id}/action``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9bd9ada1_453041d0","line":1153,"range":{"start_line":1153,"start_character":0,"end_line":1153,"end_character":38},"in_reply_to":"7b0f58b1_6d76e7b4","updated":"2021-01-04 15:48:26.000000000","message":"I\u0027ve just realized that Rebuild was the only action that returned tenant_id so you can ignore my above comment.","commit_id":"0018c5cd4600feedbfe38fdb5713d9198f06a43f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bb83ea564f2bb92945653a033cb1c5ca5c5cb95d","unresolved":true,"context_lines":[{"line_number":1191,"context_line":"* ``GET /servers``"},{"line_number":1192,"context_line":"* ``GET /servers/detail``"},{"line_number":1193,"context_line":"* ``PUT /servers/{server_id}``"},{"line_number":1194,"context_line":"* ``POST /servers/{server_id}/action``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8bb9bfc7_74270400","line":1194,"range":{"start_line":1194,"start_character":36,"end_line":1194,"end_character":37},"updated":"2021-01-22 22:01:57.000000000","message":"ditto","commit_id":"e8c9eb13247ca32f0ad72a3861512e9bf76b3979"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cc10fd58ab3c0ea3974ba2891fb7081c47fa1292","unresolved":false,"context_lines":[{"line_number":1191,"context_line":"* ``GET /servers``"},{"line_number":1192,"context_line":"* ``GET /servers/detail``"},{"line_number":1193,"context_line":"* ``PUT /servers/{server_id}``"},{"line_number":1194,"context_line":"* ``POST /servers/{server_id}/action``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b772e9fe_cff0e8df","line":1194,"range":{"start_line":1194,"start_character":36,"end_line":1194,"end_character":37},"in_reply_to":"8bb9bfc7_74270400","updated":"2021-01-25 13:40:09.000000000","message":"Done","commit_id":"e8c9eb13247ca32f0ad72a3861512e9bf76b3979"}],"nova/tests/unit/api/openstack/compute/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c48a686933c2721dfe226cd12c01c3fd32f9cd68","unresolved":true,"context_lines":[{"line_number":3031,"context_line":"        self.mock_get.side_effect \u003d fake_get"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3034,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3035,"context_line":""},{"line_number":3036,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3037,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":16,"id":"8ab0ba48_90d978dc","line":3034,"range":{"start_line":3034,"start_character":54,"end_line":3034,"end_character":55},"updated":"2021-05-21 01:32:03.000000000","message":"you removed the check from this test-\n        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])","commit_id":"487f16ad3f86912869848e4233d8d4fc4b19fabd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1571ced70853bfcdd9c65d3d5dc7070be0e18987","unresolved":false,"context_lines":[{"line_number":3031,"context_line":"        self.mock_get.side_effect \u003d fake_get"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3034,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3035,"context_line":""},{"line_number":3036,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3037,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":16,"id":"edd5e049_9afa99fe","line":3034,"range":{"start_line":3034,"start_character":54,"end_line":3034,"end_character":55},"in_reply_to":"8ab0ba48_90d978dc","updated":"2021-05-21 07:06:33.000000000","message":"Ack, rebase to master and change 2.89 to 2.88 really easy make these mistakes.","commit_id":"487f16ad3f86912869848e4233d8d4fc4b19fabd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c48a686933c2721dfe226cd12c01c3fd32f9cd68","unresolved":true,"context_lines":[{"line_number":3064,"context_line":"                                                   body\u003dbody).obj"},{"line_number":3065,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3066,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3067,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3068,"context_line":""},{"line_number":3069,"context_line":""},{"line_number":3070,"context_line":"class ServersControllerDeleteTest(ControllerTest):"}],"source_content_type":"text/x-python","patch_set":16,"id":"78146c71_b6a7a9a0","line":3067,"range":{"start_line":3067,"start_character":0,"end_line":3067,"end_character":57},"updated":"2021-05-21 01:32:03.000000000","message":"this is there in L3065. this is moved here from previous test.","commit_id":"487f16ad3f86912869848e4233d8d4fc4b19fabd"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1571ced70853bfcdd9c65d3d5dc7070be0e18987","unresolved":false,"context_lines":[{"line_number":3064,"context_line":"                                                   body\u003dbody).obj"},{"line_number":3065,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3066,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3067,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3068,"context_line":""},{"line_number":3069,"context_line":""},{"line_number":3070,"context_line":"class ServersControllerDeleteTest(ControllerTest):"}],"source_content_type":"text/x-python","patch_set":16,"id":"c9b316d5_25c06b2b","line":3067,"range":{"start_line":3067,"start_character":0,"end_line":3067,"end_character":57},"in_reply_to":"78146c71_b6a7a9a0","updated":"2021-05-21 07:06:33.000000000","message":"Ack","commit_id":"487f16ad3f86912869848e4233d8d4fc4b19fabd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0fda7d6ce97741a8b1be61c17709dc014d2ca2d9","unresolved":true,"context_lines":[{"line_number":3031,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"        self.assertIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3034,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3035,"context_line":""},{"line_number":3036,"context_line":"    def test_get_server_with_project_id(self):"},{"line_number":3037,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.path_with_id % FAKE_UUID,"}],"source_content_type":"text/x-python","patch_set":17,"id":"91909d34_837ff2d8","line":3034,"range":{"start_line":3034,"start_character":26,"end_line":3034,"end_character":35},"updated":"2021-05-24 21:14:33.000000000","message":"It should be project_id. this can be added in its original patch in this series where this test is added, gave comment there\n\nhttps://review.opendev.org/c/openstack/nova/+/764292/24/nova/tests/unit/api/openstack/compute/test_servers.py#2993\n\nself.assertNotIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])","commit_id":"9f01e59b186a5e0a54af62b917ec68af8f8beb12"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3858b5f322ff6d1e2d009371d203bb5d67ddf8a","unresolved":false,"context_lines":[{"line_number":3031,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3032,"context_line":""},{"line_number":3033,"context_line":"        self.assertIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3034,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3035,"context_line":""},{"line_number":3036,"context_line":"    def test_get_server_with_project_id(self):"},{"line_number":3037,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.path_with_id % FAKE_UUID,"}],"source_content_type":"text/x-python","patch_set":17,"id":"c76efe72_b5527dfd","line":3034,"range":{"start_line":3034,"start_character":26,"end_line":3034,"end_character":35},"in_reply_to":"91909d34_837ff2d8","updated":"2021-05-28 01:37:02.000000000","message":"Done","commit_id":"9f01e59b186a5e0a54af62b917ec68af8f8beb12"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0fda7d6ce97741a8b1be61c17709dc014d2ca2d9","unresolved":true,"context_lines":[{"line_number":3048,"context_line":"        self.mock_get.side_effect \u003d fake_get"},{"line_number":3049,"context_line":""},{"line_number":3050,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3051,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3052,"context_line":""},{"line_number":3053,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3054,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":17,"id":"b67f3772_17aabad9","line":3051,"range":{"start_line":3051,"start_character":54,"end_line":3051,"end_character":55},"updated":"2021-05-24 21:14:33.000000000","message":"below is still missing from original tests\n\nself.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])","commit_id":"9f01e59b186a5e0a54af62b917ec68af8f8beb12"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"a3858b5f322ff6d1e2d009371d203bb5d67ddf8a","unresolved":false,"context_lines":[{"line_number":3048,"context_line":"        self.mock_get.side_effect \u003d fake_get"},{"line_number":3049,"context_line":""},{"line_number":3050,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3051,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3052,"context_line":""},{"line_number":3053,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3054,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":17,"id":"e6e29b3f_0d66c5c4","line":3051,"range":{"start_line":3051,"start_character":54,"end_line":3051,"end_character":55},"in_reply_to":"b67f3772_17aabad9","updated":"2021-05-28 01:37:02.000000000","message":"Done","commit_id":"9f01e59b186a5e0a54af62b917ec68af8f8beb12"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"817308632762afb4d763e2ecf0b1bbf554938bd2","unresolved":true,"context_lines":[{"line_number":2861,"context_line":""},{"line_number":2862,"context_line":"class ServersControllerTestV289(ControllerTest):"},{"line_number":2863,"context_line":"    wsgi_api_version \u003d \u00272.89\u0027"},{"line_number":2864,"context_line":"    image_uuid \u003d \u002776fa36fc-c930-4bf3-8c8a-ea2a2420deb6\u0027"},{"line_number":2865,"context_line":""},{"line_number":2866,"context_line":"    def req(self, url, use_admin_context\u003dFalse,"},{"line_number":2867,"context_line":"            version\u003dwsgi_api_version):"}],"source_content_type":"text/x-python","patch_set":20,"id":"176225d8_c3300d29","line":2864,"updated":"2021-06-29 17:05:45.000000000","message":"This is from the glance fixture. Can you use that reference rather than hardcoding this here?\n\n  image_uuid \u003d nova_fixtures.GlanceFixture.image3[\u0027uuid\u0027]\n\nI assume this was picked at random too. If not, a single line comment explaining the rationale behind why this was chosen this way would be appreciated","commit_id":"f2dd0f80778851db8a47208739c9f31e8f88a24b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"817308632762afb4d763e2ecf0b1bbf554938bd2","unresolved":true,"context_lines":[{"line_number":3056,"context_line":""},{"line_number":3057,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3058,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3059,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3060,"context_line":""},{"line_number":3061,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3062,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":20,"id":"0d3d7c7e_2b2f40a1","line":3059,"updated":"2021-06-29 17:05:45.000000000","message":"nit: this should be in the previous patch, naturally","commit_id":"f2dd0f80778851db8a47208739c9f31e8f88a24b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"2337dee376961286e3a4014c524f3e96108b3808","unresolved":true,"context_lines":[{"line_number":3056,"context_line":""},{"line_number":3057,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3058,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3059,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3060,"context_line":""},{"line_number":3061,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3062,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":20,"id":"b70a1367_09f549c0","line":3059,"in_reply_to":"0d3d7c7e_2b2f40a1","updated":"2021-08-10 02:02:47.000000000","message":"I have not changed here, you can see line3090, I think this is a gerrit page show issue.","commit_id":"f2dd0f80778851db8a47208739c9f31e8f88a24b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e535c926430eb29bab91e76c20e53b2e48c308f6","unresolved":true,"context_lines":[{"line_number":3056,"context_line":""},{"line_number":3057,"context_line":"        res_dict \u003d self.controller.show(req, FAKE_UUID)"},{"line_number":3058,"context_line":"        self.assertIn(\u0027project_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3059,"context_line":"        self.assertNotIn(\u0027tenant_id\u0027, res_dict[\u0027server\u0027])"},{"line_number":3060,"context_line":""},{"line_number":3061,"context_line":"    def test_rebuild_response_show_tenant_id_with_old_version(self):"},{"line_number":3062,"context_line":"        body \u003d {\u0027rebuild\u0027: {\"imageRef\": self.image_uuid}}"}],"source_content_type":"text/x-python","patch_set":20,"id":"0ac12477_f35431e5","line":3059,"in_reply_to":"b70a1367_09f549c0","updated":"2022-02-14 18:05:40.000000000","message":"yeah, its confusing gerrit view but there is no change in existing test.","commit_id":"f2dd0f80778851db8a47208739c9f31e8f88a24b"}],"releasenotes/notes/bp-remove-tenant-id-dd0193d587a00d30.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2c419be5646f28cdbc37111e4d73ca967d70727d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4d733e56_bb03147c","line":12,"updated":"2021-01-04 15:42:47.000000000","message":"cool!","commit_id":"0018c5cd4600feedbfe38fdb5713d9198f06a43f"}]}