)]}'
{"nova/tests/unit/objects/test_numa.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad35c3716351b9bc075b3c4f1c0b08fefd308e","unresolved":true,"context_lines":[{"line_number":352,"context_line":"            network_metadata\u003dnetwork_metadata)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        versions \u003d ovo_base.obj_tree_get_versions(\u0027NUMACell\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        primitive \u003d cell.obj_to_primitive(target_version\u003d\u00271.4\u0027,"},{"line_number":357,"context_line":"                                          version_manifest\u003dversions)"},{"line_number":358,"context_line":"        self.assertIn(\u0027pcpuset\u0027, primitive[\u0027nova_object.data\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"d9ea1063_e8d827c3","line":355,"updated":"2021-02-19 18:07:04.000000000","message":"Can you add a check for 1.5 here that asserts socket is present there?","commit_id":"d297ed6db057764e6b387efba3bac750aec0eeee"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"22de5f68a6c58991b4cfc1601232328fc8642e21","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            network_metadata\u003dnetwork_metadata)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        versions \u003d ovo_base.obj_tree_get_versions(\u0027NUMACell\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        primitive \u003d cell.obj_to_primitive(target_version\u003d\u00271.4\u0027,"},{"line_number":357,"context_line":"                                          version_manifest\u003dversions)"},{"line_number":358,"context_line":"        self.assertIn(\u0027pcpuset\u0027, primitive[\u0027nova_object.data\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"aee6a2bd_dabddeb0","line":355,"in_reply_to":"d9ea1063_e8d827c3","updated":"2021-02-20 00:16:55.000000000","message":"Done","commit_id":"d297ed6db057764e6b387efba3bac750aec0eeee"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ad35c3716351b9bc075b3c4f1c0b08fefd308e","unresolved":true,"context_lines":[{"line_number":7537,"context_line":"            socket_id \u003d None"},{"line_number":7538,"context_line":"            sockets \u003d set([cpu.socket_id for cpu in cell.cpus])"},{"line_number":7539,"context_line":"            if len(sockets) \u003d\u003d 1:"},{"line_number":7540,"context_line":"                socket_id \u003d sockets.pop()"},{"line_number":7541,"context_line":""},{"line_number":7542,"context_line":"            cpuset \u003d cpus \u0026 available_shared_cpus"},{"line_number":7543,"context_line":"            pcpuset \u003d cpus \u0026 available_dedicated_cpus"}],"source_content_type":"text/x-python","patch_set":17,"id":"332e0790_68bcd902","line":7540,"updated":"2021-02-19 18:07:04.000000000","message":"Want to stick an exception in here if sockets \u003e 1 ?","commit_id":"d297ed6db057764e6b387efba3bac750aec0eeee"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"abf5c15ebd5797cafac42cb74bfb660c90db6b74","unresolved":false,"context_lines":[{"line_number":7537,"context_line":"            socket_id \u003d None"},{"line_number":7538,"context_line":"            sockets \u003d set([cpu.socket_id for cpu in cell.cpus])"},{"line_number":7539,"context_line":"            if len(sockets) \u003d\u003d 1:"},{"line_number":7540,"context_line":"                socket_id \u003d sockets.pop()"},{"line_number":7541,"context_line":""},{"line_number":7542,"context_line":"            cpuset \u003d cpus \u0026 available_shared_cpus"},{"line_number":7543,"context_line":"            pcpuset \u003d cpus \u0026 available_dedicated_cpus"}],"source_content_type":"text/x-python","patch_set":17,"id":"530b6697_12ffe9f0","line":7540,"in_reply_to":"28dadaaf_e4275ce7","updated":"2021-02-23 17:27:35.000000000","message":"Fair point. A warning wfm","commit_id":"d297ed6db057764e6b387efba3bac750aec0eeee"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"22de5f68a6c58991b4cfc1601232328fc8642e21","unresolved":true,"context_lines":[{"line_number":7537,"context_line":"            socket_id \u003d None"},{"line_number":7538,"context_line":"            sockets \u003d set([cpu.socket_id for cpu in cell.cpus])"},{"line_number":7539,"context_line":"            if len(sockets) \u003d\u003d 1:"},{"line_number":7540,"context_line":"                socket_id \u003d sockets.pop()"},{"line_number":7541,"context_line":""},{"line_number":7542,"context_line":"            cpuset \u003d cpus \u0026 available_shared_cpus"},{"line_number":7543,"context_line":"            pcpuset \u003d cpus \u0026 available_dedicated_cpus"}],"source_content_type":"text/x-python","patch_set":17,"id":"28dadaaf_e4275ce7","line":7540,"in_reply_to":"332e0790_68bcd902","updated":"2021-02-20 00:16:55.000000000","message":"I can log a warning, but raising an exception seems extreme - it would effectively prevent the libvirt driver from starting, right? Which we don\u0027t want - multiple sockets in a single NUMA node worked just fine until now, and should continue to do so, we just can\u0027t support it for the `socket` policy.","commit_id":"d297ed6db057764e6b387efba3bac750aec0eeee"}]}