)]}'
{"nova/tests/integrated/v3/test_shelve.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d2e1c58f2b2f25dce4651eb42c08b7fc8fd0786a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        # Don\u0027t offload instance, so we can test the offload call."},{"line_number":30,"context_line":"        CONF.set_override(\u0027shelved_offload_time\u0027, -1)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_server_action(self, uuid, template, action):"},{"line_number":33,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":34,"context_line":"                                 \u0027os-shelve\u0027, {\u0027action\u0027: action})"},{"line_number":35,"context_line":"        self.assertEqual(response.status, 202)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FXok%3D","line":32,"updated":"2014-03-18 10:29:55.000000000","message":"I don\u0027t understand the aim of this new param, where it is used?","commit_id":"438cae2c6485a63f3b68a5656a0a43030a42efa9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd4281894d35d95efeb6b5e48340db361bd459c1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        # Don\u0027t offload instance, so we can test the offload call."},{"line_number":30,"context_line":"        CONF.set_override(\u0027shelved_offload_time\u0027, -1)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_server_action(self, uuid, template, action):"},{"line_number":33,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":34,"context_line":"                                 \u0027os-shelve\u0027, {\u0027action\u0027: action})"},{"line_number":35,"context_line":"        self.assertEqual(response.status, 202)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FRfY%3D","line":32,"in_reply_to":"AAAAWH%2F%2FXok%3D","updated":"2014-03-18 23:23:15.000000000","message":"there is a bug in this patch.\nI wrote the detail in the following.","commit_id":"438cae2c6485a63f3b68a5656a0a43030a42efa9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d2e1c58f2b2f25dce4651eb42c08b7fc8fd0786a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_server_action(self, uuid, template, action):"},{"line_number":33,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":34,"context_line":"                                 \u0027os-shelve\u0027, {\u0027action\u0027: action})"},{"line_number":35,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":36,"context_line":"        self.assertEqual(response.read(), \"\")"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FXo0%3D","line":34,"updated":"2014-03-18 10:29:55.000000000","message":"this is not related to your change","commit_id":"438cae2c6485a63f3b68a5656a0a43030a42efa9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fd4281894d35d95efeb6b5e48340db361bd459c1","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _test_server_action(self, uuid, template, action):"},{"line_number":33,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"},{"line_number":34,"context_line":"                                 \u0027os-shelve\u0027, {\u0027action\u0027: action})"},{"line_number":35,"context_line":"        self.assertEqual(response.status, 202)"},{"line_number":36,"context_line":"        self.assertEqual(response.read(), \"\")"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FRfw%3D","line":34,"in_reply_to":"AAAAWH%2F%2FXo0%3D","updated":"2014-03-18 23:23:15.000000000","message":"related. and here should be template instead of \u0027os-shelve\u0027.\n\n2nd argument of _do_post() call is a template file, and 3rd argument is a value which is replaced in the template file. By setting them into one line, the line shows it more clearly, I feel.","commit_id":"438cae2c6485a63f3b68a5656a0a43030a42efa9"}]}