)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":18,"context_line":"config."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Functional tests are included to verify the basic behaviour of both this"},{"line_number":21,"context_line":"new registration code and now this leads to instances being effectively"},{"line_number":22,"context_line":"pinned to the machine type used during their initial spawn."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"blueprint: libvirt-default-machine-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"e6d62798_c6fde4aa","line":21,"range":{"start_line":21,"start_character":26,"end_line":21,"end_character":29},"updated":"2021-02-15 15:11:57.000000000","message":"how?","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"config."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Functional tests are included to verify the basic behaviour of both this"},{"line_number":21,"context_line":"new registration code and now this leads to instances being effectively"},{"line_number":22,"context_line":"pinned to the machine type used during their initial spawn."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"blueprint: libvirt-default-machine-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"50b0c67a_472e9671","line":21,"range":{"start_line":21,"start_character":26,"end_line":21,"end_character":29},"in_reply_to":"e6d62798_c6fde4aa","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"}],"nova/tests/fixtures.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":true,"context_lines":[{"line_number":2240,"context_line":"    }"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"    auto_disk_config_enabled_image \u003d {"},{"line_number":2243,"context_line":"        \u0027id\u0027: \u002770a599e0-31e7-49b7-b260-868f441e862b\u0027,"},{"line_number":2244,"context_line":"        \u0027name\u0027: \u0027fakeimage7\u0027,"},{"line_number":2245,"context_line":"        \u0027created_at\u0027: timestamp,"},{"line_number":2246,"context_line":"        \u0027updated_at\u0027: timestamp,"}],"source_content_type":"text/x-python","patch_set":6,"id":"95038e4a_1ee60535","line":2243,"range":{"start_line":2243,"start_character":0,"end_line":2243,"end_character":53},"updated":"2021-02-08 12:52:53.000000000","message":"FWIW I\u0027m going to write up a fup to convert these to uuidsentinels later.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":2240,"context_line":"    }"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"    auto_disk_config_enabled_image \u003d {"},{"line_number":2243,"context_line":"        \u0027id\u0027: \u002770a599e0-31e7-49b7-b260-868f441e862b\u0027,"},{"line_number":2244,"context_line":"        \u0027name\u0027: \u0027fakeimage7\u0027,"},{"line_number":2245,"context_line":"        \u0027created_at\u0027: timestamp,"},{"line_number":2246,"context_line":"        \u0027updated_at\u0027: timestamp,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8fd8eb81_ba0e7635","line":2243,"range":{"start_line":2243,"start_character":0,"end_line":2243,"end_character":53},"in_reply_to":"95038e4a_1ee60535","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"557f0f688f4417a566fedc8ae3b6fe3b33166207","unresolved":true,"context_lines":[{"line_number":2265,"context_line":"    }"},{"line_number":2266,"context_line":""},{"line_number":2267,"context_line":"    hw_machine_type_image \u003d copy.deepcopy(image1)"},{"line_number":2268,"context_line":"    hw_machine_type_image[\u0027id\u0027] \u003d uuidsentinel.hw_machine_type_image_id"},{"line_number":2269,"context_line":"    hw_machine_type_image[\u0027properties\u0027][\u0027hw_machine_type\u0027] \u003d \u0027q35\u0027"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"    def __init__(self, test):"}],"source_content_type":"text/x-python","patch_set":6,"id":"c581636d_40cf563a","line":2268,"range":{"start_line":2268,"start_character":47,"end_line":2268,"end_character":71},"updated":"2021-02-05 02:04:55.000000000","message":"you could add q35 to this so that its clear that it has q35 set.\njust a tought.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":2265,"context_line":"    }"},{"line_number":2266,"context_line":""},{"line_number":2267,"context_line":"    hw_machine_type_image \u003d copy.deepcopy(image1)"},{"line_number":2268,"context_line":"    hw_machine_type_image[\u0027id\u0027] \u003d uuidsentinel.hw_machine_type_image_id"},{"line_number":2269,"context_line":"    hw_machine_type_image[\u0027properties\u0027][\u0027hw_machine_type\u0027] \u003d \u0027q35\u0027"},{"line_number":2270,"context_line":""},{"line_number":2271,"context_line":"    def __init__(self, test):"}],"source_content_type":"text/x-python","patch_set":6,"id":"8611c10e_96708ae9","line":2268,"range":{"start_line":2268,"start_character":47,"end_line":2268,"end_character":71},"in_reply_to":"c581636d_40cf563a","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":2268,"context_line":"    # setUp of this fixture to avoid changes to the API sample tests."},{"line_number":2269,"context_line":"    hw_machine_type_q35_image \u003d copy.deepcopy(image1)"},{"line_number":2270,"context_line":"    hw_machine_type_q35_image[\u0027id\u0027] \u003d uuidsentinel.hw_machine_type_q35_image_id"},{"line_number":2271,"context_line":"    hw_machine_type_q35_image[\u0027properties\u0027][\u0027hw_machine_type\u0027] \u003d \u0027q35\u0027"},{"line_number":2272,"context_line":""},{"line_number":2273,"context_line":"    def __init__(self, test):"},{"line_number":2274,"context_line":"        super().__init__()"}],"source_content_type":"text/x-python","patch_set":11,"id":"be519477_24c34c45","line":2271,"updated":"2021-02-15 15:11:57.000000000","message":"Rather than polluting the fixture, can we just create this where we use it? You should be able to do\n\n  self.glance \u003d self.useFixture(nova_fixtures.GlanceFixture(self))\n  hw_machine_type_q35_image \u003d copy.deepcopy(self.glance.image1)\n  ...\n  self.glance.create(hw_machine_type_q35_image)\n\nLater: In fact, a grep show an existing example in \u0027nova/tests/functional/regressions/test_bug_1895696.py\u0027 from you (I\u0027ve clearly said this before 😄)","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":2268,"context_line":"    # setUp of this fixture to avoid changes to the API sample tests."},{"line_number":2269,"context_line":"    hw_machine_type_q35_image \u003d copy.deepcopy(image1)"},{"line_number":2270,"context_line":"    hw_machine_type_q35_image[\u0027id\u0027] \u003d uuidsentinel.hw_machine_type_q35_image_id"},{"line_number":2271,"context_line":"    hw_machine_type_q35_image[\u0027properties\u0027][\u0027hw_machine_type\u0027] \u003d \u0027q35\u0027"},{"line_number":2272,"context_line":""},{"line_number":2273,"context_line":"    def __init__(self, test):"},{"line_number":2274,"context_line":"        super().__init__()"}],"source_content_type":"text/x-python","patch_set":11,"id":"0cd58c3b_e9cf0c4b","line":2271,"in_reply_to":"be519477_24c34c45","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"}],"nova/tests/functional/libvirt/test_machine_type.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            return self.guest_configs[instance.uuid]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":45,"context_line":"            \u0027nova.virt.libvirt.LibvirtDriver._get_guest_config\u0027,"},{"line_number":46,"context_line":"            _get_guest_config))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _create_servers(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a67a06e5_ce8238f9","line":45,"updated":"2021-02-05 01:48:47.000000000","message":"this might be a useful fixture to have by default but yes +1","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            return self.guest_configs[instance.uuid]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":45,"context_line":"            \u0027nova.virt.libvirt.LibvirtDriver._get_guest_config\u0027,"},{"line_number":46,"context_line":"            _get_guest_config))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _create_servers(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"0e820765_eb0ea2e6","line":45,"in_reply_to":"a67a06e5_ce8238f9","updated":"2021-02-08 12:52:53.000000000","message":"Yeah I was thinking of writing this fixture in a fup tbh.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            \u0027server\u0027: {"},{"line_number":53,"context_line":"                \u0027name\u0027: \u0027server_with\u0027,"},{"line_number":54,"context_line":"                \u0027flavorRef\u0027: 1,"},{"line_number":55,"context_line":"                \u0027imageRef\u0027: uuidsentinel.hw_machine_type_image_id,"},{"line_number":56,"context_line":"                \u0027networks\u0027: \u0027none\u0027,"},{"line_number":57,"context_line":"            }"},{"line_number":58,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":6,"id":"c9938873_d995d08b","line":55,"updated":"2021-02-05 01:48:47.000000000","message":"this is a littele non obvious why this work since we dont see the image metadtaa just the uuid.\nbut it does work because you extended the fixture here\nhttps://review.opendev.org/c/openstack/nova/+/767533/6/nova/tests/fixtures.py#2267\nso that there is an image with the same uuid which has q35 set in the image meta.\n\nnice you of the uuidsentinel by the way.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027server\u0027: {"},{"line_number":53,"context_line":"                \u0027name\u0027: \u0027server_with\u0027,"},{"line_number":54,"context_line":"                \u0027flavorRef\u0027: 1,"},{"line_number":55,"context_line":"                \u0027imageRef\u0027: uuidsentinel.hw_machine_type_image_id,"},{"line_number":56,"context_line":"                \u0027networks\u0027: \u0027none\u0027,"},{"line_number":57,"context_line":"            }"},{"line_number":58,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":6,"id":"c3abdf93_c933c915","line":55,"in_reply_to":"c9938873_d995d08b","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        self.assertEqual("},{"line_number":83,"context_line":"            expected_machine_type,"},{"line_number":84,"context_line":"            self.guest_configs[server_id].os_mach_type"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _assert_instance_machine_type("},{"line_number":88,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"42887465_925670a0","line":85,"updated":"2021-02-05 01:48:47.000000000","message":"note in the functest this is a valid assertion\nhowever since we are using the unversioned machine type i just want to point out one thing.\n\nwhile the vaulue nova will set in the xml will be the value we have in the image/system_metadata\nthe value that we read back form libvirt via virsh may be different.\n\nso this work fine for functest as we are using it but the same type of assertion may not work in something like\nthe whitebox-tempest-plugin.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.assertEqual("},{"line_number":83,"context_line":"            expected_machine_type,"},{"line_number":84,"context_line":"            self.guest_configs[server_id].os_mach_type"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _assert_instance_machine_type("},{"line_number":88,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"eee54511_5d104bd8","line":85,"in_reply_to":"42887465_925670a0","updated":"2021-02-08 12:52:53.000000000","message":"Yup correct, whitebox or whatever it is asserting stuff about the domain will have to take that into account and match the underlying machine type.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual("},{"line_number":98,"context_line":"            expected_machine_type,"},{"line_number":99,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027]"},{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_register_machine_type(self):"},{"line_number":103,"context_line":"        # Assert that the machine type of an instance is recorded during"}],"source_content_type":"text/x-python","patch_set":6,"id":"38f03930_9091b476","line":100,"updated":"2021-02-05 01:48:47.000000000","message":"+1\n\nyou could also assert\n\n        self.assertEqual(\n            instance.image_meta.properties.hw_machine_type,\n            instance.system_metadata[\u0027image_hw_machine_type\u0027]\n        )\nbut that is implict in the previous assertions.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual("},{"line_number":98,"context_line":"            expected_machine_type,"},{"line_number":99,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027]"},{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_register_machine_type(self):"},{"line_number":103,"context_line":"        # Assert that the machine type of an instance is recorded during"}],"source_content_type":"text/x-python","patch_set":6,"id":"622f8306_8a94684d","line":100,"in_reply_to":"38f03930_9091b476","updated":"2021-02-08 12:52:53.000000000","message":"Yeah it\u0027s implicit so I\u0027d rather not.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Set the machine type being picked up to avoid this test breaking in"},{"line_number":107,"context_line":"        # the future when the defaults change"},{"line_number":108,"context_line":"        self.flags(hw_machine_type\u003d\u0027x86_64\u003dpc\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Launch two instances, with and without hw_machine_type set as an"},{"line_number":111,"context_line":"        # image property"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d8a1823_2ca2ae99","line":108,"updated":"2021-02-05 01:48:47.000000000","message":"ack","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        # Set the machine type being picked up to avoid this test breaking in"},{"line_number":107,"context_line":"        # the future when the defaults change"},{"line_number":108,"context_line":"        self.flags(hw_machine_type\u003d\u0027x86_64\u003dpc\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # Launch two instances, with and without hw_machine_type set as an"},{"line_number":111,"context_line":"        # image property"}],"source_content_type":"text/x-python","patch_set":6,"id":"1d10b4a9_8bf2388b","line":108,"in_reply_to":"2d8a1823_2ca2ae99","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        # image property"},{"line_number":112,"context_line":"        server_with, server_without \u003d self._create_servers()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Assert that hw_machine_type system_metadata isn\u0027t recorded for the"},{"line_number":115,"context_line":"        # instance *with* the hw_machine_type image property"},{"line_number":116,"context_line":"        self._assert_instance_machine_type("},{"line_number":117,"context_line":"            server_with[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"19292257_b5c242e5","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":68},"updated":"2021-02-05 01:48:47.000000000","message":"you dont actully do this\n\nyou need to do \ninstance \u003d objects.Instance.get_by_uuid(self.context, server_id)\nself.assertNotIn(\u0027hw_machine_type\u0027, instance.system_metadata)","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # image property"},{"line_number":112,"context_line":"        server_with, server_without \u003d self._create_servers()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Assert that hw_machine_type system_metadata isn\u0027t recorded for the"},{"line_number":115,"context_line":"        # instance *with* the hw_machine_type image property"},{"line_number":116,"context_line":"        self._assert_instance_machine_type("},{"line_number":117,"context_line":"            server_with[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"49025361_c07ac492","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":68},"in_reply_to":"19292257_b5c242e5","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Assert that hw_machine_type system_metadata is recorded during spawn"},{"line_number":123,"context_line":"        # for the instance *without* the hw_machine_type image metadata prop"},{"line_number":124,"context_line":"        self._assert_instance_machine_type("},{"line_number":125,"context_line":"            server_without[\u0027id\u0027],"},{"line_number":126,"context_line":"            \u0027pc\u0027,"},{"line_number":127,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ca92e19_a9aecca3","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":42},"updated":"2021-02-05 01:48:47.000000000","message":"this is checking for  instance.system_metadata[\u0027image_hw_machine_type\u0027] see line 99\n\n\nso you need to do\ninstance \u003d objects.Instance.get_by_uuid(self.context, server_id)\nself.assertIn(\u0027hw_machine_type\u0027, instance.system_metadata)\nself.assertNotIn(\u0027image_hw_machine_type\u0027, instance.system_metadata)\nif you actully want to align what is tested with the comment\n\neither that or you need to prefix hw_machine_type with image_\nin \n\"\n        # Assert that hw_machine_type system_metadata is recorded during spawn\n\"\n\ni.e. \n\"\n        # Assert that image_hw_machine_type system_metadata is recorded during spawn\n\"","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # Assert that hw_machine_type system_metadata is recorded during spawn"},{"line_number":123,"context_line":"        # for the instance *without* the hw_machine_type image metadata prop"},{"line_number":124,"context_line":"        self._assert_instance_machine_type("},{"line_number":125,"context_line":"            server_without[\u0027id\u0027],"},{"line_number":126,"context_line":"            \u0027pc\u0027,"},{"line_number":127,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"e24ee416_b50068de","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":42},"in_reply_to":"5ca92e19_a9aecca3","updated":"2021-02-08 12:52:53.000000000","message":"Gah sorry this was left over from when I was using both image_hw_machine_type and hw_machine_type. I\u0027ll rewrite.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            self.context,"},{"line_number":134,"context_line":"            server_without[\u0027id\u0027],"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        instance_without.system_metadata.pop(\u0027image_hw_machine_type\u0027)"},{"line_number":137,"context_line":"        instance_without.save()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Again set the machine type being picked up to avoid this test"}],"source_content_type":"text/x-python","patch_set":6,"id":"0ab6703d_2f772516","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":69},"updated":"2021-02-05 01:48:47.000000000","message":"this is what you would remove if you were storing the machine type in the propty used by the image\nwhen its not present. i take ti you have swapped to doing that. this is what i orgingally was suggesting but\npreviously had a sperate hw_machine_type key.\n\nany yes you have https://review.opendev.org/c/openstack/nova/+/767533/6/nova/virt/libvirt/driver.py#679\nyou had been previoulsy useing hw_machine_type https://review.opendev.org/c/openstack/nova/+/767533/4/nova/virt/libvirt/driver.py#705\nok so the comment above where just not updated  to reflect that.\n\ngiven this change yes this is correct for the current patch logic.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self.context,"},{"line_number":134,"context_line":"            server_without[\u0027id\u0027],"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        instance_without.system_metadata.pop(\u0027image_hw_machine_type\u0027)"},{"line_number":137,"context_line":"        instance_without.save()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        # Again set the machine type being picked up to avoid this test"}],"source_content_type":"text/x-python","patch_set":6,"id":"6032e1b4_f6e0b86a","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":69},"in_reply_to":"0ab6703d_2f772516","updated":"2021-02-08 12:52:53.000000000","message":"Yup sorry just leftover comment cruft.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"557f0f688f4417a566fedc8ae3b6fe3b33166207","unresolved":true,"context_lines":[{"line_number":156,"context_line":"            \u0027pc-q35-1.2.3\u0027,"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_machine_type_after_server_reboot(self):"},{"line_number":160,"context_line":"        # Assert that the recorded machine types don\u0027t change with the reboot"},{"line_number":161,"context_line":"        # of a server, even when the underlying config changes."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"eca9237d_aae16176","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":45},"updated":"2021-02-05 02:04:55.000000000","message":"while i think about it we need a test for rebuild that assert the value is updated on rebuild and we tests for the move operation that assert it does not change.\n\ne.g. cold/live migrate, shleve and resize shoudl not reset the value in system_metadata","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            \u0027pc-q35-1.2.3\u0027,"},{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_machine_type_after_server_reboot(self):"},{"line_number":160,"context_line":"        # Assert that the recorded machine types don\u0027t change with the reboot"},{"line_number":161,"context_line":"        # of a server, even when the underlying config changes."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dded28af_8802fe95","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":45},"in_reply_to":"eca9237d_aae16176","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        # image property"},{"line_number":169,"context_line":"        server_with, server_without \u003d self._create_servers()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # Assert that hw_machine_type system_metadata isn\u0027t recorded for the"},{"line_number":172,"context_line":"        # instance *with* the hw_machine_type image property"},{"line_number":173,"context_line":"        self._assert_instance_machine_type("},{"line_number":174,"context_line":"            server_with[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"85d74e78_56c7cd58","line":171,"range":{"start_line":171,"start_character":22,"end_line":171,"end_character":37},"updated":"2021-02-05 01:48:47.000000000","message":"you are now using image_hw...\nhttps://review.opendev.org/c/openstack/nova/+/767533/6/nova/virt/libvirt/driver.py#679\nso again this is not quite right","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        # image property"},{"line_number":169,"context_line":"        server_with, server_without \u003d self._create_servers()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # Assert that hw_machine_type system_metadata isn\u0027t recorded for the"},{"line_number":172,"context_line":"        # instance *with* the hw_machine_type image property"},{"line_number":173,"context_line":"        self._assert_instance_machine_type("},{"line_number":174,"context_line":"            server_with[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"0e847d31_986f02ab","line":171,"range":{"start_line":171,"start_character":22,"end_line":171,"end_character":37},"in_reply_to":"85d74e78_56c7cd58","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":"        self._assert_guest_config(server_with[\u0027id\u0027], \u0027q35\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Assert that hw_machine_type system_metadata is recorded during spawn"},{"line_number":180,"context_line":"        # for the instance *without* the hw_machine_type image metadata prop"},{"line_number":181,"context_line":"        self._assert_instance_machine_type("},{"line_number":182,"context_line":"            server_without[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"8ca9a8fa_a63923f5","line":179,"range":{"start_line":179,"start_character":22,"end_line":179,"end_character":37},"updated":"2021-02-05 01:48:47.000000000","message":"image_...","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        )"},{"line_number":177,"context_line":"        self._assert_guest_config(server_with[\u0027id\u0027], \u0027q35\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Assert that hw_machine_type system_metadata is recorded during spawn"},{"line_number":180,"context_line":"        # for the instance *without* the hw_machine_type image metadata prop"},{"line_number":181,"context_line":"        self._assert_instance_machine_type("},{"line_number":182,"context_line":"            server_without[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"bc1ed8da_61a6cb4a","line":179,"range":{"start_line":179,"start_character":22,"end_line":179,"end_character":37},"in_reply_to":"8ca9a8fa_a63923f5","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Again set the machine type being picked up to avoid this test"},{"line_number":188,"context_line":"        # breaking in the future when the defaults change"},{"line_number":189,"context_line":"        self.flags(hw_machine_type\u003d\u0027x86_64\u003dpc-q35-1.2.3\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # soft reboot both servers and assert nothing has changed"},{"line_number":192,"context_line":"        self._reboot_server(server_with)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f5284415_ddd848b9","line":189,"updated":"2021-02-05 01:48:47.000000000","message":"right this is the imporant part.\nwe are ensureing if we change the config vaule existing instnace willl not pick up the change.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Again set the machine type being picked up to avoid this test"},{"line_number":188,"context_line":"        # breaking in the future when the defaults change"},{"line_number":189,"context_line":"        self.flags(hw_machine_type\u003d\u0027x86_64\u003dpc-q35-1.2.3\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # soft reboot both servers and assert nothing has changed"},{"line_number":192,"context_line":"        self._reboot_server(server_with)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1e5e5365_48a75de7","line":189,"in_reply_to":"f5284415_ddd848b9","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            \u0027pc\u0027,"},{"line_number":220,"context_line":"        )"},{"line_number":221,"context_line":"        self._assert_guest_config(server_without[\u0027id\u0027], \u0027pc\u0027)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # Launch two more instances, and assert the server_without picks up the"},{"line_number":224,"context_line":"        # new machine type as defined by [libvirt]hw_machine_type"},{"line_number":225,"context_line":"        server_with, server_without \u003d self._create_servers()"}],"source_content_type":"text/x-python","patch_set":6,"id":"db789133_1347393b","line":222,"updated":"2021-02-05 01:48:47.000000000","message":"+1","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            \u0027pc\u0027,"},{"line_number":220,"context_line":"        )"},{"line_number":221,"context_line":"        self._assert_guest_config(server_without[\u0027id\u0027], \u0027pc\u0027)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        # Launch two more instances, and assert the server_without picks up the"},{"line_number":224,"context_line":"        # new machine type as defined by [libvirt]hw_machine_type"},{"line_number":225,"context_line":"        server_with, server_without \u003d self._create_servers()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9225d0c3_f79b65f6","line":222,"in_reply_to":"db789133_1347393b","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bebf4a0297946df69cf49f456b9898b0abe21ab4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6015f5ca_1dabc75e","line":237,"updated":"2021-02-05 01:48:47.000000000","message":"ya that works but it might be nice to have that in a different test.\n\npersonally i would break tese down so that you are more small test rahter then these long multi state test.\n\nso in this case i would boot 1 vm without the image value set tehn update the config, boot a second  instance and assert it pick up the new value.\n\nwepreatly i would have test for hard reboot and soft reboot where you boot 2 instance update config and performe either a hard or soft rebot in spereate tests.\n\nthat way if it failes its easy to see what action failded at a glance.\n\nright now if this test fails there are many placne it could have failed.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4f8ff946_189cc573","line":237,"in_reply_to":"6015f5ca_1dabc75e","updated":"2021-02-08 12:52:53.000000000","message":"Yeah the startup costs for these tests is pretty steep so I wanted to test as much as possible within each but I take your point on debugging this when it fails. I\u0027ll break things about into smaller tests.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45ed519e43983bbb12897cf6205e387de602cb6d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."},{"line_number":35,"context_line":"        # TODO(lyarwood): This seems like a useful thing to do in the libvirt"},{"line_number":36,"context_line":"        # func tests for all computes we start?"},{"line_number":37,"context_line":"        self.start_compute()"},{"line_number":38,"context_line":"        self.guest_configs \u003d {}"},{"line_number":39,"context_line":"        orig_get_config \u003d self.computes[\u0027compute1\u0027].driver._get_guest_config"}],"source_content_type":"text/x-python","patch_set":10,"id":"5ea1654f_f89b0e62","line":36,"updated":"2021-02-12 15:13:01.000000000","message":"When we do this in general then I think it is better to dot his in the libvirt fixture. I guess at some point the current fixture gets the actual config that can store.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."},{"line_number":35,"context_line":"        # TODO(lyarwood): This seems like a useful thing to do in the libvirt"},{"line_number":36,"context_line":"        # func tests for all computes we start?"},{"line_number":37,"context_line":"        self.start_compute()"},{"line_number":38,"context_line":"        self.guest_configs \u003d {}"},{"line_number":39,"context_line":"        orig_get_config \u003d self.computes[\u0027compute1\u0027].driver._get_guest_config"}],"source_content_type":"text/x-python","patch_set":10,"id":"1faf9070_a217069a","line":36,"in_reply_to":"532cbb6e_7106fd56","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"91225fc0b511be5a3bd0c5449ed31a038eb0f69a","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."},{"line_number":35,"context_line":"        # TODO(lyarwood): This seems like a useful thing to do in the libvirt"},{"line_number":36,"context_line":"        # func tests for all computes we start?"},{"line_number":37,"context_line":"        self.start_compute()"},{"line_number":38,"context_line":"        self.guest_configs \u003d {}"},{"line_number":39,"context_line":"        orig_get_config \u003d self.computes[\u0027compute1\u0027].driver._get_guest_config"}],"source_content_type":"text/x-python","patch_set":10,"id":"60e760a4_4f4ff311","line":36,"in_reply_to":"5ea1654f_f89b0e62","updated":"2021-02-15 09:34:28.000000000","message":"We only send XML to the libvirt fixture that I didn\u0027t want to end up asserting in here, IMHO asserting the configuration using the config classes is just as good.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"208d4f6f536f045af1ffd2367f8191b7d8eef04e","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."},{"line_number":35,"context_line":"        # TODO(lyarwood): This seems like a useful thing to do in the libvirt"},{"line_number":36,"context_line":"        # func tests for all computes we start?"},{"line_number":37,"context_line":"        self.start_compute()"},{"line_number":38,"context_line":"        self.guest_configs \u003d {}"},{"line_number":39,"context_line":"        orig_get_config \u003d self.computes[\u0027compute1\u0027].driver._get_guest_config"}],"source_content_type":"text/x-python","patch_set":10,"id":"532cbb6e_7106fd56","line":36,"in_reply_to":"60e760a4_4f4ff311","updated":"2021-02-15 10:12:03.000000000","message":"Ohh, you are right, if you need a config object based assert then you either need to catch the config with this mock, or catch the XML and then covert it back to config object. Both is OK to me.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45ed519e43983bbb12897cf6205e387de602cb6d","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _create_servers(self):"},{"line_number":52,"context_line":"        server_with \u003d self._create_server("},{"line_number":53,"context_line":"            image_uuid\u003duuidsentinel.hw_machine_type_q35_image_id,"},{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":10,"id":"6a694504_9fe682a6","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":64},"updated":"2021-02-12 15:13:01.000000000","message":"I would refer to this as \n  \n    GlanceFixture.hw_machine_type_q35_image[\u0027id\u0027] \n\nto avoid the literal \u0027hw_machine_type_q35_image_id\u0027 here and in the fixture to match.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"91225fc0b511be5a3bd0c5449ed31a038eb0f69a","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _create_servers(self):"},{"line_number":52,"context_line":"        server_with \u003d self._create_server("},{"line_number":53,"context_line":"            image_uuid\u003duuidsentinel.hw_machine_type_q35_image_id,"},{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":10,"id":"45ab4927_0a37d131","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":64},"in_reply_to":"04ff5280_aa3d4720","updated":"2021-02-15 09:34:28.000000000","message":"Yeah I don\u0027t mind either way tbh.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"208d4f6f536f045af1ffd2367f8191b7d8eef04e","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _create_servers(self):"},{"line_number":52,"context_line":"        server_with \u003d self._create_server("},{"line_number":53,"context_line":"            image_uuid\u003duuidsentinel.hw_machine_type_q35_image_id,"},{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":10,"id":"1bca52d4_c4af748b","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":64},"in_reply_to":"04ff5280_aa3d4720","updated":"2021-02-15 10:12:03.000000000","message":"this is now an implicit coupling between the literal \"hw_machine_type_q35_image_id\" between here and the same literal in the GlanceFixture. Note that uuidsentinel will not raise an AttributeError if you misspell the name as it will always generate a uuid for any name. So if the GlanceFixture changes the name then there will be uuid mismatch in the test. In the other hand with GlanceFixture.hw_machine_type_q35_image[\u0027id\u0027]  the coupling is explicit. If the GlanceFixture changes then there will be AttributeError here.\n\nI do support using uuidsentinel in test, but there the creation and the usage of the same sentinel is within the same test case and therefore it easy to see the connection.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _create_servers(self):"},{"line_number":52,"context_line":"        server_with \u003d self._create_server("},{"line_number":53,"context_line":"            image_uuid\u003duuidsentinel.hw_machine_type_q35_image_id,"},{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":10,"id":"a3c45805_9c94ff8d","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":64},"in_reply_to":"1bca52d4_c4af748b","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7eab8289273c9c12abe03a09067cd2f47f2960ef","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _create_servers(self):"},{"line_number":52,"context_line":"        server_with \u003d self._create_server("},{"line_number":53,"context_line":"            image_uuid\u003duuidsentinel.hw_machine_type_q35_image_id,"},{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("}],"source_content_type":"text/x-python","patch_set":10,"id":"04ff5280_aa3d4720","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":64},"in_reply_to":"6a694504_9fe682a6","updated":"2021-02-12 17:57:58.000000000","message":"i kind of think this is nicer as it is but provide we still have q35 in the name i guess its ok.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45ed519e43983bbb12897cf6205e387de602cb6d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("},{"line_number":57,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":58,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"        return (server_with, server_without)"}],"source_content_type":"text/x-python","patch_set":10,"id":"e3ceda6f_6a3cdf67","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":61},"updated":"2021-02-12 15:13:01.000000000","message":"GlanceFixture.image1[\u0027id\u0027]","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("},{"line_number":57,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":58,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"        return (server_with, server_without)"}],"source_content_type":"text/x-python","patch_set":10,"id":"d8678d08_a46f02e7","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":61},"in_reply_to":"e3ceda6f_6a3cdf67","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        self.context \u003d nova_context.get_admin_context()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Add the q35 image to the glance fixture"},{"line_number":31,"context_line":"        self.glance.create(self.context, self.glance.hw_machine_type_q35_image)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."}],"source_content_type":"text/x-python","patch_set":11,"id":"417a40c4_360506f0","line":31,"updated":"2021-02-15 15:11:57.000000000","message":"Aha, you do the create here but not the definition. Let\u0027s move this here. I\u0027d personally be okay with a small bit of duplication if it kept (very) test specific info out of the fixture.","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f0b684ffa3dace3be339ea6bdea6dde6bdf392b5","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        self.context \u003d nova_context.get_admin_context()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Add the q35 image to the glance fixture"},{"line_number":31,"context_line":"        self.glance.create(self.context, self.glance.hw_machine_type_q35_image)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."}],"source_content_type":"text/x-python","patch_set":11,"id":"afada0a6_5986c5df","line":31,"in_reply_to":"417a40c4_360506f0","updated":"2021-02-15 17:55:35.000000000","message":"If the image definition is moved here then I\u0027m more OK to use uuidsentinel in the test as the sentinel will be local to this test instead of being global in fixture","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.context \u003d nova_context.get_admin_context()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        # Add the q35 image to the glance fixture"},{"line_number":31,"context_line":"        self.glance.create(self.context, self.glance.hw_machine_type_q35_image)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # Create a pass-through mock around _get_guest_config to capture the"},{"line_number":34,"context_line":"        # config of an instance so we can assert things about it later."}],"source_content_type":"text/x-python","patch_set":11,"id":"0778a5ed_34d7f9aa","line":31,"in_reply_to":"afada0a6_5986c5df","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("},{"line_number":57,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":58,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"        return (server_with, server_without)"}],"source_content_type":"text/x-python","patch_set":11,"id":"91809cb2_f0509d1f","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":61},"updated":"2021-02-15 15:11:57.000000000","message":"Could we do\n\n  self.glance.image1[\u0027id\u0027]\n\ninstead? Below also","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f0b684ffa3dace3be339ea6bdea6dde6bdf392b5","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("},{"line_number":57,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":58,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"        return (server_with, server_without)"}],"source_content_type":"text/x-python","patch_set":11,"id":"b8ac5d12_086eb9f4","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":61},"in_reply_to":"91809cb2_f0509d1f","updated":"2021-02-15 17:55:35.000000000","message":"yes, please","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        server_without \u003d self._create_server("},{"line_number":57,"context_line":"            image_uuid\u003d\u0027155d900f-4e14-4e4c-a73d-069cbf4541e6\u0027,"},{"line_number":58,"context_line":"            networks\u003d\u0027none\u0027,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":"        return (server_with, server_without)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bc7ff2be_1f465a7d","line":57,"range":{"start_line":57,"start_character":23,"end_line":57,"end_character":61},"in_reply_to":"b8ac5d12_086eb9f4","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.flags(hw_machine_type\u003d\u0027x86_64\u003dpc-q35-1.2.3\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        server_with, server_without \u003d self._create_servers()"},{"line_number":126,"context_line":"        self._assert_machine_type(server_with[\u0027id\u0027], \u0027q35\u0027)"},{"line_number":127,"context_line":"        self._assert_machine_type(server_without[\u0027id\u0027], \u0027pc-q35-1.2.3\u0027)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"e199f76d_e8bfc97a","line":125,"updated":"2021-02-15 15:11:57.000000000","message":"This is a bit misleading. You\u0027re creating new instances but the reuse of the old names makes it look (to me) like you\u0027re referencing the old names. Could you suffix these with e.g. \u0027_a\u0027 and \u0027_b\u0027?","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.flags(hw_machine_type\u003d\u0027x86_64\u003dpc-q35-1.2.3\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        server_with, server_without \u003d self._create_servers()"},{"line_number":126,"context_line":"        self._assert_machine_type(server_with[\u0027id\u0027], \u0027q35\u0027)"},{"line_number":127,"context_line":"        self._assert_machine_type(server_without[\u0027id\u0027], \u0027pc-q35-1.2.3\u0027)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"e889c971_0fb1b892","line":125,"in_reply_to":"e199f76d_e8bfc97a","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        self._reboot_server(server_with, hard\u003dhard)"},{"line_number":166,"context_line":"        self._reboot_server(server_without, hard\u003dhard)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self._assert_machine_type(server_with[\u0027id\u0027], \u0027q35\u0027)"},{"line_number":169,"context_line":"        self._assert_machine_type(server_without[\u0027id\u0027], \u0027pc\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def test_machine_type_after_server_soft_reboot(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"23065853_f38281b7","line":168,"updated":"2021-02-15 15:11:57.000000000","message":"# Assert that the machine types didn\u0027t change after the reboot","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self._reboot_server(server_with, hard\u003dhard)"},{"line_number":166,"context_line":"        self._reboot_server(server_without, hard\u003dhard)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self._assert_machine_type(server_with[\u0027id\u0027], \u0027q35\u0027)"},{"line_number":169,"context_line":"        self._assert_machine_type(server_without[\u0027id\u0027], \u0027pc\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def test_machine_type_after_server_soft_reboot(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"c527ca9d_ad55eb80","line":168,"in_reply_to":"23065853_f38281b7","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"557f0f688f4417a566fedc8ae3b6fe3b33166207","unresolved":true,"context_lines":[{"line_number":2864,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.utils.get_default_machine_type\u0027,"},{"line_number":2865,"context_line":"                new\u003dmock.Mock(return_value\u003d\u0027config-machine_type\u0027))"},{"line_number":2866,"context_line":"    def test_get_guest_config_records_machine_type_in_instance(self):"},{"line_number":2867,"context_line":"        # Assert that the config redrived machine type is recorded when it"},{"line_number":2868,"context_line":"        # isn\u0027t present in the image_meta or system_metadata of an instance."},{"line_number":2869,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":2870,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e1d75aad_32257bc4","line":2867,"range":{"start_line":2867,"start_character":33,"end_line":2867,"end_character":41},"updated":"2021-02-05 02:04:55.000000000","message":"derived?","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":2864,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.utils.get_default_machine_type\u0027,"},{"line_number":2865,"context_line":"                new\u003dmock.Mock(return_value\u003d\u0027config-machine_type\u0027))"},{"line_number":2866,"context_line":"    def test_get_guest_config_records_machine_type_in_instance(self):"},{"line_number":2867,"context_line":"        # Assert that the config redrived machine type is recorded when it"},{"line_number":2868,"context_line":"        # isn\u0027t present in the image_meta or system_metadata of an instance."},{"line_number":2869,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), True)"},{"line_number":2870,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"2bf8a755_6a527daa","line":2867,"range":{"start_line":2867,"start_character":33,"end_line":2867,"end_character":41},"in_reply_to":"e1d75aad_32257bc4","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"557f0f688f4417a566fedc8ae3b6fe3b33166207","unresolved":true,"context_lines":[{"line_number":25635,"context_line":"        )"},{"line_number":25636,"context_line":"        mock_get_by_host.return_value \u003d [instance]"},{"line_number":25637,"context_line":"        self.drvr._register_instance_machine_type()"},{"line_number":25638,"context_line":"        # Assert that we haven\u0027t recorded anything in system_metadata"},{"line_number":25639,"context_line":"        self.assertEqual("},{"line_number":25640,"context_line":"            \u0027existing_type\u0027,"},{"line_number":25641,"context_line":"            instance.image_meta.properties.hw_machine_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0a2f7f30_35908a09","line":25638,"range":{"start_line":25638,"start_character":8,"end_line":25638,"end_character":69},"updated":"2021-02-05 02:04:55.000000000","message":"well since you now use the same key as the image you cant do that unless\nyou set the config to a didfferent value and assert that it set to the image value instead of the config value.\n\nright now this test is relying on the defualt beign pc implictly  corret for this to make that assertion\n\nso you proably should set the config option first to somethign else","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":25635,"context_line":"        )"},{"line_number":25636,"context_line":"        mock_get_by_host.return_value \u003d [instance]"},{"line_number":25637,"context_line":"        self.drvr._register_instance_machine_type()"},{"line_number":25638,"context_line":"        # Assert that we haven\u0027t recorded anything in system_metadata"},{"line_number":25639,"context_line":"        self.assertEqual("},{"line_number":25640,"context_line":"            \u0027existing_type\u0027,"},{"line_number":25641,"context_line":"            instance.image_meta.properties.hw_machine_type)"}],"source_content_type":"text/x-python","patch_set":6,"id":"0dcd63ee_84a8db6c","line":25638,"range":{"start_line":25638,"start_character":8,"end_line":25638,"end_character":69},"in_reply_to":"0a2f7f30_35908a09","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"037a2c9ea41e628aa3256ac24e7f75e81641a5e3","unresolved":true,"context_lines":[{"line_number":5766,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":5767,"context_line":""},{"line_number":5768,"context_line":"            # Find, configure and save the machine type to be used"},{"line_number":5769,"context_line":"            hw_machine_type \u003d instance.system_metadata.get(\u0027hw_machine_type\u0027)"},{"line_number":5770,"context_line":"            if hw_machine_type is None:"},{"line_number":5771,"context_line":"                # If the instance doesn\u0027t have a machine type registered yet"},{"line_number":5772,"context_line":"                # find the default from the image metadata or config before"},{"line_number":5773,"context_line":"                # saving it within system metadata."},{"line_number":5774,"context_line":"                hw_machine_type \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5775,"context_line":"                instance.system_metadata[\u0027hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":5776,"context_line":"            guest.os_mach_type \u003d hw_machine_type"},{"line_number":5777,"context_line":""},{"line_number":5778,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2198140d_2f620db6","line":5775,"range":{"start_line":5769,"start_character":11,"end_line":5775,"end_character":77},"updated":"2021-01-14 11:31:30.000000000","message":"this logic is inverted.\nwe should only get the machinetype form the system metadata if its not in the image metadata\nand if its not in the system metadta then we fall back to the config and record that value in the system_metadata.","commit_id":"2cdf407edca334483c30effbed2a6b8feb56eefe"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":5766,"context_line":"                    raise exception.UEFINotSupported()"},{"line_number":5767,"context_line":""},{"line_number":5768,"context_line":"            # Find, configure and save the machine type to be used"},{"line_number":5769,"context_line":"            hw_machine_type \u003d instance.system_metadata.get(\u0027hw_machine_type\u0027)"},{"line_number":5770,"context_line":"            if hw_machine_type is None:"},{"line_number":5771,"context_line":"                # If the instance doesn\u0027t have a machine type registered yet"},{"line_number":5772,"context_line":"                # find the default from the image metadata or config before"},{"line_number":5773,"context_line":"                # saving it within system metadata."},{"line_number":5774,"context_line":"                hw_machine_type \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5775,"context_line":"                instance.system_metadata[\u0027hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":5776,"context_line":"            guest.os_mach_type \u003d hw_machine_type"},{"line_number":5777,"context_line":""},{"line_number":5778,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a35890ac_934bc5a8","line":5775,"range":{"start_line":5769,"start_character":11,"end_line":5775,"end_character":77},"in_reply_to":"2198140d_2f620db6","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"2cdf407edca334483c30effbed2a6b8feb56eefe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"557f0f688f4417a566fedc8ae3b6fe3b33166207","unresolved":true,"context_lines":[{"line_number":679,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":680,"context_line":"            instance.save()"},{"line_number":681,"context_line":"            LOG.debug(\"Instance machine_type updated to %s\", hw_machine_type,"},{"line_number":682,"context_line":"                      instance\u003dinstance)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def _check_cpu_compatibility(self):"},{"line_number":685,"context_line":"        mode \u003d CONF.libvirt.cpu_mode"}],"source_content_type":"text/x-python","patch_set":6,"id":"6227615b_3a9f70ac","line":682,"updated":"2021-02-05 02:04:55.000000000","message":"+1 we will see this logged once and  only once the first time this is called on a given instance so we can use this to know when it was recoreded and what the value was.\n\ndepending on how we handel rebuild we could use this in test too.\nactully if you really wanted too you could use this in your current func test to assert the regeistration happened via the logs but im not sure that is requried since you are directly chekcing the db values via the instance objects","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"bf220661d450368c5da0972c6148e5d4a9bf566a","unresolved":false,"context_lines":[{"line_number":679,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":680,"context_line":"            instance.save()"},{"line_number":681,"context_line":"            LOG.debug(\"Instance machine_type updated to %s\", hw_machine_type,"},{"line_number":682,"context_line":"                      instance\u003dinstance)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def _check_cpu_compatibility(self):"},{"line_number":685,"context_line":"        mode \u003d CONF.libvirt.cpu_mode"}],"source_content_type":"text/x-python","patch_set":6,"id":"898fdbc5_2a715abe","line":682,"in_reply_to":"6227615b_3a9f70ac","updated":"2021-02-08 12:52:53.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"557f0f688f4417a566fedc8ae3b6fe3b33166207","unresolved":true,"context_lines":[{"line_number":5720,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5721,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5722,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5723,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5724,"context_line":""},{"line_number":5725,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"},{"line_number":5726,"context_line":"                guest.os_bootmenu \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":6,"id":"2855050a_b838b9fa","line":5723,"updated":"2021-02-05 02:04:55.000000000","message":"i would use set default here\n\ne.g. instead of the if do\ninstance.system_metadata.set_default(\u0027image_hw_machine_type\u0027, mtype)\n\nthis worsd too but i think set_default is a nice patteren to use here.\n\ni guess that depens on if instance.system_metadata is populated with the value form the image at this point or not.","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":5720,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5721,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5722,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5723,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5724,"context_line":""},{"line_number":5725,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"},{"line_number":5726,"context_line":"                guest.os_bootmenu \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":6,"id":"9b3d698b_88691753","line":5723,"in_reply_to":"2855050a_b838b9fa","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"7c9bb326cee552e4c3c16f5a68fa3240821d8283"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45ed519e43983bbb12897cf6205e387de602cb6d","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            hw_machine_type \u003d libvirt_utils.get_machine_type("},{"line_number":669,"context_line":"                instance.image_meta)"},{"line_number":670,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":671,"context_line":"            instance.save()"},{"line_number":672,"context_line":"            LOG.debug(\"Instance machine_type updated to %s\", hw_machine_type,"},{"line_number":673,"context_line":"                      instance\u003dinstance)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ad8f093a_725e829c","line":671,"range":{"start_line":671,"start_character":12,"end_line":671,"end_character":27},"updated":"2021-02-12 15:13:01.000000000","message":"wondering if this will become a performance impact as every computer restart for each instance will be updated even if nothing changed. Or is the ovo layer is smart enough to to generate an RPC + DB operation when the current value of image_hw_machine_type is the same as the value we set at L670","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"208d4f6f536f045af1ffd2367f8191b7d8eef04e","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            hw_machine_type \u003d libvirt_utils.get_machine_type("},{"line_number":669,"context_line":"                instance.image_meta)"},{"line_number":670,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":671,"context_line":"            instance.save()"},{"line_number":672,"context_line":"            LOG.debug(\"Instance machine_type updated to %s\", hw_machine_type,"},{"line_number":673,"context_line":"                      instance\u003dinstance)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"36b39b24_fa455339","line":671,"range":{"start_line":671,"start_character":12,"end_line":671,"end_character":27},"in_reply_to":"0e296045_2f982a9e","updated":"2021-02-15 10:12:03.000000000","message":"Ohh, so image_meta.properties.get(\u0027hw_machine_type\u0027) points to the same piece of data as instance.system_metadata[\u0027image_hw_machine_type\u0027]  in sysmeta? Yeah, please makes this information explicit in the code.  \n\nThen it is not a performance impact as the continue above will skip already updated instances.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":668,"context_line":"            hw_machine_type \u003d libvirt_utils.get_machine_type("},{"line_number":669,"context_line":"                instance.image_meta)"},{"line_number":670,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":671,"context_line":"            instance.save()"},{"line_number":672,"context_line":"            LOG.debug(\"Instance machine_type updated to %s\", hw_machine_type,"},{"line_number":673,"context_line":"                      instance\u003dinstance)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fd5d5906_4a282613","line":671,"range":{"start_line":671,"start_character":12,"end_line":671,"end_character":27},"in_reply_to":"36b39b24_fa455339","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"91225fc0b511be5a3bd0c5449ed31a038eb0f69a","unresolved":true,"context_lines":[{"line_number":668,"context_line":"            hw_machine_type \u003d libvirt_utils.get_machine_type("},{"line_number":669,"context_line":"                instance.image_meta)"},{"line_number":670,"context_line":"            instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d hw_machine_type"},{"line_number":671,"context_line":"            instance.save()"},{"line_number":672,"context_line":"            LOG.debug(\"Instance machine_type updated to %s\", hw_machine_type,"},{"line_number":673,"context_line":"                      instance\u003dinstance)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0e296045_2f982a9e","line":671,"range":{"start_line":671,"start_character":12,"end_line":671,"end_character":27},"in_reply_to":"ad8f093a_725e829c","updated":"2021-02-15 09:34:28.000000000","message":"Apologies I need to spell out the fact that hw_machine_type within the stashed image_meta properties image_hw_machine_type *is* image_hw_machine_type within system_metadata:\n\nhttps://github.com/openstack/nova/blob/a7dd1f8881484ba0bf4270dd48109c2be142c333/nova/objects/image_meta.py#L126\nhttps://github.com/openstack/nova/blob/a7dd1f8881484ba0bf4270dd48109c2be142c333/nova/utils.py#L752-L778\n\nI\u0027ll make this clear in the commit and elsewhere in a respin.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45ed519e43983bbb12897cf6205e387de602cb6d","unresolved":true,"context_lines":[{"line_number":5710,"context_line":"            # allowing host defaults to change in the future."},{"line_number":5711,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5712,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5713,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5714,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5715,"context_line":""},{"line_number":5716,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"51cfaa74_6b346f85","line":5713,"range":{"start_line":5713,"start_character":12,"end_line":5713,"end_character":68},"updated":"2021-02-12 15:13:01.000000000","message":"why do we make this conditional? Is it to support rebuild with an image having a different machine_type later?","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"91225fc0b511be5a3bd0c5449ed31a038eb0f69a","unresolved":true,"context_lines":[{"line_number":5710,"context_line":"            # allowing host defaults to change in the future."},{"line_number":5711,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5712,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5713,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5714,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5715,"context_line":""},{"line_number":5716,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"b01e672c_718b5438","line":5713,"range":{"start_line":5713,"start_character":12,"end_line":5713,"end_character":68},"in_reply_to":"51cfaa74_6b346f85","updated":"2021-02-15 09:34:28.000000000","message":"As above, we only want to save the machine type if it\u0027s not already set in the image at this point.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"208d4f6f536f045af1ffd2367f8191b7d8eef04e","unresolved":true,"context_lines":[{"line_number":5710,"context_line":"            # allowing host defaults to change in the future."},{"line_number":5711,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5712,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5713,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5714,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5715,"context_line":""},{"line_number":5716,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"b314a1d1_2d6bd29f","line":5713,"range":{"start_line":5713,"start_character":12,"end_line":5713,"end_character":68},"in_reply_to":"b01e672c_718b5438","updated":"2021-02-15 10:12:03.000000000","message":"ACK. Now I understand","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":5710,"context_line":"            # allowing host defaults to change in the future."},{"line_number":5711,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5712,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5713,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5714,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5715,"context_line":""},{"line_number":5716,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"0c0d41a2_bb9d1ba0","line":5713,"range":{"start_line":5713,"start_character":12,"end_line":5713,"end_character":68},"in_reply_to":"b314a1d1_2d6bd29f","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f0b684ffa3dace3be339ea6bdea6dde6bdf392b5","unresolved":true,"context_lines":[{"line_number":5717,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5718,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5719,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5720,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5721,"context_line":""},{"line_number":5722,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"},{"line_number":5723,"context_line":"                guest.os_bootmenu \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":11,"id":"f217fd8c_0e09ad73","line":5720,"updated":"2021-02-15 17:55:35.000000000","message":"I would add a note here that too that image_meta.properties.get(\u0027hw_machine_type\u0027) and instance.system_metadata[\u0027image_hw_machine_type\u0027] pointing to the same piece of data in the sysmeta.","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":5717,"context_line":"            mtype \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":5718,"context_line":"            guest.os_mach_type \u003d mtype"},{"line_number":5719,"context_line":"            if image_meta.properties.get(\u0027hw_machine_type\u0027) is None:"},{"line_number":5720,"context_line":"                instance.system_metadata[\u0027image_hw_machine_type\u0027] \u003d mtype"},{"line_number":5721,"context_line":""},{"line_number":5722,"context_line":"            if image_meta.properties.get(\u0027hw_boot_menu\u0027) is None:"},{"line_number":5723,"context_line":"                guest.os_bootmenu \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":11,"id":"dd7bc2fc_f858a729","line":5720,"in_reply_to":"f217fd8c_0e09ad73","updated":"2021-02-16 09:53:57.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"}],"releasenotes/notes/libvirt-store-and-change-default-machine-type-bf86b4973c4dee4c.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45ed519e43983bbb12897cf6205e387de602cb6d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    instance at startup and when launching an instance if the machine type is"},{"line_number":6,"context_line":"    not already recorded in the image metadata associated with the instance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    This machine type will then be used when the instance is restarted or"},{"line_number":9,"context_line":"    migrated as it will now appear as a image metadata property associated"},{"line_number":10,"context_line":"    with the instance."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a9a1bc3d_dc19a061","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":39},"updated":"2021-02-12 15:13:01.000000000","message":"Is this also implemented in the current patch? I see that we store the data but I don\u0027t see where we read it to use it","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"208d4f6f536f045af1ffd2367f8191b7d8eef04e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    instance at startup and when launching an instance if the machine type is"},{"line_number":6,"context_line":"    not already recorded in the image metadata associated with the instance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    This machine type will then be used when the instance is restarted or"},{"line_number":9,"context_line":"    migrated as it will now appear as a image metadata property associated"},{"line_number":10,"context_line":"    with the instance."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba23920e_48a0807c","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":39},"in_reply_to":"95ef286d_1a70ad48","updated":"2021-02-15 10:12:03.000000000","message":"Ohh, so you did not need to add any code to for this as as soon we store the machine type in sysmeta it acts like an image meta that is already used during the restart and migration. Cool","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"91225fc0b511be5a3bd0c5449ed31a038eb0f69a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    instance at startup and when launching an instance if the machine type is"},{"line_number":6,"context_line":"    not already recorded in the image metadata associated with the instance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    This machine type will then be used when the instance is restarted or"},{"line_number":9,"context_line":"    migrated as it will now appear as a image metadata property associated"},{"line_number":10,"context_line":"    with the instance."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"95ef286d_1a70ad48","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":39},"in_reply_to":"a9a1bc3d_dc19a061","updated":"2021-02-15 09:34:28.000000000","message":"Yeah again apologies, I\u0027ll call out the link between the image meta props and system metadata in the commit.","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3aa0a7a8342f94557a523e43d0646ca5d9ae2e97","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    instance at startup and when launching an instance if the machine type is"},{"line_number":6,"context_line":"    not already recorded in the image metadata associated with the instance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    This machine type will then be used when the instance is restarted or"},{"line_number":9,"context_line":"    migrated as it will now appear as a image metadata property associated"},{"line_number":10,"context_line":"    with the instance."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c77c1f3b_ad27417b","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":39},"in_reply_to":"ba23920e_48a0807c","updated":"2021-02-16 09:53:57.000000000","message":"Done","commit_id":"94ff125ed9a01d4bf6113ecc3528e2a540fb948d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0182f3989e8586164dd4e83f7ec5eaf37719d258","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    not already recorded in the image metadata associated with the instance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    This machine type will then be used when the instance is restarted or"},{"line_number":9,"context_line":"    migrated as it will now appear as a image metadata property associated"},{"line_number":10,"context_line":"    with the instance."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3e5a22ae_ae816e07","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":39},"updated":"2021-02-15 15:11:57.000000000","message":"an","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4ed6aeac547176d8f1d3a6fc410f14558c812f2d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    not already recorded in the image metadata associated with the instance."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    This machine type will then be used when the instance is restarted or"},{"line_number":9,"context_line":"    migrated as it will now appear as a image metadata property associated"},{"line_number":10,"context_line":"    with the instance."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a1157a69_a21382f5","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":39},"in_reply_to":"3e5a22ae_ae816e07","updated":"2021-02-15 19:57:34.000000000","message":"Ack","commit_id":"cc0b2f1609648592f3b9975a39f2b4eb600d48cc"}]}